[PATCH] D85301: [clang-tidy] Fix crashes in bugprone-bad-signal-to-kill-thread check.

ArcsinX added a comment. In D85301#2197263 , @hokein wrote: > while this patch fixes multiple issues (as described in the message), I'd > suggest splitting it. Thanks for you suggestion. > SIGTERM is not a literal D85398

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptSpecializationExpr {{.*}} 'bool' Concept {{.*}} 'binary_concept' - // CHECK-NE

[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

ArcsinX created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. `PP->getMacroInfo()` returns nullptr for undefined macro, which leads to null-dereference at `MI->tockens()

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge added a comment. This patch has helped me understand the difference between the two `ConceptReference`s in the AST (the `TypeConstraint` and the `ConceptSpecializationExpr`). Given that `template R>` is a shorthand for `template requires binary_concept` the `TypeConstraint` is the

[PATCH] D85398: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` is not a literal.

ArcsinX created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. If `SIGTERM` is not a literal (e.g. `#define SIGTERM ((unsigned)15)`) bugprone-bad-signal-to-kill-thread ch

[PATCH] D85362: [CMake] Print the autodetected host linker version

This revision was automatically updated to reflect the committed changes. Closed by commit rG633e3dacf27e: [CMake] Print the autodetected host linker version (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85362/new/ https://revi

[clang] 633e3da - [CMake] Print the autodetected host linker version

Author: Petr Hosek Date: 2020-08-05T20:22:28-07:00 New Revision: 633e3dacf27ea4950b7067803502490597ba96e0 URL: https://github.com/llvm/llvm-project/commit/633e3dacf27ea4950b7067803502490597ba96e0 DIFF: https://github.com/llvm/llvm-project/commit/633e3dacf27ea4950b7067803502490597ba96e0.diff LO

[PATCH] D85309: [WIP][clang][Driver] Support GNU ld on Solaris

MaskRay added a comment. Please find a suitable test file (clang/test/Driver/solaris-*.c) and add some tests there (for example, solaris-ld.c) The challenge is that CLANG_ENABLE_GLD is not a default configuration, so leaving out tests may be fine. Comment at: clang/CMakeLists

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 __

[PATCH] D85390: [Clang] Add note for bad conversion when expression is of forward-declared type

zequanwu created this revision. zequanwu added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. I think one note to speficify the forward declaretion location should be enough. Two notes might be too noisy. Repo

[PATCH] D85311: [analyzer][tests] Understand when diagnostics change between builds

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! This is one of the scripts that really deserves tests outside of buildbots. Like, it's not uncommon to use it "by hand". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D85362: [CMake] Print the autodetected host linker version

smeenai accepted this revision. smeenai added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85362/new/ https://reviews.llvm.org/D85362 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 283461. NoQ marked 2 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 Files: clang/include/clang/Analysis/PathDiagnosticConsumers.def clang/include/clang/Ana

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:25 +PathDiagnosticConsumerOptions DiagOpts, PathDiagnosticConsumers &C, +const std::string &prefix, const Preprocessor &PP, +const cross_tu::CrossTranslationUnitContext &CTU)

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper created this revision. craig.topper added reviewers: echristo, RKSimon, spatel, efriedma. Herald added a subscriber: dang. craig.topper requested review of this revision. Building on the backend support from D85165 . This parses the command line optio

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added a comment. I added prototype fixits per request by Roman, updated the LIT test, and added an additional RUN line (one for -Wparentheses and one for -Wcompare-op-parentheses). Also filed https://bugs.llvm.org/show_bug.cgi?id=47010 to follow up on the FIXME cases at the bottom o

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 283447. vabridgers added a comment. added prototype fixits for review. added additional RUN test case. filed https://bugs.llvm.org/show_bug.cgi?id=47010 for other warnings improvement post landing of this patch, after lgtm Repository: rG LLVM Github Mo

[PATCH] D82837: [Analyzer][WebKit] UncountedLambdaCaptureChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG820e8d8656ec: [Analyzer][WebKit] UncountedLambdaCaptureChecker (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 820e8d8 - [Analyzer][WebKit] UncountedLambdaCaptureChecker

Author: Jan Korous Date: 2020-08-05T15:23:55-08:00 New Revision: 820e8d8656ecf65ba29ea27c794c833f230c2698 URL: https://github.com/llvm/llvm-project/commit/820e8d8656ecf65ba29ea27c794c833f230c2698 DIFF: https://github.com/llvm/llvm-project/commit/820e8d8656ecf65ba29ea27c794c833f230c2698.diff LO

[clang] 1adc494 - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-08-05T16:07:11-07:00 New Revision: 1adc494bce44f6004994deed61b30d4b71fe1d05 URL: https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05 DIFF: https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05.diff LO

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

arsenm added a comment. Is this still necessary? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80416/new/ https://reviews.llvm.org/D80416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

thopre created this revision. thopre added reviewers: zixuw, arphaman, ributzka, steven_wu, dexonsmith. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. thopre requested review of this revision. Clang tests Driver/apple-arm64-arch.c and Driver/darwin-warning-opt

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 283406. jfb marked 5 inline comments as done. jfb added a comment. Remove restrict, update docs, call isCompleteType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files:

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2197118 , @rsmith wrote: > Two observations that are new to me in this review: > > 1. We already treat all builtins as being overloaded on address space. > 2. The revised patch treats `__builtin_mem*_overloaded` as being over

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:110 + SmartPtrChecker *Checker = Mgr.registerChecker(); + NullDereferenceBugTypePtr = &Checker->NullDereferenceBugType; } vrnithinkumar wrote: > xazax.hun wrote: > > N

[clang] 076b120 - CFG: Destroy temporaries in (a, b) expression in the correct order.

Author: Richard Smith Date: 2020-08-05T14:52:53-07:00 New Revision: 076b120bebfd727b502208601012a44ab2e1028e URL: https://github.com/llvm/llvm-project/commit/076b120bebfd727b502208601012a44ab2e1028e DIFF: https://github.com/llvm/llvm-project/commit/076b120bebfd727b502208601012a44ab2e1028e.diff

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:110 + SmartPtrChecker *Checker = Mgr.registerChecker(); + NullDereferenceBugTypePtr = &Checker->NullDereferenceBugType; } xazax.hun wrote: > NoQ wrote: > > v

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2446 +order in which they occur (and in which they are observable) can only be +guaranteed using appropriate fences around the function call. Element size must +therefore be a lock-free size for the target a

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 283402. jfb marked an inline comment as done. jfb added a comment. Use 'access size' instead of 'element size'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: cla

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

tatyana-krasnukha added a comment. I'm not familiar with the z/OS target, so I cannot check the correctness of the target-specific changes. The overall patch looks good. Comment at: clang/lib/Basic/Targets/OSTargets.h:780 +public: + ZOSTargetInfo(const llvm::Triple &Triple, c

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_handlers.cpp:659 + uptr PtrOrSize) { GET_REPORT_OPTIONS(true); + handleInvalidBuiltin(Data, Opts, PtrOrSize); vsk wrote: > It looks like `__ubsan_ha

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 283400. jfb marked an inline comment as done. jfb added a comment. Add loop test requested by Vedant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/Lan

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L updated this revision to Diff 283396. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Added descriptions for struct and functions; Addressed other comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 F

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L marked 7 inline comments as done. Xiangling_L added inline comments. Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466 + + bool preprocessStructorList(const DataLayout &DL, const Constant *List, + SmallVector &Structors); ---

[PATCH] D85362: [CMake] Print the autodetected host linker version

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. That's a great start. IMHO we should give the driver a way to print out its embedded value too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D85362: [CMake] Print the autodetected host linker version

phosek created this revision. phosek added reviewers: smeenai, beanz. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. phosek requested review of this revision. There's no easy way to find out what the autodetected version is, but sometimes it may be useful to confirm

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 283390. jfb added a comment. Do UBSan change suggested by Vedant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/LanguageExtensions.rst clang/include

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:732 +Builder.defineMacro("_OPEN_DEFAULT"); +Builder.defineMacro("_UNIX03_WITHDRAWN"); +Builder.defineMacro("__370__"); This is not defined by z/OS XL C/C++.

[clang] f496950 - [WebAssembly] Fix types in wasm_simd128.h and add tests

Author: Thomas Lively Date: 2020-08-05T14:00:01-07:00 New Revision: f496950001c47724867912d863858db0a81b4309 URL: https://github.com/llvm/llvm-project/commit/f496950001c47724867912d863858db0a81b4309 DIFF: https://github.com/llvm/llvm-project/commit/f496950001c47724867912d863858db0a81b4309.diff

[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf496950001c4: [WebAssembly] Fix types in wasm_simd128.h and add tests (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

sberg added a comment. My naive assumption was that this warning had initially been restricted to integer literals and enumerators to avoid false positives. Hence my conservative approach of extending merely to constant integer expressions for now. Maybe Richard as the original author of the

[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

tlively added inline comments. Comment at: clang/test/Headers/wasm.cpp:1 +// RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +simd128 -fsyntax-only -ffreestanding %s -verify +// expected-no-diagnostics sunfish wrote: > This test currently passes o

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

efriedma added a comment. > If the intent is for getTypeInfo to always return sizes that are multiples of > the char size, then the design should be inverted and getTypeInfo should > simply be calling getTypeInfoInChars and multiply that result by the char > size. But that isn't how it works.

[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

tlively updated this revision to Diff 283373. tlively added a comment. - Fix and test macros as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85347/new/ https://reviews.llvm.org/D85347 Files: clang/lib/Headers/wasm_simd128.h clang/test/He

[PATCH] D85354: [clangd] Reduce availability of extract function

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch introduces hoisting det

[PATCH] D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d057efddc00: [CUDA] Work around a bug in rint/nearbyint caused by a broken implementation… (authored by tra). Repository: rG LLVM Github Monorepo

[clang] 7d057ef - [CUDA] Work around a bug in rint/nearbyint caused by a broken implementation provided by CUDA.

Author: Artem Belevich Date: 2020-08-05T13:13:48-07:00 New Revision: 7d057efddc00ba7d03e6e684f23dd9b09fbd0527 URL: https://github.com/llvm/llvm-project/commit/7d057efddc00ba7d03e6e684f23dd9b09fbd0527 DIFF: https://github.com/llvm/llvm-project/commit/7d057efddc00ba7d03e6e684f23dd9b09fbd0527.diff

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

bjope added a comment. In D85191#2196863 , @rsmith wrote: > In D85191#2195923 , @ebevhan wrote: > >> In D85191#2193645 , @rsmith wrote: >> This is not ideal, since it ma

[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. Ah, it seems the reason I didn't see this is that I wasn't using `-flax-vector-conversions=none`. Thanks for fixing this! Comment at: clang/test/Headers/wasm.cpp:1 +// RUN

[PATCH] D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA.

tra updated this revision to Diff 283359. tra edited the summary of this revision. tra added a comment. Also fixed the same bug in nearbyint(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85236/new/ https://reviews.llvm.org/D85236 Files: clang

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3329 } - OMPDeclareMapperDecl *NewDMD = SemaRef.ActOnOpenMPDeclareMapperDirectiveStart( - /*S=*/nullptr, Owner, D->getDeclName(), SubstMapperTy, D->getLocation(),

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, vsavchenko. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. H

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. I think the ActOnOpenMPDeclareMapperDirective changes should be separated into its own patch. Otherwise, LGTM. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3329 } - OMPDeclareMapperDecl *NewDMD = SemaRef.ActOnOpenMPDeclareMapperDi

[clang] 105608a - [AMDGPU] Added missing gfx1031 cases to CGOpenMPRuntimeGPU.cpp

Author: Stanislav Mekhanoshin Date: 2020-08-05T12:39:03-07:00 New Revision: 105608a4c2821ca8f8340104614c1176ed1ed82d URL: https://github.com/llvm/llvm-project/commit/105608a4c2821ca8f8340104614c1176ed1ed82d DIFF: https://github.com/llvm/llvm-project/commit/105608a4c2821ca8f8340104614c1176ed1ed8

[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

tlively updated this revision to Diff 283348. tlively added a comment. - Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85347/new/ https://reviews.llvm.org/D85347 Files: clang/lib/Headers/wasm_simd128.h clang/test/Headers/wasm.c clang/tes

[clang] ea7d0e2 - [AMDGPU] gfx1031 target

Author: Stanislav Mekhanoshin Date: 2020-08-05T12:36:26-07:00 New Revision: ea7d0e2996ec6b72a08dbef26dadf217458ab382 URL: https://github.com/llvm/llvm-project/commit/ea7d0e2996ec6b72a08dbef26dadf217458ab382 DIFF: https://github.com/llvm/llvm-project/commit/ea7d0e2996ec6b72a08dbef26dadf217458ab3

LLVM buildmaster and LVM lab machines will be unavailable today at 6:00 pm PST

Hello everyone, LLVM buildmaster and LVM lab machines will be unavailable today Wednesday, August 5th at 6:00 pm PST due to Network maintenance. The planned maintenance duration is 30 minutes. Thank you for understanding. Thanks Galina ___ cfe-com

[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

tlively created this revision. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. tlively requested review of this revision. Herald added a subscriber: aheejin. 47f7174ffa

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158 if (!Marks.empty()) OS << Marks << ": "; Maybe the marks should be moved after the primary identifier of the node, WDYT? That would be more consistent with AST dump: fi

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm updated this revision to Diff 283345. arsenm added a comment. Reword comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/TargetIn

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:199 +} else { + const auto *TrackingExpr = getFirstArgExpr(Call); + C.addTransition(State, C.getNoteTag([ThisRegion, TrackingExpr]( xazax.hun wrote: > I am

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

jordan_rose added a comment. Nothing seems too mysterious here, but why limit to `constexpr` instead of anything where Clang can see a constant value, which would make it work in C as well? (If you're allowing `constexpr`, you're already allowing arbitrary work.) CHANGES SINCE LAST ACTION ht

[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc43852e4a8: [Driver] Accept -fno-lto in clang-cl (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85252/new/ https://reviews.llvm.org

[clang] 8dc4385 - [Driver] Accept -fno-lto in clang-cl

Author: Arthur Eubanks Date: 2020-08-05T12:24:10-07:00 New Revision: 8dc43852e4a8a5c6680d52aa6e73a75aef5a5954 URL: https://github.com/llvm/llvm-project/commit/8dc43852e4a8a5c6680d52aa6e73a75aef5a5954 DIFF: https://github.com/llvm/llvm-project/commit/8dc43852e4a8a5c6680d52aa6e73a75aef5a5954.diff

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1100 + +if (Subtarget.isISA3_1()) { + setOperationAction(ISD::SRA, MVT::v1i128, Legal); amyk wrote: > No brackets are needed here. > > Also, I think it might make sense

[PATCH] D85301: [clang-tidy] Fix crashes in bugprone-bad-signal-to-kill-thread check.

hokein added a comment. while this patch fixes multiple issues (as described in the message), I'd suggest splitting it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85301/new/ https://reviews.llvm.org/D85301 _

[PATCH] D85319: [analyzer][RFC] Get info from the LLVM IR for precision

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:720 + F->getAttributes().hasFnAttribute(llvm::Attribute::ReadOnly)) +return; + NoQ wrote: > Before i forget: you still need to conjure th

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added a comment. In D75181#2193447 , @danielkiss wrote: > I don't see any other alternative option, I'm open to any other idea. My original idea was to pass options to LLVM. I'll come up with a patch in a day or two (if it works) and then we'll see

[clang-tools-extra] 618db68 - [clangd][NFC] Delete dead code in ExtractFunction code action

Author: Kadir Cetinkaya Date: 2020-08-05T21:14:39+02:00 New Revision: 618db6803d6c8b453abe6a1e92938ee20ac3aff6 URL: https://github.com/llvm/llvm-project/commit/618db6803d6c8b453abe6a1e92938ee20ac3aff6 DIFF: https://github.com/llvm/llvm-project/commit/618db6803d6c8b453abe6a1e92938ee20ac3aff6.dif

[PATCH] D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85113/new/ https://reviews.llvm.org/D85113 _

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

rjmccall added a comment. There's no way to do that, no. Stripping sugar down to the point where you don't have that qualifier anymore is the best we can do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83325/new/ https://reviews.llvm.org/D83325

[PATCH] D85315: [AIX][Clang] Add C++ linker option to the driver toolchain

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:152 + if (getToolChain().ShouldLinkCXXStdlib(Args)) +getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); This is commonly added before `-lc`, etc. To be consistent

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

martong added a comment. In D85319#2197104 , @rjmccall wrote: > This seems a huge architectural change that we need to talk about. Yes, sure. I am open to and welcome any discussions and suggestions. This patch is just a prototype to demonstrate the usab

[clang-tools-extra] d3ac301 - [clangd] Disable define out-of-line code action on templates

Author: Kadir Cetinkaya Date: 2020-08-05T20:57:28+02:00 New Revision: d3ac30188666b182daa87d23533543543b789e97 URL: https://github.com/llvm/llvm-project/commit/d3ac30188666b182daa87d23533543543b789e97 DIFF: https://github.com/llvm/llvm-project/commit/d3ac30188666b182daa87d23533543543b789e97.dif

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. I thought part of the point of `__builtin_memcpy` was so that C library headers could do `#define memcpy(x, y, z) __builtin_memcpy(x, y, z)`. If so, the conformance issue touches `__builtin_memcpy` as well, not just calls to the library builtin. If that's not true, o

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ac30188666: [clangd] Disable define out-of-line code action on templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85310/new/

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

rjmccall added a comment. Thanks. It'd be a good idea to mention that this is contingent on that discussion in the patch summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85319/new/ https://reviews.llvm.org/D85319 __

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

NoQ added a comment. In D85319#2197104 , @rjmccall wrote: > This seems a huge architectural change that we need to talk about. Absolutely. I believe the relevant discussion is at http://lists.llvm.org/pipermail/cfe-dev/2020-August/066426.html. Reposit

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8816 + // FIXME: Should use byref when promoting pointers in structs, but this + // requires adding implementing the coercion. + if (!getContext().getLangOpts().OpenCL && LTy == OrigLTy && ---

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:720 + F->getAttributes().hasFnAttribute(llvm::Attribute::ReadOnly)) +return; + Before i forget: you still need to conjure the return value.

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added a comment. Two observations that are new to me in this review: 1. We already treat all builtins as being overloaded on address space. 2. The revised patch treats `__builtin_mem*_overloaded` as being overloaded *only* on address space, volatility, and atomicity. (We've tuned the desi

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:42 +LLVM_NODISCARD Optional +getCStringLength(CheckerContext &Ctx, const ProgramStateRef &State, SVal Buf); + Just pass by value then. It's already a "Ref".

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8816 + // FIXME: Should use byref when promoting pointers in structs, but this + // requires adding implementing the coercion. + if (!getContext().getLangOpts().OpenCL && LTy == OrigLTy && -

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. This seems a huge architectural change that we need to talk about. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85319/new/ https:

[clang] 7ad60f6 - [clang-format] fix BreakBeforeBraces.MultiLine with for each macros

Author: Mitchell Balan Date: 2020-08-05T14:31:42-04:00 New Revision: 7ad60f6452ff483912776ef6eda4e28c60d9da6e URL: https://github.com/llvm/llvm-project/commit/7ad60f6452ff483912776ef6eda4e28c60d9da6e DIFF: https://github.com/llvm/llvm-project/commit/7ad60f6452ff483912776ef6eda4e28c60d9da6e.diff

[PATCH] D85304: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ad60f6452ff: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2446 +order in which they occur (and in which they are observable) can only be +guaranteed using appropriate fences around the function call. Element size must +therefore be a lock-free size for the tar

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; arsenm wrote: > arsenm wrote: > > rjmccall wrote: > > > arsenm wrote: > > > > rjmccall wrote: > >

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 283305. eduucaldas added a comment. Rollback strOfLeaf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib

[PATCH] D85304: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85304/new/ https://reviews.llvm.org/D85304

[PATCH] D85318: [clangd] Hide "swap if branch" tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a7b8b22a75c: [clangd] Hide "swap if branch" tweak (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85318/new/ https://reviews.llvm.org/D

[clang-tools-extra] 9a7b8b2 - [clangd] Hide "swap if branch" tweak

Author: Haojian Wu Date: 2020-08-05T20:03:21+02:00 New Revision: 9a7b8b22a75c4b5a065775a75a6a3dd2718ac970 URL: https://github.com/llvm/llvm-project/commit/9a7b8b22a75c4b5a065775a75a6a3dd2718ac970 DIFF: https://github.com/llvm/llvm-project/commit/9a7b8b22a75c4b5a065775a75a6a3dd2718ac970.diff LO

[clang] 2143a90 - Fix _ExtInt(1) to be a i1 in memory.

Author: Erich Keane Date: 2020-08-05T10:54:51-07:00 New Revision: 2143a90b34a7846369127e762cec5917d5e1a5bd URL: https://github.com/llvm/llvm-project/commit/2143a90b34a7846369127e762cec5917d5e1a5bd DIFF: https://github.com/llvm/llvm-project/commit/2143a90b34a7846369127e762cec5917d5e1a5bd.diff L

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && hliao wrote: > tra wrote: > >

[PATCH] D79279: Add overloaded versions of builtin mem* functions

vsk added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_handlers.cpp:659 + uptr PtrOrSize) { GET_REPORT_OPTIONS(true); + handleInvalidBuiltin(Data, Opts, PtrOrSize); It looks like `__ubsan_handle_invalid_

[PATCH] D85316: [SyntaxTree] Proposition of new tree dump

gribozavr2 added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85316/new/ https://reviews.llvm.org/D85316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D85316: [SyntaxTree] Proposition of new tree dump

eduucaldas updated this revision to Diff 283298. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85316/new/ https://reviews.llvm.org/D85316 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index:

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// RUN:

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Functional changes in the dump: - Surround Leaf tokens with `'` - Append `Node` dumps with `NodeRole` information, except for unknown roles Non-

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && tra wrote: > We will still

  1   2   3   >