[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. The most immediate problem is divergence analysis, which is extremely complex and difficult to get right. If I had tried to fight the accidental complexity that comes with attempting to write such an algorithm as C++ templates in addition to the inh

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

SouraVX added inline comments. Comment at: flang/tools/flang-driver/fc1_main.cpp:1 +//===-- fc1_main.cpp - Flang FC1 Compiler Frontend ===// +// This file-name seems odd considering LLVM style. How about just `Flang.cpp` or `FlangMain.cp

[PATCH] D86427: Fix some spelling errors

plotfi accepted this revision. plotfi added a comment. This revision is now accepted and ready to land. LGTM. Go ahead and land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86427/new/ https://reviews.llvm.org/D86427 __

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge updated this revision to Diff 287291. nridge added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/ https://reviews.llvm.org/D86424 Files: clang/lib/Index/IndexTypeSourceInfo.cpp clang/unittests/Index/Index

[PATCH] D85596: [Docs] Link to --print-supported-cpus option

tmfink updated this revision to Diff 287290. tmfink added a comment. Fix rendering of --print-supported-cpus option and make alias documentation a complete sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85596/new/ https://reviews.llvm.org/

[PATCH] D86426: [Docs] Fix --print-supported-cpus option rendering

tmfink abandoned this revision. tmfink added a comment. Accidentally created new review instead of updating https://reviews.llvm.org/D85596 Please ignore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86426/new/ https://reviews.llvm.org/D86426 _

[PATCH] D86427: Fix some spelling errors

YangZhihui created this revision. YangZhihui added reviewers: peter.smith, plotfi. YangZhihui added a project: clang. Herald added subscribers: cfe-commits, dang. YangZhihui requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86427 Files: clang/in

[PATCH] D86426: [Docs] Fix --print-supported-cpus option rendering

tmfink created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. tmfink requested review of this revision. Adds link/code sample to avoid rendering two dashes as non-ASCII "en dash". Also make wording a complete sentence. Repository: rG LLVM Github Monorepo

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

OikawaKirie added a comment. @vsavchenko @NoQ The patch has been updated as required. Is there anything I need to do with the patch? Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:56 /// last node should be unique. - /// Use {@code

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. nridge requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86424 Files: clang/lib/Index/IndexTypeSourceI

[PATCH] D85596: [Docs] Link to --print-supported-cpus option

tmfink added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:346 - Aliases of --print-supported-cpus + Aliases of :option:`--print-supported-cpus` nickdesaulniers wrote: > Would you mind adding a `.` for punctuation while you're here? This is

[clang] bf3577e - [clang][Driver] Implement addLibCxxIncludePaths and getCompilerRT for the OpenBSD clang driver.

Author: Brad Smith Date: 2020-08-23T20:44:29-04:00 New Revision: bf3577ef64c300ba7841a90a4e09e1e305271976 URL: https://github.com/llvm/llvm-project/commit/bf3577ef64c300ba7841a90a4e09e1e305271976 DIFF: https://github.com/llvm/llvm-project/commit/bf3577ef64c300ba7841a90a4e09e1e305271976.diff LO

[clang] 2b37174 - [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

Author: Brad Smith Date: 2020-08-23T20:08:40-04:00 New Revision: 2b37174b9a5db235e493cb72e4454cc08a1b1791 URL: https://github.com/llvm/llvm-project/commit/2b37174b9a5db235e493cb72e4454cc08a1b1791 DIFF: https://github.com/llvm/llvm-project/commit/2b37174b9a5db235e493cb72e4454cc08a1b1791.diff LO

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b37174b9a5d: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

3405691582 added a comment. Thanks! please commit on my be half as appropriate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https://reviews.llvm.org/D86412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

mikhail.ramalho requested changes to this revision. mikhail.ramalho added a comment. This revision now requires changes to proceed. In D86223#2231991 , @steakhal wrote: > In D86223#2231959 , @mikhail.ramalho > wrot

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

brad accepted this revision. brad added a comment. This revision is now accepted and ready to land. I was wondering why we had not seen any issues like this but your followup post clarified the situation. Thank you. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

CarolineConcatto marked 17 inline comments as done. CarolineConcatto added a comment. Hey Folks, Fist of all, thank you very much for your review. I have answered some questions and update some of the requests. There are some that I did not had time to go inside yet. I have the week of 24th off.

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

CarolineConcatto updated this revision to Diff 287270. CarolineConcatto added a comment. Address review comments Replace namespace flang for Fortran::frontend and fix style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

3405691582 updated this revision to Diff 287263. 3405691582 edited the summary of this revision. 3405691582 added a comment. Those platforms still use the legacy mechanism in `InitHeaderSearch.cpp`. For platforms which have moved include handling to the driver, the mechanism in `InitHeaderSearch

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps updated this revision to Diff 287269. alanphipps marked 2 inline comments as done. alanphipps added a comment. Updating for formatting and comments (and some test adjustments after rebase). Bypassing logical-NOT operators in CodeGenFunction::isLeafCondition(), which checks the condit

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked 13 inline comments as done. alanphipps added a comment. Herald added a subscriber: wenlei. In D84467#2180421 , @vsk wrote: > I haven't taken a close look at the tests yet, but plan on getting to it soon. > > I'm not sure whether this is s

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. Thanks for the patch! A few questions: > probe blocks some CFG transformations that can mess up profile correlation. Can you enumerate some CFG transformations which be blocked? Is it possible that some CFG transformations being blocked are actually beneficial for later op

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante updated this revision to Diff 287264. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments: - Adds support for c2x using `[[clang::likely]]` and `[[clang::unlikely]]` - Remove warnings about conflicting likelihoods, except those required by the

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 8 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs]; aaron.ballman wrote:

Re: [clang] f76adc2 - [docs] Add an initial (non-exhaustive) list of intrinsics that can be used in constant expressions

Thank you! On Sun, 23 Aug 2020 at 02:55, Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Simon Pilgrim > Date: 2020-08-23T10:55:14+01:00 > New Revision: f76adc2603f6cc466dd809142388ffb56a1c3e31 > > URL: > https://github.com/llvm/llvm-project/commit/f76adc2603f6cc466

[clang] a1dc3d2 - [X86] Enable constexpr on ROTL/ROTR intrinsics (PR31446)

Author: Simon Pilgrim Date: 2020-08-23T16:11:58+01:00 New Revision: a1dc3d241ba00042b6160287f887d1019e36bae0 URL: https://github.com/llvm/llvm-project/commit/a1dc3d241ba00042b6160287f887d1019e36bae0 DIFF: https://github.com/llvm/llvm-project/commit/a1dc3d241ba00042b6160287f887d1019e36bae0.diff

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2231927 , @mati865 wrote: > @phosek in MSYS2 (targeting x86_64-w64-windows-gnu) Zlib works properly for > LLVM 10 but with master I'm now seeing: > > -- Constructing LLVMBuild project information > -- DEBUG zlib_libra

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

mati865 added a comment. @phosek > Looks like that's an issue introduced by D86134 > or D86245 . Indeed, I apologize for bothering you. Should I move the discussion to one of patches created by @haampie? Continuing the discus

[clang] 55208f5 - [analyzer] Add modeling for unque_ptr::get()

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-08-23T14:50:26+02:00 New Revision: 55208f5a2126e491c41ba9ff6542551bfc090e86 URL: https://github.com/llvm/llvm-project/commit/55208f5a2126e491c41ba9ff6542551bfc090e86 DIFF: https://github.com/llvm/llvm-project/commit/55208f5a2126e491c41ba9ff6

[PATCH] D86029: [analyzer] Add modeling for unque_ptr::get()

This revision was automatically updated to reflect the committed changes. Closed by commit rG55208f5a2126: [analyzer] Add modeling for unque_ptr::get() (authored by vrnithinkumar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86029/new/ https://rev

[clang] f76adc2 - [docs] Add an initial (non-exhaustive) list of intrinsics that can be used in constant expressions

Author: Simon Pilgrim Date: 2020-08-23T10:55:14+01:00 New Revision: f76adc2603f6cc466dd809142388ffb56a1c3e31 URL: https://github.com/llvm/llvm-project/commit/f76adc2603f6cc466dd809142388ffb56a1c3e31 DIFF: https://github.com/llvm/llvm-project/commit/f76adc2603f6cc466dd809142388ffb56a1c3e31.diff

[PATCH] D86398: [X86] Enable constexpr on _cast fp<-> uint intrinsics (PR31446)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8e0e5db4860: [X86] Enable constexpr on _cast fp<-> uint intrinsics (PR31446) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES

[clang] f8e0e5d - [X86] Enable constexpr on _cast fp<-> uint intrinsics (PR31446)

Author: Simon Pilgrim Date: 2020-08-23T10:27:46+01:00 New Revision: f8e0e5db48601cb0d019405703ccaa2378f503e0 URL: https://github.com/llvm/llvm-project/commit/f8e0e5db48601cb0d019405703ccaa2378f503e0 DIFF: https://github.com/llvm/llvm-project/commit/f8e0e5db48601cb0d019405703ccaa2378f503e0.diff