[clang] 2d65294 - [PowerPC] Provide vec_cmpne on pre-Power9 architectures in altivec.h

Author: Nemanja Ivanovic Date: 2020-09-04T21:48:38-04:00 New Revision: 2d652949be4b772f2c11577621b0ad33052ac844 URL: https://github.com/llvm/llvm-project/commit/2d652949be4b772f2c11577621b0ad33052ac844 DIFF:

[PATCH] D87064: Thread safety analysis: Test and document release_generic_capability

aaronpuchert updated this revision to Diff 290045. aaronpuchert added a comment. Add some prose, not just code. Otherwise our list of attributes would be incomplete. @aaron.ballman, I think you should have another look. Sorry for missing that in my first patch. Repository: rG LLVM Github

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng added a comment. In D87162#2257233 , @MaskRay wrote: > LGTM. > >> It's probably not used very common, but we do have some baremetal use cases >> still relying on these flags to be propagated to GCC. > > Thanks for the explanation! (Though I think

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

MaskRay added a comment. LGTM. > It's probably not used very common, but we do have some baremetal use cases > still relying on these flags to be propagated to GCC. Thanks for the explanation! (Though I think in these cases calling `ld` or `ld.lld` directly might be better?) And apologies

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bccd2b4350f: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2bccd2b - [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

Author: Pengxuan Zheng Date: 2020-09-04T15:09:33-07:00 New Revision: 2bccd2b4350f887cc7fea1cc488690f58186c440 URL: https://github.com/llvm/llvm-project/commit/2bccd2b4350f887cc7fea1cc488690f58186c440 DIFF:

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng updated this revision to Diff 290038. pzheng marked an inline comment as done. pzheng added a comment. Updated the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87162/new/ https://reviews.llvm.org/D87162 Files:

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng marked an inline comment as done. pzheng added a comment. In D87162#2257192 , @MaskRay wrote: > Can D83648 be closed now? Yes, I have closed it. > BTW, can you describe a bit about your use cases? Forwarding

[clang] 7cfc8f0 - [libclang] Add missing dependency on clangRewrite lib

Author: Jan Korous Date: 2020-09-04T14:59:53-07:00 New Revision: 7cfc8f0c7c2440ea8aa722304f9e6ef32472833b URL: https://github.com/llvm/llvm-project/commit/7cfc8f0c7c2440ea8aa722304f9e6ef32472833b DIFF: https://github.com/llvm/llvm-project/commit/7cfc8f0c7c2440ea8aa722304f9e6ef32472833b.diff

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

MaskRay added a comment. Can D83648 be closed now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87162/new/ https://reviews.llvm.org/D87162 ___ cfe-commits mailing list

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/gcc_forward.c:4 // RUN: 2>&1 | FileCheck --check-prefix=FORWARD %s -// FORWARD: gcc{{[^"]*}}" "--coverage" "-fuse-ld=lld"

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:115 cl::desc("The number of memory instructions to scan for " "dead store elimination (default = 100)")); static cl::opt

[clang] 69e5abb - [libclang] Add CXRewriter to libclang API

Author: Jan Korous Date: 2020-09-04T14:17:03-07:00 New Revision: 69e5abb57b70570cf04671a93246e5e624023650 URL: https://github.com/llvm/llvm-project/commit/69e5abb57b70570cf04671a93246e5e624023650 DIFF: https://github.com/llvm/llvm-project/commit/69e5abb57b70570cf04671a93246e5e624023650.diff

[PATCH] D86992: [libclang] Expose Rewriter in libclang API

This revision was automatically updated to reflect the committed changes. Closed by commit rG69e5abb57b70: [libclang] Add CXRewriter to libclang API (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco created this revision. mcarrasco added reviewers: jroelofs, clang. mcarrasco added a project: clang-modules. Herald added subscribers: cfe-commits, abidh, kristof.beyls. Herald added a project: clang. mcarrasco requested review of this revision. The Baremetal toolchain currently has a

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn created this revision. fhahn added reviewers: efriedma, dmgreen, asbirlea, reames. Herald added subscribers: cfe-commits, lxfind, nikic, kerbowa, jfb, dexonsmith, steven_wu, george.burgess.iv, modocache, hiraditya, Prazek, nhaehnle, jvesely. Herald added projects: clang, LLVM. fhahn

[PATCH] D87162: [Driver] Allow -specs and -nostartfiles to be forwarded to GCC

pzheng created this revision. pzheng added reviewers: MaskRay, apazos. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. pzheng requested review of this revision. With 6a75496836ea14bcfd2f4b59d35a1cad4ac58cee

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 290023. BRevzin added a comment. Herald added subscribers: rupprecht, MaskRay. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Updating this review with some additional changes that need to be made since I last touched it, and some of

[PATCH] D86991: [libclang] Expose couple AST details

This revision was automatically updated to reflect the committed changes. Closed by commit rG052f83890349: [libclang] Expose couple more AST details via cursors (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 052f838 - [libclang] Expose couple more AST details via cursors

Author: Jan Korous Date: 2020-09-04T13:38:47-07:00 New Revision: 052f83890349822a606c916b2fee501bc087652b URL: https://github.com/llvm/llvm-project/commit/052f83890349822a606c916b2fee501bc087652b DIFF: https://github.com/llvm/llvm-project/commit/052f83890349822a606c916b2fee501bc087652b.diff

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

Thanks for the revert and the test. I'd imagine that we're forgetting that we need to ask the most recent declaration whether it's weak -- isWeak() can (presumably) change along the redecl chain. Fun :) On Fri, 4 Sep 2020, 07:36 Nico Weber, wrote: > Actually in

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

manojgupta accepted this revision. manojgupta added a comment. This revision is now accepted and ready to land. Looks ok to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87143/new/ https://reviews.llvm.org/D87143

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

dmantipov updated this revision to Diff 289998. dmantipov added a comment. Add D.SysRoot as suggested during initial review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87143/new/ https://reviews.llvm.org/D87143 Files:

[PATCH] D86841: [clang] Add mayprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 289997. atmnpatel added a comment. Renamed `mayprogress` to `maynotprogress`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files:

[clang] 54205f0 - [PowerPC] Allow const pointers for load builtins in altivec.h

Author: Nemanja Ivanovic Date: 2020-09-04T13:56:39-04:00 New Revision: 54205f0bd2377503b818d7f62cc4ed63ef5b1e94 URL: https://github.com/llvm/llvm-project/commit/54205f0bd2377503b818d7f62cc4ed63ef5b1e94 DIFF:

[clang] 64bb582 - Fix the type of the invoke function in the block ABI documentation

Author: Akira Hatanaka Date: 2020-09-04T10:29:09-07:00 New Revision: 64bb582f4a07d7195a6e6a44a34d166a06f0f071 URL: https://github.com/llvm/llvm-project/commit/64bb582f4a07d7195a6e6a44a34d166a06f0f071 DIFF:

[PATCH] D86930: [clang-format] Handle typename macros inside cast expressions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86930/new/ https://reviews.llvm.org/D86930

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM, I think we need something like this for those keywords/macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782

[PATCH] D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Assuming it builds with minimum required c++ compiler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87006/new/

[PATCH] D87007: [clang-format] Correctly parse function declarations with TypenameMacros

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87007/new/ https://reviews.llvm.org/D87007

[PATCH] D86950: [clang-format] Check that */& after typename macros are pointers/references

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86950/new/ https://reviews.llvm.org/D86950

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2537-2538 const SmallVectorImpl ) { + if (!D.getVFS().exists(GentooConfigDir)) +return false; + manojgupta wrote: > I think it should be D.SysRoot + GentooConfigDir.

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0b9dbcfc7ba: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions (authored by martong). Repository: rG LLVM Github Monorepo

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2254967 , @rjmccall wrote: > I didn't see the specific example, sorry. I agree that my description is > more applicable to builtins in the `__builtin` namespace, which describes > most of the builtins with custom

[clang] f0b9dbc - [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

Author: Gabor Marton Date: 2020-09-04T18:44:12+02:00 New Revision: f0b9dbcfc7ba2a217cab3217d6217fc270c88b58 URL: https://github.com/llvm/llvm-project/commit/f0b9dbcfc7ba2a217cab3217d6217fc270c88b58 DIFF: https://github.com/llvm/llvm-project/commit/f0b9dbcfc7ba2a217cab3217d6217fc270c88b58.diff

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 289986. tambre added a comment. Improve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include/clang/Basic/Attr.td

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

manojgupta added a reviewer: mgorny. manojgupta added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2537-2538 const SmallVectorImpl ) { + if (!D.getVFS().exists(GentooConfigDir)) +return false; + I think it should be D.SysRoot +

[clang] baf3c77 - [libclang] Add translateCXRangeToCharRange conversion

Author: Jan Korous Date: 2020-09-04T09:41:22-07:00 New Revision: baf3c77bd9f6baf60a09ef3625fef84080642b72 URL: https://github.com/llvm/llvm-project/commit/baf3c77bd9f6baf60a09ef3625fef84080642b72 DIFF: https://github.com/llvm/llvm-project/commit/baf3c77bd9f6baf60a09ef3625fef84080642b72.diff

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

martong added a comment. In D84248#2215519 , @Szelethus wrote: > Lets make sure we invite the wider community to see whats going on. > Otherwise, LGTM! I am committing this because it already has two accepts, plus I am //very// confident with the

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

martong updated this revision to Diff 289982. martong added a comment. - Rebase to master, ie using optionals everywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84248/new/ https://reviews.llvm.org/D84248 Files:

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware updated this revision to Diff 289981. baloghadamsoftware added a comment. `isIterator()` updated because it did not work perfectly with the refactored `handleBegin()` after rebase. (Why did it work before the rebase?) The problem was that it only looked for the necessary

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

arichardson updated this revision to Diff 289980. arichardson added a comment. fix configuration parsing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86782/new/ https://reviews.llvm.org/D86782 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante updated this revision to Diff 289979. Mordante marked an inline comment as done. Mordante added a comment. Addresses review comments, mainly: - Improving the documentation - Removing the AST bits since they're no longer required CHANGES SINCE LAST ACTION

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:578 +static std::pair +getLikelihood(const Stmt *Stmt) { + if (const auto *AS = dyn_cast(Stmt)) aaron.ballman wrote: > Mordante wrote: > > rsmith

[clang] 45c3560 - [HeapProf] Address post-review comments in instrumentation code

Author: Teresa Johnson Date: 2020-09-04T08:59:00-07:00 New Revision: 45c3560384814d04c9813e644efa8e2155ecae52 URL: https://github.com/llvm/llvm-project/commit/45c3560384814d04c9813e644efa8e2155ecae52 DIFF:

[PATCH] D86941: [clang-format] Add a test showing the current config file list parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0ff5a8410ea: [clang-format] Add a test showing the current config file list parsing (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D86941?vs=289166=289974#toc

[PATCH] D86926: FormatTest: Provide real line number in failure messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG2108bceceb5e: FormatTest: Provide real line number in failure messages (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86926/new/

[clang] e0ff5a8 - [clang-format] Add a test showing the current config file list parsing

Author: Alex Richardson Date: 2020-09-04T16:57:46+01:00 New Revision: e0ff5a8410ea58ba3d2e75791789a28ce976a7e7 URL: https://github.com/llvm/llvm-project/commit/e0ff5a8410ea58ba3d2e75791789a28ce976a7e7 DIFF:

[PATCH] D86775: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c810acc94ed: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2108bce - FormatTest: Provide real line number in failure messages

Author: Alex Richardson Date: 2020-09-04T16:57:46+01:00 New Revision: 2108bceceb5e6eca361aaa6b10441d83bd9edc1b URL: https://github.com/llvm/llvm-project/commit/2108bceceb5e6eca361aaa6b10441d83bd9edc1b DIFF:

[clang] 8c810ac - [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier

Author: Alex Richardson Date: 2020-09-04T16:56:21+01:00 New Revision: 8c810acc94ed462238242c04c75ab33fc96da6e8 URL: https://github.com/llvm/llvm-project/commit/8c810acc94ed462238242c04c75ab33fc96da6e8 DIFF:

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

balazske added a comment. This checker will make an additional assumption on `fread` and `fwrite` with the ReturnValueCondition. The return value is constrained by `StreamChecker` too but it splits the error (if returned value is less that arg 3) and non-error cases into separate branches. I

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added a comment. Polite ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong updated this revision to Diff 289970. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 Files:

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. The change LGTM,!. If it really can speed up performance or improve memory organization, let's load this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - I think the odds of code that is using intrinsic vector abs inter-mixing with auto-vectorized code using the abs idiom are small. I noticed one other LLVM codegen test that might want

[PATCH] D87138: [analyzer][NFC] Introduce refactoring of PthreadLockChecker

ASDenysPetrov added a comment. In D87138#2256360 , @martong wrote: > This seems to be a total non-functional-change. Please include [NFC] next > time with a similar refactoring. Otherwise, Looks good to me, thanks! Thanks! Added [NFC] to the title.

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86959/new/ https://reviews.llvm.org/D86959

[PATCH] D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield

MyDeveloperDay added a comment. I'm not a C++ language lawyer so I'm not sure which standard introduce enum inheritance? (maybe its something we could always do?), if its a recent change we just need to ensure we are conforming to the C++ version that is needed to build clang. Apart from that

[PATCH] D86941: [clang-format] Add a test showing the current config file list parsing

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86941/new/ https://reviews.llvm.org/D86941

[PATCH] D86926: FormatTest: Provide real line number in failure messages

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, I've certainly been bit myself in the past with not knowing which test actually failed especially when they are all foo() something.. thank you Repository: rG

[PATCH] D86775: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86775/new/ https://reviews.llvm.org/D86775

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. In D66564#2256424 , @Eugene.Zelenko wrote: > In D66564#2256423 , @ffrankies wrote: > >> @Eugene.Zelenko I don't have commit access to the repository, could you >> please commit this

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

Actually in 2a03f270d69cf1079feb029f84727288e217588a On Fri, Sep 4, 2020 at 10:27 AM Nico Weber wrote: > Test added in 85a9f6512a3cff797f1964c36c59d53e97a680c4 > > On Fri, Sep 4, 2020 at 10:14 AM Nico Weber wrote: > >> To keep the bots greener over the long weekend, I went ahead and reverted

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

dmantipov created this revision. dmantipov added a reviewer: manojgupta. Herald added a project: clang. Herald added a subscriber: cfe-commits. dmantipov requested review of this revision. Check whether /etc/env.d/gcc exists before trying to read from any file from there. This saves a few OS

[clang] 2a03f27 - clang: Add test for -Wunreachable-code + weak redeclaration

Author: Nico Weber Date: 2020-09-04T10:35:50-04:00 New Revision: 2a03f270d69cf1079feb029f84727288e217588a URL: https://github.com/llvm/llvm-project/commit/2a03f270d69cf1079feb029f84727288e217588a DIFF: https://github.com/llvm/llvm-project/commit/2a03f270d69cf1079feb029f84727288e217588a.diff

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx added a comment. Thanks for the excellent feedback, @ebevhan . @aaron.ballman , @krememek , or @rsmith , could one of you take a look at this change and if it's acceptable, please approve it? I have not requested commit privileges yet, either, so I will need your

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

Test added in 85a9f6512a3cff797f1964c36c59d53e97a680c4 On Fri, Sep 4, 2020 at 10:14 AM Nico Weber wrote: > To keep the bots greener over the long weekend, I went ahead and reverted > this for now in 7b0332389afd705f46b02fcf87ec3414b8dece34. I'll add a test > for this. > > On Fri, Sep 4, 2020 at

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

To keep the bots greener over the long weekend, I went ahead and reverted this for now in 7b0332389afd705f46b02fcf87ec3414b8dece34. I'll add a test for this. On Fri, Sep 4, 2020 at 10:11 AM Nico Weber wrote: > Hi Richard, > > this breaks Wunreachable-code which now ignore "weak" on

[clang] 7b03323 - Revert "Canonicalize declaration pointers when forming APValues."

Author: Nico Weber Date: 2020-09-04T10:13:28-04:00 New Revision: 7b0332389afd705f46b02fcf87ec3414b8dece34 URL: https://github.com/llvm/llvm-project/commit/7b0332389afd705f46b02fcf87ec3414b8dece34 DIFF: https://github.com/llvm/llvm-project/commit/7b0332389afd705f46b02fcf87ec3414b8dece34.diff

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

Hi Richard, this breaks Wunreachable-code which now ignore "weak" on redeclarations: thakis@thakis:~/src/llvm-project$ cat foo.cc extern "C" void foo(void); extern "C" __attribute__((weak)) decltype(foo) foo; void g(), h(); void f() { if (foo) return g(); h(); }

[PATCH] D66564: [clang-tidy] new altera struct pack align check

Eugene.Zelenko added a comment. In D66564#2256423 , @ffrankies wrote: > @Eugene.Zelenko I don't have commit access to the repository, could you > please commit this check on our behalf? Sorry, I don't have it either. @aaron.ballman or @njames93 could do

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. @Eugene.Zelenko I don't have commit access to the repository, could you please commit this check on our behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 ___

[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Ah, this reads more clearly to me, thank you for the additional changes. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/ https://reviews.llvm.org/D84604

[PATCH] D87138: [analyzer] Introduce refactoring of PthreadLockChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. This seems to be a total non-functional-change. Please include [NFC] next time with a similar refactoring. Otherwise, Looks good to me, thanks! Repository: rG LLVM Github Monorepo

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13981 +bool overflow; +llvm::APInt product(index); +product += 1; ebevhan wrote: > chrish_ericsson_atx wrote: > > ebevhan wrote: > > > What if index is wider than

[PATCH] D87138: [analyzer] Introduce refactoring of PthreadLockChecker

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, vsavchenko, xazax.hun, NoQ, baloghadamsoftware. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs,

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

martong added a comment. About the whole raw offset and the related warning. There is a fundamental question: Should we warn at `[0][10]` ? void foo() { int a[10][10]; int *p0 = [9][9]; // OK int *p1 = [10][10]; // Out-of-bounds static_assert([0][10] == [1][0]); int *p2

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

martong added a comment. I am coping my comments that I've sent in mail, just in case. > However, in the checker, we don't check `byte offset < 0` directly. > We //simplify// the left part of the `byte offset < 0` inequality by > substracting/dividing both sides with the constant `C`, if the

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c9dbcda4f71: [modules] Correctly parse LateParsedTemplates in case of dependent modules. (authored by gargvaibhav64, committed by v.g.vassilev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 2c9dbcd - [modules] Correctly parse LateParsedTemplates in case of dependent modules.

Author: Vaibhav Garg Date: 2020-09-04T11:39:04Z New Revision: 2c9dbcda4f71497d4a58020bb093af438fb6e967 URL: https://github.com/llvm/llvm-project/commit/2c9dbcda4f71497d4a58020bb093af438fb6e967 DIFF: https://github.com/llvm/llvm-project/commit/2c9dbcda4f71497d4a58020bb093af438fb6e967.diff LOG:

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss added a comment. @chill Could you check the latest update? I think it should be submitted with D84502 together. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14063 + if (isUnboundedArray) { +if (index.isUnsigned() || !index.isNegative()) { + const auto = getASTContext(); This could be early return to avoid the indentation.

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

martong added a comment. The key question is this: Why exactly does `1735: ExpectedDecl ImportedOrErr = import(From);` fails to do the import properly when called from ASTImporter::ImportDefinition? Would it be possible to debug that from your LLDB test cases? Maybe starting with the simpler

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm added a comment. Another random thought that just came to me: what does the new driver do when you invoke it with no input files or options? I could imagine a few sensible outcomes (error: no input (clang and gcc/gfortran behaviour), print version and exit, print help and

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal added a comment. In D86874#2255990 , @martong wrote: > Hi Balázs, > > Since reviews.llvm.org is offline, I am sending my comments below, inline. > Thanks for your huge effort in explaining all this! > > Overall, I have a feeling that this

[PATCH] D86921: [FPEnv] Partially implement #pragma STDC FENV_ROUND

This revision was automatically updated to reflect the committed changes. Closed by commit rGa633da5391b0: [FPEnv] Partially implement #pragma STDC FENV_ROUND (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D86921?vs=289110=289901#toc Repository: rG LLVM Github

[clang] fe0972d - [analyzer][StdLibraryFunctionsChecker] Do not match based on the restrict qualifier in C++

Author: Gabor Marton Date: 2020-09-04T11:48:38+02:00 New Revision: fe0972d3e4a65b4c5f5fa602b17ad30e463050b3 URL: https://github.com/llvm/llvm-project/commit/fe0972d3e4a65b4c5f5fa602b17ad30e463050b3 DIFF: https://github.com/llvm/llvm-project/commit/fe0972d3e4a65b4c5f5fa602b17ad30e463050b3.diff

[PATCH] D87097: [analyzer][StdLibraryFunctionsChecker] Do not match based on the restrict qualifier in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0972d3e4a6: [analyzer][StdLibraryFunctionsChecker] Do not match based on the restrict… (authored by martong). Changed prior to commit:

[clang] a633da5 - [FPEnv] Partially implement #pragma STDC FENV_ROUND

Author: Serge Pavlov Date: 2020-09-04T16:47:10+07:00 New Revision: a633da5391b0e42c0185132e8b532ae9bc34489f URL: https://github.com/llvm/llvm-project/commit/a633da5391b0e42c0185132e8b532ae9bc34489f DIFF: https://github.com/llvm/llvm-project/commit/a633da5391b0e42c0185132e8b532ae9bc34489f.diff

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Is there anything left to do to get approval? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing list

[PATCH] D87097: [analyzer][StdLibraryFunctionsChecker] Do not match based on the restrict qualifier in C++

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87097/new/ https://reviews.llvm.org/D87097

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 289893. simoll added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h

Re: [PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

Hi Balázs, Since reviews.llvm.org is offline, I am sending my comments below, inline. Thanks for your huge effort in explaining all this! Overall, I have a feeling that this approach targets only one specific case, which is fine. But I believe we should think about all the other possible cases,

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

jhenderson added inline comments. Comment at: llvm/lib/Object/MachOObjectFile.cpp:2745 ArrayRef MachOObjectFile::getValidArchs() { - static const std::array validArchs = {{ + static const std::array validArchs = {{ "i386", "x86_64", "x86_64h", "armv4t", "arm",