[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

rjmccall added inline comments. Comment at: llvm/include/llvm/IR/FixedPointBuilder.h:126 + /// \p Ty, or a floating point type with a larger exponent than Ty. + Type *getAccommodatingFloatType(Type *Ty, const FixedPointSemantics ) { +const fltSemantics *FloatSema =

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2131 +.. option:: -fsplit-machine-functions, -fno-split-machine-functions + You don't need to edit this file. It is auto-generated from Options.td Comment

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

rjmccall added a reviewer: ahatanak. rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2198 +// reference to the underlying object. Mark it accordingly. +Attrs.addAttribute(llvm::Attribute::NoAlias); + fhahn wrote: >

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

rjmccall added a comment. Follow-up on my previous request. It's fine by me if you commit with that fix. Comment at: clang/lib/Analysis/BodyFarm.cpp:188 + const_cast(Arg), nullptr, VK_RValue, +

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall added a comment. Also LGTM with a testcase. It's fine to test the result of IRGen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. In D75574#2262622 , @lanza wrote: >> I don't think it'll actually error out at link time: protocol objects get >> emitted eagerly on use, cross-module linking is just a code-size >> optimization. This actually has caused

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2267060 , @junparser wrote: > Thanks for the change. LGTM, and testcase？ Not sure how to add a test case for this though. We don't seem to explicitly test AST output. Repository: rG LLVM Github Monorepo CHANGES

Upcoming upgrade of LLVM buildbot

Hello everyone, The buildbot upgrade is entering the phase when the results to become visible. No change is required at this time on any of the builders. The bot owners could upgrade the buildbot on build computers later, at their convenience, as this is not on the critical path. We are going

[libclc] 16ba78e - libclc/spirv: Add missing files from D85911

Author: Jan Vesely Date: 2020-09-10T23:41:38-04:00 New Revision: 16ba78ee627c3fe66906349e8c90ee8cc1224298 URL: https://github.com/llvm/llvm-project/commit/16ba78ee627c3fe66906349e8c90ee8cc1224298 DIFF: https://github.com/llvm/llvm-project/commit/16ba78ee627c3fe66906349e8c90ee8cc1224298.diff

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked an inline comment as done. snehasish added inline comments. Comment at: clang/test/CodeGen/split-machine-functions.c:3 + +// RUN: echo "foo"> %t.proftext +// RUN: echo "# Func Hash:" >> %t.proftext snehasish wrote: >

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291122. snehasish marked an inline comment as done. snehasish added a comment. Fix test formatting. Added clang-format off to disable clang format for the test which contains both profile data (as text) and c code. Repository: rG LLVM Github Monorepo

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in an hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu updated this revision to Diff 291118. zequanwu added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Address comment. - Add cl::opt to disable emitting skipped regions for empty lines and comments (used on test case only), and update test cases

[clang] b22d450 - Remove dependency on clangASTMatchers.

Author: Michael Liao Date: 2020-09-10T22:17:48-04:00 New Revision: b22d45049682d1461b6b786f159681e2e5c2ce24 URL: https://github.com/llvm/llvm-project/commit/b22d45049682d1461b6b786f159681e2e5c2ce24 DIFF: https://github.com/llvm/llvm-project/commit/b22d45049682d1461b6b786f159681e2e5c2ce24.diff

Re: r364428 - Make CodeGen depend on ASTMatchers

That change was added long ago to fix the shared library build. Possibly, there are changes removing that dependency then. Just verified that removing that dependency is just fine. On Thu, Sep 10, 2020 at 6:48 AM Vassil Vassilev wrote: > > Hello, > >IIUC, clang's CodeGen does not immediately

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 29. zequanwu marked 2 inline comments as done. zequanwu retitled this revision from "[MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral " to "[MS ABI] Add mangled type for auto template parameter whose argument kind

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Thanks for the change. LGTM, and testcase？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits mailing list

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked 3 inline comments as done. snehasish added a comment. PTAL, thanks! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4259 options::OPT_fno_unique_basic_block_section_names, +options::OPT_fsplit_machine_functions, +

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291108. snehasish added a comment. Use OptInFFlag, split-file and update tests. - Change the flag type to OptInFFlag. - Use split-file in the test to avoid "RUN: echo" lines. - Use an existing warn message (if no profile is available) and add a check for

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 added inline comments. Comment at: clang/test/SemaObjC/attr-swift_objc_members.m:4 +#if !__has_attribute(swift_objc_members) +#error cannot verify precense of swift_objc_members attribute +#endif compnerd wrote: > aaron.ballman wrote: > > gribozavr2

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. Thanks, this one crept in during mass-renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87463/new/ https://reviews.llvm.org/D87463

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx added a comment. Thank you for the comments, @aaron.ballman . I'll update with the changes you requested shortly. I did have some requests for clarification of you, though. Thanks! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8841-8844

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing list

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Ping? It's been a week and AFAICT there's nothing left for me to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftObjCMembers : Attr { + let Spellings = [GNU<"swift_objc_members">]; aaron.ballman wrote: > Should this be inherited by

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:1992 +def fsplit_machine_functions : Flag <["-"], "fsplit-machine-functions">, + Group,

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:383 +const NonTypeTemplateParmDecl *PD = nullptr, +QualType *TemplateArgType = nullptr); + void mangleExpression(const Expr *E, const

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb109c42d91c: [DSE] Switch to MemorySSA-backed DSE by default. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fb109c4 - [DSE] Switch to MemorySSA-backed DSE by default.

Author: Florian Hahn Date: 2020-09-10T22:24:32+01:00 New Revision: fb109c42d91c30c8c7497ef1fd7aff6f2969c6e7 URL: https://github.com/llvm/llvm-project/commit/fb109c42d91c30c8c7497ef1fd7aff6f2969c6e7 DIFF: https://github.com/llvm/llvm-project/commit/fb109c42d91c30c8c7497ef1fd7aff6f2969c6e7.diff

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 291083. fhahn added a comment. Also restrict to types that are `isNonTrivialToPrimitiveCopy`, so we do not add noalias for problematic types, like ObjC structs with weak references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp

jthemphill created this revision. jthemphill added a reviewer: eduucaldas. Herald added a project: clang. Herald added a subscriber: cfe-commits. jthemphill requested review of this revision. Building on Mac OS with clang 12: jhemphill@jhemphill-mbp build % clang --version Apple clang

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2266725 , @asbirlea wrote: > I'm running additional testing in the background. I don't have anything > holding this back at this point. > Either check in and if something shows up, I'll let you know to resolve or >

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. I'm running additional testing in the background. I don't have anything holding this back at this point. Either check in and if something shows up, I'll let you know to resolve or revert,

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn updated this revision to Diff 291078. fhahn added a comment. Final rebase after new memcpy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 Files:

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry.c:1 -// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t +// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3394 +parameter. Currently, the error parameter is always the last parameter of type +``NSError**`` or ``CFErrorRef*``. Swift will remove the error parameter from +the imported API. When calling

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3387 +The ``swift_objc_members`` attribute maps to the ``@objcMembers`` Swift +attribute, which indicates that Swift members of this class, its subclasses, and +all extensions thereof, will

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

dim added a comment. In D73425#2266446 , @Bdragon28 wrote: > Any chance of a backport to 11? I submitted https://bugs.llvm.org/show_bug.cgi?id=47485 for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3387 +The ``swift_objc_members`` attribute maps to the ``@objcMembers`` Swift +attribute, which indicates that Swift members of this class, its subclasses, and +all extensions thereof, will

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

MaskRay added a subscriber: hans. MaskRay added a comment. In D73425#2266446 , @Bdragon28 wrote: > Any chance of a backport to 11? CC the release manager @hans Perhaps there is still time

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3387 +The ``swift_objc_members`` attribute maps to the ``@objcMembers`` Swift +attribute, which indicates that Swift members of this class, its subclasses, and +all extensions thereof, will

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3387 +The ``swift_objc_members`` attribute maps to the ``@objcMembers`` Swift +attribute, which indicates that Swift members of this class, its subclasses, and +all extensions thereof, will

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 added inline comments. Comment at: clang/test/SemaObjC/attr-swift_objc_members.m:4 +#if !__has_attribute(swift_objc_members) +#error cannot verify precense of swift_objc_members attribute +#endif aaron.ballman wrote: > gribozavr2 wrote: > > > The

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

dblaikie added a comment. In D85408#2262134 , @rahmanl wrote: > @efriedma Would you please chime in specially with respect to @MaskRay 's > comment about the clang test involving assembly? I'll chime in, perhaps @efriedma will/can too: This patch has no

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 291068. awarzynski marked 2 inline comments as done. awarzynski added a comment. Address final comments I also took the liberty and made the following changes in CMake scripts: - replaced add_library wiht add_flang_library - replaced add_executable with

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. Hey, any updates on this? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4934127 - Diable sanitizer options for amdgpu

Author: Yaxun (Sam) Liu Date: 2020-09-10T15:41:07-04:00 New Revision: 4934127e627d7c58342be15bc9230a7cbdf5273f URL: https://github.com/llvm/llvm-project/commit/4934127e627d7c58342be15bc9230a7cbdf5273f DIFF:

[PATCH] D87461: Disable sanitizer options for AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rG4934127e627d: Diable sanitizer options for amdgpu (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291063. snehasish added a comment. Check warning, specify target to avoid failures on windows. - Added a check for warning emitted if no profile is provided. - Added a triple for the remaining checks since we now emit an error for incompatible targets.

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added a comment. Any chance of a backport to 11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425 ___ cfe-commits mailing list

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291051. snehasish added a comment. Updated test and warning type. - Updated test to check for the diagnostic message. - Updated BackendUtil.cpp to use backend optimization failure warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Type.cpp:2324 // scalable and fixed-length vectors. -return Ctx.UnsignedCharTy; - case BuiltinType::SveInt16: -return

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added a comment. In D78938#2262713 , @jhenderson wrote: > In D78938#2261411 , @jfb wrote: > >> On C++20 mode rotting: it won't if someone sets up a bot. If it rots, then >> it's easier to un-rot with

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added a comment. Hi @jkorous > Do you guys intend to open-source also the training part of the model > pipeline ? Open sourcing the training part (both dataset generation and using an open sourced DecisionForest based framework for training) has been on our radar. Although

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; Should this be inherited on redeclarations? Comment at:

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftObjCMembers : Attr { + let Spellings = [GNU<"swift_objc_members">]; Should this be inherited by redeclarations, or is that not a thing with

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

flx updated this revision to Diff 291030. flx retitled this revision from "[clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from methods/functions without arguments " to "[clang-tidy]

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2128 + ]; + let Subjects = SubjectList<[Function, ObjCMethod], ErrorDiag>; + let Documentation = [SwiftErrorDocs]; rjmccall wrote: > compnerd wrote: > > aaron.ballman wrote: >

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from methods/functions without arguments

flx added a comment. The motivating false positive was the free functions `std::min`. To not limit the usefulness of the check I'll only disable arguments for free functions for now. Updated change coming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:30 + +set(DF_COMPILER ${CMAKE_CURRENT_SOURCE_DIR}/CompletionModelCodegen.py) +include(${CMAKE_CURRENT_SOURCE_DIR}/CompletionModel.cmake) sammccall wrote: > if you want the

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291024. usaxena95 marked 23 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files:

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind created this revision. lxfind added reviewers: lewissbaker, wenlei, hoy, bruno, junparser, rjmccall. Herald added subscribers: cfe-commits, dexonsmith, modocache. Herald added a project: clang. lxfind requested review of this revision. In generating the code for symmetric transfer, a

[clang] ab1de1f - [gcov] Delete flush_fn_list (unused since D83149)

Author: Fangrui Song Date: 2020-09-10T10:15:27-07:00 New Revision: ab1de1fcfb0c53bc768deb8f8bacefad7d378b7b URL: https://github.com/llvm/llvm-project/commit/ab1de1fcfb0c53bc768deb8f8bacefad7d378b7b DIFF: https://github.com/llvm/llvm-project/commit/ab1de1fcfb0c53bc768deb8f8bacefad7d378b7b.diff

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. for context this caused standalone swift-lldb builds to have warnings disabled via `-w` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. @compnerd Saleem, what do you think? (see also my reply to you) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___ cfe-commits

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2264785 , @asbirlea wrote: > I'm running into a crash with this, could you please hold off until tomorrow? > I'm working on getting a reproducer. @asbirlea Thanks for the reproducer, the issue should be sorted out. The

[PATCH] D83154: clang: Add -fcoverage-prefix-map

rnk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); keith wrote: > rnk wrote: > >

[PATCH] D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`

This revision was automatically updated to reflect the committed changes. Closed by commit rGc01d28dc51bd: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest`, `MutationsTest` and… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87461: Disable sanitizer options for AMDGPU

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87461/new/ https://reviews.llvm.org/D87461 ___ cfe-commits mailing list

[clang] c01d28d - [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest`, `MutationsTest` and `SynthesisTest`

Author: Eduardo Caldas Date: 2020-09-10T16:44:14Z New Revision: c01d28dc51bdd33404828a327320e3307a51bb22 URL: https://github.com/llvm/llvm-project/commit/c01d28dc51bdd33404828a327320e3307a51bb22 DIFF: https://github.com/llvm/llvm-project/commit/c01d28dc51bdd33404828a327320e3307a51bb22.diff

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

ldionne commandeered this revision. ldionne edited reviewers, added: CaseyCarter; removed: ldionne. ldionne added a comment. Herald added a subscriber: jkorous. In D87459#2265875 , @CaseyCarter wrote: >> Ah, I see it. I'll add that bit to libc++ so we

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware added a comment. OK, I reversed the matcher expression now, it seems to work, but I will check it on the //LLVM/Clang// codebase first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware added a comment. I found the problem: `hasBody()` always returns true if the function has //somewhere// a body. This means that also the `hasBody` matcher matches forward declarations. However, I only need the definition. This far I could not find any method to achieve that:

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, SjoerdMeijer, stuij. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. c-rhodes requested review of this revision. The AAPCS64 specifies the internal type is used for c++ mangling. For bfloat16

[PATCH] D87461: Disable sanitizer options for AMDGPU

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added subscribers: t-tye, tpr, dstuttard, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. Currently AMDGPU does not support sanitizer. Disable sanitizer options for now until they are

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter added a comment. > Ah, I see it. I'll add that bit to libc++ so we don't need special casing in > the tests. Feel free to steal this for your test changes. Shall I close this differential then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

ldionne added a comment. In D87459#2265871 , @CaseyCarter wrote: > In D87459#2265864 , @ldionne wrote: > >> What paper is this? I searched but failed to find a paper this falls off >> from. > > P0896R4 "The One

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290990. compnerd added a comment. Address @gribozavr2's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Files: clang/include/clang/Basic/Attr.td

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter added a comment. In D87459#2265864 , @ldionne wrote: > What paper is this? I searched but failed to find a paper this falls off from. P0896R4 "The One Ranges Proposal" - Ranges demands that all iterators have useful difference types.

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/test/SemaObjC/attr-swift-error.m:55 + +// This is unconventional and very odd but we do process it. +- (int)q0:(const NSError **)error __attribute__((__swift_error__(nonzero_result)));

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

ldionne added a comment. What paper is this? I searched but failed to find a paper this falls off from. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87459/new/ https://reviews.llvm.org/D87459 ___

RE: Clang-Format, Clang-Tidy - Absolute Path to config files

Hi Francois, I read your usecase. Our usecase is similar, but the difference is that we use Artifactory to store our tools and Conan to manage and install them. This way, having a Conan package with everything in it, including the config file is very scalable and maintainable. I did not quite

Re: [clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

On Thu, Sep 10, 2020 at 11:27 AM Nico Weber wrote: > > Looks like this broke the sphinx bot: > http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/65757/steps/docs-clang-tools-html/logs/stdio > > Can you take a look? Hopefully 66ac212ea97a529e171a7b8aea10638d7b9b9907 will resolve

[PATCH] D87451: add new clang option -fnovisibility.

DiggerLin updated this revision to Diff 290987. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/ClangCommandLineReference.rst

[clang-tools-extra] 66ac212 - Speculatively fix the Sphinx builder.

Author: Aaron Ballman Date: 2020-09-10T11:35:10-04:00 New Revision: 66ac212ea97a529e171a7b8aea10638d7b9b9907 URL: https://github.com/llvm/llvm-project/commit/66ac212ea97a529e171a7b8aea10638d7b9b9907 DIFF: https://github.com/llvm/llvm-project/commit/66ac212ea97a529e171a7b8aea10638d7b9b9907.diff

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter created this revision. CaseyCarter added reviewers: ldionne, mclow.lists, EricWF. Herald added subscribers: libcxx-commits, dexonsmith. Herald added a project: libc++. Herald added a reviewer: libc++. CaseyCarter requested review of this revision. Although libc++ doesn't yet implement

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet requested review of this revision. This patch updates the documentation about `__builtin_memcpy_inline` and reorders the sections so it is more

Re: [clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

Looks like this broke the sphinx bot: http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/65757/steps/docs-clang-tools-html/logs/stdio Can you take a look? On Tue, Sep 8, 2020 at 9:36 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Frank Derry

[PATCH] D87451: add new clang option -fnovisibility.

DiggerLin updated this revision to Diff 290978. DiggerLin added a comment. add a pragmas test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/ClangCommandLineReference.rst

[clang-tools-extra] 29cecbc - Fix clangd build after 33c9dbbd380

Author: Nico Weber Date: 2020-09-10T11:05:53-04:00 New Revision: 29cecbc5d6fe2ee36635d593171d59eab631639f URL: https://github.com/llvm/llvm-project/commit/29cecbc5d6fe2ee36635d593171d59eab631639f DIFF: https://github.com/llvm/llvm-project/commit/29cecbc5d6fe2ee36635d593171d59eab631639f.diff

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

ASDenysPetrov added a comment. Here is my five cents. I haven't done with the review yet. I'm gonna return to it a bit later. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:56 + bool operator==(const Range ) const { return Impl

Re: Clang-Format, Clang-Tidy - Absolute Path to config files

Hello, I worked on adding a similar feature some time back : https://reviews.llvm.org/D50147 It supports specifying styles by absolute file name as well as lookup of a style by name in various locations (like ~/.local/share/clang-format or /usr/share/clang-format), allowing to install styles on

[PATCH] D87455: Restrict UnnecessaryCopyInitialization check to variables initialized from methods/functions without arguments

flx created this revision. flx added reviewers: alexfh, sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. flx requested review of this revision. This restriction avoids cases where an alias is returned to an argument and which could lead to to a false positive

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

c-rhodes added inline comments. Comment at: clang/lib/AST/Type.cpp:2339 case BuiltinType::SveInt32: -return Ctx.IntTy; +return IsILP32 ? Ctx.LongTy : Ctx.IntTy; case BuiltinType::SveUint32: efriedma wrote: > sdesmalen wrote: > > Rather than

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

c-rhodes updated this revision to Diff 290974. c-rhodes edited the summary of this revision. c-rhodes added a comment. - Get the element type of scalable vectors from `getBuiltinVectorTypeInfo` when creating VLS types. This fixes the ABI issue since it calls `ASTContext::getIntTypeForBitwidth`

[clang-tools-extra] 33c9dbb - Add an explicit toggle for the static analyzer in clang-tidy

Author: Nico Weber Date: 2020-09-10T10:48:17-04:00 New Revision: 33c9dbbd380913e8ab7e5a8e82468f9f7d092187 URL: https://github.com/llvm/llvm-project/commit/33c9dbbd380913e8ab7e5a8e82468f9f7d092187 DIFF: https://github.com/llvm/llvm-project/commit/33c9dbbd380913e8ab7e5a8e82468f9f7d092187.diff

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

nemanjai added inline comments. Comment at: clang/lib/Headers/altivec.h:7743 + return __builtin_altivec_vrlqnm(__a, ((__c << ShiftMask) | +(__b << ShiftRotation))); +} While correct, this implementation will require two

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added a comment. In D71199#2265693 , @lebedev.ri wrote: > In D71199#2265692 , > @baloghadamsoftware wrote: > >> In D71199#2265594 , @lebedev.ri >> wrote: >>

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

baloghadamsoftware added a comment. In D85424#2258886 , @steakhal wrote: > void foo(int x) { > > int uninit; > x - uninit; // will-crash > > } This is not even related to the iterators. We could check first whether `LHS` is an iterator and early

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

baloghadamsoftware updated this revision to Diff 290967. baloghadamsoftware added a comment. Test added. Thank you for the test @steakhal! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85424/new/ https://reviews.llvm.org/D85424 Files:

  1   2   >