[PATCH] D87837: [Driver] Remove the deprecation warning for -fuse-ld=/abs/path

chandlerc added a comment. FWIW, I would like to see *something* like this (both in the release and on trunk) but not sure this is actually the patch we want... Clang typically uses `FIXME` comments, and doesn't leave commented out code... I feel like this should be an off-by-default warning, w

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf64903fd8176: Add -Wno-error=unknown flag to clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f64903f - Add -Wno-error=unknown flag to clang-format.

Author: Joachim Meyer Date: 2020-09-19T10:17:57+02:00 New Revision: f64903fd81764f1fde7aeb00eea5e1d488458f63 URL: https://github.com/llvm/llvm-project/commit/f64903fd81764f1fde7aeb00eea5e1d488458f63 DIFF: https://github.com/llvm/llvm-project/commit/f64903fd81764f1fde7aeb00eea5e1d488458f63.diff

[clang-tools-extra] 985deba - Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code completion.""

Author: Utkarsh Saxena Date: 2020-09-19T10:54:04+02:00 New Revision: 985deba9319be464673c1002767f8a3ec597480d URL: https://github.com/llvm/llvm-project/commit/985deba9319be464673c1002767f8a3ec597480d DIFF: https://github.com/llvm/llvm-project/commit/985deba9319be464673c1002767f8a3ec597480d.diff

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous created this revision. nomanous added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nomanous requested review of this revision. The multi-character character constants should be implementation-defined according to the C standard but actually w

[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

chrish_ericsson_atx added inline comments. Comment at: clang/test/Analysis/plist-macros-with-expansion.cpp:536 + do { \ + } while (0) + Seems the do {} while (0) idiom is a problem, because the plist output gets formatted differently on w

[clang] e50465e - [HIP] Fix -gsplit-dwarf option

Author: Yaxun (Sam) Liu Date: 2020-09-19T10:06:51-04:00 New Revision: e50465ecefc964e5700df26fc7e02a673eed085a URL: https://github.com/llvm/llvm-project/commit/e50465ecefc964e5700df26fc7e02a673eed085a DIFF: https://github.com/llvm/llvm-project/commit/e50465ecefc964e5700df26fc7e02a673eed085a.dif

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGe50465ecefc9: [HIP] Fix -gsplit-dwarf option (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D87791?vs=292

[clang] 2819cea - Revert "[HIP] Fix -gsplit-dwarf option"

Author: Yaxun (Sam) Liu Date: 2020-09-19T10:15:27-04:00 New Revision: 2819cea2ef8aab9d7ef8ba29feec9cb58cc942f6 URL: https://github.com/llvm/llvm-project/commit/2819cea2ef8aab9d7ef8ba29feec9cb58cc942f6 DIFF: https://github.com/llvm/llvm-project/commit/2819cea2ef8aab9d7ef8ba29feec9cb58cc942f6.dif

[PATCH] D87561: [Sema] List conversion validate character array

Mordante added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:411-414 + void f(const char[4]); + void f(const wchar_t[4]); + void f(const char16_t[4]); + void f(const char32_t[4]); rsmith wrote: > These should presumably be references to arrays, r

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek updated this revision to Diff 292970. klimek marked 7 inline comments as done. klimek added a comment. Worked in review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83296/new/ https://reviews.llvm.org/D83296 Files: clang/lib/Fo

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek added inline comments. Comment at: clang/lib/Format/FormatToken.h:177 +/// EndOfExpansion: 0 0 0 21 0 1 +struct MacroContext { + MacroContext(MacroRole Role) : Role(Role) {} sammccall wrote: > "context" is often pretty vague - "MacroSource" i

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-non-word for the deprecation warning for -fuse-ld=/abs/path

MaskRay updated this revision to Diff 292973. MaskRay retitled this revision from "[Driver] Remove the deprecation warning for -fuse-ld=/abs/path" to "[Driver] Add disabled-by-default -Wuse-ld-non-word for the deprecation warning for -fuse-ld=/abs/path". MaskRay edited the summary of this revisio

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Replied comments by @aaron.ballman Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:216 +{"long","l"}, +{"long long", "ll"}, +{"unsigned long", "ul"}, aaron.bal

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292979. tianshilei1992 added a comment. Fixed the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeG

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri updated this revision to Diff 292984. lebedev.ri added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixing a few clang tests and updating one more llvm test to check this also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-non-word for the deprecation warning for -fuse-ld=/abs/path

dblaikie added a comment. Rather than "non-word" maybe "path" would be more legible (that's the terminology the message text uses, and seems shorter/clearer in the warning name/constant name/etc), ie: -Wuse-ld-path (how do other warnings about flags do naming regarding the 'f' (or 'g', etc) pr

[PATCH] D87974: Summary: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zoecarver requested review of this revision. Adds `__builtin_zero_non_value_bits` to zero all padding bits of a struct. Currently does not support unions or bitfields. Repository: rG LLVM G

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path

MaskRay updated this revision to Diff 292989. MaskRay retitled this revision from "[Driver] Add disabled-by-default -Wuse-ld-non-word for the deprecation warning for -fuse-ld=/abs/path" to "[Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path". MaskRa

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path

chandlerc added a comment. Good to confirm with Dave of course, but this looks pretty great to me, and thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87837/new/ https://reviews.llvm.org/D87837 __

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D87837#2283784 , @chandlerc wrote: > Good to confirm with Dave of course, but this looks pretty great to me, and > thanks so much! Works for me

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path

This revision was automatically updated to reflect the committed changes. Closed by commit rG9087209314ca: [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 9087209 - [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path

Author: Fangrui Song Date: 2020-09-19T15:49:44-07:00 New Revision: 9087209314caafed4b232d4a66287f2d16054ad3 URL: https://github.com/llvm/llvm-project/commit/9087209314caafed4b232d4a66287f2d16054ad3 DIFF: https://github.com/llvm/llvm-project/commit/9087209314caafed4b232d4a66287f2d16054ad3.diff

[PATCH] D87974: Summary: [Builtin] Add __builtin_zero_non_value_bits.

jfb added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1682 + + size_t NumFeilds = std::distance(R->field_begin(), R->field_end()); + auto CurrentField = R->field_begin(); Typo in "fields". Comment at: clang/test/CodeGenCXX/bu

[PATCH] D87979: [clangd] Link libclangdSupport into clangd-index-server

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/534 Repos

[PATCH] D87953: [xray] Function coverage groups

dberris added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:817 +CurFn->getName().bytes_end()); + auto Group = crc32(FuncName) % FuncGroups; + if (Group != CGM.getCodeGenOpts().XRaySelectedFunctionGroup && ---

[PATCH] D87953: [xray] Function coverage groups

ianlevesque added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:817 +CurFn->getName().bytes_end()); + auto Group = crc32(FuncName) % FuncGroups; + if (Group != CGM.getCodeGenOpts().XRaySelectedFunctionGroup &&

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny, qcolombet, MatzeB. Herald added projects: clang, LLVM. LuoYuanke requested review of this revision. Herald added a subscriber: jdoerfert. Change-Id: I935e1080916ffcb72af54c2c83faa8b2e97d5cb0

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293007. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Fixed some clang format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981