[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

Szelethus added a comment. The fix is great, thank you so much! The test seems to be annoying, it might be worth looking into it some other time, but that is definitely orthogonal to this patch. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1211-1212 -

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. Hi @dblaikie . I did run `ninja check-all` and `/bin/llvm-lit -av ../clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp` on this very new revision (abd70fb3983f342bc1c90f9c70a7b59790ad5206

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. I figured you're still working on this, sorry! I'd really like to chat about my earlier comment D71524#1917251 , as it kind of challenges the high level idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. @dblaikie sorry for not getting to it for so long. I'm taking a look at the problem you've described now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531

[clang] 0cd73db - [c++20] For P1907R1: Add checking for structural types for non-type

Author: Richard Smith Date: 2020-09-20T20:20:52-07:00 New Revision: 0cd73dbe2c0d169ec2cdd9a8264f4ee1695b53b7 URL: https://github.com/llvm/llvm-project/commit/0cd73dbe2c0d169ec2cdd9a8264f4ee1695b53b7 DIFF: https://github.com/llvm/llvm-project/commit/0cd73dbe2c0d169ec2cdd9a8264f4ee1695b53b7.diff

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293051. LuoYuanke added a comment. Herald added a subscriber: nikic. Updating D87981 : [X86] AMX programming model prototype. Fixed lit test case failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87225: [clangd] When finding refs for a template specialization, do not return refs to other specializations

nridge updated this revision to Diff 293047. nridge added a comment. Take a different fix approach, as suggested in the issue discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87225/new/ https://reviews.llvm.org/D87225 Files:

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge updated this revision to Diff 293045. nridge added a comment. Herald added a subscriber: mgrang. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87256/new/ https://reviews.llvm.org/D87256 Files:

[clang-tools-extra] 90a8c44 - [clangd] Fix typo in field name

Author: Nathan Ridge Date: 2020-09-20T19:52:39-04:00 New Revision: 90a8c44d92b217eccba2467a11d0658675b5fe80 URL: https://github.com/llvm/llvm-project/commit/90a8c44d92b217eccba2467a11d0658675b5fe80 DIFF: https://github.com/llvm/llvm-project/commit/90a8c44d92b217eccba2467a11d0658675b5fe80.diff

[PATCH] D87995: [clangd] Fix typo in field name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90a8c44d92b2: [clangd] Fix typo in field name (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87995: [clangd] Fix typo in field name

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge updated this revision to Diff 293040. nridge added a comment. Add clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87257/new/ https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge added a comment. In D87257#2260499 , @hokein wrote: > In D87257#2260022 , @nridge wrote: > >> I did try to add a test to `clang/test/Index/Core/index-source.cpp`, however >> the output of `c-index-test`

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

rsmith added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:421 -public: - constexpr TemplateArgumentLocInfo() : Template({nullptr, nullptr, 0, 0}) {} - - TemplateArgumentLocInfo(TypeSourceInfo *TInfo) : Declarator(TInfo) {} + T *getTemplate() const { +

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. Minor improvement and then LGTM. Comment at: clang/lib/Sema/SemaLookup.cpp:924 +void Sema::LookupNecessaryTypesForBuiltin(Scope *S, unsigned ID) { + if

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#2283961 , @sylvestre.ledru wrote: > Any chance this changes could have caused this regression > https://bugs.llvm.org/show_bug.cgi?id=47589 ? I don't think so, but I can double check the style defaults for the

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein added a comment. > Would it be possible to compile some big file in LLVM (probably doesn't > matter much which, Sema something?) and observe if there's a significant > change in overall ASTContext size? ~3% saving (measuring the `ASTContext::.getASTAllocatedMemory`) | |

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein updated this revision to Diff 293029. hokein marked an inline comment as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87080/new/ https://reviews.llvm.org/D87080 Files:

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 marked 9 inline comments as done. boga95 added a comment. Ping Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:289-293 + {"c_str", {"std::__cxx11::basic_string", {{0}, {ReturnValueIndex, + {"data", {"std::__cxx11::basic_string", {{0},

[PATCH] D87974: Summary: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added inline comments. Comment at: clang/test/CodeGenCXX/builtin-zero-non-value-bits.cpp:160 + +int main() { + testAllForType<32, 16, char>(11, 22, 33, 44); jfb wrote: > Usually CodeGen tests will use lit to check the emitted IR matches >

[PATCH] D87561: [Sema] List conversion validate character array

rsmith added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:411-414 + void f(const char[4]); + void f(const wchar_t[4]); + void f(const char16_t[4]); + void f(const char32_t[4]); rsmith wrote: > Mordante wrote: > > rsmith wrote: > > > These

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

CarolineConcatto updated this revision to Diff 293024. CarolineConcatto added a comment. - remove changes from cmakefiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 Files:

[PATCH] D87561: [Sema] List conversion validate character array

rsmith added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:411-414 + void f(const char[4]); + void f(const wchar_t[4]); + void f(const char16_t[4]); + void f(const char32_t[4]); Mordante wrote: > rsmith wrote: > > These should presumably be

[PATCH] D87953: [xray] Function coverage groups

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:814 +auto FuncGroups = CGM.getCodeGenOpts().XRayTotalFunctionGroups; +if (FuncGroups > 1) { + auto FuncName = ArrayRef(CurFn->getName().bytes_begin(), kyulee wrote: >

Re: [clang] 2ae1822 - [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof reference type (PR47495)

Thanks, I uploaded https://reviews.llvm.org/D87990 to fix this issue. ne 20. 9. 2020 o 19:58 Richard Smith napísal(a): > > On Sun, 20 Sep 2020 at 08:43, Dávid Bolvanský via cfe-commits > wrote: >> >> Author: Dávid Bolvanský >> Date: 2020-09-20T17:43:06+02:00 >> New Revision:

[PATCH] D87953: [xray] Function coverage groups

kyulee added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:814 +auto FuncGroups = CGM.getCodeGenOpts().XRayTotalFunctionGroups; +if (FuncGroups > 1) { + auto FuncName = ArrayRef(CurFn->getName().bytes_begin(), MaskRay wrote: >

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

CarolineConcatto created this revision. Herald added subscribers: cfe-commits, dang, mgorny. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. CarolineConcatto requested review of this revision. The sole purpose of this action is to read a

Re: [clang] 2ae1822 - [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof reference type (PR47495)

On Sun, 20 Sep 2020 at 08:43, Dávid Bolvanský via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: Dávid Bolvanský > Date: 2020-09-20T17:43:06+02:00 > New Revision: 2ae182258c49724e4daaae196de829ea65c116e8 > > URL: >

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri added a comment. In D87972#2284064 , @xbolva00 wrote: > In D87972#2284060 , @MaskRay wrote: > >> I have tested this patch internally and seen gains and losses. On one >> document search related

[PATCH] D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

MaskRay added a comment. The `(aWidth - 1) - clzsi(a)` change is correct, but why is the ctz change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86547/new/ https://reviews.llvm.org/D86547 ___

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

MaskRay added a comment. @rnk @amccarth Do you have more comments? ☺️ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70378/new/ https://reviews.llvm.org/D70378 ___ cfe-commits mailing list

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @aaron.ballman About changing `size_t nLength` to `cbLength`. I searched MSVC folders with `size_t`, many names of variable start with `n`, or `i` in MFC related files. So I prefer to keep it starts with `n`. Another side to name starts with `cb`, I found

[PATCH] D87953: [xray] Function coverage groups

MaskRay added a comment. The idea seems fine. > By selecting different groups over time you could cover the entire > application incrementally with lower overhead than instrumenting the entire > application at once. How large the overhead is? This is somewhat surprising to me.

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 added a comment. In D87972#2284060 , @MaskRay wrote: > I have tested this patch internally and seen gains and losses. On one > document search related benchmark 3~5% improvement. One zippy (snappy) there > is 3~5% regression. Perhaps we do need

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri added a comment. (I'm guessing that we are talking about run-time performance here.) In D87972#2284060 , @MaskRay wrote: > I have tested this patch internally and seen gains and losses. On one > document search related benchmark 3~5%

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 added a comment. In D87972#2284060 , @MaskRay wrote: > I have tested this patch internally and seen gains and losses. On one > document search related benchmark 3~5% improvement. One zippy (snappy) there > is 3~5% regression. Perhaps we do need

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

MaskRay added a comment. I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 2ae1822 - [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof reference type (PR47495)

Author: Dávid Bolvanský Date: 2020-09-20T17:43:06+02:00 New Revision: 2ae182258c49724e4daaae196de829ea65c116e8 URL: https://github.com/llvm/llvm-project/commit/2ae182258c49724e4daaae196de829ea65c116e8 DIFF:

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:66 +bool isPassedToStdMove(const ParmVarDecl , ASTContext ) { + // Check if the parameter has a name, in case of functions like -

[clang] a735d6e - JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI.

Author: Simon Pilgrim Date: 2020-09-20T13:55:29+01:00 New Revision: a735d6eae2847b039d12c75d4c794862dad59bc1 URL: https://github.com/llvm/llvm-project/commit/a735d6eae2847b039d12c75d4c794862dad59bc1 DIFF: https://github.com/llvm/llvm-project/commit/a735d6eae2847b039d12c75d4c794862dad59bc1.diff

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 added a comment. https://reviews.llvm.org/D68593 added late SROA to NPM so it would be good to enable it for LPM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

fhahn added a comment. Surprising this causes only such a small perf regression. I guess it should be OK given that, but here probably are some pathological cases out there where this may cause some noticeable compile-time regressions. IIUC the additional cases this catches come mainly from

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

sylvestre.ledru added a comment. Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

sylvestre.ledru added a comment. Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81272/new/ https://reviews.llvm.org/D81272

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

tambre created this revision. tambre added reviewers: rsmith, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre requested review of this revision. In case further such cases appear in the future we've got a generic function to add them to. Additionally

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293007. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Fixed some clang format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION