[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:746 + Expanded.BraceWrapping.SplitEmptyRecord = true; + Expanded.BraceWrapping.SplitEmptyNamespace = true; + Expanded.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; I didn't

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:586 IO.mapOptional("SortIncludes", Style.SortIncludes); IO.mapOptional("SortJavaStaticImport", Style.SortJavaStaticImport); IO.mapOptional("SortUsingDeclarations", Style.SortUsingDeclarat

[PATCH] D88034: [SyntaxTree][Synthesis] Implement `deepCopyExpandingMacros`

eduucaldas updated this revision to Diff 293361. eduucaldas added a comment. Remove buggy `deepCopy` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88034/new/ https://reviews.llvm.org/D88034 Files: clang/include/clang/Tooling/Syntax/BuildTree.h

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 293362. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Fix clang format and add test case for RA that across function call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D88034: [SyntaxTree][Synthesis] Implement `deepCopyExpandingMacros`

eduucaldas updated this revision to Diff 293363. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88034/new/ https://reviews.llvm.org/D88034 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Tooling/Syn

[clang] 3fec6dd - Reapply: [clang-cl] Always interpret the LIB env var as separated with semicolons

Author: Martin Storsjö Date: 2020-09-22T10:51:25+03:00 New Revision: 3fec6ddc276a595e4409f04dabdd50c84f5f2a2d URL: https://github.com/llvm/llvm-project/commit/3fec6ddc276a595e4409f04dabdd50c84f5f2a2d DIFF: https://github.com/llvm/llvm-project/commit/3fec6ddc276a595e4409f04dabdd50c84f5f2a2d.diff

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf93514545cd9: [AArch64] Fix return type of Neon scalar comparison intrinsics (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88009

[clang] f935145 - [AArch64] Fix return type of Neon scalar comparison intrinsics

Author: David Spickett Date: 2020-09-22T08:53:24+01:00 New Revision: f93514545cd91b132fe987618488b8c1e5388fb0 URL: https://github.com/llvm/llvm-project/commit/f93514545cd91b132fe987618488b8c1e5388fb0 DIFF: https://github.com/llvm/llvm-project/commit/f93514545cd91b132fe987618488b8c1e5388fb0.diff

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

NoQ requested changes to this revision. NoQ added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValu

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *RetValUnderCons

[PATCH] D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88077 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[clang] 66bcb14 - [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`.

Author: Eduardo Caldas Date: 2020-09-22T09:15:21Z New Revision: 66bcb14312a08b5d7e1197d23d748b2e23c4d852 URL: https://github.com/llvm/llvm-project/commit/66bcb14312a08b5d7e1197d23d748b2e23c4d852 DIFF: https://github.com/llvm/llvm-project/commit/66bcb14312a08b5d7e1197d23d748b2e23c4d852.diff LOG

[PATCH] D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66bcb14312a0: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto added a comment. Thank you @awarzynski for this patch. Very good that you added color feature for Fortran. It is just a shame that we do not test. Is there a way to add a regression test for it? I don't see any inconsistency with what we have on clang side, so it is good. My com

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. > I'm going to concentrate on the standalone port as I think that's the way > forward. If I get that working then can work through the other issues. I'm considering a slight change of plan. @cryptoad, in the name of incremental development, would you be happy for

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas updated this revision to Diff 293386. eduucaldas added a comment. - [SyntaxTree] Split `TreeTest` and `ListTest` testing fixtures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87839/new/ https://reviews.llvm.org/D87839 Files: clang/i

[PATCH] D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag.

eduucaldas updated this revision to Diff 293389. eduucaldas added a comment. Add FIXME for `MIN(X, Y)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88077/new/ https://reviews.llvm.org/D88077 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.c

[PATCH] D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag.

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:3858 -TEST_P(BuildSyntaxTreeTest, NonModifiableNodes) { - // Some nodes are non-modifiable, they are marked with 'I:'. +TEST_P(BuildSyntaxTre

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. I made a separate class for the tests on Lists, as it didn't share any methods with the tests for Trees. What do you think about that? Should I also put the tests for lists in a different file, even though `TreeTest.cpp` could

[PATCH] D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag.

eduucaldas added a comment. Looking for feedback, specially on the names I used. Also if you have ideas of interesting tests they will be gladly accepted :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88077/new/ https://reviews.llvm.org/D88077

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 293392. JonasToth added a comment. - rebase to master after AST Matchers are extracted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/CMak

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2255358 , @AlexanderLanin wrote: > Observed behavior: > > Change: `for(string_view token : split_into_views(file_content, " \t\r\n"))` > --> `for(string_view const token : split_into_views(file_content, " > \t\r\n"))

[PATCH] D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

atrosinenko added a comment. In D86547#2284095 , @MaskRay wrote: > The `(aWidth - 1) - clzsi(a)` change is correct, but why is the ctz change? `d.s.low` and `d.s.high` are `su_int`. While some helpers from `libgcc` are documented with `int`, `long`, etc.

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

MarcusJohnson91 created this revision. MarcusJohnson91 added reviewers: MyDeveloperDay, sylvestre.ledru. MarcusJohnson91 added a project: clang-format. Herald added a project: clang. MarcusJohnson91 requested review of this revision. Which should make these defaults more immune to changes in the B

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked an inline comment as not done. MarcusJohnson91 added inline comments. Comment at: clang/lib/Format/Format.cpp:586 IO.mapOptional("SortIncludes", Style.SortIncludes); IO.mapOptional("SortJavaStaticImport", Style.SortJavaStaticImport); IO.mapOp

[PATCH] D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space.

hokein added a comment. bump this in case you have missed this patch :) our another internal pipeline seems to need this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86964/new/ https://reviews.llvm.org/D86964 __

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

MyDeveloperDay added a comment. In the examples you give here.. (and I have a feeling there are others in the tests) some of these fields are the same in all 3 cases i.e. `SplitEmptyRecord, SplitEmptyFunction and SplitEmptyNamespace` In which case why doesn't BraceWrapping have a constructor th

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

MyDeveloperDay added a comment. I noticed the pre-merge tests failed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88084/new/ https://reviews.llvm.org/D88084 ___ cfe-commits mailing list cfe-commits@lis

[clang] 0fb97fd - [SystemZ][z/OS] Set default wchar_t type for zOS

Author: Abhina Sreeskantharajan Date: 2020-09-22T08:03:03-04:00 New Revision: 0fb97fd6a4f2ec9267a1f4d039ec8895c2460ab7 URL: https://github.com/llvm/llvm-project/commit/0fb97fd6a4f2ec9267a1f4d039ec8895c2460ab7 DIFF: https://github.com/llvm/llvm-project/commit/0fb97fd6a4f2ec9267a1f4d039ec8895c246

[PATCH] D87624: [SystemZ][z/OS] Set default wchar_t type for zOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb97fd6a4f2: [SystemZ][z/OS] Set default wchar_t type for zOS (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87624/new

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2262414 , @Meinersbur wrote: > Rebase after D83261 I will try to adapt it to the new interface (it won't work for `simd`, still need to capture the variables) and will send the patch ba

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 293418. JonasToth added a comment. - include ExprMutAnalyzer implementation changes, that got lost somehow with prior rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

JonasToth created this revision. JonasToth added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, jfb, a.sidorin, baloghadamsoftware. Herald added a project: clang. JonasToth requested review of this revision. This patch extracts the

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 293420. JonasToth added a comment. - rebase to revision for https://reviews.llvm.org/D88088 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 293422. JonasToth added a comment. - remove spurious formatting change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/clang-tidy/cppcoregu

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne updated this revision to Diff 293429. ldionne added a comment. Add some tests from D69134 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68364/new/ https://reviews.llvm.org/D68364 Files: libcxx/docs/Feat

[PATCH] D88003: Fix typos in ASTMatchers.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88003/new/ https://reviews.llvm.org/D88003 ___ cfe-commits mailing list

[PATCH] D88092: [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures

martong created this revision. martong added reviewers: balazske, Szelethus, steakhal, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald ad

[PATCH] D87839: [SyntaxTree] Test the List API

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:224 + /// "a, b c" <=> [("a", ","), ("b", nul), ("c", nul)] + /// "a, b,"<=> [("a", ","), ("b", ","), (nul, nul)] /// I'd slightly prefer "null" b/c "nul" refers to

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 293432. reikdas added a comment. Attempt an alternate approach, following @rsmith 's inline suggestions. Unfortunately, one of the tests added in this revision unexpectedly fail in this approach :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7759

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp:466 + template <> struct S<1> { using type = int; }; // expected-note {{'S<1>::type' declared here}} + S<1L>::type t; // expected-error {{no type named 'type' in 'PR9227::S<1L>'; did

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else ldionne wrote: > This breaks GCC (as of GCC 9). I don't know what mechanism G

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne accepted this revision as: libc++. ldionne added a comment. I'll go ahead and ship this even though I know it will cause problems on GCC. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size,

[clang] 6dc06fa - [SyntaxTree] Add tests for the assignment of the `canModify` tag.

Author: Eduardo Caldas Date: 2020-09-22T13:17:33Z New Revision: 6dc06fa09d1a259df1f897dc821ba1544e2bcd24 URL: https://github.com/llvm/llvm-project/commit/6dc06fa09d1a259df1f897dc821ba1544e2bcd24 DIFF: https://github.com/llvm/llvm-project/commit/6dc06fa09d1a259df1f897dc821ba1544e2bcd24.diff LOG

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else jwakely wrote: > ldionne wrote: > > This breaks GCC (as of GCC 9). I don't kn

[PATCH] D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of the `canModify` tag. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88077

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

jwakely added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else ldionne wrote: > jwakely wrote: > > jwakely wrote: > > > ldionne wrote: > > >

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); jasonliu wrote: > Question: > It looks like getNaturalAlignI

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

sanwou01 added a comment. SPEC 2017 on AArch64 is neutral on the geomean. The only slight worry is omnetpp with a 1% regression, but this is balanced by a .8% improvement on mcf. Other changes are in the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] e8fb4eb - [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

Author: David Tenty Date: 2020-09-22T09:55:06-04:00 New Revision: e8fb4eba4fb6cbda661080d76059f2b130df5020 URL: https://github.com/llvm/llvm-project/commit/e8fb4eba4fb6cbda661080d76059f2b130df5020 DIFF: https://github.com/llvm/llvm-project/commit/e8fb4eba4fb6cbda661080d76059f2b130df5020.diff L

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8fb4eba4fb6: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87927/ne

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. In D87946#2286434 , @grokos wrote: > Correct, all `__tgt_target_*` functions not ending in `_mapper` are part of > the old interface and we are keeping them for compatibility with older > versions of clang. These older clang vers

[PATCH] D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr

kpn abandoned this revision. kpn added a comment. Unneeded since D85960 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85920/new/ https://reviews.llvm.org/D85920

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk added a comment. @nemanjai Would you please take another look to see if I have addressed your comments when you get a chance? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500 __

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2287242 , @russell.gallop wrote: > I'm considering a slight change of plan. @cryptoad, in the name of > incremental development, would you be happy for me to put the scudo sanitizer > version up (with working tests),

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0724f8bf47f8: [libc++] Implement C++20's P0784 (More constexpr con

[PATCH] D88100: [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries

martong created this revision. martong added reviewers: balazske, Szelethus, steakhal, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald ad

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

FWIW I tested check-msan in a -DCMAKE_BUILD_TYPE=Release build on a powerpc64le machine. All tests passed. I cannot connect the failure to the clang patch. On Mon, Sep 21, 2020 at 10:02 PM Sriraman Tallam wrote: > > On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator > wrote: > > > >

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293466. tianshilei1992 added a comment. Fixed the case `target_teams_distribute_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added a comment. Thanks for working on it. Few comments inline: 1. For an out-of-tree build, I see `check-flang` target failing with /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fatal error: filesystem: No such file or directory #include ^~~~ I us

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. compnerd marked 4 inline comments as done. Closed by commit rG9bb5ecf1f760: Sema: introduce `__attribute__((__swift_name__))` (authored by compnerd). Changed prior to

[clang] 9bb5ecf - Sema: introduce `__attribute__((__swift_name__))`

Author: Saleem Abdulrasool Date: 2020-09-22T15:32:23Z New Revision: 9bb5ecf1f760e1b1fe4697189e4db99100baffad URL: https://github.com/llvm/llvm-project/commit/9bb5ecf1f760e1b1fe4697189e4db99100baffad DIFF: https://github.com/llvm/llvm-project/commit/9bb5ecf1f760e1b1fe4697189e4db99100baffad.diff

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

Conanap updated this revision to Diff 293474. Conanap marked 2 inline comments as done. Conanap added a comment. Changed implementation for vrlqnm as per Nemanja CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86819/new/ https://reviews.llvm.org/D86819 Files: clang/include/clang/Basic/

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall created this revision. sammccall added reviewers: clayborg, kadircet, wallace. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, arphaman, mgrang, hiraditya. Herald added projects: clang, LLVM. sammccall requested review of this revision. Herald added a subscriber: ilya-bir

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas updated this revision to Diff 293489. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Answer code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87839/new/ https://reviews.llvm.org/D87839 Files: clang/i

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas updated this revision to Diff 293490. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87839/new/ https://reviews.llvm.org/D87839 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/unittests/Tooling/Sy

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:224 + /// "a, b c" <=> [("a", ","), ("b", nul), ("c", nul)] + /// "a, b,"<=> [("a", ","), ("b", ","), (nul, nul)] /// g

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Tue, Sep 22, 2020 at 8:34 AM Fāng-ruì Sòng wrote: > > FWIW I tested check-msan in a -DCMAKE_BUILD_TYPE=Release build on a > powerpc64le machine. All tests passed. I cannot connect the failure to > the clang patch. Thanks for doing this! Much appreciated! > > On Mon, Sep 21, 2020 at 10:02 PM S

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

morehouse added a comment. Thanks for looking. Indeed, it looks like an issue with the disk being full on the bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87921/new/ https://reviews.llvm.org/D87921 _

[clang] 079757b - [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

Author: Amy Kwan Date: 2020-09-22T11:31:44-05:00 New Revision: 079757b551f3ab5218af7344a7ab3c79976ec478 URL: https://github.com/llvm/llvm-project/commit/079757b551f3ab5218af7344a7ab3c79976ec478 DIFF: https://github.com/llvm/llvm-project/commit/079757b551f3ab5218af7344a7ab3c79976ec478.diff LOG:

[clang] b314705 - [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM

Author: Amy Kwan Date: 2020-09-22T11:31:44-05:00 New Revision: b3147058dec7d42ae0284d6e6edf25eb762c8b89 URL: https://github.com/llvm/llvm-project/commit/b3147058dec7d42ae0284d6e6edf25eb762c8b89 DIFF: https://github.com/llvm/llvm-project/commit/b3147058dec7d42ae0284d6e6edf25eb762c8b89.diff LOG:

[PATCH] D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3147058dec7: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM (authored by amyk). Repository: rG LLVM Github Monorep

[PATCH] D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079757b551f3: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Synt

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm created this revision. cebowleratibm added reviewers: daltenty, ZarkoCA, sfertile. Herald added subscribers: cfe-commits, shchenz, nemanjai. Herald added a project: clang. cebowleratibm requested review of this revision. Adding this test so that I can extend it in a follow on patch w

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

JonasToth added a comment. In D54222#2281642 , @jranieri-grammatech wrote: > @JonasToth It looks like there are some outstanding review comments that need > to be addressed. I've gotten some time allocated to work on this next week. Great! Repository:

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth added a comment. In D87588#2278948 , @ro wrote: > As described in D87825 , this patch broke > `Debug` builds on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`. Thank you for reporting this issue. I it is f

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(

[PATCH] D87839: [SyntaxTree] Test the List API

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c08bfdfd62: [SyntaxTree] Test the List API (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87839/new/ https://reviews.llvm.org/D87

[clang] c3c08bf - [SyntaxTree] Test the List API

Author: Eduardo Caldas Date: 2020-09-22T17:07:41Z New Revision: c3c08bfdfd6244e0429753ee56df39c90187d772 URL: https://github.com/llvm/llvm-project/commit/c3c08bfdfd6244e0429753ee56df39c90187d772 DIFF: https://github.com/llvm/llvm-project/commit/c3c08bfdfd6244e0429753ee56df39c90187d772.diff LOG

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

dblaikie added a comment. In D87808#2286664 , @rsmith wrote: > In D87808#2280197 , @dblaikie wrote: > >> @rsmith What's the deal with these anonymous structs/unions? Why do they >> have copy/move constructors (are

[PATCH] D87989: [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag

awarzynski added a comment. @CarolineConcatto , thank you for this patch! It implements some really important functionality and IMO the overall structure is solid. I've left quite a few comments, but mostly nits and suggestions for more detailed comments. There's a few, but it's a relatively bi

[PATCH] D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:705 + // Unlike matchesAnyAncestorOf there's no memoization: it doesn't save much. + bool matchesParentOf(const DynTypedNode &Node, const DynTypedMa

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/powerpc-c99complex.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-linux -emit-llvm %s -o - | FileCheck %s --check-prefixes=PPC64LNX +// RUN: %clang_cc1 -triple powerpc-unknown-linux -emit-llvm %s -o - | FileCheck

[clang] 6257618 - [ASTMatchers] Avoid recursion in ancestor matching to save stack space.

Author: Sam McCall Date: 2020-09-22T19:43:41+02:00 New Revision: 625761825620f19a44c7a1482ce05d678a1b0deb URL: https://github.com/llvm/llvm-project/commit/625761825620f19a44c7a1482ce05d678a1b0deb DIFF: https://github.com/llvm/llvm-project/commit/625761825620f19a44c7a1482ce05d678a1b0deb.diff LO

[PATCH] D86964: [ASTMatchers] Avoid recursion in ancestor matching to save stack space.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG625761825620: [ASTMatchers] Avoid recursion in ancestor matching to save stack space. (authored by sammccall). Changed prior to commit: https://reviews.llvm.o

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293505. tianshilei1992 added a comment. Fixed the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeG

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

bruno accepted this revision. bruno added a comment. This looks pretty useful, thanks for adding this Volodymyr. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.org/D86895 ___

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

tschuett added a comment. Where is the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.org/D86895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. Should we wait for that one to land and then pick this one up? Otherwise any thoughts on the outstanding discussion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 _

[PATCH] D87949: [ThinLTO] Option to bypass function importing.

mtrofin updated this revision to Diff 293506. mtrofin added a comment. clang tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87949/new/ https://reviews.llvm.org/D87949 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/Backe

[clang] 8a64689 - [Analyzer][WebKit] UncountedLocalVarsChecker

Author: Jan Korous Date: 2020-09-22T11:05:04-07:00 New Revision: 8a64689e264ce039e4fb0a09c3e136a1c8451838 URL: https://github.com/llvm/llvm-project/commit/8a64689e264ce039e4fb0a09c3e136a1c8451838 DIFF: https://github.com/llvm/llvm-project/commit/8a64689e264ce039e4fb0a09c3e136a1c8451838.diff LO

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

dmajor added a comment. The expensive-checks bots have been red for several days. Could you please take a look or revert? riscv_generated_funcs.test: *** Bad machine code: MBB exits via unconditional fall-through but ends with a barrier instruction! *** - function:check_boundaries -

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

saghir added a comment. In D87921#2288096 , @morehouse wrote: > Thanks for looking. Indeed, it looks like an issue with the disk being full > on the bot. Hi, I checked the disk is not full on the bot. I am not sure what is going on here but its definit

[PATCH] D87815: [clang] Fix a typo-correction crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16ca71180330: [clang] Fix a typo-correction crash (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 16ca711 - [clang] Fix a typo-correction crash

Author: Haojian Wu Date: 2020-09-22T20:21:21+02:00 New Revision: 16ca711803300bd966acf8759876a1ccd478c616 URL: https://github.com/llvm/llvm-project/commit/16ca711803300bd966acf8759876a1ccd478c616 DIFF: https://github.com/llvm/llvm-project/commit/16ca711803300bd966acf8759876a1ccd478c616.diff LO

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293537. tianshilei1992 added a comment. Refined the case `declare_mapper_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

Conanap added a comment. It looks like this commit is causing a few failures on nearly all PPC bots and a sanitizer bot; would it be possible to revert this commit for now until the issue is resolved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

  1   2   >