[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

chandlerc added a comment. In D88789#2310967 , @efriedma wrote: > In D88789#2310606 , @chandlerc wrote: > >> FWIW, I still very much feel that this is the correct canonicalization, and >> that downstream problems *

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. In D88789#2310967 , @efriedma wrote: > To address the issue at hand, I think changing the isNonIntegralPointerType() > check to just isPtrOrPtrVectorTy() would be enough. I think that might make > sense? I briefly considered

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 296092. compnerd added a comment. Herald added a subscriber: mgorny. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 Files: clang/lib/DirectoryWatch

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:87 +DWORD dwLength = GetFinalPathNameByHandleW(hDirectory, NULL, 0, 0); +std::unique_ptr buffer{new WCHAR[dwLength + 1]}; +(void)GetFinalPathNameByHandleW(hDire

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 14 inline comments as done. compnerd added a comment. There already is testing coverage for this - I just missed the CMake changes. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:36 + alignas(DWORD) + CHAR Buffer[4 * (sizeof(FILE_N

[PATCH] D88550: [HIP] Fix -fgpu-allow-device-init option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe372c1d7624e: [HIP] Fix -fgpu-allow-device-init option (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D885

[clang] e372c1d - [HIP] Fix -fgpu-allow-device-init option

Author: Yaxun (Sam) Liu Date: 2020-10-04T22:13:05-04:00 New Revision: e372c1d7624e2402a5f91a640780fb32649922b6 URL: https://github.com/llvm/llvm-project/commit/e372c1d7624e2402a5f91a640780fb32649922b6 DIFF: https://github.com/llvm/llvm-project/commit/e372c1d7624e2402a5f91a640780fb32649922b6.dif

[PATCH] D88730: [HIP] Fix default output file for -E

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b551b79d3bb: [HIP] Fix default output file for -E (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D88730?vs=295799&id=296088#toc Repository: rG

[clang] 5b551b7 - [HIP] Fix default output file for -E

Author: Yaxun (Sam) Liu Date: 2020-10-04T22:03:16-04:00 New Revision: 5b551b79d3bba5a8a282bf5f72c7baaccf925870 URL: https://github.com/llvm/llvm-project/commit/5b551b79d3bba5a8a282bf5f72c7baaccf925870 DIFF: https://github.com/llvm/llvm-project/commit/5b551b79d3bba5a8a282bf5f72c7baaccf925870.dif

[clang] 9756a40 - Recommit "[HIP] Add option --gpu-instrument-lib="

Author: Yaxun (Sam) Liu Date: 2020-10-04T21:41:43-04:00 New Revision: 9756a402f297d0030689aaade3651785b7496649 URL: https://github.com/llvm/llvm-project/commit/9756a402f297d0030689aaade3651785b7496649 DIFF: https://github.com/llvm/llvm-project/commit/9756a402f297d0030689aaade3651785b7496649.dif

[clang] fef0ebb - Revert "[HIP] Add option --gpu-instrument-lib="

Author: Yaxun (Sam) Liu Date: 2020-10-04T21:27:29-04:00 New Revision: fef0ebbc0b39167656bd11283e3084b000b309dd URL: https://github.com/llvm/llvm-project/commit/fef0ebbc0b39167656bd11283e3084b000b309dd DIFF: https://github.com/llvm/llvm-project/commit/fef0ebbc0b39167656bd11283e3084b000b309dd.dif

[PATCH] D88557: [HIP] Add option --gpu-instrument-lib=

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f7790e7d23: [HIP] Add option --gpu-instrument-lib= (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D88557?vs=295244&id=296087#toc Repository:

[clang] 64f7790 - [HIP] Add option --gpu-instrument-lib=

Author: Yaxun (Sam) Liu Date: 2020-10-04T21:16:36-04:00 New Revision: 64f7790e7d2309b5d38949921a256acf8068e659 URL: https://github.com/llvm/llvm-project/commit/64f7790e7d2309b5d38949921a256acf8068e659 DIFF: https://github.com/llvm/llvm-project/commit/64f7790e7d2309b5d38949921a256acf8068e659.dif

[clang] 2c94d88 - [NewPM] collapsing nested pass mangers of the same type

Author: Yuanfang Chen Date: 2020-10-04T15:57:13-07:00 New Revision: 2c94d88e076990a7b533578a392a150d4b9b0fa8 URL: https://github.com/llvm/llvm-project/commit/2c94d88e076990a7b533578a392a150d4b9b0fa8 DIFF: https://github.com/llvm/llvm-project/commit/2c94d88e076990a7b533578a392a150d4b9b0fa8.diff

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c94d88e0769: [NewPM] collapsing nested pass mangers of the same type (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296081. jhuber6 added a comment. Changed the lit substitution to be for fixing this problem specifically. It made the tests too unreadable and wasn't a good solution since it didn't detect 16 bit architectures anyway. Repository: rG LLVM Github Monorepo

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

efriedma added a comment. In D88789#2310606 , @chandlerc wrote: > FWIW, I still very much feel that this is the correct canonicalization, and > that downstream problems *must* be fixed downstream. Avoiding this > canonicalization doesn't actually fix the

[clang] 6c6cd5f - [X86] Consolidate wide Key Locker intrinsics into the same header as the other Key Locker intrinsics.

Author: Craig Topper Date: 2020-10-04T12:09:21-07:00 New Revision: 6c6cd5f8a9750865800ce26bdeacd8455db3 URL: https://github.com/llvm/llvm-project/commit/6c6cd5f8a9750865800ce26bdeacd8455db3 DIFF: https://github.com/llvm/llvm-project/commit/6c6cd5f8a9750865800ce26bdeacd8455db3.diff

[clang] a02b449 - [X86] Sync AESENC/DEC Key Locker builtins with gcc.

Author: Craig Topper Date: 2020-10-04T12:09:41-07:00 New Revision: a02b449bb1556fe0f17b86eaa69f6bcda945d123 URL: https://github.com/llvm/llvm-project/commit/a02b449bb1556fe0f17b86eaa69f6bcda945d123 DIFF: https://github.com/llvm/llvm-project/commit/a02b449bb1556fe0f17b86eaa69f6bcda945d123.diff

[clang] 230c57b - [X86] Synchronize the encodekey builtins with gcc. Don't assume void* is 16 byte aligned.

Author: Craig Topper Date: 2020-10-04T12:09:35-07:00 New Revision: 230c57b0bd8321085a5e0339baf37b509d5c76f6 URL: https://github.com/llvm/llvm-project/commit/230c57b0bd8321085a5e0339baf37b509d5c76f6 DIFF: https://github.com/llvm/llvm-project/commit/230c57b0bd8321085a5e0339baf37b509d5c76f6.diff

[clang] 28595cb - [X86] Synchronize the loadiwkey builtin operand order with gcc version.

Author: Craig Topper Date: 2020-10-04T12:09:29-07:00 New Revision: 28595cbbeb2cc75584410b8b974f67ec99a853f2 URL: https://github.com/llvm/llvm-project/commit/28595cbbeb2cc75584410b8b974f67ec99a853f2 DIFF: https://github.com/llvm/llvm-project/commit/28595cbbeb2cc75584410b8b974f67ec99a853f2.diff

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

CarolineConcatto marked 7 inline comments as done. CarolineConcatto added a comment. @awarzynski patch updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 __

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

CarolineConcatto updated this revision to Diff 296066. CarolineConcatto edited the summary of this revision. CarolineConcatto added a comment. address reviews comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org

[PATCH] D88394: [Driver][M68K] (Patch 8/8) Add driver support for M68K

myhsu updated this revision to Diff 296065. myhsu added a comment. - Use the canonical CPU name (i.e. names started with upper case 'M') - Tell the driver to use integrated assembler (i.e. MC) by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 296064. myhsu added a comment. Fix the CPU name passing to the Backend CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt clang/lib/Ba

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri updated this revision to Diff 296055. lebedev.ri added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase/fix remaining tests. In D88789#2310441 , @nlopes wrote: > Not introducing inttoptr during optimizati

[clang] aaae13d - [NFC][clang][codegen] Autogenerate a few ARM SVE tests that are being affected by an upcoming patch

Author: Roman Lebedev Date: 2020-10-04T19:54:09+03:00 New Revision: aaae13d0c29ec2a20f93e6adb9d9b5c2656d2af6 URL: https://github.com/llvm/llvm-project/commit/aaae13d0c29ec2a20f93e6adb9d9b5c2656d2af6 DIFF: https://github.com/llvm/llvm-project/commit/aaae13d0c29ec2a20f93e6adb9d9b5c2656d2af6.diff

[clang] e3475f5 - [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Author: Esme-Yi Date: 2020-10-04T16:24:20Z New Revision: e3475f5b91c8dc3142b90b2bb4a1884d6e8d8c2c URL: https://github.com/llvm/llvm-project/commit/e3475f5b91c8dc3142b90b2bb4a1884d6e8d8c2c DIFF: https://github.com/llvm/llvm-project/commit/e3475f5b91c8dc3142b90b2bb4a1884d6e8d8c2c.diff LOG: [Powe

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3475f5b91c8: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp). (authored by Esme). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 296050. LuoYuanke added a comment. Herald added a subscriber: pengfei. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/Built

[clang] 1113fbf - [CodeGen] Improve likelihood branch weights

Author: Mark de Wever Date: 2020-10-04T14:24:27+02:00 New Revision: 1113fbf44c2250621548e278d2a1e11ab2b2d63d URL: https://github.com/llvm/llvm-project/commit/1113fbf44c2250621548e278d2a1e11ab2b2d63d DIFF: https://github.com/llvm/llvm-project/commit/1113fbf44c2250621548e278d2a1e11ab2b2d63d.diff

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG1113fbf44c22: [CodeGen] Improve likelihood branch weights (authored by Mordante). Changed prior to commit

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. In D88154#2290205 , @abique wrote: > Looks good to me. > Regarding the tests, it seems that you check if auto-vectorization takes > advantages of libmvec? > Would it be interesting to have a test which declares a

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 296035. venkataramanan.kumar.llvm added a reviewer: spatel. venkataramanan.kumar.llvm added a comment. Herald added a subscriber: pengfei. Selection of Glibc vector math library is enabled via the option -fvec-lib=libmvec . CHANGES SINCE L

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

This revision was automatically updated to reflect the committed changes. Closed by commit rG03bd5198b6f7: [OldPM] Pass manager: run SROA after (simple) loop unrolling (authored by lebedev.ri). Changed prior to commit: https://reviews.llvm.org/D87972?vs=296005&id=296028#toc Repository: rG LL

[clang] 03bd519 - [OldPM] Pass manager: run SROA after (simple) loop unrolling

Author: Roman Lebedev Date: 2020-10-04T11:53:50+03:00 New Revision: 03bd5198b6f7d9f49d72e6516d813a206f3b6d0d URL: https://github.com/llvm/llvm-project/commit/03bd5198b6f7d9f49d72e6516d813a206f3b6d0d DIFF: https://github.com/llvm/llvm-project/commit/03bd5198b6f7d9f49d72e6516d813a206f3b6d0d.diff

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri added a comment. In D87972#2310603 , @xbolva00 wrote: >> ! In D87972#2310595 , @nikic wrote: >> >>> I'll just say this LGTM as it establishes parity with what NewPM has been >>> doing for a while already

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 accepted this revision. xbolva00 added a comment. >> I'll just say this LGTM as it establishes parity with what NewPM has been >> doing for a while already. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. I'll just say this LGTM as it establishes parity with what NewPM has been doing for a while already. Reviewers, in the future, please reject any patches that only change the NewPM pipeline or o