[clang] e5e4653 - Remove dead variable to silence compiler warning [NFC]

Author: Mikael Holmen Date: 2020-10-16T09:26:52+02:00 New Revision: e5e4653255ff7d78d62923038ff085fae47e950b URL: https://github.com/llvm/llvm-project/commit/e5e4653255ff7d78d62923038ff085fae47e950b DIFF: https://github.com/llvm/llvm-project/commit/e5e4653255ff7d78d62923038ff085fae47e950b.diff

[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

gamesh411 created this revision. Herald added subscribers: cfe-commits, martong, Szelethus, dkrupp. Herald added a reviewer: Szelethus. Herald added a project: clang. gamesh411 requested review of this revision. Prefix operator++ should return the iterator incremented by reference. Repository:

[clang] 6030a07 - Fix hidden-redecls.m test for some environments

Author: Konstantin Schwarz Date: 2020-10-16T09:51:13+02:00 New Revision: 6030a075164c7016b29a67680ed5c9e7c5932109 URL: https://github.com/llvm/llvm-project/commit/6030a075164c7016b29a67680ed5c9e7c5932109 DIFF: https://github.com/llvm/llvm-project/commit/6030a075164c7016b29a67680ed5c9e7c5932109.

[PATCH] D89453: Fix hidden-redecls.m test for some environments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6030a075164c: Fix hidden-redecls.m test for some environments (authored by kschwarz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 51ff045 - Recommit "[DSE] Switch to MemorySSA-backed DSE by default."

Author: Florian Hahn Date: 2020-10-16T09:02:53+01:00 New Revision: 51ff04567b2f8d06b2062bd3ed72eab2e93e4466 URL: https://github.com/llvm/llvm-project/commit/51ff04567b2f8d06b2062bd3ed72eab2e93e4466 DIFF: https://github.com/llvm/llvm-project/commit/51ff04567b2f8d06b2062bd3ed72eab2e93e4466.diff

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

gamesh411 added a comment. In D87830#2298198 , @aaron.ballman wrote: > > know of any tests that are impacted by this? I haven't found any tidy-tests that were negative-tests (ie.: tests that assert that there are no diagnostics). > ... if I underst

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin updated this revision to Diff 298566. AlexanderLanin added a comment. Readd removed 'print help without crashing' test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 Files: clang-tools-extra/test/clang-tidy/infrastructure/run-c

[PATCH] D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89496/new/ https://reviews.llvm.org/D89496 ___ cfe-commits mailing list cfe-commi

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

MyDeveloperDay added a comment. LGTM, only keep the tests if they remain passing, otherwise perhaps @JakeMerdichAMD can add them back in. Could you add a test for the thing that broke to keep us honest? @JakeMerdichAMD when you get time, swing back round again with your fix because I think th

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 298568. aguinet added a comment. Add some clang-format tags, and restore back the "original" formatting for these cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 298569. aguinet added a comment. One missing formatting case... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/c

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall added a comment. This looks really nice! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:615 {"workspaceSymbolProvider", true}, {"referencesProvider", true}, {"executeCommandProvider", can you add `{"mem

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch 7 marshalling tests fails on Windows. This patch conta

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2333937 , @jvesely wrote: > In D89372#2332997 , @Anastasia wrote: > >> In D89372#2332853 , @jvesely wrote: >> >>> `cl_khr_byte_addressabl

[PATCH] D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang (authored by CarolineConcatto). Repository: rG LLVM Githu

[clang] e8d9ee9 - [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang

Author: Caroline Concatto Date: 2020-10-16T10:56:39+01:00 New Revision: e8d9ee9c7cfe46d9b552111a27d866fce0498b0a URL: https://github.com/llvm/llvm-project/commit/e8d9ee9c7cfe46d9b552111a27d866fce0498b0a DIFF: https://github.com/llvm/llvm-project/commit/e8d9ee9c7cfe46d9b552111a27d866fce0498b0a.d

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298578. kadircet marked 5 inline comments as done. kadircet added a comment. - Add memoryTreeProvider to initialization params - Move serialization logic to Protocol.h and return MemoryTree directly. - Drop `dump` from method name. Repository: rG LLVM Git

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

njames93 added a comment. In D89407#2333560 , @Eugene.Zelenko wrote: > I think will be good idea to add test for suffix/prefix too. Not strictly necessary, there are tests that make sure prefixes and suffixes are applied correctly. Then there are tests

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Hi, thanks for flagging the issue! Could you please give more information where exactly the tests fail (e.g. logs with assertions)? This way I could understand where exactly the

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2334407 , @kbobyrev wrote: > Hi, thanks for flagging the issue! Could you please give more information > where exactly the tests fail (e.g. logs with assertions)? This way I could > understand where exactly the failure

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. Logs: D:\work\llvm-project\build>ninja check-clangd [6/7] Running the Clangd regression tests llvm-lit.py: D:\work\llvm-project\build\bin\..\..\llvm\utils\lit\lit\llvm\config.py:347: note: using clang: d:\work\llvm-project\build\bin\clang.exe -- Testing: 905 tes

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

Anastasia added a comment. > Permitting non-standards-driven "do the best you can" constant-folding > of array bounds is permitted solely as a GNU compatibility feature. We > should not be doing it in any language mode that is attempting to be > conforming. > > From https://reviews.llvm.org/D20090

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a subscriber: thakis. lebedev.ri added a comment. Herald added a subscriber: wenlei. @paulkirth @phosek @leonardchan @thakis @nickdesaulniers It seems to me that this feature is still broken an unusable - https://bugs.llvm.org/show_bug.cgi?id=45073 -and the bug was reported more

[PATCH] D89487: [AMDGPU] gfx1032 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1beb95d1241: [AMDGPU] gfx1032 target (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec added inline comments. Comment at: clang/test/Driver/amdgpu-macros.cl:216 // GFX1031-DAG: #define FP_FAST_FMA 1 +// GFX1032-DAG: #define FP_FAST_FMA 1 tra wrote: > This test could use some refactoring. > Individual macro checks could be collapsed to >

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. The problem seems to be with a tied earlyclobber operand: asm("" : "+&r"(a)); Per the comment in InlineAsm::ConstraintInfo::Parse(), only output can be earlyclobber. I am not sure if the earlyclobber ('&') should with this patch be removed from the added use of the re

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev added a comment. In D89529#2334475 , @ArcsinX wrote: > In D89529#2334407 , @kbobyrev wrote: > >> Hi, thanks for flagging the issue! Could you please give more information >> where exactly the tests fail (e

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

uweigand added a comment. In D87279#2334510 , @jonpa wrote: > The problem seems to be with a tied earlyclobber operand: > > asm("" : "+&r"(a)); > > Per the comment in InlineAsm::ConstraintInfo::Parse(), only output can be > earlyclobber. > > I am not su

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2334517 , @kbobyrev wrote: > In D89529#2334475 , @ArcsinX wrote: > >> In D89529#2334407 , @kbobyrev wrote: >> >>> Hi, thanks for flagging t

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong added a comment. Seems like this patch handles already existing attributes in Clang, so this might not be affected by the concerns brought up here by James: http://lists.llvm.org/pipermail/cfe-dev/2020-October/066996.html Comment at: clang/include/clang/APINotes/APINot

[clang-tools-extra] 8a548bc - [clang-tidy] modernize-loop-convert reverse iteration support

Author: Nathan James Date: 2020-10-16T14:16:30+01:00 New Revision: 8a548bc203cfb0b2f830959cb7ec578c25512025 URL: https://github.com/llvm/llvm-project/commit/8a548bc203cfb0b2f830959cb7ec578c25512025 DIFF: https://github.com/llvm/llvm-project/commit/8a548bc203cfb0b2f830959cb7ec578c25512025.diff

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a548bc203cf: [clang-tidy] modernize-loop-convert reverse iteration support (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added a comment. LGTM from the perspective of making sure that this solution can be extended to any of the architectures that `libmvec` supports. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 __

[PATCH] D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks

njames93 updated this revision to Diff 298616. njames93 added a comment. Updated release notes to reflect change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79674/new/ https://reviews.llvm.org/D79674 Files: clang-tools-extra/clang-tidy/utils/R

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. In D89372#2334225 , @Anastasia wrote: >> > > Ok, so the pragma is supposed to control the pointer dereferencing which > seems like a valid case but however, it is not implemented now. Do we know of > any immediate plans from any

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 298624. jonpa added a comment. That makes sense... Patch updated to keep the tying of operands for this case of earlyclobber. @nickdesaulniers : Can you see if this patch now passes your builds? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/DeclSpec.cpp:1200 + // It has also been historically deprecated on AIX (as an alias for + // "vector int" in both 32-bit and 64-bi

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 298601. ffrankies marked 7 inline comments as done. ffrankies added a comment. Addressed comments by @aaron.ballman regarding the diagnostic warning. I tried to add a test case for when the filename is `kernel.cl`, `verilog.cl`, or `vhdl.cl`, but that did

[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

martong added a comment. What is the context here? Did it cause any crash/bug or were you just reading through the code for a good night sleep? :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89528/new/ https://reviews.llvm.org/D89528 __

[clang] 59a3b1a - clang-format: Assert in-memory file created in createInMemoryFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-16T10:20:32-04:00 New Revision: 59a3b1afb28541d5bf37445b028bfd711e3c556a URL: https://github.com/llvm/llvm-project/commit/59a3b1afb28541d5bf37445b028bfd711e3c556a DIFF: https://github.com/llvm/llvm-project/commit/59a3b1afb28541d5bf37445b028bfd711e3c

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel added a subscriber: aeubanks. spatel added a comment. In D88154#2328312 , @venkataramanan.kumar.llvm wrote: > I can add few more float type tests with meta data for VF=8. please let me > know your suggestions. I may be missing some subtlety of

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: ributzka, martong. Herald added a reviewer: shafik. dexonsmith requested review of this revision. It turns out that `FileInfo` *always* has a ContentCache. Clarify that in the code: - Update the pri

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski updated this revision to Diff 298635. awarzynski added a comment. Rebase + refector the unit test This is re-based on top of the latest version of D87989 . The unit test is update for consistency with D87989 . Reposit

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Since @CarolineConcatto has recently moved to a different project, I am assigning this to myself and will be responding to the future review comments. Tha

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:623 {"typeHierarchyProvider", true}, +{"memoryTreeProvider", true}, // clangd exte

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked 3 inline comments as done. compnerd added a comment. Thanks for the feedback! Comment at: clang/include/clang/APINotes/Types.h:1 +//===-- Types.h - API Notes Data Types --*- C++ -*-===// +// martong wrote: > So we are ma

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added a comment. +1 for revert Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru updated this revision to Diff 298639. sylvestre.ledru added a comment. Add the test which was failing + add the previous tests (but disabled) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298644. kadircet added a comment. s/memoryTree/memoryUsage/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89277/new/ https://reviews.llvm.org/D89277 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cl

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall. erichkeane requested review of this revision. As mentioned in the defect, the lambda static invoker does not follow the calling convention of the lambda itself, which seems wrong. This patch ensures that the calling co

[PATCH] D89487: [AMDGPU] gfx1032 target

foad added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack *TBA* +

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2334728 , @jvesely wrote: > In D89372#2334225 , @Anastasia wrote: > >>> >> >> Ok, so the pragma is supposed to control the pointer dereferencing which >> seems like a valid cas

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini updated this revision to Diff 298660. mantognini added a comment. Keep cl_khr_byte_addressable_store and cles_khr_int64 out of this PR. Add more details on the extensions being removed in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. I agree that it seems reasonable to preserve an explicit CC from the lambda on the converted function pointer. Comment at: clang/lib/Sema/SemaLambda.cpp:1268 +calcLambdaConversionFunctionCallConv(Sema &S, + const Fu

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; ...I made this comment in my first review, but Phabricator threw it away. The attributes let you explici

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1268 +calcLambdaConversionFunctionCallConv(Sema &S, + const FunctionProtoType *CallOpProto) { + CallingConv DefaultFree =

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464 _

[PATCH] D89487: [AMDGPU] gfx1032 target

t-tye added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack *TBA* +

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec marked 3 inline comments as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; rjmccall wrote: > ...I made this comment in my first review, but Phabricator threw it away. > > The at

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane updated this revision to Diff 298666. erichkeane marked an inline comment as done. erichkeane added a comment. Calc->get. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559 Files: clang/lib/Sema/SemaLambda.cpp clang/test/SemaCXX/lamb

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec marked 3 inline comments as done. rampitec added inline comments. Comment at: llvm/lib/Support/TargetParser.cpp:66 // Don't bother listing the implicitly true features -constexpr GPUInfo AMDGCNGPUs[43] = { +constexpr GPUInfo AMDGCNGPUs[44] = { // Name Canonic

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4d10e7e9bb4: [AMDGPU][HIP] Switch default DWARF version to 5 (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c4d10e7 - [AMDGPU][HIP] Switch default DWARF version to 5

Author: Scott Linder Date: 2020-10-16T17:53:27Z New Revision: c4d10e7e9bb47b77fad43d8ddcfa328298f36c88 URL: https://github.com/llvm/llvm-project/commit/c4d10e7e9bb47b77fad43d8ddcfa328298f36c88 DIFF: https://github.com/llvm/llvm-project/commit/c4d10e7e9bb47b77fad43d8ddcfa328298f36c88.diff LOG:

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a mass-market ver

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

john.brawn created this revision. john.brawn added reviewers: efriedma, vhscampos, chill. Herald added subscribers: dexonsmith, steven_wu, hiraditya, kristof.beyls. Herald added a project: clang. john.brawn requested review of this revision. LLVM assumes that when it creates a call to a C library

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Thanks for updating the patch. Please add a test case for the earlyclobber case. In particular, if none of the in-tree tests failed for the initial version of this

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

thakis resigned from this revision. thakis added a comment. hans and compnerd got this, no need for so many reviewers :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63473/new/ https://reviews.llvm.org/D63473 ___ cfe-commits mailing list cfe

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85788/new/ https://reviews.llvm.org/D85788 ___

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. dgoldman requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Nullability annotations are implmented using attributes; previusly clan

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:621-623 + if (auto AT = TL->getAs()) +S = AT.getModifiedLoc() +.getSourceRange(); // should we just return false? Let me know if you think it would be

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. 4dc5573acc0d2e7c59d8bac2543eb25cb4b32984 added `FileEntryRef` in order to help enable sharing of a `FileManager` between `CompilerIn

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith updated this revision to Diff 298702. rsmith marked 2 inline comments as done. rsmith added a comment. - Update User's Manual to more accurately describe GNU mode and Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.l

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. arsenm requested review of this revision. Herald added a subscriber: wdng. When the default flat work group size is 256, it should also ap

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. No, if you put a calling convention on a lambda and then convert it to a function pointer, you almost certainly want that CC to be honored. Is the `AttributedType` still present in `CallOperator->getType()`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. In D89559#2335557 , @rjmccall wrote: > No, if you put a calling convention on a lambda and then convert it to a > function pointer, you almost certainly want that CC to be honored. > > Is the `AttributedType` still present in `

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. Perhaps a better example: (gdb) p CallOperator->getType()->dump() FunctionProtoType 0x1177edf0 'void (void) __attribute__((vectorcall)) const' const vectorcall `-AutoType 0x1177a0d0 'void' sugar `-BuiltinType 0x11716dc0 'void' CHANGES SINCE LAST ACTION https://

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith updated this revision to Diff 298705. rsmith added a comment. - Update User's Manual to more accurately describe GNU mode and Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.llvm.org/D89523 Files: clang/docs/Users

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith added a comment. In D89523#2333939 , @efriedma wrote: > Also update the documentation? See > https://clang.llvm.org/docs/UsersManual.html#differences-between-various-standard-modes > . Done. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] dd4e8a5 - [docs] Fix some out-of-date / inaccurate text and missing formatting in the User's Manual.

Author: Richard Smith Date: 2020-10-16T12:00:13-07:00 New Revision: dd4e8a54b2ba9cec78441ba537b94f4eaa5acd84 URL: https://github.com/llvm/llvm-project/commit/dd4e8a54b2ba9cec78441ba537b94f4eaa5acd84 DIFF: https://github.com/llvm/llvm-project/commit/dd4e8a54b2ba9cec78441ba537b94f4eaa5acd84.diff

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

yaxunl added a comment. What if a device function is called by kernels with different work group sizes, will caller's work group size override callee's work group size? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89582/new/ https://reviews.llvm.org/D89582 ___

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

arsenm added a comment. In D89582#2335574 , @yaxunl wrote: > What if a device function is called by kernels with different work group > sizes, will caller's work group size override callee's work group size? It's user error to call a function with a larg

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith added a comment. In D89520#2334477 , @Anastasia wrote: >> I couldn't find any spec justification for accepting the kinds of cases >> that D20090 accepts, so a reference to >> where in the OpenCL specification >> th

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. In D89372#2335027 , @Anastasia wrote: > In D89372#2334728 , @jvesely wrote: > >> In D89372#2334225 , @Anastasia >> wrote: >> >>> >>> Ok, so th

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

rampitec added a comment. In D89582#2335619 , @arsenm wrote: > In D89582#2335574 , @yaxunl wrote: > >> What if a device function is called by kernels with different work group >> sizes, will caller's work group siz

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

arsenm added a comment. In D89582#2335671 , @rampitec wrote: > In D89582#2335619 , @arsenm wrote: > >> In D89582#2335574 , @yaxunl wrote: >> >>> What if a device function is

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith updated this revision to Diff 298724. rsmith added a comment. - Add more testcases to demonstrate behavior in C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89360/new/ https://reviews.llvm.org/D89360 Files: clang/lib/AST/ExprConstant.cp

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

rampitec added a comment. In D89582#2335704 , @arsenm wrote: > In D89582#2335671 , @rampitec wrote: > >> In D89582#2335619 , @arsenm wrote: >> >>> In D89582#2335574

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith added a comment. In D89360#2329167 , @rjmccall wrote: > Okay. I can accept the fairly unfortunate thing with `const int` > initializers. When is `IsConstantContext` set in C, just static initializers? This affects static initializers, enumerator

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89360/new/ https://reviews.llvm.org/D89360

[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

JDevlieghere added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:705 +llvm::Optional +SourceManager::getMemoryBufferForFileOrNone(const FileEntry *File) { const SrcMgr::ContentCache *IR = getOrCreateContentCache(File); Would it make sense to r

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Herald added a subscriber: sstefan1. If you're still interested in pursuing this, I'm happy to review it. A general comment is that there are a couple of functional changes in

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

guiand added a comment. Did we decide that we wanted this change then? I remember there being discussion around whether it's the right approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85788/new/ https://reviews.llvm.org/D85788

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298734. atmnpatel added a comment. Reverted to prior diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/ll

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis added a comment. I don't like the %clang_bin substitution - imho it's unclear for the test authors when to use it instead of %clang, but I can't come up with a better idea. Is it true that %clang_bin is only necessary when the automatically added -disable-noundef-analysis flag triggers

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298736. atmnpatel added a comment. nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transforms/Utils

[clang] 48c70c1 - Extend memset-to-zero optimization to C++11 aggregate functional casts

Author: Richard Smith Date: 2020-10-16T13:21:08-07:00 New Revision: 48c70c1664aa4512cb7e08352dd8eb33dde4807c URL: https://github.com/llvm/llvm-project/commit/48c70c1664aa4512cb7e08352dd8eb33dde4807c DIFF: https://github.com/llvm/llvm-project/commit/48c70c1664aa4512cb7e08352dd8eb33dde4807c.diff

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298740. atmnpatel added a comment. fixed splice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transfo

[clang] 7e801ca - Treat constant contexts as being in the default rounding mode.

Author: Richard Smith Date: 2020-10-16T13:26:15-07:00 New Revision: 7e801ca0efa99f7cec7a2aea30513ad282030b51 URL: https://github.com/llvm/llvm-project/commit/7e801ca0efa99f7cec7a2aea30513ad282030b51 DIFF: https://github.com/llvm/llvm-project/commit/7e801ca0efa99f7cec7a2aea30513ad282030b51.diff

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e801ca0efa9: Treat constant contexts as being in the default rounding mode. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SI

  1   2   >