[clang] 08c8d5b - Properly track whether a variable is constant-initialized.

Author: Richard Smith Date: 2020-10-19T23:59:11-07:00 New Revision: 08c8d5bc51c512e605840b8003fcf38c86d0fc96 URL: https://github.com/llvm/llvm-project/commit/08c8d5bc51c512e605840b8003fcf38c86d0fc96 DIFF: https://github.com/llvm/llvm-project/commit/08c8d5bc51c512e605840b8003fcf38c86d0fc96.diff

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

lebedev.ri added a comment. Reminder to upload patches with diff to master, not last patch/commit/upload. Wouldn't it be better for this to be a clang-tidy check, as opposed to a standalone tool? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday updated this revision to Diff 299274. oneraynyday added a comment. Don't use C++17 features as clang currently uses C++14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://reviews.llvm.org/D89765 Files: clang-tools-ex

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie accepted this revision. dblaikie added a comment. Looks good to me - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D89766: Driver: Add integer sanitizers to trapping group automatically.

pcc created this revision. pcc added reviewers: jfb, eugenis. Herald added a project: clang. pcc requested review of this revision. In D86000 we added a new sanitizer to the integer group without adding it to the trapping group. This broke usage of -fsanitize=int

[clang] 2484e91 - [Driver] Clean up -gz & --compress-debug-sections

Author: Fangrui Song Date: 2020-10-19T23:06:33-07:00 New Revision: 2484e9159c54def19aac69c4a217a55329da54d2 URL: https://github.com/llvm/llvm-project/commit/2484e9159c54def19aac69c4a217a55329da54d2 DIFF: https://github.com/llvm/llvm-project/commit/2484e9159c54def19aac69c4a217a55329da54d2.diff

[PATCH] D89700: [clangd] Don't offer to expand auto in structured binding declarations.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89700/new/ https://reviews.llvm.org/D89700 __

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

rsmith added inline comments. Comment at: clang/test/CodeGen/X86/avx-union.c:7 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx512f -fclang-abi-compat=11.0 -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK-LEGACY --check-prefix=AVX512-LEG

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

JDevlieghere added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:33 + +using llvm::Optional; +using llvm::StringRef; Won't this now make `llvm::Optional` visible as `clang::Optional` everywhere this header is included? Isn't this considered

[clang] 545c687 - [gcov] Unify driver and CC1 option names for -ftest-coverage & -fprofile-arcs

Author: Fangrui Song Date: 2020-10-19T22:19:00-07:00 New Revision: 545c687c4b06b403915b92f422ddad737a6357b9 URL: https://github.com/llvm/llvm-project/commit/545c687c4b06b403915b92f422ddad737a6357b9 DIFF: https://github.com/llvm/llvm-project/commit/545c687c4b06b403915b92f422ddad737a6357b9.diff

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks, Vitaly. Somebody is looking at this. On Mon, Oct 19, 2020 at 9:56 PM Vitaly Buka wrote: > it's not just staging, this build must be marked as failed > http://lab.llvm.org:8011/#/builders/74/builds/122 > > > On Mon, 19 Oct 2020 at 11:50, Vitaly Buka wrote: > >> There is some issue, at l

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

it's not just staging, this build must be marked as failed http://lab.llvm.org:8011/#/builders/74/builds/122 On Mon, 19 Oct 2020 at 11:50, Vitaly Buka wrote: > There is some issue, at least on staging. > http://lab.llvm.org:8014/#/builders/89/builds/184 has multiple failed > stages but marked a

[clang] 0ab222e - [gcov] Delete CC1 option -test-coverage

Author: Fangrui Song Date: 2020-10-19T21:48:51-07:00 New Revision: 0ab222e7d730bb1f8b676e64b51615624e08614b URL: https://github.com/llvm/llvm-project/commit/0ab222e7d730bb1f8b676e64b51615624e08614b DIFF: https://github.com/llvm/llvm-project/commit/0ab222e7d730bb1f8b676e64b51615624e08614b.diff

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]]

[clang] 3692d20 - Refactor tracking of constant initializers for variables.

Author: Richard Smith Date: 2020-10-19T21:31:19-07:00 New Revision: 3692d20d2b994ce865ffb97096b05218279e1ebd URL: https://github.com/llvm/llvm-project/commit/3692d20d2b994ce865ffb97096b05218279e1ebd DIFF: https://github.com/llvm/llvm-project/commit/3692d20d2b994ce865ffb97096b05218279e1ebd.diff

[clang-tools-extra] c7a7bba - Fixup clang-tidy after recent Clang change.

Author: Richard Smith Date: 2020-10-19T20:13:56-07:00 New Revision: c7a7bba8c101f575ef10cb54737033d71f2b722c URL: https://github.com/llvm/llvm-project/commit/c7a7bba8c101f575ef10cb54737033d71f2b722c DIFF: https://github.com/llvm/llvm-project/commit/c7a7bba8c101f575ef10cb54737033d71f2b722c.diff

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/ https://reviews.llvm.org/D88410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 added a comment. Herald added a subscriber: dexonsmith. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88352/new/ https://reviews.llvm.org/D88352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith created this revision. dexonsmith added reviewers: teemperor, Bigcheese, arphaman, JDevlieghere. Herald added subscribers: llvm-commits, ributzka, mgorny. Herald added a project: LLVM. dexonsmith requested review of this revision. Split out llvm/Support/FileSystem/UniqueID.h and clang/B

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 299246. dexonsmith edited the summary of this revision. dexonsmith added a comment. Improved the naming of the helper types for `FileEntryRef` and the `SeenFileEntries` map and removed dead code for the old typedef. Found when working on a follow-up. CH

Re: Upcoming upgrade of LLVM buildbot

Hello everyone, We have reached the point when all the bots could be updated to a newer buildbot-worker software. We should be fine to go with whatever the version is current for the OS on your bots. If you are a bot owner, please feel free to move your bots to the staging, upgrade the buildbot

[clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

Author: Richard Smith Date: 2020-10-19T19:04:04-07:00 New Revision: 76c0092665867a6defcd328ba0d0d976eb65d991 URL: https://github.com/llvm/llvm-project/commit/76c0092665867a6defcd328ba0d0d976eb65d991 DIFF: https://github.com/llvm/llvm-project/commit/76c0092665867a6defcd328ba0d0d976eb65d991.diff

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

vsapsai added a comment. In D86895#2340548 , @thakis wrote: > Looks like the test is still failing on windows: > http://45.33.8.238/win/26155/step_11.txt > > Ptal, and revert for now if it takes a while to fix. Reverted. Have you seen similar problems on

[clang] a28678e - Revert "Reland "[Modules] Add stats to measure performance of building and loading modules.""

Author: Volodymyr Sapsai Date: 2020-10-19T18:27:30-07:00 New Revision: a28678e20a112f8851fda2550e415924420bdcd5 URL: https://github.com/llvm/llvm-project/commit/a28678e20a112f8851fda2550e415924420bdcd5 DIFF: https://github.com/llvm/llvm-project/commit/a28678e20a112f8851fda2550e415924420bdcd5.di

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG774ab60125ee: Add option to use older clang ABI behavior when passing certain union types as… (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 774ab60 - Add option to use older clang ABI behavior when passing certain union types as function arguments

Author: Douglas Yung Date: 2020-10-19T18:17:34-07:00 New Revision: 774ab60125eeaeac8bf2470b7aaa6aa428d68453 URL: https://github.com/llvm/llvm-project/commit/774ab60125eeaeac8bf2470b7aaa6aa428d68453 DIFF: https://github.com/llvm/llvm-project/commit/774ab60125eeaeac8bf2470b7aaa6aa428d68453.diff

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

LiuChen3 added a comment. Adding an option compatible with old abi is good method. Looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89747/new/ https://reviews.llvm.org/D89747 ___ cfe-com

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

thakis added a comment. Looks like the test is still failing on windows: http://45.33.8.238/win/26155/step_11.txt Ptal, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.o

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

dyung added a comment. Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks! Comment at: clang/test/CodeGen/X86/avx-union.c:7 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -ta

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems fine to me; thanks for the fix. For future reference, please upload diffs with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). ===

[clang] b03ae74 - clang/Lex: Stop using SourceManager::getBuffer

Author: Duncan P. N. Exon Smith Date: 2020-10-19T20:27:56-04:00 New Revision: b03ae74319f19c3b86982638671d00205a91d263 URL: https://github.com/llvm/llvm-project/commit/b03ae74319f19c3b86982638671d00205a91d263 DIFF: https://github.com/llvm/llvm-project/commit/b03ae74319f19c3b86982638671d00205a91

[PATCH] D89402: clang/Lex: Stop using SourceManager::getBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb03ae74319f1: clang/Lex: Stop using SourceManager::getBuffer (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. In D89559#2340357 , @rsmith wrote: > In D89559#2339206 , @erichkeane > wrote: > >> Since the work is 99% the same, I think I should start doing that (emitting >> BOTH in the case where

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra updated this revision to Diff 299223. tra edited the summary of this revision. tra added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ https://reviews.llvm.org/D89752 Files: clang/lib/Driver/ToolChains/Cud

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra created this revision. tra added reviewers: yaxunl, emankov, hans. Herald added a subscriber: bixia. Herald added a project: clang. tra requested review of this revision. CUDA-11.1 does not carry version.txt which causes clang to assume that it's CUDA-7.0, which used to be the only CUDA versio

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

janosbenjaminantal added a comment. In D85697#2339055 , @aaron.ballman wrote: > I tend to be very skeptical of the value of checks that basically throw out > entire usable chunks of the base language because the check is effectively > impossible to appl

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rsmith added a comment. In D89559#2339206 , @erichkeane wrote: > Since the work is 99% the same, I think I should start doing that (emitting > BOTH in the case where it matches the default member but NOT the default free > function CC) in this review, th

[clang] 34ccc3e - [hmaptool] Fix `NameError: global name 'num_buckets' is not defined` in `action_dump`.

Author: Volodymyr Sapsai Date: 2020-10-19T16:27:13-07:00 New Revision: 34ccc3e13bccde6f5cf993c744efe4bcb1fd439a URL: https://github.com/llvm/llvm-project/commit/34ccc3e13bccde6f5cf993c744efe4bcb1fd439a DIFF: https://github.com/llvm/llvm-project/commit/34ccc3e13bccde6f5cf993c744efe4bcb1fd439a.di

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith created this revision. dexonsmith added reviewers: teemperor, Bigcheese. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Convert `SLocEntryLoaded` into an index vector into `LoadedSLocEntryTable`, where 0 indicates "not loaded", and change `LoadedSLocE

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

janosbenjaminantal added a comment. In D85697#2338249 , @njames93 wrote: > In D85697#2234468 , > @janosbenjaminantal wrote: > >> The known "limitations" are mostly similar to other checks: >> >> - It cannot detect

[clang] b3eff6b - Lexer: Update the Lexer to use MemoryBufferRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-19T19:10:21-04:00 New Revision: b3eff6b7bb31e7ef059a3d238de138849839fbbd URL: https://github.com/llvm/llvm-project/commit/b3eff6b7bb31e7ef059a3d238de138849839fbbd DIFF: https://github.com/llvm/llvm-project/commit/b3eff6b7bb31e7ef059a3d238de138849839

[PATCH] D89398: Lexer: Update the Lexer to use MemoryBufferRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3eff6b7bb31: Lexer: Update the Lexer to use MemoryBufferRef, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D89748: SourceManager: Use the same fake SLocEntry whenever it fails to load

dexonsmith created this revision. dexonsmith added a reviewer: teemperor. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Instead of putting a fake `SLocEntry` at `LoadedSLocEntryTable[Index]` when it fails to load in `SourceManager::loadSLocEntry`, allocate a fa

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

njames93 added a comment. In D85697#2339055 , @aaron.ballman wrote: > I tend to be very skeptical of the value of checks that basically throw out > entire usable chunks of the base language because the check is effectively > impossible to apply to an ex

[clang] 4000c9e - Reland "[Modules] Add stats to measure performance of building and loading modules."

Author: Volodymyr Sapsai Date: 2020-10-19T15:44:11-07:00 New Revision: 4000c9ee18ecebe3ff0f197af8c1fb434ad986e5 URL: https://github.com/llvm/llvm-project/commit/4000c9ee18ecebe3ff0f197af8c1fb434ad986e5 DIFF: https://github.com/llvm/llvm-project/commit/4000c9ee18ecebe3ff0f197af8c1fb434ad986e5.di

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

dyung created this revision. dyung added reviewers: probinson, rsmith, LiuChen3, craig.topper. dyung added a project: clang. Herald added subscribers: dexonsmith, pengfei. dyung requested review of this revision. Recently commit D78699 (commit 26cfb6e562f1

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89708/new/ https://reviews.llvm.org/D89708 _

[PATCH] D89398: Lexer: Update the Lexer to use MemoryBufferRef, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Lex/Lexer.h:145 /// outlive it, so it doesn't take ownership of either of them. - Lexer(FileID FID, const llvm::MemoryBuf

[PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

vsk abandoned this revision. vsk added a comment. This isn't on my radar at the moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22943/new/ https://reviews.llvm.org/D22943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D89398: Lexer: Update the Lexer to use MemoryBufferRef, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:145 /// outlive it, so it doesn't take ownership of either of them. - Lexer(FileID FID, const llvm::MemoryBuffer *InputFile, Preprocessor &PP); + Lexer(FileID FID, const llvm::MemoryBufferRef &Inpu

[PATCH] D31363: [libc++] Remove cmake glob for source files

dexonsmith resigned from this revision. dexonsmith added a reviewer: ldionne. dexonsmith added a comment. In D31363#889044 , @smeenai wrote: > @rjmccall, this adds a libc++ build dependency on LLVM's cmake modules. There > were some issues when @zturner ha

[PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Herald added subscribers: pengfei, fedor.sergeev, kristof.beyls, krytarowski. Herald added a reviewer: JDevlieghere. I'm not sure if you're still interested in pursuing this, b

[clang] 52bcd69 - Recommit "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"

Author: Yaxun (Sam) Liu Date: 2020-10-19T17:48:04-04:00 New Revision: 52bcd691cb1992187d022161e95977a9db371f51 URL: https://github.com/llvm/llvm-project/commit/52bcd691cb1992187d022161e95977a9db371f51 DIFF: https://github.com/llvm/llvm-project/commit/52bcd691cb1992187d022161e95977a9db371f51.dif

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7e561b62d2f2: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic (authored by yaxunl). Herald added a subscriber: dexo

[clang] 7e561b6 - [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Author: Yaxun (Sam) Liu Date: 2020-10-19T17:48:04-04:00 New Revision: 7e561b62d2f2140fcacfcdf78c42f01181fe0df5 URL: https://github.com/llvm/llvm-project/commit/7e561b62d2f2140fcacfcdf78c42f01181fe0df5 DIFF: https://github.com/llvm/llvm-project/commit/7e561b62d2f2140fcacfcdf78c42f01181fe0df5.dif

[PATCH] D89398: Lexer: Update the Lexer to use MemoryBufferRef, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:145 /// outlive it, so it doesn't take ownership of either of them. - Lexer(FileID FID, const llvm::MemoryBuffer *InputFile, Preprocessor &PP); + Lexer(FileID FID, const llvm::MemoryBufferRef &Inpu

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89743 Files: clang/include/clang/AST/ASTFwd.h

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. An alternative would be to update the unions to an `AlignedCharArrayUnion` and use `SourceLocation` directly. WDYT? Comment at: clang/include/clang/AST/Dec

[PATCH] D69844: [Basic] Integrate SourceLocation and SourceRange with FoldingSet, NFCI

dexonsmith requested changes to this revision. dexonsmith added a reviewer: dexonsmith. dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceLocation.h:184-185 + /// Write this source location to a FoldingSetNodeID + void Profile(llvm::FoldingSetNodeI

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Assuming everyone is okay with the direction, any comments on the change itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 _

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-co

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. I cannot reproduce the problem and there is just not enough info to go on. Is there any way to get anything in addition? e.g. run the same test with `-vv` or add some additional print commands? Maybe it's some access rights problem, or different version of some non

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. We don't usually add code without any current users. I suggest either adding a small unit test proving `SourceLocation` can now be used as a `DenseMap` key (probably preferre

[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:121-127 llvm::Optional ContentCache::getBufferOrNone(DiagnosticsEngine &Diag, FileManager &FM, SourceLocation Loc) const { if (auto *B = getBufferPointer(Diag, FM,

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

rsmith added a comment. In D63640#2331779 , @Tyker wrote: > but the "real" blocker is that the testing depends on D85144 > for testing. > we could land it marking the tests XFAIL and correct it when dumping > improvement

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eece137bc76: [clang] Automatically link against oldnames just as linking against libcmt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 5eece13 - [clang] Automatically link against oldnames just as linking against libcmt

Author: Martin Storsjö Date: 2020-10-20T00:07:00+03:00 New Revision: 5eece137bc76f349cefc8922447694bea29ae101 URL: https://github.com/llvm/llvm-project/commit/5eece137bc76f349cefc8922447694bea29ae101 DIFF: https://github.com/llvm/llvm-project/commit/5eece137bc76f349cefc8922447694bea29ae101.diff

[PATCH] D89406: clang/{Format,Rewrite}: Stop using SourceManager::getBuffer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ddf4bd47c18: clang/{Format,Rewrite}: Stop using SourceManager::getBuffer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 0ddf4bd - clang/{Format,Rewrite}: Stop using SourceManager::getBuffer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-19T17:02:59-04:00 New Revision: 0ddf4bd47c18a4608b67fdda537f575c4c7a0a52 URL: https://github.com/llvm/llvm-project/commit/0ddf4bd47c18a4608b67fdda537f575c4c7a0a52 DIFF: https://github.com/llvm/llvm-project/commit/0ddf4bd47c18a4608b67fdda537f575c4c7a

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan updated this revision to Diff 299138. leonardchan edited the summary of this revision. leonardchan added a comment. Updated to use the `-fexperimental-relative-c++-ab-vtables` flag now that D85802 was reverted. This will be used for the purpose of te

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

mstorsjo added a comment. In D89702#2339716 , @rnk wrote: > lgtm > > We need to invent spellings for /MD /MT for the GCC-style driver if we want > it to be usable in the MSVC environment. I don't think there's a precise > translation to the `-static-*` f

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

amccarth accepted this revision. amccarth added a comment. It seems weird that we're implicitly adding `defaultlib` options without checking if the user specified `nodefaultlib`. But given that's already the case, I don't see a big problem with also adding oldnames.lib. Repository: rG LLVM

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm We need to invent spellings for /MD /MT for the GCC-style driver if we want it to be usable in the MSVC environment. I don't think there's a precise translation to the `-static-*` family of op

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-co

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:238 + if (D->hasAttr()) +return IsDarwin ? CC_C : CC_AArch64Darwin; + aaron.ballman wrote: > Can you help me understand this change a bit better? If the declaration uses > the Darwin A

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Herald added a subscriber: dexonsmith. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:489 Options.FloatABIType = getFloatABIForCalls(); + Options.AIXExtendedAltivecABI = getAIXExtendedAltivecABI(); Options.NoZerosInBSS = getDontPlaceZero

[PATCH] D88498: [FPEnv] Apply dynamic rounding to function body only

rsmith added a comment. Herald added a subscriber: dexonsmith. The tests in this patch exhibit the same behavior with and without the patch applied; I think almost all the functionality changes from here are superseded by the change to consider whether we're in a manifestly constant evaluated c

[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

JDevlieghere added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89430/new/ https://reviews.llvm.org/D89430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:167 Buffer.setInt(Buffer.getInt() | InvalidFlag); +return None; dexonsmith wrote: > JDevlieghere wrote: > > Orthogonal to this patch but an idea for a follow-up: this seems

[PATCH] D89722: SourceManager: Simplify early returns in ContentCache::getBufferOrNone, NFC

dexonsmith created this revision. dexonsmith added a reviewer: JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. As suggested in the review for https://reviews.llvm.org/D89430, simplify the logic for marking the buffer as invalid in the early return p

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

miyuki updated this revision to Diff 299126. miyuki edited the summary of this revision. miyuki added a comment. Split out the refactoring part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 Files: clang-tools-extra/clang-tidy/cppcoreguideli

[PATCH] D89398: Lexer: Update the Lexer to use MemoryBufferRef, NFC

JDevlieghere added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:145 /// outlive it, so it doesn't take ownership of either of them. - Lexer(FileID FID, const llvm::MemoryBuffer *InputFile, Preprocessor &PP); + Lexer(FileID FID, const llvm::MemoryBufferRef &In

[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

dexonsmith added a comment. Thanks for the review! Comment at: clang/lib/Basic/SourceManager.cpp:167 Buffer.setInt(Buffer.getInt() | InvalidFlag); +return None; JDevlieghere wrote: > Orthogonal to this patch but an idea for a follow-up: this seems li

[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/SourceManager.cpp:167 Buffer.setInt(Buffer.getInt() | InvalidFlag); +return None; Orthogonal to this

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

There is some issue, at least on staging. http://lab.llvm.org:8014/#/builders/89/builds/184 has multiple failed stages but marked as SUCCESS On Mon, 19 Oct 2020 at 11:43, Vitaly Buka wrote: > Thanks! > Done. > > On Sat, 17 Oct 2020 at 12:45, Galina Kistanova > wrote: > >> Thanks everyone for k

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks! Done. On Sat, 17 Oct 2020 at 12:45, Galina Kistanova wrote: > Thanks everyone for keeping your annotated builders in the staging area! > Much appreciated. > > Please feel free to move all the green builders back to the production. It > has a new AnnotatedCommand now. > > Thanks > > Galin

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki created this revision. miyuki added a reviewer: dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. This change creates a `DenseMapInfo` trait specialization for the SourceLocation class. The empty key, the tombstone k

[PATCH] D88659: [FE]Split SuitableAlign into two parts

jyknight added a comment. In D88659#2339357 , @Xiangling_L wrote: > Hi @jyknight , are you okay with us changing the "definition" of > SuitableAlign without sending a note to the mailing list? Yes, I think that it is fine to adjust the comment just in th

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

nickdesaulniers added a comment. It looks like this caused breakage for us for x86 Linux kernels, too: https://github.com/ClangBuiltLinux/linux/issues/1177. The Linux kernel does not and will not link against libgcc_s/compiler-rt, so optimizations at `-Oz` tend to both produce libcalls that ar

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall accepted this revision. rjmccall added a comment. Okay. This LGTM if you feel that the operator forwarders is the better approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 ___ cfe-com

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. Hi @jyknight , are you okay with us changing the "definition" of SuitableAlign without sending a note to the mailing list? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 _

[PATCH] D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file.

rupprecht added a comment. It looks like this fix caused a different regression in not accepting `name..h` as the main header for `name..cc`, e.g.: $ cat /tmp/foo.bar.cc #include "a.h" #include "z.h" #include "foo.bar.h" $ clang-format /tmp/foo.bar.cc # Before #include "foo.bar.h

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added a comment. Thanks Hans. I've merged the revert into the apple fork. While the commit was in-tree, we noticed that this enabled HCS during LTO. There was a surprising ~17% regression of 483.xalancbmk with LTO (+ PGO) enabled: `2020-10-16 CINT2006/483.xalancbmk 17.87%`. We don't

[clang] 24df30e - [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

Author: Joseph Huber Date: 2020-10-19T13:41:53-04:00 New Revision: 24df30efda6169915bc75bbf78d4c7f65d5f57e2 URL: https://github.com/llvm/llvm-project/commit/24df30efda6169915bc75bbf78d4c7f65d5f57e2 DIFF: https://github.com/llvm/llvm-project/commit/24df30efda6169915bc75bbf78d4c7f65d5f57e2.diff

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rG24df30efda61: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https:

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299100. awarzynski added a comment. Apply fix to unit test that got lost in the previous patch, simplify C input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381

[clang] a3c1603 - [clang] Use SourceLocation as key in std::map, NFCI

Author: Mikhail Maltsev Date: 2020-10-19T18:31:05+01:00 New Revision: a3c16039b3f119cd83d872f256c45599ae6ac60c URL: https://github.com/llvm/llvm-project/commit/a3c16039b3f119cd83d872f256c45599ae6ac60c DIFF: https://github.com/llvm/llvm-project/commit/a3c16039b3f119cd83d872f256c45599ae6ac60c.dif

[PATCH] D89705: [clang] Use SourceLocation as key in std::map, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3c16039b3f1: [clang] Use SourceLocation as key in std::map, NFCI (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D89705?v

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return parsing to be used by Actions. + Fortran::parser::Parsing &GetParsing() const { return *parsing_; } + sameeranjoshi wrote: > If I am correct this seems

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 299092. awarzynski marked 3 inline comments as done. awarzynski added a comment. Address PR comments, make clearer separation between option types, simplify/fix tests Based on the feedback, I've made a clearer separation between the parser and the fronten

  1   2   3   >