[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Parser/pragma-fp-warn.c:1 + +// RUN: %clang_cc1 -triple wasm32 -fsyntax-only -Wno-unknown-pragmas -Wignored-pragmas -verify %s ---

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. I haven't checked the instruction descriptions in detail, but the overall structure looks good to me. Perhaps wait a day with committing in case @bryanpkc has more comments. CHAN

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a reviewer: jhenderson. Herald added projects: clang, LLVM. tpr requested review of this revision.

[PATCH] D90291: [clangd] Add lit tests for remote index

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/test/lit.cfg.py:26 config.clangd_binary_dir + "/benchmarks")) +config.substitutions.appen

[PATCH] D90447: [AMDGPU] Add gfx1033 target

foad added a comment. Don't you need to update lib/Object/ELFObjectFile.cpp and test/Object/AMDGPU/elf-header-flags-mach.yaml? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 __

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous created this revision. nomanous added reviewers: rsmith, chandlerc, Eugene.Zelenko, majnemer, lvoufo. Herald added a project: clang. Herald added a subscriber: cfe-commits. nomanous requested review of this revision. Add type check for explicit instantiation of template classes' static da

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet updated this revision to Diff 301842. kadircet marked an inline comment as done. kadircet added a comment. - Return "." if Path == FragmentDir in conifgRelative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90270/new/ https://reviews.llvm

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:51 +return llvm::StringRef(); + return Path; +} sammccall wrote: > not that if Path == FragmentDir you're going to return "" which means "not > under". > I don't think th

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo updated this revision to Diff 301845. Hiralo added a comment. clang-tidy: adding "--config-file=" to specify custom config file. Let clang-tidy to read config from specified file. This option internally works exactly the same way as --config option after reading specified config file. Th

[PATCH] D90419: [AMDGPU] Add gfx90c target

foad added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:261 + ``gfx90c`` ``amdgcn`` APU - xnack *TBA* + [off] +

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo marked 6 inline comments as done. Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. S

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

svenvh accepted this revision. svenvh added a comment. LGTM. I also checked that this brings `Index.h` back in sync with `bindings/python/clang/cindex.py` again. We are not exposing `CXCursor_CXXAddrspaceCastExpr` through the python bindings, but some other values are missing too so that's bey

[PATCH] D90452: [clangd] Respect codeAction.isPreferredSupport in client capabilities

kadircet created this revision. kadircet added reviewers: sammccall, adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clan

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added a comment. In D83717#2279263 , @aaron.ballman wrote: > One of the concerns I have with this not being a flow-sensitive check is that > most of the bad situations are not going to be caught by the clang-tidy > version of the check. The CE

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:329-330 + + if (!ConfigFile.empty()) { +if (!Config.empty()) { + llvm::errs() << "Error: --config-file and --config are " nit: Should we be using `Config(Fil

[PATCH] D90455: [clangd] Pass parameters to config apply functions

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will enable some fragments to apply th

[clang-tools-extra] 888969f - [clangd] Fix MSVC implicit capture build failure.

Author: Simon Pilgrim Date: 2020-10-30T11:36:59Z New Revision: 888969f62abe6df9c9bafd593a6ba345577198b3 URL: https://github.com/llvm/llvm-project/commit/888969f62abe6df9c9bafd593a6ba345577198b3 DIFF: https://github.com/llvm/llvm-project/commit/888969f62abe6df9c9bafd593a6ba345577198b3.diff LOG:

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:329-330 + + if (!ConfigFile.empty()) { +if (!Config.empty()) { + llvm::errs() << "Error: --config-file and --config are " njames93 wrote: > nit: Should we be u

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo updated this revision to Diff 301862. Hiralo added a comment. clang-tidy: adding "--config-file=" to specify custom config file. Let clang-tidy to read config from specified file. This option internally works exactly the same way as --config option after reading specified config file. Th

[clang] 52ff86d - [AST] Fix traversal over CXXConstructExpr in Syntactic mode

Author: Stephen Kelly Date: 2020-10-30T12:14:41Z New Revision: 52ff86d25598175d3304498b14c0f6c780e46ae3 URL: https://github.com/llvm/llvm-project/commit/52ff86d25598175d3304498b14c0f6c780e46ae3 DIFF: https://github.com/llvm/llvm-project/commit/52ff86d25598175d3304498b14c0f6c780e46ae3.diff LOG:

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52ff86d25598: [AST] Fix traversal over CXXConstructExpr in Syntactic mode (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo marked an inline comment as done. Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:329-330 + + if (!ConfigFile.empty()) { +if (!Config.empty()) { + llvm::errs() << "Error: --config-file and --config are " -

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:329-330 + + if (!ConfigFile.empty()) { +if (!Config.empty()) { + llvm::errs() << "Error: --config-file and --config are " Hiralo wrote: > Hiralo wrote: > > nja

[PATCH] D90452: [clangd] Respect codeAction.isPreferredSupport in client capabilities

sammccall added a comment. I hadn't seen the bug, will ask here what the problem is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90452/new/ https://reviews.llvm.org/D90452 ___ cfe-commits mailing list

[PATCH] D90452: [clangd] Respect codeAction.isPreferredSupport in client capabilities

sammccall added a comment. Hang on - why do we need to do this? In general we don't do client feature detection for every piece of functionality we have, only when it causes us to behave incompatibly. And again in general we assume that setting extra properties on JSON objects is compatible. (e

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 301865. ffrankies marked an inline comment as done. ffrankies added a comment. Implemented changes requested by @aaron.ballman - Added a helper function that implements the string comparison logic - Clarified that check is case insensitive - Removed unused

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies marked 3 inline comments as done. ffrankies added a comment. @aaron.ballman Can you please commit this on my behalf? My github username is ffrankies . And could you take a look at D72241 altera single work item barrier check

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

tbaeder created this revision. tbaeder added reviewers: tstellar, sfantao, tejohnson. Herald added subscribers: cfe-commits, steven_wu, hiraditya, inglorion, mgorny. Herald added a project: clang. tbaeder requested review of this revision. After setting the LTO mode from the -flto option, look at

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

epastor added inline comments. Comment at: clang/test/CodeGen/X86/ms-inline-asm-prefix.c:1 +// RUN:%clang_cc1 %s -ferror-limit 0 -triple=x86_64-pc-widows-msvc -target-feature +avx512f -target-feature +avx2 -target-feature +avx512vl -fasm-blocks -mllvm -x86-asm-syntax=intel -S -

Re: [clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

Thanks! Maybe the diag text for this case could be a bit friendlier :) On Thu, Oct 29, 2020 at 10:41 PM Richard Smith wrote: > On Thu, 29 Oct 2020 at 19:32, Nico Weber wrote: > >> On Thu, Oct 29, 2020 at 6:10 PM Richard Smith >> wrote: >> >>> On Thu, 29 Oct 2020 at 08:07, Nico Weber wrote: >

[clang] 13bfd89 - [clang][FPEnv] Diagnose Strict FP pragmas if target does not support StrictFP

Author: Melanie Blower Date: 2020-10-30T06:11:25-07:00 New Revision: 13bfd89c4962e738cbe50662013267b33a678b8f URL: https://github.com/llvm/llvm-project/commit/13bfd89c4962e738cbe50662013267b33a678b8f DIFF: https://github.com/llvm/llvm-project/commit/13bfd89c4962e738cbe50662013267b33a678b8f.diff

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mibintc marked an inline comment as done. Closed by commit rG13bfd89c4962: [clang][FPEnv] Diagnose Strict FP pragmas if target does not support StrictFP (authored by mi

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 301872. nomanous added a comment. Change some format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[clang] cea69fa - [SVE] Add fatal error for unnamed SVE variadic arguments

Author: David Sherwood Date: 2020-10-30T13:35:47Z New Revision: cea69fa4dcc4fcf3be62dba49ad012879d89377d URL: https://github.com/llvm/llvm-project/commit/cea69fa4dcc4fcf3be62dba49ad012879d89377d DIFF: https://github.com/llvm/llvm-project/commit/cea69fa4dcc4fcf3be62dba49ad012879d89377d.diff LOG

[PATCH] D90230: [SVE] Add fatal error for unnamed SVE variadic arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcea69fa4dcc4: [SVE] Add fatal error for unnamed SVE variadic arguments (authored by david-arm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] ec809e4 - PR47372: Fix Lambda invoker calling conventions

Author: Erich Keane Date: 2020-10-30T06:39:55-07:00 New Revision: ec809e4cfe0be08b1bab7ba7e6ff905b9430571a URL: https://github.com/llvm/llvm-project/commit/ec809e4cfe0be08b1bab7ba7e6ff905b9430571a DIFF: https://github.com/llvm/llvm-project/commit/ec809e4cfe0be08b1bab7ba7e6ff905b9430571a.diff L

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

This revision was automatically updated to reflect the committed changes. Closed by commit rGec809e4cfe0b: PR47372: Fix Lambda invoker calling conventions (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D90459: [WIP][clang] Use RecoveryExpr to suppress secondary diagnostics for typo correction.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90459 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprCXX.cpp clang/test/

[PATCH] D46791: Make -gsplit-dwarf generally available

emaste added a comment. Herald added a subscriber: arichardson. running `clang -target x86_64-unknown-freebsd13.0 -split-dwarf foo.c` indeed produces a foo.dwo and foo.o w/o invoking objcopy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 _

[PATCH] D90419: [AMDGPU] Add gfx90c target

tpr updated this revision to Diff 301886. tpr added a comment. V3: Listed products. Marked as "xnack enabled". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90419/new/ https://reviews.llvm.org/D90419 Files: clang/include/clang/Basic/Cuda.h cla

[clang] bbdbd02 - Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

Author: Marco Antognini Date: 2020-10-30T14:12:01Z New Revision: bbdbd020d2c2f315ed1545b23c23ec6ff1abc022 URL: https://github.com/llvm/llvm-project/commit/bbdbd020d2c2f315ed1545b23c23ec6ff1abc022 DIFF: https://github.com/llvm/llvm-project/commit/bbdbd020d2c2f315ed1545b23c23ec6ff1abc022.diff LO

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbdbd020d2c2: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr (authored by mantognini). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033`` ``amdgcn`` dGPU - wavefrontsize64 *TBA* +

[PATCH] D90419: [AMDGPU] Add gfx90c target

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90419/new/ https://reviews.llvm.org/D90419 ___ cfe

[clang] 71bf9f0 - [clang] add fexperimental-strict-floating-point to test cases that fail on arm and aarch not sure this will work due to commit rG13bfd89c4962

Author: Melanie Blower Date: 2020-10-30T07:30:06-07:00 New Revision: 71bf9f07d514e160ff130eced53248667021829d URL: https://github.com/llvm/llvm-project/commit/71bf9f07d514e160ff130eced53248667021829d DIFF: https://github.com/llvm/llvm-project/commit/71bf9f07d514e160ff130eced53248667021829d.diff

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added a comment. I'll see how much I can simplify of the tests. Comment at: clang/test/CodeGen/exprs-strictfp.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -ffp-exception-beha

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

sammccall added a comment. Still LG but a few more nits Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:46 +// Returns an empty stringref if Path is not under FragmentDir. +llvm::StringRef configRelative(llvm::StringRef Path, you should document+verify

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert added a comment. In D84604#2363768 , @rupprecht wrote: > I applied D87194 locally and rebuilt the > original source, and not only am I seeing the original issue (also firing on > `DoThings()` when it should

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert planned changes to this revision. aaronpuchert added a comment. Need to rebase this on top of D84604 plus a subsequent fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87194/new/ https://reviews.llv

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

This revision was automatically updated to reflect the committed changes. c-rhodes marked an inline comment as done. Closed by commit rG58d3f0ea4972: [clang][aarch64] Address various fixed-length SVE vector operations (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 58d3f0e - [clang][aarch64] Address various fixed-length SVE vector operations

Author: Cullen Rhodes Date: 2020-10-30T15:10:54Z New Revision: 58d3f0ea497206950d7bcb22b05d161e834e4396 URL: https://github.com/llvm/llvm-project/commit/58d3f0ea497206950d7bcb22b05d161e834e4396 DIFF: https://github.com/llvm/llvm-project/commit/58d3f0ea497206950d7bcb22b05d161e834e4396.diff LOG:

[PATCH] D44964: Change order of libclang_rt.profile link for freebsd

dim added a comment. Yes, this looks pretty fine to me, but indeed needs a test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44964/new/ https://reviews.llvm.org/D44964 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D46791: Make -gsplit-dwarf generally available

pcc added a comment. Correct, clang no longer uses objcopy for this as of D47093 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 ___ cfe-commits mailing list cfe-com

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet updated this revision to Diff 301912. kadircet added a comment. - Explicitly handle FragmentDir.empty() case by returning Path as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90270/new/ https://reviews.llvm.org/D90270 Files: clang-

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:170 + [PathMatch(std::move(PathMatch)), + FragmentDir(FragmentDirectory)](const Params &P) { if (P.Path.empty()) -

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 301913. jansvoboda11 added a comment. Herald added a subscriber: mgorny. Added LLVM unit tests, reverted back to `array_pod_sort`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:36 + bool operator<(const UniqueID &Other) const { +return std::tie(Device, File) < std::tie(Other.Device, Other.File); + } rnk wrote: > FYI std::tie is pretty exp

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144 + assert(ValueExpr && "Attribute must have a valid value expression."); + if (S.CheckLoopHintExpr(ValueEx

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. Hi @rjmccall , thank you for your quick reply! > It sounds like what you want is a diagnostic library that's almost completely > abstracted over the kinds of entities that can be stored in a diagnostic, > including the definition of a source location. No :) We sugge

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. I've added tests for OptParserEmitter. Let me know if you had something more detailed in mind. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be reassoci

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

fhahn added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144 + assert(ValueExpr && "Attribute must have a valid value expression."); + if (S.CheckLoopHintExpr(ValueExpr, St->getBeginLoc())) +return nullptr; sdesmalen wrote: > dav

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks for working through this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 __

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec added a comment. Missing changes to these files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/lib/Object/ELFObjectFile.cpp llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml llvm/test/tools/llvm-

[clang] bbe055d - [CodeGen][X86] Remove unused check-prefix in amx inline asm tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:45Z New Revision: bbe055dd73cf3f87e6e6481b5aa36bcc875cbe23 URL: https://github.com/llvm/llvm-project/commit/bbe055dd73cf3f87e6e6481b5aa36bcc875cbe23 DIFF: https://github.com/llvm/llvm-project/commit/bbe055dd73cf3f87e6e6481b5aa36bcc875cbe23.diff LOG:

[clang] fe3d765 - [CodeGen][X86] Tidyup CHECKs on bitscan tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:52Z New Revision: fe3d765ac72ed58cc81cc93d5a1bf0f61491f80d URL: https://github.com/llvm/llvm-project/commit/fe3d765ac72ed58cc81cc93d5a1bf0f61491f80d DIFF: https://github.com/llvm/llvm-project/commit/fe3d765ac72ed58cc81cc93d5a1bf0f61491f80d.diff LOG:

[clang] 5cdd470 - [CodeGen][X86] Remove unused check-prefix in bitscan tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:50Z New Revision: 5cdd47050408d826d7fb324d9a130cf8e74298e2 URL: https://github.com/llvm/llvm-project/commit/5cdd47050408d826d7fb324d9a130cf8e74298e2 DIFF: https://github.com/llvm/llvm-project/commit/5cdd47050408d826d7fb324d9a130cf8e74298e2.diff LOG:

[clang] 0ff9d8c - [CodeGen][X86] Remove unused check-prefix in bswap tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:49Z New Revision: 0ff9d8c8baa317f4135e08cfe8d64e4b824b7c49 URL: https://github.com/llvm/llvm-project/commit/0ff9d8c8baa317f4135e08cfe8d64e4b824b7c49 DIFF: https://github.com/llvm/llvm-project/commit/0ff9d8c8baa317f4135e08cfe8d64e4b824b7c49.diff LOG:

[clang] d7389f0 - [CodeGen][X86] Cleanup + remove unused check-prefixes in avx union tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:47Z New Revision: d7389f05ee27e703ac9c0873d3ac183d8d9cf0c5 URL: https://github.com/llvm/llvm-project/commit/d7389f05ee27e703ac9c0873d3ac183d8d9cf0c5 DIFF: https://github.com/llvm/llvm-project/commit/d7389f05ee27e703ac9c0873d3ac183d8d9cf0c5.diff LOG:

[clang] c44846f - [CodeGen][X86] Cleanup + fix unused check-prefixes in bmi tests

Author: Simon Pilgrim Date: 2020-10-30T16:13:54Z New Revision: c44846f537efb4f996becc6f665af828051a08f6 URL: https://github.com/llvm/llvm-project/commit/c44846f537efb4f996becc6f665af828051a08f6 DIFF: https://github.com/llvm/llvm-project/commit/c44846f537efb4f996becc6f665af828051a08f6.diff LOG:

[clang] 365f46e - [CodeGen][X86] Remove unused check-prefix in movdir tests

Author: Simon Pilgrim Date: 2020-10-30T16:23:08Z New Revision: 365f46efebe09378af57628f38bfe55018451d17 URL: https://github.com/llvm/llvm-project/commit/365f46efebe09378af57628f38bfe55018451d17 DIFF: https://github.com/llvm/llvm-project/commit/365f46efebe09378af57628f38bfe55018451d17.diff LOG:

[clang] 973317c - [CodeGen][X86] Remove unused check-prefix in constrained fma tests

Author: Simon Pilgrim Date: 2020-10-30T16:23:08Z New Revision: 973317cc5e4612a85e39dc1ffb20423c96bc9db2 URL: https://github.com/llvm/llvm-project/commit/973317cc5e4612a85e39dc1ffb20423c96bc9db2 DIFF: https://github.com/llvm/llvm-project/commit/973317cc5e4612a85e39dc1ffb20423c96bc9db2.diff LOG:

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong added inline comments. Comment at: clang/include/clang/APINotes/Types.h:25 +/// auditing. +enum class EnumExtensibilityKind { + None, compnerd wrote: > martong wrote: > > compnerd wrote: > > > martong wrote: > > > > compnerd wrote: > > > > > martong wrot

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the point @rjmccall made about the note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90336/new/ https://reviews.

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a request about the note. Thank you for this! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161 + InGroup; +def note_attribute

[libunwind] 1d7786d - [libunwind] Support DW_CFA_remember/restore_state without heap allocation.

Author: Daniel Kiss Date: 2020-10-30T17:45:20+01:00 New Revision: 1d7786d45f48b4793baf4e4b903c4476f56ffc94 URL: https://github.com/llvm/llvm-project/commit/1d7786d45f48b4793baf4e4b903c4476f56ffc94 DIFF: https://github.com/llvm/llvm-project/commit/1d7786d45f48b4793baf4e4b903c4476f56ffc94.diff L

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr updated this revision to Diff 301931. tpr added a comment. V2: Update ELFObjectFile.cpp and elf-header-flags-mach.yaml. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 Files: clang/lib/Basic/Targets/A

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @thakis I've got test working, here's the code: // RUN: chmod +w %t.dir || true // RUN: rm -rf %t.dir // RUN: mkdir %t.dir // RUN: cp %s %t.dir/read-only.cpp // RUN: chmod -w %t.dir // RUN: clang-format -style=LLVM -i %t.dir/read-only.cpp || test $? == 1 i

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks updated this revision to Diff 301937. aeubanks retitled this revision from "[NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0 " to "[NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0". aeubanks added a comment. revert back to running all c

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5699b8ff1b6: [clang][driver] Rename DriverOption as NoXarchOption (NFC) (authored by awarzynski). Changed prior to commit: https://reviews.llvm.o

[clang] e5699b8 - [clang][driver] Rename DriverOption as NoXarchOption (NFC)

Author: Andrzej Warzynski Date: 2020-10-30T17:00:06Z New Revision: e5699b8ff1b6ea68e77dffb037e1c5d612131580 URL: https://github.com/llvm/llvm-project/commit/e5699b8ff1b6ea68e77dffb037e1c5d612131580 DIFF: https://github.com/llvm/llvm-project/commit/e5699b8ff1b6ea68e77dffb037e1c5d612131580.diff

[clang] 2e31727 - [NFC] Clean up PassBuilder

Author: Arthur Eubanks Date: 2020-10-30T10:03:59-07:00 New Revision: 2e31727a884affa11f2955ddfa40590715f144df URL: https://github.com/llvm/llvm-project/commit/2e31727a884affa11f2955ddfa40590715f144df DIFF: https://github.com/llvm/llvm-project/commit/2e31727a884affa11f2955ddfa40590715f144df.diff

[PATCH] D90437: [NFC] Clean up PassBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e31727a884a: [NFC] Clean up PassBuilder (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 2177e45 - PR47861: Expand dangling reference warning to look through copy

Author: Richard Smith Date: 2020-10-30T10:19:50-07:00 New Revision: 2177e4555ab84771c611a3295ab1149af7f79c29 URL: https://github.com/llvm/llvm-project/commit/2177e4555ab84771c611a3295ab1149af7f79c29 DIFF: https://github.com/llvm/llvm-project/commit/2177e4555ab84771c611a3295ab1149af7f79c29.diff

[clang] 84e8257 - FileManager: Improve the FileEntryRef API and customize its OptionalStorage

Author: Duncan P. N. Exon Smith Date: 2020-10-30T13:25:46-04:00 New Revision: 84e8257937ec6a332aa0b688f4dce57016516ffd URL: https://github.com/llvm/llvm-project/commit/84e8257937ec6a332aa0b688f4dce57016516ffd DIFF: https://github.com/llvm/llvm-project/commit/84e8257937ec6a332aa0b688f4dce5701651

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

This revision was automatically updated to reflect the committed changes. Closed by commit rG84e8257937ec: FileManager: Improve the FileEntryRef API and customize its OptionalStorage (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90478: Basic: Split out DirectoryEntry.h, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Move `DirectoryEntry` and `DirectoryEntryRef` into their own header, similar to the creation of FileEntry.h. No functionality cha

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Change `Module::Umbrella` from a `const void *` to a `PointerUnion` of `FileEntry` and `DirectoryEntry`. We can drop the `HasUmbr

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr updated this revision to Diff 301953. tpr added a comment. Herald added subscribers: emaste, jholewinski. Herald added a reviewer: espindola. V3: Add missing bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.or

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Add `FileEntryRef::getDir`, which returns a `DirectoryEntryRef`. This includes a few changes: - Customize `OptionalStorage` so t

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update `Module::findHeader` to return `Optional` and fix its one caller. https://reviews.llvm.org/D90485 Files: clang/includ

[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, tpr, mgorny. Herald added a reviewer: bollu. Herald added projects: clang, LLVM. aeubanks requested review of this revision. To prevent targets from adding optional passes for -O0, TargetMac

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added a comment. I may not have been clear. I'm not saying SourceLocation is a meaningful concept in the driver. I'm saying that if you generalize the concept of "source location" to "location in the input", there is a clear analogue in the driver (namely, a position in the argument

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. https://reviews.llvm.org/D90486 for adding OptimizationLevel to registerPassBuilderCallbacks(), although this one should land first since that one needs to update PassBuilder::runRegisteredEPCallbacks() to call TargetMachine::registerPassBuilderCallbacks() Repository

[clang] 010238a - Speculative fix for bots after 84e8257937ec6a332aa0b688f4dce57016516ffd

Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:01:01-04:00 New Revision: 010238a296e61cbf6f4d7f4383e26cf00c4e4992 URL: https://github.com/llvm/llvm-project/commit/010238a296e61cbf6f4d7f4383e26cf00c4e4992 DIFF: https://github.com/llvm/llvm-project/commit/010238a296e61cbf6f4d7f4383e26cf00c4e

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added a comment. In D83717#2364187 , @gamesh411 wrote: > In D83717#2279263 , @aaron.ballman > wrote: > >> One of the concerns I have with this not being a cfg-only check is that most >> of the bad si

[clang] 5530fb5 - Speculative fix for bots after 84e8257937ec6a332aa0b688f4dce57016516ffd, v2

Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:04:48-04:00 New Revision: 5530fb586f30da9dcb434f6be39198dbf016b866 URL: https://github.com/llvm/llvm-project/commit/5530fb586f30da9dcb434f6be39198dbf016b866 DIFF: https://github.com/llvm/llvm-project/commit/5530fb586f30da9dcb434f6be39198dbf016

[clang] 940d0a3 - Revert "FileManager: Improve the FileEntryRef API and customize its OptionalStorage" and follow-ups

Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:06:55-04:00 New Revision: 940d0a310dca31ae97080b068cef92eadfee6367 URL: https://github.com/llvm/llvm-project/commit/940d0a310dca31ae97080b068cef92eadfee6367 DIFF: https://github.com/llvm/llvm-project/commit/940d0a310dca31ae97080b068cef92eadfee

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3163 def note_attribute_has_no_effect_here : Note< - "annotating the %select{infinite loop}0 here">; + "annotating the %se

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161 + InGroup; +def note_attribute_has_no_effect_here : Note< + "annotating the %select{infinite loop}0 here">; -

  1   2   >