[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/ItaniumMangle.cpp:5136 + case APValue::FixedPoint: +llvm_unreachable("Fixed point types are disabled for c++"); +return; -

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal created this revision. ortogonal added reviewers: klimek, Alexander-Shukaev, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. ortogonal requested review of this revision. When running git-clang-format in a pre-commit hook it's very useful to be able to tel

[clang] d2da05d - [test] Fix Other/new-pass-manager.ll & clang/test/Misc/loop-opt-setup.c

Author: Fangrui Song Date: 2020-11-06T21:55:11-08:00 New Revision: d2da05de7c9ec11c3c9f26ea957cbf2225dbd0e5 URL: https://github.com/llvm/llvm-project/commit/d2da05de7c9ec11c3c9f26ea957cbf2225dbd0e5 DIFF: https://github.com/llvm/llvm-project/commit/d2da05de7c9ec11c3c9f26ea957cbf2225dbd0e5.diff

[clang] d3e75d3 - Revert "[CodeGen] Fixes sanitizer test"

Author: Atmn Patel Date: 2020-11-07T00:32:12-05:00 New Revision: d3e75d31e3c831d00277518caee80b15b72666a8 URL: https://github.com/llvm/llvm-project/commit/d3e75d31e3c831d00277518caee80b15b72666a8 DIFF: https://github.com/llvm/llvm-project/commit/d3e75d31e3c831d00277518caee80b15b72666a8.diff LO

[PATCH] D90815: -fbasic-block-sections=list=: Suppress output if failed to open the file

tmsriram accepted this revision. tmsriram added a comment. This revision is now accepted and ready to land. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90815/new/ https://reviews.llvm.org/D90815 __

[clang] b1878b4 - [CodeGen] Fixes sanitizer test

Author: Atmn Patel Date: 2020-11-06T23:53:38-05:00 New Revision: b1878b4641e06baa754ce6e3e0387b1e7d7dc143 URL: https://github.com/llvm/llvm-project/commit/b1878b4641e06baa754ce6e3e0387b1e7d7dc143 DIFF: https://github.com/llvm/llvm-project/commit/b1878b4641e06baa754ce6e3e0387b1e7d7dc143.diff LO

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +CurInfo.NonContigInfo.Dims.push_back(0); emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct); MaskRay wrote: >

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5181 + mangleType(T); + Out << "0E"; + return; rsmith wrote: > rjmccall wrote: > > This could also be extracted and shared with the template-argument mangler. > > In fact,

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith updated this revision to Diff 303611. rsmith marked an inline comment as done. rsmith added a comment. - Factor out duplicated mangling of null pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89998/new/ https://reviews.llvm.org/D8999

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

MaskRay added a comment. > map item can be non-contiguous for target update The subject appears to describe a situation, but patch subjects should usually be imperative Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +Cu

[clang] f2e479d - [OpenMP] Fix -Wmisleading-indentation after D84192

Author: Fangrui Song Date: 2020-11-06T20:09:43-08:00 New Revision: f2e479db92452594dfe6aff45ab7841f0a8c69a5 URL: https://github.com/llvm/llvm-project/commit/f2e479db92452594dfe6aff45ab7841f0a8c69a5 DIFF: https://github.com/llvm/llvm-project/commit/f2e479db92452594dfe6aff45ab7841f0a8c69a5.diff

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/AST/APValue.cpp:1052 + // FIXME: These should be modeled as having the + // LifetimeExtendedTemporaryDecl itself as the base. + auto *MTE = dyn_cast(E); rj

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith updated this revision to Diff 303609. rsmith marked 10 inline comments as done. rsmith added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89998/new/ https://reviews.llvm.org/D89998 Files: clang/lib/A

[clang] 569abb5 - [LoopDeletion] Fixes failing test

Author: Atmn Patel Date: 2020-11-06T22:45:28-05:00 New Revision: 569abb530ece721675032d3127bd6d63f252b12b URL: https://github.com/llvm/llvm-project/commit/569abb530ece721675032d3127bd6d63f252b12b DIFF: https://github.com/llvm/llvm-project/commit/569abb530ece721675032d3127bd6d63f252b12b.diff LO

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel). Repository: rG LLVM Github Monor

[clang] 0b17c6e - [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

Author: Atmn Patel Date: 2020-11-06T22:06:58-05:00 New Revision: 0b17c6e4479d62bd4ff05c48d6cdf340b198832f URL: https://github.com/llvm/llvm-project/commit/0b17c6e4479d62bd4ff05c48d6cdf340b198832f DIFF: https://github.com/llvm/llvm-project/commit/0b17c6e4479d62bd4ff05c48d6cdf340b198832f.diff LO

[clang] 0cab911 - [OpenMP5.0] map item can be non-contiguous for target update

Author: cchen Date: 2020-11-06T21:04:37-06:00 New Revision: 0cab91140f61a8271e8eef591f130145dd6e8084 URL: https://github.com/llvm/llvm-project/commit/0cab91140f61a8271e8eef591f130145dd6e8084 DIFF: https://github.com/llvm/llvm-project/commit/0cab91140f61a8271e8eef591f130145dd6e8084.diff LOG: [O

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cab91140f61: [OpenMP5.0] map item can be non-contiguous for target update (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 303598. njames93 added a comment. Fix the unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.llvm.org/D90531 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cl

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 303597. atmnpatel added a comment. final fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transfor

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 303596. njames93 marked an inline comment as done. njames93 added a comment. Removed Enable. Removed the scalarBool parser as it was only needed by Enable. Removed DynamicDictParser in favour of reworking DictParser to get better control of how to handle unk

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/this-nonnull.cpp:1-2 +// RUN: %clang_cc1 -S -emit-llvm -o - -triple %itanium_abi_triple %s | FileCheck %s -check-prefix=CHECK-YES +// R

[PATCH] D90992: [clang-tidy] Use vfs::FileSystem when getting config

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. The config providers that look for configuration files currently take a pointer

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

dblaikie added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2339-2353 /// Determine whether the given types \p T1 and \p T2 are equivalent. - bool hasSameType(QualType T1, QualType T2) const { -return getCanonicalType(T1) == getCanonicalType(T2); + /

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2379785 , @mibintc wrote: > you're right about the regex syntax. i think the 4088 is over the max > repetition count and there's also a problem with balanced. not sure what i > did wrong here. if you have a chance to l

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind created this revision. Herald added subscribers: cfe-commits, modimo, wenlei, modocache. Herald added a project: clang. lxfind requested review of this revision. The original bug was discovered in T75057860. Clang front-end emits an AST that looks like this for an co_await expression: | -

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added a comment. In D87981#2379249 , @akashk4 wrote: > It would be great if TILE_RELEASE is supported in the backend, so the scope > of transaction is known and the configurations are at least stored to memory > properly. TILERELEASE don't sto

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr *NewMI = akashk4 wrote: > I

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

On Fri, 6 Nov 2020 at 13:30, Alex L wrote: > Hi Rchard, > > Some of our code started triggering the warning you added in this code, > but I'm not sure if the warning is actually valid or not in this case: > > https://godbolt.org/z/9fxs3K > > namespace geo { > template > class optional { > o

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 updated this revision to Diff 303580. njames93 marked 3 inline comments as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90555/new/ https://reviews.llvm.org/D90555 Files: clang-tools-extr

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:127 + unsigned EnumIntWidth = Ctx.getIntWidth(QualType(EnumT, 0)); + bool EnumIsSigned = EnumT->isSignedIntegerOrEnumerationType();

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLOBAL PROPERTY CLANG${distribution}_HAS_EXPORTS True) endif() phosek wrot

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D88295#2365560 , @Quuxplusone wrote: >> So, how about we add another `CES` flag > > As the original author of `CES_AsIfByStdMove`, I am opposed to an

[PATCH] D90984: Update matchers to be traverse-aware

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Don't match Stmt or Decl nodes not spelled in the source when using TK_IgnoreUnlessSpelledInSource. This pre

[PATCH] D90983: Change algorithms to return iterators

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Make it possible to inspect the matched node, possibly to ignore it. Repository: rG LLVM Github Monorepo

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Update the ASTNodeTraverser to dump only nodes spelled in source. There are only a few which need to be hand

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. @rnk @vsk does this look good to you as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek updated this revision to Diff 303567. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/include/clang/Lex/PreprocessorOptions.h clang/lib/Co

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLO

[PATCH] D90976: Fixed an issue where diagnostics printed expressions in a roundabout way

wchilders created this revision. wchilders added reviewers: yaxunl, hans, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. wchilders requested review of this revision. Previously expressions were being printed in diagnostics via an implicit conversion to an expressio

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:68 + // Maps the Enum values to the EnumConstantDecl and a bool signifying if its + // cov

[clang] c9ca3a3 - [AArch64] Add driver tests for HiSilicon's TSV110

Author: Elvina Yakubova Date: 2020-11-07T01:51:37+03:00 New Revision: c9ca3a3c66a493d72cf7afc7ee975e2de399f2e5 URL: https://github.com/llvm/llvm-project/commit/c9ca3a3c66a493d72cf7afc7ee975e2de399f2e5 DIFF: https://github.com/llvm/llvm-project/commit/c9ca3a3c66a493d72cf7afc7ee975e2de399f2e5.dif

[PATCH] D90975: [clangd] Don't run clang-tidy AST traversal if there are no checks.

sammccall created this revision. sammccall added a reviewer: njames93. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. While here, clean up ParsedAST:

[libunwind] c1887e3 - Revert "Allow running back-deployment testing against libc++abi"

Author: Louis Dionne Date: 2020-11-06T17:26:42-05:00 New Revision: c1887e3f15aeac7037b88b066b33d142c6bb1321 URL: https://github.com/llvm/llvm-project/commit/c1887e3f15aeac7037b88b066b33d142c6bb1321 DIFF: https://github.com/llvm/llvm-project/commit/c1887e3f15aeac7037b88b066b33d142c6bb1321.diff

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

This revision was automatically updated to reflect the committed changes. Closed by commit rG93b99728b167: [AArch64] Add pipeline model for HiSilicon's TSV110 (authored by Elvina). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89972/new/ https://rev

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:78 +std::string Checks; +std::vector> CheckOptions; + } ClangTidy; njames93 wrote: > sammccall wrote: > > I think this should be a StringMap > > > > It makes sense to use a v

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

Flow created this revision. Flow added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Flow requested review of this revision. The run-clang-tidy.py helper script is supposed to be used by the user, hence it should be placed in

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2379892 , @thakis wrote: > Very belated update: We've been running with this on our clang/tot bots for a > few weeks now and turned this on (or, more accurately stopped turning it off) > for "normal" builds today. All tes

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil updated this revision to Diff 303540. bsaleil added a comment. Fix unaligned load/store select Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

thakis added a comment. Very belated update: We've been running with this on our clang/tot bots for a few weeks now and turned this on (or, more accurately stopped turning it off) for "normal" builds today. All tests pass and so far everything's happy. Repository: rG LLVM Github Monorepo CH

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Hi Rchard, Some of our code started triggering the warning you added in this code, but I'm not sure if the warning is actually valid or not in this case: https://godbolt.org/z/9fxs3K namespace geo { template class optional { optional() { } ~optional(); }; } template geo::optional::~optiona

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 303532. segoon added a comment. - use static instead of namespace {} - don't use SourceRange() - revert unrelated changes to .rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/cla

[clang] 0d6e125 - Add new matchers for dependent names in templates

Author: Stephen Kelly Date: 2020-11-06T21:03:20Z New Revision: 0d6e1251d79d07a03d8cf528e3537d41d4285680 URL: https://github.com/llvm/llvm-project/commit/0d6e1251d79d07a03d8cf528e3537d41d4285680 DIFF: https://github.com/llvm/llvm-project/commit/0d6e1251d79d07a03d8cf528e3537d41d4285680.diff LOG:

[PATCH] D90767: Add new matchers for dependent names in templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d6e1251d79d: Add new matchers for dependent names in templates (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D907

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added a comment. In D90944#2379688 , @njames93 wrote: > It appears to not check for signs that the code is running in a multi > threaded manner, This will result in many false positives in code that is > known to be single threaded. I'm not sure

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

nickdesaulniers added a comment. In D90180#2375878 , @aaron.ballman wrote: > In D90180#2374839 , @nickdesaulniers > wrote: > >> In D90180#2357247 , @aaron.ballman >> wrote

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aaron.ballman added a comment. In D90221#2374344 , @aronsky wrote: >> It seems surprising to me that you'd have to add those declarations; I think >> that's a layering violation. There's something somewhat strange going on >> here that I think is related

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. you're right about the regex syntax. i think the 4088 is over the max repetition count and there's also a problem with balanced. not sure what i did wrong here. if you have a chance to look at this otherwise i'll toil over the weekend, i'm off for the day--cheers. here

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:33 `abseil-upgrade-duration-conversions `_, "Yes" - `altera-struct-pack-align `_, + `altera-struct-pack-align `_, "Yes" `android-cloexec-accept `_, "Yes" se

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon marked an inline comment as done. segoon added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:33 `abseil-upgrade-duration-conversions `_, "Yes" - `altera-struct-pack-align `_, + `altera-struct-pack-align `_, "Yes" `android-cloex

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rG062b5c598f21: [clangd] Set the User option for clang-tidy to mimick its behaviour (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D90552?vs=302871&id=303519#toc Repository:

[clang-tools-extra] 062b5c5 - [clangd] Set the User option for clang-tidy to mimick its behaviour

Author: Nathan James Date: 2020-11-06T19:58:21Z New Revision: 062b5c598f21c1591b10362219e3c89e934367b0 URL: https://github.com/llvm/llvm-project/commit/062b5c598f21c1591b10362219e3c89e934367b0 DIFF: https://github.com/llvm/llvm-project/commit/062b5c598f21c1591b10362219e3c89e934367b0.diff LOG:

[PATCH] D90963: Allow searching for prebuilt implicit modules.

arames created this revision. arames added a reviewer: stella.stamenova. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. arames requested review of this revision. This reverts commit c67656b994c87224e0b33e2c4b09093986a5cfa6

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added a comment. It appears to not check for signs that the code is running in a multi threaded manner, This will result in many false positives in code that is known to be single threaded. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:19 + +namespa

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Config.h:78 +std::string Checks; +std::vector> CheckOptions; + } ClangTidy; sammccall wrote: > I think this should be a StringMap > > It makes sense to use a vector-of-pairs in ConfigF

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:117 - // We trigger if there are fewer cases than enum values (and no case covers - // multiple values). This guarantees we'll ha

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 updated this revision to Diff 303502. njames93 added a comment. Addressed comments. Now using a MapVector to collect all uncovered cases in prepare, then just loop over that in apply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90555/new

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie accepted this revision. dblaikie added a comment. Generally looks good, thanks! The inline comment trying to understand the `4095 - 4088 == 7` math I think should be answered (possibly in the form of the test/CHECK rephrasing I mentioned to clarify what the extra 7 characters are, and

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon marked an inline comment as done. segoon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-mt-unsafe.cpp:3-4 + +#include +#include + lebedev.ri wrote: > Tests should be hermetic, they can not use headers from system fixed

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 303499. segoon added a comment. don't include any system headers in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-ti

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 303495. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/Diagnost

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Comment at: llvm/unittests/Support/TargetParserTest.cpp:10-11 #include "llvm/Support/TargetParser.h" #include "llvm/ADT/STLExtras.h" +#include "llvm/Support/

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Simple and straightforward, with documentation! :) LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90956/new/ https://reviews.l

[PATCH] D90957: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Qualify definitions with `clang::` rather than opening/closing a namespace. https://reviews.llvm.org/D90957 File

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303486. pratlucas added a comment. Updating default extensions in target parser to match tablegen features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files: c

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. (If `-mmacosx-version-min` is passed too, open-source clang does the right thing, but for quick command-line testing it'd be nice if both clangs behaved consistently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. Testing this out: `--target=arm64-apple-macos` now does the right thing, but `-march arm64` sets the target triple to iOS (and hence doesn't pass the a12 cpu either). That's different from what Xcode clang does. Could you upstream whatever causes that difference too? R

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

sammccall added a comment. I'm not sure we should do this - it complicates the model substantially (I don't think I could explain it to a user), and it still leaves surprising cases. I'm not sure config is the place for a lot of magic do-what-I-mean behavior - it's the place where the user over

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

fpetrogalli created this revision. fpetrogalli added reviewers: peterwaller-arm, paulwalker-arm, efriedma, c-rhodes. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli requested review of this revisi

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

sammccall added a comment. AsyncTaskRunner is definitely threadsafe, but const doesn't exactly mean threadsafe... This might be OK or maybe we should put `mutable` at the callsite - can you show the real example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc updated this revision to Diff 303477. mibintc added a comment. Fixed test case according to @dblaikie 's suggestion and input, thanks a lot David, the test case is certainly a lot easier to read and understand now. Anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

Anastasia added a comment. Ok, it would still segfault but perhaps it is acceptable as this is an internal frontend only option for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928

[PATCH] D90949: [clang-format] avoid introducing multiline comments

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. One concern about looping, otherwise just style nits. Comment at: clang/lib/Format/BreakableToken.cpp:104 static const auto kNumberedListRegexp = llvm::Regex("^[1-9]

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

NoQ added a comment. You cannot have an argument expression because there's no argument expression anywhere in the AST. There's an argument, but it's not computed as a value of any syntactic expression. If there was no argument, `getArgExpr(0)` would have crashed; but it returns a `nullptr` whi

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:110 +OPENCLFEAT_INTERNAL(__opencl_c_generic_address_space, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_work_group_collective_functions, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_atomic_order

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2378235 , @azabaznov wrote: >> I guess targets like SPIR will be supporting all features by default? > > It sounds confusing for me: can you please elaborate about why does SPIR-V > target should support all features/e

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90434/new/ https://reviews.llvm.org/D90434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D87981: [X86] AMX programming model prototype.

akashk4 requested changes to this revision. akashk4 added a comment. This revision now requires changes to proceed. It would be great if TILE_RELEASE is supported in the backend, so the scope of transaction is known and the configurations are at least stored to memory properly. ==

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:254 +// native path. +if (!External.File && !External.Server) { + diag(Error, "At least one of File or Server must be specified.", My math friends would call this

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > steveire wrote: >

[PATCH] D90949: [clang-format] avoid introducing multiline comments

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir requested review of this revision. In C++ with -Werror=comment, multiline comments are not allowed. clang-format could accidentally introduce multiline comments when reflowing. This adap

[PATCH] D90886: [AMDGPU] Simplify amdgpu-macros.cl test. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fcdfc4398bd: [AMDGPU] Simplify amdgpu-macros.cl test. NFC. (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

steakhal added a comment. In D52957#2377914 , @NoQ wrote: > Everything looks good to me here. The new-expression `new int;` has 1 > implicit argument (allocation size passed to the implementation of operator > new, the value is probably 4) and 0 placemen

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303462. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[clang] aa0dc1c - [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

Author: Balazs Benics Date: 2020-11-06T16:51:34+01:00 New Revision: aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe URL: https://github.com/llvm/llvm-project/commit/aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe DIFF: https://github.com/llvm/llvm-project/commit/aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe.diff

[PATCH] D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0dc1c3b862: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup (authored by steakhal). Repository: rG LLVM Github Monorepo CH

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

vhscampos added a comment. @Tyker This is causing another build failure in another example: [2858/4034] Building CXX object tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o FAILED: tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o CCACHE_CPP2=

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. In D68997#2377641 , @stella.stamenova wrote: > This change broke the windows lldb bot: > > http://lab.llvm.org:8011/#/builders/83/builds/570 > > Can you please fix this or revert? Looking at this now. Repository: rG LLVM Githu

[clang] 7efe07a - Traverse-ignore explicit template instantiations

Author: Stephen Kelly Date: 2020-11-06T15:25:59Z New Revision: 7efe07a12b6967bc358678adf75dffd238a00250 URL: https://github.com/llvm/llvm-project/commit/7efe07a12b6967bc358678adf75dffd238a00250 DIFF: https://github.com/llvm/llvm-project/commit/7efe07a12b6967bc358678adf75dffd238a00250.diff LOG:

  1   2   >