[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

yonghong-song updated this revision to Diff 305413. yonghong-song added a comment. fix clang-format warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91489/new/ https://reviews.llvm.org/D91489 Files:

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BTFDebug.cpp:1230 +Reloc == BPFCoreSharedInfo::BTF_TYPE_ID_REMOTE) OutMI.setOpcode(BPF::LD_imm64); else anakryiko wrote: > yonghong-song wrote: > > ast wrote: >

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff abandoned this revision. sepavloff added a comment. Implemented in D87528 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69272/new/ https://reviews.llvm.org/D69272

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @chandlerc @majnemer @aaron.ballman @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge updated this revision to Diff 305409. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91124/new/ https://reviews.llvm.org/D91124 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge added a comment. In D91123#2387032 , @kadircet wrote: > can you also add some tests to ClangdTests.cpp ? It seems like they would be highly duplicative of the tests in CallHierarchyTests.cpp. Comment at:

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge updated this revision to Diff 305408. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91123/new/ https://reviews.llvm.org/D91123 Files:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 305407. nridge added a comment. Update variable names and remove a commented declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[PATCH] D91047: Add a call super attribute plugin example

psionic12 marked 6 inline comments as done. psionic12 added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + aaron.ballman wrote: > psionic12 wrote: > > aaron.ballman wrote: > > > aaron.ballman wrote: >

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

nridge updated this revision to Diff 305406. nridge added a comment. Forgot to rename a few fields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-extra/clangd/Protocol.cpp

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 305405. psionic12 added a comment. Fix the grammar Simplify the code logic Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://reviews.llvm.org/D91047 Files:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1317 -static Optional -symbolToTypeHierarchyItem(const Symbol , const SymbolIndex *Index, - PathRef TUPath) { kadircet wrote: > that's a great change to have,

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 305400. nridge marked 12 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[clang] dc58cd1 - PR48169: Fix crash generating debug info for class non-type template

Author: Richard Smith Date: 2020-11-15T17:43:26-08:00 New Revision: dc58cd1480374a6d5dbf87e8a2424811c0003ce3 URL: https://github.com/llvm/llvm-project/commit/dc58cd1480374a6d5dbf87e8a2424811c0003ce3 DIFF: https://github.com/llvm/llvm-project/commit/dc58cd1480374a6d5dbf87e8a2424811c0003ce3.diff

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

nridge updated this revision to Diff 305397. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files:

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305396. DaanDeMeyer added a comment. Fixed formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc updated this revision to Diff 305395. smhc added a comment. Re-based to llvm master and re-diffed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305394. DaanDeMeyer retitled this revision from "[clangd] RFC: Add --prebuild-asts option" to "[clangd] Add AST config to prebuild ASTs". DaanDeMeyer edited the summary of this revision. DaanDeMeyer added a comment. Herald added a project: clang. Herald

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM we may consider implementing `-fsource-dir` in terms of `-fprofile-prefix-map` as suggested in D87928 so I think we should go ahead and land this.

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

nridge added a reviewer: sammccall. nridge added a comment. Sam, you're my go-to reviewer for "tricky macro stuff", but feel free to hand off if you prefer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91025/new/

[PATCH] D91131: [clangd] Bump index version number.

nridge added a comment. My apologies for not thinking of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91131/new/ https://reviews.llvm.org/D91131 ___ cfe-commits mailing list

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. In D87928#2394913 , @dexonsmith wrote: > I missed this before, and it's an interesting problem. > > I have a few questions: > > - I'm not clear on the expected interaction between the current working > directory of the compiler

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4861 +// We need correct types when the template-name is unresolved or when it +// might be overloaded. +if (!ResolvedTemplate) Quuxplusone wrote: > And from the PR summary: >

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith updated this revision to Diff 305393. rsmith added a comment. Tweak wording of comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91488/new/ https://reviews.llvm.org/D91488 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith updated this revision to Diff 305392. rsmith added a comment. Improve commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91488/new/ https://reviews.llvm.org/D91488 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 305388. abelkocsis added a comment. Some fixes. Needs further improvement Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files:

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

anakryiko added inline comments. Comment at: llvm/lib/Target/BPF/BTFDebug.cpp:1230 +Reloc == BPFCoreSharedInfo::BTF_TYPE_ID_REMOTE) OutMI.setOpcode(BPF::LD_imm64); else yonghong-song wrote: > ast wrote: > > libbpf would need to

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: ioeric, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. HazardyKnusperkeks requested review of this revision. I think the title

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BTFDebug.cpp:1230 +Reloc == BPFCoreSharedInfo::BTF_TYPE_ID_REMOTE) OutMI.setOpcode(BPF::LD_imm64); else ast wrote: > libbpf would need to support both (ld_imm64

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

tschuett created this revision. tschuett added reviewers: aaron.ballman, faisalv, wchilders. Herald added subscribers: cfe-commits, dexonsmith, usaxena95, kadircet. Herald added a project: clang. tschuett requested review of this revision. Herald added a subscriber: ilya-biryukov. > ninja clang

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

MaskRay added a comment. Herald added a subscriber: dexonsmith. https://fedoraproject.org/wiki/Toolchain/Watermark Seems that `.gnu.build.attributes` is used with a GCC plugin (annobin?). The feature on its own is probably not that useful. `.gnu.linkonce` is a proto-comdat legacy feature which

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

ast accepted this revision. ast added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/BPF/BTFDebug.cpp:1230 +Reloc == BPFCoreSharedInfo::BTF_TYPE_ID_REMOTE) OutMI.setOpcode(BPF::LD_imm64); else

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

rsmith added a comment. The direction here seems fine to me. Comment at: clang/include/clang/Sema/Sema.h:2478 - Decl *ActOnDeclarator(Scope *S, Declarator ); + Decl *ActOnDeclarator(Scope *S, Declarator , bool NextTokIsEqual = false); Can we set a

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 updated this revision to Diff 305373. njames93 added a comment. Fix assertions failing with included files. Ran this over the entire clang directory, which has a lot of macro (ab)use, and no crashes or otherwise unexpected behaviour. Repository: rG LLVM Github Monorepo CHANGES

[clang] e6aa065 - [NFC, Refactor] Modernize the TypeSpecifierWidth enum (Specifiers.h) to a scoped enum

Author: faisalv Date: 2020-11-15T11:13:57-06:00 New Revision: e6aa06545b123292be283af7c414daead23cf9ab URL: https://github.com/llvm/llvm-project/commit/e6aa06545b123292be283af7c414daead23cf9ab DIFF: https://github.com/llvm/llvm-project/commit/e6aa06545b123292be283af7c414daead23cf9ab.diff LOG:

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Fixed the spelling issue in rGdea31f135ceae6e860e6301f9bb66d3b3adb1357 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f84779674a9: [Sema] Improve notes for value category mismatch in overloading (authored by aaronpuchert). Repository: rG LLVM Github Monorepo

[clang] 6f84779 - [Sema] Improve notes for value category mismatch in overloading

Author: Aaron Puchert Date: 2020-11-15T18:05:11+01:00 New Revision: 6f84779674a9764c6adee29b9a48ed3b3f0d5132 URL: https://github.com/llvm/llvm-project/commit/6f84779674a9764c6adee29b9a48ed3b3f0d5132 DIFF: https://github.com/llvm/llvm-project/commit/6f84779674a9764c6adee29b9a48ed3b3f0d5132.diff

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4280 "candidate %sub{select_ovl_candidate_kind}0,1,2 not viable: " -"expects an l-value for " +"expects an %select{l-value|r-value}5 for " "%select{%ordinal4

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis updated this revision to Diff 305361. zinovy.nis added a comment. Extend the context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91495/new/ https://reviews.llvm.org/D91495 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES:

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis created this revision. zinovy.nis added reviewers: aaron.ballman, baloghadamsoftware. Herald added subscribers: cfe-commits, rnkovacs, xazax.hun. Herald added a project: clang. zinovy.nis requested review of this revision. Inspired by discussion in https://reviews.llvm.org/D91037

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

Quuxplusone added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4861 +// We need correct types when the template-name is unresolved or when it +// might be overloaded. +if (!ResolvedTemplate) And from the PR summary: > namely mangling

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 305353. aaronpuchert added a comment. Herald added a subscriber: lxfind. Rebase and add a comment about the limitations of this implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68845/new/

[PATCH] D91421: Fix temporary file name on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb58142e00ad: Fix temporary file name on Windows (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D91421?vs=305127=305352#toc Repository: rG

[clang] fb58142 - Fix temporary file name on Windows

Author: Yaxun (Sam) Liu Date: 2020-11-15T08:11:05-05:00 New Revision: fb58142e00ad73c2e6bfd80452e5e9b080c81552 URL: https://github.com/llvm/llvm-project/commit/fb58142e00ad73c2e6bfd80452e5e9b080c81552 DIFF:

[clang] 5e373b2 - [Sema] Use isa<> instead of dyn_cast<> as pointer is never dereferenced. NFCI.

Author: Simon Pilgrim Date: 2020-11-15T12:58:36Z New Revision: 5e373b2e94d714a7250e961029a58bae5585f33e URL: https://github.com/llvm/llvm-project/commit/5e373b2e94d714a7250e961029a58bae5585f33e DIFF: https://github.com/llvm/llvm-project/commit/5e373b2e94d714a7250e961029a58bae5585f33e.diff

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

mnauw abandoned this revision. mnauw added a comment. Looks like PenaltyBreakBeforeFirstCallParameter not being considered so well has been addressed somewhat differently in D90246 , and so that does the job as well. Repository: rG LLVM Github Monorepo