[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein updated this revision to Diff 308267. hokein added a comment. Herald added a subscriber: lxfind. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80109/new/ https://reviews.llvm.org/D80109 Files:

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, that's very clean. Comment at: clang/lib/Sema/SemaDecl.cpp:6027 +/// Attempt to fold a variable-sized type to a constant-sized type, returning +/// true if it we

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92298 Files: clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dump-recovery.cpp

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

rsmith added a comment. This was discussed on the original patch (https://reviews.llvm.org/D17993#inline-830995) and @jdoerfert argued that `dereferenceable` is correct even in `NullPointerIsValid` mode. Does this indicate a bug in the middle-end? If so, we should add a FIXME here to remove

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

MaskRay created this revision. MaskRay added reviewers: bkramer, CJ-Johnson, jdoerfert, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay requested review of this revision. After D17993 , with

[clang] 1db60c1 - Remove redundant check for access in the conversion from the naming

Author: Richard Smith Date: 2020-11-29T19:21:59-08:00 New Revision: 1db60c1307ac2e24796047c39d09bf400c22e531 URL: https://github.com/llvm/llvm-project/commit/1db60c1307ac2e24796047c39d09bf400c22e531 DIFF: https://github.com/llvm/llvm-project/commit/1db60c1307ac2e24796047c39d09bf400c22e531.diff

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 308249. atmnpatel added a comment. I believe this happened becase when I removed the loop, I did not update MemorySSA. The exact error was from GVN, but this update seems to fix the stage 2 build compile time error locally (I checked by running the build

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel reopened this revision. atmnpatel added a comment. This revision is now accepted and ready to land. This introduced a compile-time error that showed up during a stage 2 build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/

[PATCH] D92291: clang/test: Remove platform-linker feature

thakis created this revision. thakis added reviewers: serge-sans-paille, leonardchan, vvereschaka. Herald added subscribers: llvm-commits, frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

NoQ accepted this revision. NoQ added a reviewer: vsavchenko. NoQ added a comment. This revision is now accepted and ready to land. Aha, ok then! Thanks for cleaning this up. Maybe we should provide default initializers for `bool` flags then, so that they weren't undefined by default.

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rGf15b7869e5af: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] f15b786 - [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

Author: Nathan Ridge Date: 2020-11-29T18:32:23-05:00 New Revision: f15b7869e5afbd6c24ef440b0b62593e80fbd24f URL: https://github.com/llvm/llvm-project/commit/f15b7869e5afbd6c24ef440b0b62593e80fbd24f DIFF: https://github.com/llvm/llvm-project/commit/f15b7869e5afbd6c24ef440b0b62593e80fbd24f.diff

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92272/new/ https://reviews.llvm.org/D92272

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91025/new/ https://reviews.llvm.org/D91025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, javed.absar. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Use it to remove the NameFactory hack from

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

nridge updated this revision to Diff 308235. nridge added a comment. Rebase and address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92272/new/ https://reviews.llvm.org/D92272 Files:

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > I didn't want to end up with a big refactoring from this patch but now I > start to think that considering the situation it might be unavoidable. :( Well, it was expected. However, I didn't want to mess this refactoring with OpenCL C 3.0 support at first. I

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 308214. trixirt edited the summary of this revision. trixirt added a comment. Refactor to combine switch and trailing macro into one fixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. > How does the CLI options correspond with the back-end capabilities? `clang -print-supported-cpus` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. The TypeOf_xxx field is only used by the searchable tables backend. My trek through all the backends revealed it as the only one that needs to distinguish string and code, because it can emit the C++ initializer for any type of field. All the other

[PATCH] D92269: [TableGen] Eliminate the 'code' type

lattner added a comment. Oh ok, well I have no problem keeping it around in searchable tables, I misread this as making that more general. jrtc27, we had a long conversation about this. We'd like to eliminate the Code type as a way to simplify the internals of tblgen. It is a distinction

[PATCH] D92269: [TableGen] Eliminate the 'code' type

jrtc27 added a comment. In D92269#2421399 , @Paul-C-Anagnostopoulos wrote: > Yes, we could create !codeconcat instead, along with !codeinterleave, > !codeeq, etc. We could also just extend the existing bang operators to work > on the code type. I

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. Yes, we could create !codeconcat instead, along with !codeinterleave, !codeeq, etc. We could also just extend the existing bang operators to work on the code type. I thought it was cleaner just to get rid of the distinction. I agree that !subst is a

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos added a comment. The TypeOf_xxx feature of searchable tables already exists. I just co-opted it as the way to tell the searchable table backend to emit the code without quotes. If we go with this revision, we will always need it in certain cases, when the code is

[PATCH] D92269: [TableGen] Eliminate the 'code' type

jrtc27 added a comment. Losing types and permitting nonsensical operators like `!subst` on code seems a bit sad. Why not just define a `!codeconcat`, like how we have a separate `!listconcat`? I agree that the TypeOf_xxx stuff is really ugly and so having _greater_ expressivity like

[PATCH] D92269: [TableGen] Eliminate the 'code' type

lattner added a comment. Ah, I thought TypeOf_xxx was a transitionary thing that we'd drop over time (to reduce complexity). If that's the case, I'd recommend not documenting it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis added a comment. What do you think of it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91495/new/ https://reviews.llvm.org/D91495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] d99da80 - [clangd] Fix path edge-case condition.

Author: Sam McCall Date: 2020-11-29T13:40:29+01:00 New Revision: d99da80841cb4d9734db4a48cd49e37b623176bc URL: https://github.com/llvm/llvm-project/commit/d99da80841cb4d9734db4a48cd49e37b623176bc DIFF: https://github.com/llvm/llvm-project/commit/d99da80841cb4d9734db4a48cd49e37b623176bc.diff

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG67d16b6da4be: [clangd] Cache .clang-tidy files again. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 67d16b6 - [clangd] Cache .clang-tidy files again.

Author: Sam McCall Date: 2020-11-29T13:28:53+01:00 New Revision: 67d16b6da4bef1ee174514148854e77151a62605 URL: https://github.com/llvm/llvm-project/commit/67d16b6da4bef1ee174514148854e77151a62605 DIFF: https://github.com/llvm/llvm-project/commit/67d16b6da4bef1ee174514148854e77151a62605.diff

[PATCH] D92270: [ConstantFold] Fold more operations to poison

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53040a968dc2: [ConstantFold] Fold more operations to poison (authored by aqjune). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 53040a9 - [ConstantFold] Fold more operations to poison

Author: Juneyoung Lee Date: 2020-11-29T21:19:48+09:00 New Revision: 53040a968dc2ff20931661e55f05da2ef8b964a0 URL: https://github.com/llvm/llvm-project/commit/53040a968dc2ff20931661e55f05da2ef8b964a0 DIFF: https://github.com/llvm/llvm-project/commit/53040a968dc2ff20931661e55f05da2ef8b964a0.diff

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

njames93 added a comment. This small fix is definitely worth while, the more involved patch may not ever land. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:322 DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage) -

[PATCH] D92198: [clangd] Implement remote index handshake

sammccall added a comment. It'd be nice to know what problem this is trying to solve :-) I can guess, but don't feel entirely sure here. In D92198#2420203 , @kadircet wrote: > Haven't checked the details but is there a specific reason for implementing a

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

sammccall added a comment. In D92201#2419933 , @kbobyrev wrote: > Hm, yes, this makes sense. I just found it awkward that memory usage estimate > will spike right after the first request but that's actually the reality > (loading the index is deferred

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr contains expr.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great stuff, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92211/new/ https://reviews.llvm.org/D92211

[PATCH] D92270: [ConstantFold] Fold more operations to poison

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92270/new/ https://reviews.llvm.org/D92270 ___

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 308203. aguinet added a comment. Relax checks in `CodeGenCXX/darwinabi-returnthis.cpp` Clang test (to adapt to new attributes), and removes some useless brackets in if statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1481 +def DarwinABI : DeclOrTypeAttr { + let Spellings = [GCC<"darwin_abi">]; +// let Subjects = [Function, ObjCMethod]; aaron.ballman wrote: > I suspect this should be using the

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 308202. aguinet marked 10 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h