[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ikudrin added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4016 + auto *dwarfArgs = + Args.getLastArg(options::OPT_gdwarf64, options::OPT_gdwarf32); Maybe make this more descriptive? Comment at: clang/test/Driver/d

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

kernigh added a comment. Hi, Eli. I'm missing emails from Phabricator, so I didn't know about your recent post. I will respond to your question about numUsedRegs when I find time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90329/new/ https://reviews.llvm.org/D90329

[PATCH] D92006: Refactoring the attribute plugin example to fit the new API

psionic12 marked an inline comment as done. psionic12 added a comment. Hi, could anyone help to commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 ___ c

[clang] db1616c - [test] Fix new-pass-manager-opt-bisect.c

Author: Arthur Eubanks Date: 2020-12-20T17:13:42-08:00 New Revision: db1616c768475545453cf025d774db8d47f39ce3 URL: https://github.com/llvm/llvm-project/commit/db1616c768475545453cf025d774db8d47f39ce3 DIFF: https://github.com/llvm/llvm-project/commit/db1616c768475545453cf025d774db8d47f39ce3.diff

[PATCH] D93452: [clangd] Trim memory periodically

qchateau added a comment. Here is the latest version, I believe it should mostly look like what you expect. Let me know if there is anything that you'd like me to change, it's totally fine to have a few more iterations on this diff. I added a `CLANGD_ENABLE_MEMORY_CLEANUP` to make sure people c

[PATCH] D93452: [clangd] Trim memory periodically

qchateau updated this revision to Diff 313000. qchateau marked 16 inline comments as done. qchateau added a comment. - Move platform specific code to ClangdMain - Generic memory cleanup callback in ClangdLSPServer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47dbee6790cb: Make NPM OptBisectInstrumentation use global singleton OptBisect (authored by swamulism, committed by aeubanks). Repository: rG LLVM

[clang] 47dbee6 - Make NPM OptBisectInstrumentation use global singleton OptBisect

Author: Samuel Eubanks Date: 2020-12-20T13:47:56-08:00 New Revision: 47dbee6790cb813e4f4bc993585b9770c357e508 URL: https://github.com/llvm/llvm-project/commit/47dbee6790cb813e4f4bc993585b9770c357e508 DIFF: https://github.com/llvm/llvm-project/commit/47dbee6790cb813e4f4bc993585b9770c357e508.diff

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

vabridgers added a comment. Based on a suggestion from Balazs, I reduced the scope of the initial change to just scalars. There is one issue I'd like to hear comments on, and that's how to handle the case of extracting a bit field outside of the represented APInt. Currently, I'm returning Unkno

[PATCH] D93452: [clangd] Trim memory periodically

qchateau added a comment. > Sorry to mess you around like this, but I think I might have jumped the gun > in asking this to be abstracted away in `Process.h`. No problem, there is not much code anyway. The thought process behind the "right" solution is by far the most important. > So I think m

[PATCH] D93595: [analyzer] Fix extraction of punned and known SVals

vabridgers updated this revision to Diff 312996. vabridgers added a comment. Reduce scope of this initial change to just scalars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93595/new/ https://reviews.llvm.org/D93595 Files: clang/lib/StaticAnal

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic added a comment. Just wanted to say that this is my first patch submission to the LLVM/clangd project, so please call me out on any mistake! The arc tool caught me by surprise by opening the revision before I could double check it, hence the rename and edits... Repository: rG LLVM

[PATCH] D93600: When querying drivers by binary, look in PATH too

rapgenic created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. rapgenic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sometimes compile_commands.json databases are created without an absolute path for the driver

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

nikic added a comment. In D86844#2465027 , @jdoerfert wrote: > @nikic Is this OK or do you want it split? After looking again, I assume this can't really be split, because prior to this change we would never delete a loop without an exit block, so the co

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert added a comment. @nikic Is this OK or do you want it split? Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:661 + } +} } atmnpatel wrote: > nikic wrote: > > These fixes look unrelated. Is it possible to test them separately? > So my un

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2089 + static const char *const M68kTriples[] = { + "m68k-linux-gnu", "m68k-unknown-linux-gnu", "m68k-suse-linux"}; + rengolin wrote: > The front-end supports FreeBSD, too. Aren't

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:38-50 + // M68k pointers are always 32 bit wide even for 16 bit cpus + Layout += "-p:32:32"; + + // M68k integer data types + Layout += "-i8:8:8-i16:16:16-i32:32:32"; + + // FIXME no floats at the mom

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

tschuett added a comment. constexpr bool test() { float A = 1,0; float B = 2,0; float C = 3.0; float D = 4,0; __m128 AV; __m128 BV; __m128 result = _mm_setr_ps(A, B, C, D); result = _mm_setzero_ps(); result = _mm_xor_ps(AV, BV); return true; } It should help you to test,

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon added a comment. In D93597#2464870 , @tschuett wrote: > libcxx uses a function test and calls test() and static_assert(test()), see > below > https://github.com/llvm/llvm-project/blob/d86a00d8febd0138a21f92d1420c4b62d7acb0ca/libcxx/test/std/utilit

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas marked 22 inline comments as done. reikdas added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:111-115 + Out << "u8'" << Val << "'"; +else if (T->isUnsignedIntegerType() && T->isChar16Type()) + Out << "u16'" << Val << "'"; +

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

tschuett added a comment. libcxx uses a function test and calls test() and static_assert(test()), see below https://github.com/llvm/llvm-project/blob/d86a00d8febd0138a21f92d1420c4b62d7acb0ca/libcxx/test/std/utilities/memory/pointer.conversion/to_address.pass.cpp#L102-126 Repository: rG LLVM G

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 312980. reikdas added a comment. Address @rsmith comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td cl

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon updated this revision to Diff 312979. RKSimon added a comment. missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93597/new/ https://reviews.llvm.org/D93597 Files: clang/lib/Headers/xmmintrin.h clang/test/CodeGen/X86/sse-bui

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei, rsmith, erichkeane, spatel. RKSimon requested review of this revision. Herald added a project: clang. This is an initial exploratory patch towards making some (basic initialization and arithmetic) SSE/AVX intrinsics us

[PATCH] D93595: [analyzer] Fix extraction of punned and known SVals

vabridgers added a comment. This proposed change seems to address the referenced issues (https://bugs.llvm.org/show_bug.cgi?id=39032 and https://bugs.llvm.org/show_bug.cgi?id=44114). I believe the scalars test cases to be mostly complete, and the structures test cases to be at most a baseline

[PATCH] D93595: [analyzer] Prototype change to fix type punning of known SVals

vabridgers updated this revision to Diff 312977. vabridgers added a comment. Update commit header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93595/new/ https://reviews.llvm.org/D93595 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp cl

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

spatel added reviewers: nlopes, regehr, RKSimon, zhengyangl, nikic, hfinkel. spatel added a comment. Thank you for working on this! Looking back at the bug comments (and adding reviewers based on those comments), this is a step towards killing undef that has been discussed for a long time now. :

[PATCH] D93595: [analyzer] Prototype change to fix type punning of known SVals

vabridgers updated this revision to Diff 312976. vabridgers added a comment. Clean up a few typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93595/new/ https://reviews.llvm.org/D93595 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp cla

[PATCH] D93596: [ASTMatchers] Traverse-ignore range-for implementation details

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93596 Files: clang/lib/ASTMatchers/ASTMat

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. Sorry to mess you around like this, but I think I might have jumped the gun in asking this to be abstracted away in `Process.h`. My reasoning is: - Once we are injecting the cleanup function from ClangdMain, that's not actually a crazy place to put this kind of system

[PATCH] D93595: [analyzer] Prototype change to fix type punning of known SVals

vabridgers created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. Herald added a project: clang. Herald

[PATCH] D93452: [clangd] Trim memory periodically

qchateau added a comment. > Interestingly clangd held rock solid at 1.0GB recorded memory usage > throughout. What do you mean exactly ? Using the built in memory usage measurement ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93452/new/ https:

[clang] 7e84aa1 - Fix MSVC "not all control paths return a value" warnings. NFCI.

Author: Simon Pilgrim Date: 2020-12-20T11:32:40Z New Revision: 7e84aa1b81e72d44bcc58ffe1731bfc7abb73ce0 URL: https://github.com/llvm/llvm-project/commit/7e84aa1b81e72d44bcc58ffe1731bfc7abb73ce0 DIFF: https://github.com/llvm/llvm-project/commit/7e84aa1b81e72d44bcc58ffe1731bfc7abb73ce0.diff LOG:

[PATCH] D93333: [clang-tidy] ppcoreguidelines-pro-type-member-init: suppress warning for default member funcs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35f2c3a8b41f: [clang-tidy] cppcoreguidelines-pro-type-member-init: suppress warning for… (authored by cwarner-8702, committed by malcolm.parsons).

[clang-tools-extra] 35f2c3a - [clang-tidy] cppcoreguidelines-pro-type-member-init: suppress warning for default member funcs

Author: Chris Warner Date: 2020-12-20T11:22:41Z New Revision: 35f2c3a8b41fd3b6ef88d013a7c3ed9478b765e4 URL: https://github.com/llvm/llvm-project/commit/35f2c3a8b41fd3b6ef88d013a7c3ed9478b765e4 DIFF: https://github.com/llvm/llvm-project/commit/35f2c3a8b41fd3b6ef88d013a7c3ed9478b765e4.diff LOG: