[clang] 2820a2c - Move -fno-semantic-interposition dso_local logic from TargetMachine to Clang CodeGenModule

Author: Fangrui Song Date: 2020-12-29T23:37:55-08:00 New Revision: 2820a2ca3a0e69c3f301845420e00672251b URL: https://github.com/llvm/llvm-project/commit/2820a2ca3a0e69c3f301845420e00672251b DIFF: https://github.com/llvm/llvm-project/commit/2820a2ca3a0e69c3f301845420e00672251b.diff

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG981a0bd85811: [X86] Add x86_amx type for intel AMX. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 981a0bd - [X86] Add x86_amx type for intel AMX.

Author: Luo, Yuanke Date: 2020-12-30T13:52:13+08:00 New Revision: 981a0bd85811fe49379fdbef35528e2c2f3511a3 URL: https://github.com/llvm/llvm-project/commit/981a0bd85811fe49379fdbef35528e2c2f3511a3 DIFF: https://github.com/llvm/llvm-project/commit/981a0bd85811fe49379fdbef35528e2c2f3511a3.diff L

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/ppc-endian.c:1 -// RUN: %clang -target powerpc64le -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-LE %s -// RUN: %clang -target powerpc6

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

Bdragon28 marked 3 inline comments as done. Bdragon28 added inline comments. Comment at: clang/test/Driver/ppc-endian.c:1 -// RUN: %clang -target powerpc64le -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-LE %s -// RUN: %clang -target powerpc64le -mlittle-endian -### -c %s 2>&1

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

Bdragon28 updated this revision to Diff 314049. Bdragon28 added a comment. - Adjust the GNU LD settings for 32 bit powerpc to more closely match reality. - Add linker emulation test for powerpcle, as well as adding testing for the FreeBSD emulations. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 314043. hoy added a comment. Removing the checks of VerifierAnalysis in test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llvm/include/llvm/Passes/PassBui

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: llvm/tools/opt/NewPMDriver.cpp:136-138 +static cl::opt PseudoProbeForProfiling( +"new-pm-pseudo-probe-for-profiling", cl::init(false), cl::Hidden, +cl::desc("Emit pseudo probes to enable PGO profile generation.")); d

[PATCH] D93919: [PowerPC] powerpcle target 3/5

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:260 + case llvm::Triple::ppcle: +return "elf32lppc"; case llvm::Triple::ppc64: This needs a linker test in clang/test/Driver/ppc-features.cpp Comment at: cla

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global hoy wrote: > d

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

dblaikie added a subscriber: rtrieu. dblaikie added a comment. In D93822#2474355 , @lebedev.ri wrote: > Thank you for taking a look! > > In D93822#2474236 , @dblaikie wrote: > >> Haven't reviewed the code in detail,

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

curdeius added a comment. Nit. Comment at: clang/docs/ClangFormatStyleOptions.rst:1545 +**EmptyLineBeforeAccessModifier** (``bool``) + If true, the empty line is inserted before access modifiers + Full stop at the end of the phrase. CHANGES SINCE LAST ACTION

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:364 + +if (TheLine->Last->is(tok::l_brace) && I != AnnotatedLines.begin() && +I[-1]->Las

[PATCH] D93923: Use unary CreateShuffleVector if possible

aqjune added inline comments. Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:2260 - V = IRB.CreateSelect(ConstantVector::get(Mask), V, Old, Name + "blend"); + V = IRB.CreateSelect(ConstantVector::get(Mask2), V, Old, Name + "blend"); LLVM_DEBUG(dbgs() << "blend: " << *

[PATCH] D93923: Use unary CreateShuffleVector if possible

aqjune created this revision. aqjune added reviewers: spatel, nikic, lebedev.ri, craig.topper, RKSimon, efriedma. Herald added subscribers: dexonsmith, kerbowa, pengfei, dmgreen, hiraditya, nhaehnle, jvesely, nemanjai, arsenm. aqjune requested review of this revision. Herald added projects: clang

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight created this revision. jyknight added reviewers: rsmith, rjmccall. jyknight requested review of this revision. Herald added projects: clang, libc++abi, LLVM. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits. Herald added a reviewer: libc++abi. The two operations have ac

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global dblaikie wrote: > h

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global hoy wrote: > d

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314019. Bdragon28 added a comment. Re-uploading patch for part 5 now that I have the dependency tree fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: l

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri added a comment. Thank you for taking a look! In D93822#2474236 , @dblaikie wrote: > Haven't reviewed the code in detail, but the idea seems sound. That's reassuring! > Is there any prior art in other compilers you can draw data/experiences f

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314012. Bdragon28 retitled this revision from "[PowerPC] Add powerpcle target." to "[PowerPC] Add powerpcle target. (5/5)". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92

[PATCH] D93919: [PowerPC] powerpcle target 3/5

Bdragon28 created this revision. Herald added subscribers: shchenz, kbarton, nemanjai, emaste. Bdragon28 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Splitting D92445 . Repository: rG LLVM Github Mono

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

dblaikie added a comment. Haven't reviewed the code in detail, but the idea seems sound. Is there any prior art in other compilers you can draw data/experiences from? & having some data from some reasonably sized codebases on false positive (how often the correct thing is to suppress the warnin

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks added a comment. In D93844#2473725 , @MyDeveloperDay wrote: > I like what you are suggesting, do you think `BasedOnStyle: File` is the best > terminology as the term `File` is used elsewhere to mean read from the > .clang_format file,

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:234 +SmallString<8> ResultCharConv; +Converter->convert(std::string(1, ByteChar), ResultCharConv); +memcpy((void *)&Re

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. This change looks good to me but I would like @rnk to sign off. My opinion is that the change is simple enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 __

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 8 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:244 bool Pascal; + ConversionState TranslationState; + tahonermann wrote: > abhina.sreeskantharajan w

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aqjune marked an inline comment as done. Closed by commit rG278aa65cc495: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as… (authored by aqjune)

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 313990. abhina.sreeskantharajan added a comment. Thanks for the review! I've addressed most of the comments but I still need to work on the translation issues in CharLiteralParser that was kindly pointed out by Tom and Richard. Here are the s

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

aqjune marked an inline comment as done. aqjune added inline comments. Comment at: llvm/lib/IR/IRBuilder.cpp:1020 Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC)); - return CreateShuffleVector(V, Undef, Zeros, Name + ".splat"); + return CreateShuffleVect

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

aqjune updated this revision to Diff 313989. aqjune added a comment. Herald added a reviewer: bollu. Update comments Call unary CreateShuffleVector Update polly tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93793/new/ https://reviews.llvm.org

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 313986. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Rebase on renaming NFC patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 File

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 313973. thezbyg added a comment. Switched to verifyFormat in most of the tests. Rerun clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 Files: clang/docs/ClangFormatStyleOptions.rst clang/inc

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:637 PragmaStack VtorDispStack; - // #pragma pack. - // Sentinel to represent when the stack is set to mac68k alignment. - static const unsigned kMac6

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, efriedma, jyknight, aaron.ballman. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch renames `PackStack` and related var

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

spatel added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:2527 /// Create a unary shuffle. The second vector operand of the IR instruction /// is undefined. Value *CreateShuffleVector(Value *V, ArrayRef Mask, update code comment: undefin

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. There are some polly tests that also need to be updated, but otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93793/new/ https://revi

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei added a comment. In D93179#2473620 , @RKSimon wrote: > In D93179#2473342 , @pengfei wrote: > >> Hi Simon, I found we have the same problem for fadd/fmul. See >> https://godbolt.org/z/3YKaGx >> X86 Intrinsic

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544-8556 + EXPECT_EQ("struct foo {\n" +" int i;\n" +"\n" +"private:\n" +" int j;\n" +"}\n", +format("struct foo {\n"

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

MyDeveloperDay added a comment. I like what you are suggesting, do you think `BasedOnStyle: File` is the best terminology as the term `File` is used elsewhere to mean read from the .clang_format file, how about `BasedOnStyle: Inherit` `BasedOnStyle: InheritFromParent` `BasedOnStyle: InheritFrom

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-prefetch-offset.ll:126 +;=== +; v128.load64_zero +;===

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:318 + Intrinsic<[], [llvm_ptr_ty], +[IntrInaccessibleMemOrArgMemOnly, IntrWillReturn, +

[clang] 5abfecc - [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

Author: Mark Murray Date: 2020-12-29T10:18:59Z New Revision: 5abfeccf10bcbc0d673ece21ddd8d4ac4a0e7594 URL: https://github.com/llvm/llvm-project/commit/5abfeccf10bcbc0d673ece21ddd8d4ac4a0e7594 DIFF: https://github.com/llvm/llvm-project/commit/5abfeccf10bcbc0d673ece21ddd8d4ac4a0e7594.diff LOG: [

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

aqjune added inline comments. Comment at: clang/test/CodeGen/SystemZ/builtins-systemz-zvector-constrained.c:84 vd = vec_splat(vd, 1); // CHECK: shufflevector <2 x double> %{{.*}}, <2 x double> undef, <2 x i32> // CHECK-ASM: vrepg These SystemZ zvector

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

aqjune updated this revision to Diff 313945. aqjune added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Update IRBuilder to fill poison at shufflevector's empty operand Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93793/new/ htt

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. In D93179#2473342 , @pengfei wrote: > Hi Simon, I found we have the same problem for fadd/fmul. See > https://godbolt.org/z/3YKaGx > X86 Intrinsics imply `reassoc` flag, but `llvm.vector.reduce.*` doesn't. I'm not surprised - my

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks added a comment. In D93844#2472352 , @njames93 wrote: > In D93844#2472346 , @MyDeveloperDay > wrote: > >> I'm a little confused why this is needed as clang-format always read up the >> directory

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

dongAxis1944 added inline comments. Herald added a subscriber: lxfind. Comment at: cfe/trunk/lib/AST/StmtCXX.cpp:107-108 + Result->NumParams = NumParams; + auto *ParamBegin = Result->getStoredStmts() + SubStmt::FirstParamMove; + std::uninitialized_fill(ParamBegin, ParamBegin +