[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

NoQ added a comment. This patch adds a new core checker. I wouldn't be comfortable enabling it by default without a much more careful evaluation (than a single lit test). In particular, i'm worried about false positives due to constraint solving issues and our incorrect cast representation - it

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The as

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:219 + ProgramStateManager &Mgr = State->getStateManager(); + SValBuilder &Bldr = Mgr.getSValBuilder(); + SVal Eval = `Bldr` is always equal to `*this` here, there's no n

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added a comment. The exact call chain, if the added test is called without the fix: $ ./tools/clang/unittests/AST/ASTTests --gtest_filter='*HasNoDescribedTemplateSet*' Note: Google Test filter = *HasNoDescribedTem* [==] Running 4 tests from 1 test case. [--] Glob

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

SjoerdMeijer accepted this revision. SjoerdMeijer added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/arm_neon.td:1911 +// vcmlaq{ROT}_lane +def : SOpInst<"vcmla" # ROT # "_lane", "...qI", "Q" # type, Op<(call "vc

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

hokein updated this revision to Diff 314522. hokein marked 2 inline comments as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92749/new/ https://reviews.llvm.org/D92749 Files: clang-tools-ext

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

hokein added a comment. In D92749#2436658 , @njames93 wrote: > How does this handle Dependent base classes (including CRTP). Can tests be > added to demonstrate that behaviour if its supported. Thanks, this is a good point. Repository: rG LLVM Github

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:213 ParsedStmtContext()) && -(GNUAttributeLoc.isValid() || isDeclarationStatement())) { +((GNUAttributeLoc.isValid() && !Attrs.back().isStmtAttr()) || + isDeclaration

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1222-1223 +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1) + ++Newlines; +else if (!Style.EmptyLineBeforeAccessModifier &

[clang] 6725860 - Sema::BuildCallExpr - use cast<> instead of dyn_cast<> for dereferenced pointer. NFCI.

Author: Simon Pilgrim Date: 2021-01-05T09:34:00Z New Revision: 6725860d21a03741d6c3331ab0560416bb19e068 URL: https://github.com/llvm/llvm-project/commit/6725860d21a03741d6c3331ab0560416bb19e068 DIFF: https://github.com/llvm/llvm-project/commit/6725860d21a03741d6c3331ab0560416bb19e068.diff LOG:

[clang] 02eb8e2 - Inform the consumer on invalid template instantiations.

Author: Vassil Vassilev Date: 2021-01-05T09:43:38Z New Revision: 02eb8e20b51b3ea263bbfe696241b8541c72ee7a URL: https://github.com/llvm/llvm-project/commit/02eb8e20b51b3ea263bbfe696241b8541c72ee7a DIFF: https://github.com/llvm/llvm-project/commit/02eb8e20b51b3ea263bbfe696241b8541c72ee7a.diff LO

[PATCH] D92248: Inform the consumer on invalid template instantiations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02eb8e20b51b: Inform the consumer on invalid template instantiations. (authored by v.g.vassilev). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added a comment. Order of previous declarations may get confusable: ClassTemplateDecl1 <-(Prev)- ClassTemplateDecl2 <-(Prev)- ClassTemplateDecl3 | | | | | CXXRecorddDecl1 <-- CXXRecordDecl2 -(Prev)-> CXXRecordDecl3 - |

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added a comment. Thank you for submitting this patch? Comment at: clang/include/clang/Format/Format.h:117 +/// int b= 23; +/// +/// int ccc = 23; tinloaf wrote: > HazardyKnusperkeks wrote: > > You are adding a Tab here, or do

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments** (``AlignConsecutiveAssignmentsStyle``) + Style of aligning

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. I guess I want to clarify one point here, after this patch the parser **will not assume** that statement always follows statement attributes. We simply turn off the assumption that what follows is a declaration, parser will simply determine whether it is a statement

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. > BTW, I cannot optimize function f to returning zero directly with GCC-10.2.1 > and Clang-10.0.1 under -O3. Should I add any other flags? Or it is version > specific? Yeah I can't reproduce that with latest gcc/clang neither. Try gcc 4.x and gcc 5.x. > But fo

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM. This is the same hook hip & opencl use to indicate that a function is a kernel entry point. We may need to create the metadata openmp nvptx uses as well, but that's sep

[PATCH] D94076: [VE] Change clang to support SjLj Loweirng

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We supports SjLj exception handling in the backend, so changing clang to allow lowerin

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 2 inline comments as done. tinloaf added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments** (``AlignConsecutiveAssign

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments** (``AlignConsecutiveAssignmentsStyle``) + Style of aligning

[clang] 0e4d236 - [OpenCL] Warn about side effects for unevaluated vec_step arg

Author: Sven van Haastregt Date: 2021-01-05T11:51:10Z New Revision: 0e4d2361b817bd16f97cd45d5792017edc3891ee URL: https://github.com/llvm/llvm-project/commit/0e4d2361b817bd16f97cd45d5792017edc3891ee DIFF: https://github.com/llvm/llvm-project/commit/0e4d2361b817bd16f97cd45d5792017edc3891ee.diff

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4d2361b817: [OpenCL] Warn about side effects for unevaluated vec_step arg (authored by svenvh). Changed prior to commit: https://reviews.llvm.or

[clang-tools-extra] 2f8d1e9 - [clangd] When querying drivers by binary, look in PATH too

Author: Giulio Girardi Date: 2021-01-05T12:54:07+01:00 New Revision: 2f8d1e9eb27e111eb6dfd242d88dd7c98005fb5c URL: https://github.com/llvm/llvm-project/commit/2f8d1e9eb27e111eb6dfd242d88dd7c98005fb5c DIFF: https://github.com/llvm/llvm-project/commit/2f8d1e9eb27e111eb6dfd242d88dd7c98005fb5c.diff

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f8d1e9eb27e: [clangd] When querying drivers by binary, look in PATH too (authored by rapgenic, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

sammccall added a comment. Sorry for the delay getting this landed, and thanks for the patch! It'll be part of the clangd 12 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93600/new/ https://reviews.llvm.org/D93600

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2477937 , @emaste wrote: >> For now, only Linux/ARM64 is supported/tested. > > Is there any reason this is Linux-specific (as far as support; I understand > if it's not easy for you to test on non-Linux arm64). It's mai

[PATCH] D93796: [clangd][fuzzyFind] Do not show stale symbols in the result.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yup, as mentioned on D93393 this seems like a reasonable tradeoff to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

sammccall added a comment. Seems fair enough to do something about this, though it's a bit sad we're doing it just because VSCode has bad UI. A couple of open design questions: 1. In the future it may make sense to have other documentLinks too. (e.g. imagine a comment `Configures the Frobnicat

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 314565. aguinet marked 4 inline comments as done. aguinet added a comment. Rebase on current master, and take into account @aaron.ballman 's fixes (thanks!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: clang/test/Sema/callingconv-darwin_abi.c:10 + +void(__attribute__((darwin_abi)) * pfoo2)(void) = foo; // expected-warning{{incompatible function pointer types}} aaron.ballman wrote: > You should also add some tests like

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch updated this revision to Diff 314566. kiausch edited the summary of this revision. kiausch added a comment. implemented review suggestions: - updated clang/docs/ClangCommandLineReference.rst - removed unneccessary HasEFPU2() wrapper function - initialize HasEFPU member - merged tests into

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 314568. simoll marked an inline comment as done. simoll added a comment. NFC - Use `bool4` in docs. - Rebased, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files:

[PATCH] D94076: [VE] Change clang to support SjLj Loweirng

simoll added a comment. You might want to fix the typo in the title before committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.org/D94076 ___ cfe-commits mailin

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

steakhal added a comment. In D92634#2478503 , @OikawaKirie wrote: > Besides, as far as I am thinking, the compiler optimizes the expression as it > is literally inferable, i.e. the result should be determinable literally > during compilation. Otherwise,

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. In D93452#2460646 , @qchateau wrote: > It does indeed look like facing the problem from the wrong side (fight the > end result instead of finding the root cause) but at that point it does solve > an annoying problem. As I inves

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. I tried to sketch a couple of tetris-based mental models for why these hashtables might never fit inside an existing gap, leading us to stack our arena size (tetris field height) higher and higher. This is predicated on the assumption that the index hashtables are the

[PATCH] D94076: [VE] Change clang to support SjLj Lowering

kaz7 added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.org/D94076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm

[clang] 489000d - [VE] Change clang to support SjLj Lowering

Author: Kazushi (Jam) Marukawa Date: 2021-01-05T22:19:02+09:00 New Revision: 489000d8516da7eaf6aabaad11cce0ed7e67c61f URL: https://github.com/llvm/llvm-project/commit/489000d8516da7eaf6aabaad11cce0ed7e67c61f DIFF: https://github.com/llvm/llvm-project/commit/489000d8516da7eaf6aabaad11cce0ed7e67c

[PATCH] D94076: [VE] Change clang to support SjLj Lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG489000d8516d: [VE] Change clang to support SjLj Lowering (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.o

[clang] 6f77029 - [OpenCL] Restrict pointer to member functions.

Author: Anastasia Stulova Date: 2021-01-05T13:32:18Z New Revision: 6f770292a39f265c985623b1550aa50566b0 URL: https://github.com/llvm/llvm-project/commit/6f770292a39f265c985623b1550aa50566b0 DIFF: https://github.com/llvm/llvm-project/commit/6f770292a39f265c985623b1550aa50566b0.diff

[PATCH] D93958: [OpenCL] Restrict pointer to member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f770292a000: [OpenCL] Restrict pointer to member functions. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch marked 4 inline comments as done. kiausch added inline comments. Comment at: llvm/test/CodeGen/PowerPC/efpu2.ll:6 +; Single tests +; identical to tests in spe.ll + nemanjai wrote: > It might make sense to just add a RUN line in that test case rather than

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

MarkMurrayARM updated this revision to Diff 314579. MarkMurrayARM added a comment. Fixed the parent commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94083/new/ https://reviews.llvm.org/D94083 Files: clang/lib/Basic/Targets/AArch64.cpp cla

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2478977 , @vsavchenko wrote: > I guess I want to clarify one point here, after this patch the parser **will > not assume** that statement always follows statement attributes. We simply > turn off the assumption t

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93483/new/ https://reviews.llvm.org/D93483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:526 +TraverseStmt(LE->getTrailingRequiresClause()); + +TraverseStmt(LE->getBody()); --

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

aaron.ballman added a comment. In D93988#2477961 , @steveire wrote: > In D93988#2477602 , @aaron.ballman > wrote: > >> Could you give me a bit more background about why you want to make this >> change? > > This ch

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. I guess I could add a test for the example I posted, but I'm not sure of how much value that is. Or do you mean a test case that -ansi and -std=c89 behave the same in every situation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llv

[PATCH] D94029: [clang-tidy] Add extra tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94029/new/ https://reviews.llvm.org/D94029 __

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2479303 , @tbaeder wrote: > I guess I could add a test for the example I posted, but I'm not sure of how > much value that is. Or do you mean a test case that -ansi and -std=c89 behave > the same in every situatio

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2479260 , @aaron.ballman wrote: > In D93630#2478977 , @vsavchenko > wrote: > >> I guess I want to clarify one point here, after this patch the parser **will >> not assume** t

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450897 , @thopre wrote: > In D92409#2450690 , @rsmith wrote: > >> In D92409#2450550 , @thopre wrote: >> >>> In D92409#2426196

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:727 + virtual bool IsMatchingChildrenNotSpelledInSource() const = 0

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

fhahn added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:1756 + +class VectorTypeLoc : public ConcreteTypeLoc { Can we reuse/unify this with `MatrixTypeLoc`? And then have `MatrixTypeLoc` just deal with the row/column operands. CHANGES SINCE

[clang] c3a21e5 - [ASTMatchers] Ensure that we can match inside lambdas

Author: Stephen Kelly Date: 2021-01-05T14:39:46Z New Revision: c3a21e5de3dc3f55e4d219afd55dec518159d356 URL: https://github.com/llvm/llvm-project/commit/c3a21e5de3dc3f55e4d219afd55dec518159d356 DIFF: https://github.com/llvm/llvm-project/commit/c3a21e5de3dc3f55e4d219afd55dec518159d356.diff LOG:

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3a21e5de3dc: [ASTMatchers] Ensure that we can match inside lambdas (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ htt

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

nemanjai added a comment. In D92935#2477171 , @kiausch wrote: > Regarding similar GCC options: > > AFAIK GCC has had the spe options -msingle-float and -mdouble-float until spe > support was dropped after version 8.3. > These options would kind of match h

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein abandoned this revision. hokein added a comment. Closing it as Richard has landed a better patch in https://github.com/llvm/llvm-project/commit/638867afd4bce4a2c56dea041299428af3727d61. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87349/new

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94081/new/ https://reviews.llvm.org/D94081 ___ cf

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314594. Anastasia marked an inline comment as done. Anastasia added a comment. Addressed comments from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/do

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314597. Anastasia added a comment. Further change suggested by Marco CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/Us

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+===+ +| Comm

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:822 + /// calling the parameter itself, but rather uses it as the argument. + template + void checkIndirectCall(const CallLikeExpr *CallOrMessage) { NoQ wrote: > vsavchenko w

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia added a comment. > (I only discovered the "Suggest Edit" feature halfway through the review; I > didn't update the comments I already made as I'm not sure in which format you > prefer them?) I do like the feature but I wish it would be more useful like on github that you can update

[clang] 3d5b18a - [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

Author: Joe Ellis Date: 2021-01-05T15:18:21Z New Revision: 3d5b18a3fdf47ae2286642131e4a92968dd01c2a URL: https://github.com/llvm/llvm-project/commit/3d5b18a3fdf47ae2286642131e4a92968dd01c2a DIFF: https://github.com/llvm/llvm-project/commit/3d5b18a3fdf47ae2286642131e4a92968dd01c2a.diff LOG: [cl

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d5b18a3fdf4: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments (authored by joechrisellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4020 bool IsListInit = false, bool IsInitListCopy = false) { assert(((!IsListInit && !IsInitListCopy) || -

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

sammccall added a comment. Ah, thanks for working on this! A few thoughts: - when we're pseudoparsing the file we're going to modify as we do here, using the new content is strictly better, no downside :-) - the old method here of accessing the content through the FS attached to the AST is a h

[clang] 7e4f53f - [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

Author: Stephen Kelly Date: 2021-01-05T15:22:21Z New Revision: 7e4f53f748d3c97f0b9b852bfbcab0740aba521b URL: https://github.com/llvm/llvm-project/commit/7e4f53f748d3c97f0b9b852bfbcab0740aba521b DIFF: https://github.com/llvm/llvm-project/commit/7e4f53f748d3c97f0b9b852bfbcab0740aba521b.diff LOG:

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e4f53f748d3: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods (authored by stephenkelly). Changed prior to commit: https:

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:727 + virtual bool IsMatchingChildrenNotSpelledInSource() const = 0; + virtual void SetMatchingChildrenNotSpelledInSource(bool Set) = 0; + aaron.ballman wrote: > W

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske updated this revision to Diff 314604. balazske added a comment. Found a better solution. And the decl chain looks more normal if this change is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

balazske added a comment. The problem is reproduced and fixed in D94067 . It is caused by import of default template arguments indirectly, because that import causes lot of other things to be imported. And the import of default arguments happens in a incomplete

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

balazske added a comment. There are still problems related to import type argument default values: If there are forward declarations of the same template, the "inheritedness" of these arguments (in AST) is not set correctly and the default arguments can appear at more places instead of at only

[clang-tools-extra] 53c3acb - [clang-tidy] Add extra tests

Author: Stephen Kelly Date: 2021-01-05T15:43:56Z New Revision: 53c3acb89fcc25ba7ef1f1d76a79c241eeacb7f0 URL: https://github.com/llvm/llvm-project/commit/53c3acb89fcc25ba7ef1f1d76a79c241eeacb7f0 DIFF: https://github.com/llvm/llvm-project/commit/53c3acb89fcc25ba7ef1f1d76a79c241eeacb7f0.diff LOG:

[PATCH] D94029: [clang-tidy] Add extra tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG53c3acb89fcc: [clang-tidy] Add extra tests (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94029/new/ https://reviews.llvm.org/D94

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel updated this revision to Diff 314615. ymandel added a comment. added comment known smart pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93637/new/ https://reviews.llvm.org/D93637 Files: clang/include/clang/Tooling/Transformer/St

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! Comment at: clang/unittests/Tooling/StencilTest.cpp:273 + std::string Snippet = R"cc( +Smart x; +x; tdl-g wrote: > You're only testing the "QuacksLike" case. I s

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aaron.ballman added a comment. The frontend parts LGTM, but you should wait for someone else to review the backend parts before landing. Comment at: clang/test/Sema/callingconv-darwin_abi.c:10 + +void(__attribute__((darwin_abi)) * pfoo2)(void) = foo; // expected-warning{{inco

[clang] 51d5991 - [Clang] Add AArch64 VCMLA LANE variants.

Author: Florian Hahn Date: 2021-01-05T16:14:00Z New Revision: 51d5991f04dda76c2f07123569b5c31ed3dfcfe8 URL: https://github.com/llvm/llvm-project/commit/51d5991f04dda76c2f07123569b5c31ed3dfcfe8 DIFF: https://github.com/llvm/llvm-project/commit/51d5991f04dda76c2f07123569b5c31ed3dfcfe8.diff LOG:

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d5991f04dd: [Clang] Add AArch64 VCMLA LANE variants. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D93014?vs=314452&id=314620#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 added a comment. In D93701#2477239 , @jansvoboda11 wrote: > Another solution would be to create a "dummy" `DiagnosticsEngine` for the > `ParseDiagnosticArgs` calls, but I didn't find a way to do that. Something like `CompilerInstance::creat

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

tdl-g added a comment. Ah, if it's just an optimization that makes sense. I still think it's worth having a test case to confirm that one of the specially-handled cases works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93637/new/ https://revie

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn created this revision. fhahn added reviewers: aaron.ballman, rjmccall, Bigcheese, erichkeane. fhahn requested review of this revision. Herald added a project: clang. The MatrixType, ExtVectorType and VectorSize attributes have arguments defined as ExprArguments in Attr.td. So their arguments

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

peterwaller-arm updated this revision to Diff 314629. peterwaller-arm added a comment. Update for review comment. - Generalize WARN-NOT to disallow any warnings, not just those with specific text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9180

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

peterwaller-arm marked an inline comment as done. peterwaller-arm added inline comments. Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13 + +; ERR-NOT: TypeSize is not scalable + peterwaller-arm wrote: > sdesmalen wrote: > > After yo

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93700/new/ https://reviews.llvm.org/D93700 ___

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn updated this revision to Diff 314632. fhahn added a comment. Also remove Attr.isArgIdent check from AddressSpaceTypeAttribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94092/new/ https://reviews.llvm.org/D94092 Files: clang/lib/Sema/Se

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314631. segoon edited the summary of this revision. segoon added a comment. Herald added a subscriber: lxfind. - review fixes - drop of atomic::is_always_lock_free check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.or

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 314633. saiislam added a comment. Modified to handle multiple targets/outputs in one run of the tool for archive unbundling. Other minor changes as requested in the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

erichkeane added a comment. I'm not sure how well Attr.td's constraints are enforced on type attributes, as these often happen before parsing is completely done. I'd imagine this code was put into place at least the 1st time for good reason, but I'm curious as to why we wouldn't have tests tha

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7855 + return; +RowsExpr = Columns.get(); + } else { fhahn wrote: > RKSimon wrote: > > @fhahn Should this be ColsExpr? > > ``` > > ColsExpr = Columns.get(); > > ``` > > Noticed when lo

[PATCH] D93587: [hip] Fix HIP version parsing.

hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93587/new/ https://reviews.llvm.org/D93587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

clementval accepted this revision. clementval added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 _

  1   2   3   >