[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge planned changes to this revision. nridge added a comment. That all sounds reasonable -- thanks for the suggestions! I've been meaning to factor out the heuristic resolution stuff into its own file anyways, this patch is as good a time as any to do it. Repository: rG LLVM Github Monore

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

qchateau added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1843 +auto Kind = Callee.SymInfo.Kind; +if (Kind != SK::Function && Kind != SK::InstanceMethod && +Kind != SK::ClassMethod && Kind != SK::StaticMethod && nridge wrote:

[clang] ee27c76 - [clang-format] Skip UTF8 Byte Order Mark while sorting includes

Author: Rafał Jelonek Date: 2021-01-11T09:32:55+01:00 New Revision: ee27c767bd2062c81f0affc0e8992f60a755f099 URL: https://github.com/llvm/llvm-project/commit/ee27c767bd2062c81f0affc0e8992f60a755f099 DIFF: https://github.com/llvm/llvm-project/commit/ee27c767bd2062c81f0affc0e8992f60a755f099.diff

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

This revision was automatically updated to reflect the committed changes. Closed by commit rGee27c767bd20: [clang-format] Skip UTF8 Byte Order Mark while sorting includes (authored by rjelonek, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 7473940 - [clang-format] turn on formatting after "clang-format on" while sorting includes

Author: Rafał Jelonek Date: 2021-01-11T09:41:15+01:00 New Revision: 7473940bae0f263832456d2c99a4bd606ed0d76e URL: https://github.com/llvm/llvm-project/commit/7473940bae0f263832456d2c99a4bd606ed0d76e DIFF: https://github.com/llvm/llvm-project/commit/7473940bae0f263832456d2c99a4bd606ed0d76e.diff

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

This revision was automatically updated to reflect the committed changes. Closed by commit rG7473940bae0f: [clang-format] turn on formatting after "clang-format on" while sorting includes (authored by rjelonek, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D94206?vs

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. find-references on `virtual void meth^od() = 0` will include ov

[clang] 89878e8 - [clang-format] Find main include after block ended with #pragma hdrstop

Author: Rafał Jelonek Date: 2021-01-11T09:49:34+01:00 New Revision: 89878e8c966a82ed6b7f0254700017f0a97fb7d7 URL: https://github.com/llvm/llvm-project/commit/89878e8c966a82ed6b7f0254700017f0a97fb7d7 DIFF: https://github.com/llvm/llvm-project/commit/89878e8c966a82ed6b7f0254700017f0a97fb7d7.diff

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

This revision was automatically updated to reflect the committed changes. Closed by commit rG89878e8c966a: [clang-format] Find main include after block ended with #pragma hdrstop (authored by rjelonek, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D94217?vs=315509&id

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay created this revision. MaskRay added reviewers: debug-info, aprantl, dblaikie, rjmccall. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getLineNumber() picks CurLoc if the parameter is invalid. This appears to mainly work a

[PATCH] D94393: [clangd] Add metrics for go-to-implementation.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[clang] 9710064 - Reapply "[clang][cli] Port DiagnosticOpts to new option parsing system"

Author: Jan Svoboda Date: 2021-01-11T10:05:53+01:00 New Revision: 97100646d1b4526de1eac3aacdb0b098739c6ec9 URL: https://github.com/llvm/llvm-project/commit/97100646d1b4526de1eac3aacdb0b098739c6ec9 DIFF: https://github.com/llvm/llvm-project/commit/97100646d1b4526de1eac3aacdb0b098739c6ec9.diff L

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. friendly ping, any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D94393: [clangd] Add metrics for go-to-implementation.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94393/new/ https://reviews.llvm.org/D94393

[clang-tools-extra] 1677c86 - [clangd] Add metrics for go-to-implementation.

Author: Haojian Wu Date: 2021-01-11T10:26:50+01:00 New Revision: 1677c86124e5b82a8dbf991f2d5fc450d06db4ad URL: https://github.com/llvm/llvm-project/commit/1677c86124e5b82a8dbf991f2d5fc450d06db4ad DIFF: https://github.com/llvm/llvm-project/commit/1677c86124e5b82a8dbf991f2d5fc450d06db4ad.diff LO

[PATCH] D94393: [clangd] Add metrics for go-to-implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1677c86124e5: [clangd] Add metrics for go-to-implementation. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94396: Fix macos target assumption in test

thopre created this revision. thopre added a reviewer: arphaman. thopre requested review of this revision. Herald added a project: clang. Clang test Driver/macos-apple-silicon-slice-link-libs-darwin-only.cpp assumes the target is darwin when the host is darwin which is not necessarily the case, ca

[PATCH] D94359: [clangd] Remove ScratchFS from tests

njames93 updated this revision to Diff 315735. njames93 added a comment. Remove extra semi-colon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94359/new/ https://reviews.llvm.org/D94359 Files: clang-tools-extra/clangd/unittests/GlobalCompilatio

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

sammccall added a comment. Doh, I really thought we'd get away without an explicit recursion guard here. But the example is compelling, so this seems like the right approach. Unfortunately, I think we're going to end up needing to add allocations too... Comment at: clang-tools

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:660 + /// Location of the left and right angle brackets. + alignas(ObjCTypeParamDecl *) SourceRange Brackets; /// The number of parameters in the list, which are tail-allocated. apr

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/driver-help.f90:22 ! HELP-NEXT: -### Print (but do not run) the commands to run for this compilation +! HELP-NEXT: -D = Define to (or 1 if omitted) ! HELP-NEXT: -E

[clang] 8ea72b3 - [clang][AArch64][SVE] Avoid going through memory for coerced VLST return values

Author: Joe Ellis Date: 2021-01-11T12:10:59Z New Revision: 8ea72b388734ce660f861e0dfbe53d203e94876a URL: https://github.com/llvm/llvm-project/commit/8ea72b388734ce660f861e0dfbe53d203e94876a DIFF: https://github.com/llvm/llvm-project/commit/8ea72b388734ce660f861e0dfbe53d203e94876a.diff LOG: [cl

[PATCH] D94290: [clang][AArch64][SVE] Avoid going through memory for coerced VLST return values

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea72b388734: [clang][AArch64][SVE] Avoid going through memory for coerced VLST return values (authored by joechrisellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, lebedev.ri,

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

JDevlieghere added a comment. LGTM for LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre added a reviewer: ldionne. tambre added a comment. ldionne: for libc++ review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki updated this revision to Diff 315759. miyuki added a comment. Fixed a typo in the word "implicit" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files: clang/include/clang/AST/DependentDiagnostic.

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook created this revision. simoncook added reviewers: asb, luismarques, kito-cheng. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzhen

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski updated this revision to Diff 315765. awarzynski added a comment. Implement SUGGESTION 1 I haven't updated the patch description yet - I'd rather keep it as is while the actual direction for this patch is being discussed. Also, I regenerated ClangCommandLineReference.rst and discover

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

t.p.northover added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:460 + /// Test whether this toolchain supports outline atomics by default. + virtual bool IsOADefault(const llvm::opt::ArgList &Args) const { +return false; This is a pr

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2486574 , @aaron.ballman wrote: > I'm going to see if I can run the patch against our internal corpus here at > work to see if it shakes out any breakages to real world code. I've not tried > this before, so I ha

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some very minor nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784 + " converts between pointers to integer types %select{

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 315788. DavidTruby marked an inline comment as done. DavidTruby added a comment. Fix tests to use check-label correctly and add proper precondition on aarch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D927

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1994 + return None; +return FD->getNumParams() > 0 ? UO_PostInc : UO_PreInc; + } Not certain how much we want to care about it, but I think we need to

[clang] c163aae - [attributes] Add a facility for enforcing a Trusted Computing Base.

Author: Artem Dergachev Date: 2021-01-11T06:39:42-08:00 New Revision: c163aae45ef6b7f3bd99601195d3ce4aad5850c6 URL: https://github.com/llvm/llvm-project/commit/c163aae45ef6b7f3bd99601195d3ce4aad5850c6 DIFF: https://github.com/llvm/llvm-project/commit/c163aae45ef6b7f3bd99601195d3ce4aad5850c6.dif

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc163aae45ef6: [attributes] Add a facility for enforcing a Trusted Computing Base. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2000 + CXXRewrittenBinaryOperator> +cxxRewrittenBinaryOperator; + Missing changes to Registry.cpp to expose this t

[PATCH] D94411: [clangd] Fix -check mode doesn't respect any tidy configs.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D90976: [NFC] Fixed an issue where diagnostics printed expressions in a roundabout way

hans added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:485 case TemplateArgument::Expression: { -// This shouldn't actually ever happen, so it's okay that we're -// regurgitating an expression here. This code looks like a very special c

[clang] 419ef38 - Revert "[attributes] Add a facility for enforcing a Trusted Computing Base."

Author: Nico Weber Date: 2021-01-11T09:51:06-05:00 New Revision: 419ef38a50293c58078f830517f5e305068dbee6 URL: https://github.com/llvm/llvm-project/commit/419ef38a50293c58078f830517f5e305068dbee6 DIFF: https://github.com/llvm/llvm-project/commit/419ef38a50293c58078f830517f5e305068dbee6.diff LO

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

thakis added a comment. Hi, this broke check-clang everywhere as far as I can tell. Please run tests before committing. I've reverted this for now in 419ef38a50293c58078f830517f5e305068dbee6 . For some host compilers, it also

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2739 +/// Matches nodes which can be used with binary operators +/// Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2785 +internal::Bin

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94127/new/ https://reviews.llvm.org/D94127 __

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D94131#2481804 , @njames93 wrote: > Theres a few compile errors here in the pre merge. Is this patch based > against trunk or some loc

[PATCH] D94411: [clangd] Fix -check mode doesn't respect any tidy configs.

hokein added a comment. no test added -- it is not easy, since we don't emit tidy warnings in check mode (maybe we should?), I confirmed that it worked (with manual test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94411/new/ https://reviews.ll

Re: [clang] 419ef38 - Revert "[attributes] Add a facility for enforcing a Trusted Computing Base."

Uh-oh, missed the test. Thanks! The compile error looks like a gcc bug; i'll add a workaround. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67274; fixed in gcc 7.1 but this buildbot uses gcc 6.3) On 1/11/21 6:51 AM, Nico Weber via cfe-commits wrote: Author: Nico Weber Date: 2021-01-11T09:51

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ added a comment. Yup, i'm sorry. I even saw this failure locally but was like "this test doesn't look familiar, probably someone else broke it" which i wouldn't have said if i looked at it for more than 1 second as it's strikingly obvious. My bad. Repository: rG LLVM Github Monorepo CHA

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 315805. simoncook added a comment. Correct constant used in macros, 2.0 should be 200 not 2000 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 Files: clang/

[clang-tools-extra] a2dbf34 - [clangd] Fix -check mode doesn't respect any tidy configs.

Author: Haojian Wu Date: 2021-01-11T16:43:33+01:00 New Revision: a2dbf3443af79426c80e8a808821236c5a2b305e URL: https://github.com/llvm/llvm-project/commit/a2dbf3443af79426c80e8a808821236c5a2b305e DIFF: https://github.com/llvm/llvm-project/commit/a2dbf3443af79426c80e8a808821236c5a2b305e.diff LO

[PATCH] D94411: [clangd] Fix -check mode doesn't respect any tidy configs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2dbf3443af7: [clangd] Fix -check mode doesn't respect any tidy configs. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94411/new/ http

[PATCH] D93873: [clangd] Cache preambles of closed files

sammccall added a reviewer: kadircet. sammccall added a comment. Thanks! This is a really good idea, but not without its risks :-) Sorry for not getting to this for a while! My only *really* high-level design question is: I wonder what the tradeoffs are in keeping just the preamble vs the whole

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

aaron.ballman added subscribers: NoQ, Szelethus. aaron.ballman added a comment. In D93822#2474475 , @dblaikie wrote: > In D93822#2474355 , @lebedev.ri > wrote: > >> I'm open to input here, but it would be good to h

[clang-tools-extra] 31732e6 - [clangd] Remove ScratchFS from tests

Author: Nathan James Date: 2021-01-11T16:14:26Z New Revision: 31732e6f52c8e5e722d3e4cca053db793dae3b8c URL: https://github.com/llvm/llvm-project/commit/31732e6f52c8e5e722d3e4cca053db793dae3b8c DIFF: https://github.com/llvm/llvm-project/commit/31732e6f52c8e5e722d3e4cca053db793dae3b8c.diff LOG:

[PATCH] D94359: [clangd] Remove ScratchFS from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG31732e6f52c8: [clangd] Remove ScratchFS from tests (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94359/new/ https://reviews.llvm.org

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Except for the google-benchmark nit, LGTM. Thanks a lot for the cleanup! Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - -

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Many useful signals can be derived from a valid AST which is regula

[clang] c15b0e2 - [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

Author: Scott Linder Date: 2021-01-11T17:23:24Z New Revision: c15b0e2229ea04d1c36fafaa1f717f433a995e9a URL: https://github.com/llvm/llvm-project/commit/c15b0e2229ea04d1c36fafaa1f717f433a995e9a DIFF: https://github.com/llvm/llvm-project/commit/c15b0e2229ea04d1c36fafaa1f717f433a995e9a.diff LOG:

[PATCH] D94338: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGc15b0e2229ea: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94338/new/

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 315839. usaxena95 added a comment. Documentation change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-too

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 315840. aorlov added a comment. @Quuxplusone Thank you for your comments. I updated the patch according to your suggestions. Does anyone else from the review list want to waste some time to look at this patch? I would appreciate this. Repository: rG LLVM

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added inline comments. Comment at: clang/test/CXX/class.access/class.friend/p1.cpp:290 A::I f2(A::I i = A::x) {} // expected-error 3 {{is a private member of}} - template A::I g2(A::I i) { // expected-error 2 {{is a private member of}} + template A::I g2(A::I i) { /

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre updated this revision to Diff 315847. tambre added a comment. Don't modify third-party checked-in libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 Files: clang/CMakeLists.txt compiler-r

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added inline comments. Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - ldionne wrote: > I don't think we want to change this. It's a third-party project (which is > inconvenientl

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau added a comment. Hey, don't worry about the delay, I won't have as much time on my hands anymore anyway. - we can definitely make this opt-in - MB instead of # is an idea, it's probably closer to what the user want to configure - if he does - but it would also probably give a worse def

[clang] 35c9baa - [attributes] Add a facility for enforcing a Trusted Computing Base.

Author: Sean Dooher Date: 2021-01-11T10:20:51-08:00 New Revision: 35c9baa11e4be6ae570674eec2de8bd928639b18 URL: https://github.com/llvm/llvm-project/commit/35c9baa11e4be6ae570674eec2de8bd928639b18 DIFF: https://github.com/llvm/llvm-project/commit/35c9baa11e4be6ae570674eec2de8bd928639b18.diff L

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

compnerd added a comment. Can you please add some more context around the motivation for this change? It seems ... unnecessary as everything is already AAPCS/AAPCS-VFP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94364/new/ https://reviews.llvm

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 315855. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. Rebased on latest master; Addressed the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include

[PATCH] D93703: [libTooling] Change `addInclude` to use expansion locs.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93703/new/ https://reviews.llvm.org/D93703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D94337: Add cuda header type for cuh files

tra added a comment. > This adds a cuda header type with file extension "cuh". The output type file > extension is "cuhi" - not sure if this is a good choice. This allows > language servers to properly handle cuh files without additional arguments. CUDA compilation is ... odd. While I don't have

[clang] d8c6d24 - -funique-internal-linkage-names appends a hex md5hash suffix to the symbol name which is not demangler friendly, convert it to decimal.

Author: Sriraman Tallam Date: 2021-01-11T11:10:29-08:00 New Revision: d8c6d24359f17c55a8966231ef74e8f4b03ad282 URL: https://github.com/llvm/llvm-project/commit/d8c6d24359f17c55a8966231ef74e8f4b03ad282 DIFF: https://github.com/llvm/llvm-project/commit/d8c6d24359f17c55a8966231ef74e8f4b03ad282.dif

[PATCH] D94154: Unique Internal Linkage Name suffixes must be demangler friendly

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8c6d24359f1: -funique-internal-linkage-names appends a hex md5hash suffix to the symbol name… (authored by tmsriram). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

mstorsjo added a comment. In D94364#2490743 , @compnerd wrote: > Can you please add some more context around the motivation for this change? > It seems ... unnecessary as everything is already AAPCS/AAPCS-VFP. Yeah it's a redundant attribute, but I don'

[PATCH] D94438: Fis for Assertion failure on dependent expression.

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: jstenglein, erichkeane. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check for the value passed to __buildtin_return_address needs to be guard

[PATCH] D94438: Fis for Assertion failure on dependent expression.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Fix looks fine, I'm on the fence about how to handle the test, whether it is valuable to convert it to a C++ test and omit the #ifdef/extra run line, or leave it as it is (without the

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1324 + +llvm::DenseSet OverrideSymbols; +if (Index) { nit: s/OverrideSymbols/Overrid

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 315886. ahatanak added a comment. Rebase and fix a few bugs in the patch. - In the loop in `DeadArgumentEliminationPass::SurveyFunction` that visits the uses of a function, continue instead of break so that the function is marked live when a function is us

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

njames93 added a comment. Should we be providing virtual method overrides when querying definitions, surely that's what query implementations is for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94390/new/ https://reviews.llvm.org/D94390 ___

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks Comment at: llvm/test/CodeGen/AArch64/arm64-windows-calls.ll:117 + ret %struct.Pod %x1 +; CHECK: ldp d0, d1, [x0] +} peterwaller-arm wrote: > rnk wro

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 315908. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h llvm/lib/Transforms/Utils/UniqueI

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsandifo-arm added a comment. In D77056#2487754 , @rsmith wrote: > In D77056#2465936 , @rsandifo-arm > wrote: > >> Either way, I realise this isn't great style. It just seems like a >> practical compromise betwee

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

peterwaller-arm accepted this revision. peterwaller-arm added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-windows-calls.ll:117 + ret %struct.Pod %x1 +; CHECK: ldp d0, d1, [x0] +} rnk wrote: > peterwaller-arm wrote: > > rnk wrote: > > > Please us

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. Any particular bug you're trying to fix? (this looks like it changes the debug locations, so it would need tests) Not necessarily clear that these are better debug locations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D93769: RFC [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. @rjmccall Hoping you can take a look at this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 ___ cfe-commits mailing list cfe-commi

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2491178 , @dblaikie wrote: > Any particular bug you're trying to fix? (this looks like it changes the > debug locations, so it would need tests) > > Not necessarily clear that these are better debug locations? No partic

[clang] 9b222b1 - [c++20] Don't consider string literal operator templates for numeric

Author: Richard Smith Date: 2021-01-11T13:19:00-08:00 New Revision: 9b222b108a2e37eb45d3156ec8554d148d658a8a URL: https://github.com/llvm/llvm-project/commit/9b222b108a2e37eb45d3156ec8554d148d658a8a DIFF: https://github.com/llvm/llvm-project/commit/9b222b108a2e37eb45d3156ec8554d148d658a8a.diff

[clang] f4cec70 - Add an assert to CGDebugInfo::getTypeOrNull

Author: Fangrui Song Date: 2021-01-11T13:25:20-08:00 New Revision: f4cec703ec8452f9d8b04fae171ba459adf38123 URL: https://github.com/llvm/llvm-project/commit/f4cec703ec8452f9d8b04fae171ba459adf38123 DIFF: https://github.com/llvm/llvm-project/commit/f4cec703ec8452f9d8b04fae171ba459adf38123.diff

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt added a comment. In D94337#2490828 , @tra wrote: > The problem is that just telling compiler that the header is a CUDA source is > not sufficient. Clang relies on a lot of CUDA SDK headers in order to make > the standard CUDA things like `__h

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That's even better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224

[clang] b88c8f1 - CGDebugInfo: Delete unused parameters

Author: Fangrui Song Date: 2021-01-11T13:39:03-08:00 New Revision: b88c8f1aab527f1aebe612ab6c50a418bff88584 URL: https://github.com/llvm/llvm-project/commit/b88c8f1aab527f1aebe612ab6c50a418bff88584 DIFF: https://github.com/llvm/llvm-project/commit/b88c8f1aab527f1aebe612ab6c50a418bff88584.diff

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

This revision was automatically updated to reflect the committed changes. Closed by commit rG32bcfcda4e28: Rename debug linkage name with -funique-internal-linkage-names (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ htt

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. Ping 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D94453: [libTooling] Add function to Transformer for creating a diagnostic-only rule.

ymandel created this revision. ymandel added a reviewer: tdl-g. ymandel requested review of this revision. Herald added a project: clang. Adds a convenience function for creating a rule that only generates a diagnostic, without any correpsonding edits. Repository: rG LLVM Github Monorepo http

[clang] 0a23fbd - clang: Always pass PowerPC endian information to GNU as

Author: Nathan Chancellor Date: 2021-01-11T14:50:28-08:00 New Revision: 0a23fbd28c7509f2f980946091e6055bf27164d2 URL: https://github.com/llvm/llvm-project/commit/0a23fbd28c7509f2f980946091e6055bf27164d2 DIFF: https://github.com/llvm/llvm-project/commit/0a23fbd28c7509f2f980946091e6055bf27164d2.d

[PATCH] D94442: clang: Always pass PowerPC endian information to GNU as

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a23fbd28c75: clang: Always pass PowerPC endian information to GNU as (authored by nathanchance, committed by nickdesaulniers). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repos

[PATCH] D94337: Add cuda header type for cuh files

tra added a comment. In D94337#2491269 , @rgreenblatt wrote: > My primary goal for this change was to allow for language servers and other > tooling to properly handle cuda header files. From my understanding the way > that language servers handle c++ he

[PATCH] D50739: Clean up macros to detect underling C library functionality

ldionne commandeered this revision. ldionne edited reviewers, added: mclow.lists; removed: ldionne. ldionne added a comment. This revision now requires review to proceed. Herald added a subscriber: jkorous. Commandeering to close as I don't think this applies anymore. Repository: rG LLVM Githu

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai added a comment. Sorry, I seem to have somehow blanked out on this diff entirely. Is it still relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https://reviews.llvm.org/D35388 _

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

leonardchan updated this revision to Diff 315951. leonardchan retitled this revision from "[clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI" to "[clang] Override the Fuchsia platform ABI using the triple environment". leonardchan edited the summary of this revision. Repos

[clang] f635bcd - NFC: Pre-commit test: -Wpointer-sign with plain char to [un]signed char

Author: Hubert Tong Date: 2021-01-11T18:41:14-05:00 New Revision: f635bcd16105a0a01eefa2c69a71cd103dedaddd URL: https://github.com/llvm/llvm-project/commit/f635bcd16105a0a01eefa2c69a71cd103dedaddd DIFF: https://github.com/llvm/llvm-project/commit/f635bcd16105a0a01eefa2c69a71cd103dedaddd.diff L

  1   2   >