[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge updated this revision to Diff 317272. nridge added a comment. Herald added a subscriber: mgorny. Change approach to factor out a HeuristicResolver class I didn't make it an optional parameter to allTargetDecls() etc. If you feel there are call sites which would benefit from //not// passin

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

mkazantsev added a comment. This is awesome. And scary. This is scarily awesome. :) Comment at: llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp:263 const SimplifyCFGOptions &Options) { - assert((!RequireAndPreserveDomTree || - (DT && DT

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske updated this revision to Diff 317278. balazske added a comment. Improved test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImport

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:655 + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(cxxFoldExpr(; +} shafik wro

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks updated this revision to Diff 317292. HazardyKnusperkeks added a comment. Fix documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 Files: clang/docs/ClangFormatStyleOptions.rs

[clang] b43075e - [clang-format] Fix documentation of bcc1dee600

Author: Björn Schäpers Date: 2021-01-18T11:03:13+01:00 New Revision: b43075e34a598460fe1590d950862a26449e8d10 URL: https://github.com/llvm/llvm-project/commit/b43075e34a598460fe1590d950862a26449e8d10 DIFF: https://github.com/llvm/llvm-project/commit/b43075e34a598460fe1590d950862a26449e8d10.diff

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks updated this revision to Diff 317294. HazardyKnusperkeks added a comment. - Rebased - Fixed(?) the last UnitTest, please take a look @krasimir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D922

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 317295. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. - Rebased - Renamed to `InhteritParentConfig` - Reworked to remove the recursion of `getStyle` -

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 317299. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you @FarisRehman , LGTM! I believe that you addressed all PR comments. As requested, there are tests for: - `#include` - `INCLUDE` - `USE` Your tests also demonstrate that the o

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson updated this revision to Diff 317306. tmatheson added a comment. Added more test cases and explanatory comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93101/new/ https://reviews.llvm.org/D93101 Files: clang/lib/AST/ExprConstant.

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Comment at: clang/lib/AST/DeclBase.cpp:986 + isa(this) || + isa(this)) return true; nit: personally I'd keep the old format style, jus

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

MyDeveloperDay added a comment. What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style. Comment at: clang/include/clang/Format/Format.h:57 + // the parent directories. It is not part of the actual style for formatt

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 updated this revision to Diff 317307. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 Files: clang-tool

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson updated this revision to Diff 317309. tmatheson added a comment. Add test RUN line that checks C++11 behaviour Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93101/new/ https://reviews.llvm.org/D93101 Files: clang/lib/AST/ExprConstant.c

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks added a comment. In D93844#2504376 , @MyDeveloperDay wrote: > What I can't easily tell from the tests is if you are overriding any styles > defined in the parent with a local style. Yes I do, but I will try to make it clearer in the t

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous marked 3 inline comments as done. nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

SjoerdMeijer added a comment. I am trying to remember details here, but first about this: > vectorize_width(1) is also used, since that effectively disables > vectorization. I am not sure this is true (i.e. effectively disabling auto-vec) since in LangRef we specify: > The vector width is spe

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

fhahn added a comment. > This ensures that the Clang loop pragma vectorize_predicate([enable|disable]) > is ignored > when vectorize_width(1) is also used, since that effectively disables > vectorization. Could you elaborate *why* it `vectorize_predicate` should be ignored when `vectorize_widt

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added a comment. I had a look at the Clang Language Extension ... and I saw this: > Specifying a width/count of 1 disables the optimization, and is equivalent to > vectorize(disable) or interle

[clang] 689aaba - [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

Author: Abhina Sreeskantharajan Date: 2021-01-18T07:14:37-05:00 New Revision: 689aaba7acf5778bfe96bfd7bc4f1f3ceed20dc8 URL: https://github.com/llvm/llvm-project/commit/689aaba7acf5778bfe96bfd7bc4f1f3ceed20dc8 DIFF: https://github.com/llvm/llvm-project/commit/689aaba7acf5778bfe96bfd7bc4f1f3ceed2

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG689aaba7acf5: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit… (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to https:

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInfo(

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. I have re-analysed Bitcoin and Xerces with the new version (not yet published to Phab), and the results are looking really good! There is an insignificant change in the number of reports, 1 or 2 new ones compared to the previous, all explained by the fact that "unnam

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein added a comment. In D94785#2503939 , @nridge wrote: > In D94785#2501806 , @usaxena95 wrote: > >> Although now that I enabled this in all SymbolCollectorTests, this causes a >> regression in RefContainers. >>

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:17 // If the extensions are to be enumerated without the supported OpenCL version, -// define OPENCLEXT(ext) where ext is the name of the extension. +// define OPENCLEXTNAME(ext) where ex

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

SjoerdMeijer added a comment. In D94779#2504519 , @malharJ wrote: > I had a look at the Clang Language Extension > > ... and I saw this: > >> Specifying a width/

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:62 - /// Check if \c Ext is supported as an (optional) OpenCL core features for - /// the given OpenCL version. - /// - /// \param Ext - Extension to look up. - /// \param LO - \c LangOp

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein abandoned this revision. hokein added a comment. Herald added a subscriber: dexonsmith. Thanks for @rsmith's initial comments. This is done, all related patches have been landed in upstream, and this feature is enabled by default for all languages. Repository: rG LLVM Github Monorepo

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317339. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Left a todo to fix the bug in RefContainers later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ h

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added a comment. > what is the problem with the current behaviour (i.e. not ignoring/handling > it)? The current behaviour is //ignoring/not handling// the vectorize_predication pragma whenever vectorization width is non-zero. Could you kindly see the original condition I stated in my p

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson updated this revision to Diff 317340. tmatheson added a comment. Make unions in test cases const, and clarify logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93101/new/ https://reviews.llvm.org/D93101 Files: clang/lib/AST/ExprConst

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

dmgreen added a comment. I believe this sentence is the important part (the width=1 is just an edge case): > For all other non-zero vectorization widths, the pragma is not ignored unless > vectorization is explicitly disabled using vectorize(disable) And this sounds like a sensible fix to me.

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson marked 3 inline comments as done. tmatheson added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9801-9804 +return EvaluateInPlace(Result.getUnionValue(), Info, Subobject, InitExpr) || + (Field->isBitField() && +truncateBitfieldVa

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov updated this revision to Diff 317342. ASDenysPetrov added a comment. Unfortunately I wasn't able to reproduce the singe difference in PostgreSQL project. So I revised the patch in a part of the difference nature. This update passed all of CodeChecker's tests without any difference.

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ updated this revision to Diff 317345. malharJ added a comment. added tests for loop predication enabled case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94779/new/ https://reviews.llvm.org/D94779 Files: clang/lib/CodeGen/CGLoopInfo.cp

[PATCH] D89699: [ExtVector] Make .even/.odd/.lo/.hi return vectors for single elements.

fhahn abandoned this revision. fhahn added a comment. This unfortunately breaks a bunch of existing projects. I'll abandon the change for now, as the gains are probably not worth the cost of breaking backwards compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames; ---

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

steakhal added a comment. Please @ASDenysPetrov, give full context with the option `-U` when you export the diff from git. I would like to quickly swipe through the code before I accept this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90157/new/ https://reviews.llvm.org/D901

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2490034 , @aaron.ballman wrote: > In D93630#2486574 , @aaron.ballman > wrote: > >> I'm going to see if I can run the patch against our internal corpus here at >> work to see

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning {{u

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov updated this revision to Diff 317351. ASDenysPetrov added a comment. @steakhal Oh, sure. Updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90157/new/ https://reviews.llvm.org/D90157 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

HazardyKnusperkeks updated this revision to Diff 317358. HazardyKnusperkeks added a comment. Formatting corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94906/new/ https://reviews.llvm.org/D94906 Files: clang/lib/Format/Format.cpp clan

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 317355. Conanap marked 2 inline comments as done. Conanap added a comment. Loads Hi before Lo now; removed implicit cast. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCI

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

sammccall updated this revision to Diff 317365. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94606/new/ https://reviews.llvm.org/D94606 Files: clang-tools-e

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496 + std::condition_variable CV; + std::atomic ShouldStop = {false}; // Must notify CV after writing. + std::deque Queue; kadircet wrote: > nit: we already hol

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

adamcz added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:986 + isa(this) || + isa(this)) return true; hokein wrote: > nit: personally I'd keep the old format style, just appending the new case. I like the old formatting a little better

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; Anastasia wrote: > a

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Just a ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D91944: OpenMP 5.0 metadirective

protze.joachim added a comment. I found two issues with this patch regarding the `default` clause: - The spec does not require a default clause. I get `error: expected expression` if I omit a default clause. The error is gone if I add `default()`. - The spec does not allow an empty `default()` c

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; azabaznov wrote: > A

[clang-tools-extra] 275716d - [clangd] Derive new signals in CC from ASTSignals.

Author: Utkarsh Saxena Date: 2021-01-18T17:37:27+01:00 New Revision: 275716d6db79a6da3d5cee12139dd0c0abf8fd07 URL: https://github.com/llvm/llvm-project/commit/275716d6db79a6da3d5cee12139dd0c0abf8fd07 DIFF: https://github.com/llvm/llvm-project/commit/275716d6db79a6da3d5cee12139dd0c0abf8fd07.diff

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG275716d6db79: [clangd] Derive new signals in CC from ASTSignals. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://r

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-commits mailing list cfe-commit

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This fix will make us not crash, but ideally we would handle this case bett

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

sammccall added a comment. Thanks a lot for doing this! I have some thoughts on how we can give it a nice API/more clearly separate it from FindTarget/improve internal structure. I'm not sure how we should sequence that/how much to do. One the one hand, simply moving this code is progress! On th

[clang] 291ac7e - [AArch64] Revert back to Intrinsic<> for TME instructions.

Author: Florian Hahn Date: 2021-01-18T18:03:58Z New Revision: 291ac7e622d542f8b25f74bc28051762edc90938 URL: https://github.com/llvm/llvm-project/commit/291ac7e622d542f8b25f74bc28051762edc90938 DIFF: https://github.com/llvm/llvm-project/commit/291ac7e622d542f8b25f74bc28051762edc90938.diff LOG:

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

MyDeveloperDay added a comment. I think this is LGTM, however.. I've always felt that we shouldn't require `BreakBeforeBraces` to be `Custom` in order to be able to use the BraceWrapping. Users in my view should be able to say: BreakBeforeBraces: Allman BraceWrapping: BeforeLambda

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

MyDeveloperDay added a comment. Similarly I see users having to define everything just to turn one thing off {F15089845, size=full} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94906/new/ https://reviews.llvm.org/D94906 ___

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook added a comment. In D94403#2504046 , @kito-cheng wrote: > Thanks you implement that on clang, I think it's really great to included > that in LLVM 12 release. > > I would like to define marco for sub-extension too, I know that's my fault, I > d

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks added a comment. In D93844#2504388 , @HazardyKnusperkeks wrote: > In D93844#2504376 , @MyDeveloperDay > wrote: > >> What I can't easily tell from the tests is if you are overriding any styles >

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. In D91944#2504924 , @protze.joachim wrote: > I found two issues with this patch regarding the `default` clause: > > - The spec does not require a default clause. I get `error: expected > expression` if I omit a default clause.

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. In D91944#2485167 , @jdoerfert wrote: > Are the test all passing? Can we fix the failing tests so we can merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ http

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. @vsavchenko > F14534708: report-6ea17d.html I checked it in IE. It doesn't draw arrows. Investigate this, please. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:147 +bool isArrowPiece(const Pat

[clang] 196cc96 - [clang] Allow LifetimeExtendedTemporary to have no access specifier

Author: Adam Czachorowski Date: 2021-01-18T19:19:57+01:00 New Revision: 196cc96f9a643d1cb828f48ef15ec30d0de24df7 URL: https://github.com/llvm/llvm-project/commit/196cc96f9a643d1cb828f48ef15ec30d0de24df7 DIFF: https://github.com/llvm/llvm-project/commit/196cc96f9a643d1cb828f48ef15ec30d0de24df7.d

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG196cc96f9a64: [clang] Allow LifetimeExtendedTemporary to have no access specifier (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94804/n

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added a comment. Thanks for the comments! I'll have a more detailed look later, but just wanted to ask one clarifying question for now: Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:90 +for (const auto &Entry : + allTargetDecls(N->ASTNod

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2505159 , @jdoerfert wrote: > In D91944#2485167 , @jdoerfert wrote: > >> Are the test all passing? > > Can we fix the failing tests so we can merge this? I will work on it

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping x 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

nikic added a comment. I'm somewhat skeptical about this change. The motivation seems a bit weak given the costs involved. The costs are: - Compile-time cost. Your best case estimate puts this at a 0.5% compile-time regression. This is for the case where SimplifyCFG simplify preserves DT, with

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94927 Files:

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

xbolva00 added a comment. >> Code complexity Was there any RFC or general agreement? After many patches for this goal the pass is now more complex and harder to read.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94827/new/ https://reviews.llvm

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:90 +for (const auto &Entry : + allTargetDecls(N->ASTNode, AST.getHeuristicResolver())) ActualDecls.emplace_back(Entry.first, Entry.second); nrid

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

HazardyKnusperkeks added a comment. I think that would have helped me also. I think it's not that easy, but honestly never checked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94906/new/ https://reviews.llvm.org/D94906 _

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

curdeius accepted this revision. curdeius added a comment. LGTM. As a note, I agree with @MyDeveloperDay. It's more user-friendly and IMO less surprising to set the base wrapping style in `BreakBeforeBraces` and then customize it changing in `BraceWrapping`. I'd argue that it won't be a breaking

[PATCH] D94930: [RISCV] Add support for Zvamo/Zvlsseg to driver

simoncook created this revision. simoncook added reviewers: asb, luismarques, kito-cheng. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc2

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 317409. simoncook added a comment. Rebase on D94930 to show updated version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 Files:

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

lebedev.ri added a comment. Wow. So much polarization here. In D94827#2502435 , @kuhar wrote: > Wow, this is fantastic. When I first started working on the domtree updater > back in 2017, SimplifyGFG seemed like one of the most difficult passes to > han

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, one nit in the test below. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone.

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

jdoerfert added a comment. Oh, and fix the test. If you have -verify and no errors you need `// expected-no-diagnostics` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94871/new/ https://reviews.llvm.org/D94871

[PATCH] D94933: [clang] Check for nullptr when instantiating late attrs

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet. adamcz requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This was already done in SemaTemplateInstantiateDecl.cpp, but

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added a comment. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInfo(Dev

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:52 + property(get = __fetch_builtin_##NAME##_##FIELD)) unsigned int FIELD; +#endif Why do we need these __fetch_builtins (for C). They have a different name than in

[PATCH] D94827: [SimplifyCFG] Require and preserve dominator tree

nikic added a comment. In D94827#2505431 , @lebedev.ri wrote: > Wow. So much polarization here. > > In D94827#2502435 , @kuhar wrote: > >> Wow, this is fantastic. When I first started working on the domtree updater

[PATCH] D94933: [clang] Check for nullptr when instantiating late attrs

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. this looks reasonable to me, thanks for tracking it down! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94933/new/ https://reviews.llvm.org/D949

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, Paren

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 updated this revision to Diff 317443. tianshilei1992 added a comment. Fixed the test case and rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94871/new/ https://reviews.llvm.org/D94871 Files: clang/lib/CodeGen/CGOpenMPRuntim

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 updated this revision to Diff 317444. tianshilei1992 added a comment. Removed the useless assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94871/new/ https://reviews.llvm.org/D94871 Files: clang/lib/CodeGen/CGOpenMPRuntime.

[clang] bc713f6 - PR48763: Better handling for classes that inherit a default constructor.

Author: Richard Smith Date: 2021-01-18T18:54:04-08:00 New Revision: bc713f6a004723d1325bc16e1efc32d0ac82f939 URL: https://github.com/llvm/llvm-project/commit/bc713f6a004723d1325bc16e1efc32d0ac82f939 DIFF: https://github.com/llvm/llvm-project/commit/bc713f6a004723d1325bc16e1efc32d0ac82f939.diff

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 updated this revision to Diff 317453. tianshilei1992 added a comment. Removed code for C that are still not supported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884 Files: clang/lib/Header

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:52 + property(get = __fetch_builtin_##NAME##_##FIELD)) unsigned int FIELD; +#endif jdoerfert wrote: > Why do we

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10111-10124 +// Check the static member's type given in the explicit instantiation +// definition against the one in the class template. This won't happen in +// explicit instantiation declarati

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar created this revision. tstellar added a reviewer: sylvestre.ledru. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. This patch is for the release/11.x branch. We need to bump the SONAME, because the ABI of the shared library is

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Add a tweak that will crea

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 317456. njames93 added a comment. Forgot to add the untracked files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/ https://reviews.llvm.org/D94942 Files: clang-tools-extra/clangd/refactor/tweaks/C

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInf

[PATCH] D94943: [X86][AMX] Fix the typo.

LuoYuanke created this revision. Herald added a subscriber: pengfei. LuoYuanke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dpbsud should be dpbssd. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94943 Files: c

[clang] e3065ce - DR2064: decltype(E) is only a dependent type if E is type-dependent, not

Author: Richard Smith Date: 2021-01-18T21:05:01-08:00 New Revision: e3065ce238475ec202c707f4c58d90df171626ca URL: https://github.com/llvm/llvm-project/commit/e3065ce238475ec202c707f4c58d90df171626ca DIFF: https://github.com/llvm/llvm-project/commit/e3065ce238475ec202c707f4c58d90df171626ca.diff

[clang] fbb83f1 - PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence of

Author: Richard Smith Date: 2021-01-18T21:05:01-08:00 New Revision: fbb83f18b5485218ad3c36c1d079c89f061372b8 URL: https://github.com/llvm/llvm-project/commit/fbb83f18b5485218ad3c36c1d079c89f061372b8 DIFF: https://github.com/llvm/llvm-project/commit/fbb83f18b5485218ad3c36c1d079c89f061372b8.diff

  1   2   >