[PATCH] D95346: [clang][cli] Port LangOpts to marshalling system, pt.1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d87e6a92a9: [clang][cli] Port LangOpts to marshalling system, pt.1 (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputManager in CompilerInstance

dexonsmith added a comment. RFC is up at https://lists.llvm.org/pipermail/cfe-dev/2021-January/067576.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95502/new/ https://reviews.llvm.org/D95502 ___ cfe

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added a comment. In D78058#2481050 , @dexonsmith wrote: > In D78058#2480411 , @dexonsmith > wrote: > >> In D78058#2471735 , @sammccall >> wrote: >> >>> @dexonsmi

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputManager in CompilerInstance

dexonsmith created this revision. dexonsmith added reviewers: sammccall, erik.pilkington, marcrasi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. [This is supporting an RFC I'll post in a bit; marked WIP for now] Adopt the new ll

[PATCH] D95499: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX

mtrofin created this revision. mtrofin added a reviewer: rnk. mtrofin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The only test that needed change had 'QUAL' as an unused prefix. The rest of the changes are to simplify the prefix lists.

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

dexonsmith created this revision. dexonsmith added a reviewer: erik.pilkington. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Call `FixupRelativePath` when opening output files to ensure that `-working-directory` is used when chec

[PATCH] D95496: [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonicial loop.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, AMDChirag, anchu-rajendran, kiranchandramohan, SouraVX, ftynse, kiranktp, fghanim, ABataev, craig.topper, dblaikie, rsmith, aaron.ballman. Herald added subscribers: dexonsmith, martong, guansong, hiraditya, yaxunl. Herald ad

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rnk added a comment. We need a solution to our problem in the short term, though: there must be a code pattern that can be used in -std=c++14 modes to accomplish what the `, ## __VA_ARGS__` code pattern accomplishes with GCC extensions. As of right now, my understanding is that `__VA_OPT__` is

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGStmt.cpp:2491 +std::string::size_type position1 = +Constraints.find("={" + Clobber.str() + "}"); +if (posi

[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9eb1982980: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=319359&id=319444#toc Repository: rG LLVM Git

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

JonChesterfield abandoned this revision. JonChesterfield added a comment. Abandoned in favour of multiple instantiations of the devicertl, which works across all languages and doesn't require hacks to clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D95492: Pack relocations for Android when possible.

danalbert created this revision. danalbert added reviewers: rprichard, srhines, rahulchaudhry. danalbert added a project: clang. danalbert requested review of this revision. First supported by API 28. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95492 Files: clang/lib/Driv

[PATCH] D94881: WIP: Add a way to define matcher builders in the dynamic registry

steveire abandoned this revision. steveire added a comment. The split here is artificial. This can't be tested without the changes adding mapAnyOf support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94881/new/ https://reviews.llvm.org/D94881 _

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire updated this revision to Diff 319431. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D95166: Disable rosegment for old Android versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae16fc0eed7: Disable rosegment for old Android versions. (authored by danalbert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/ https://reviews.

[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad7aaa475e5e: Frontend: Fix layering between create{,Default}OutputFile, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D93922: Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

jyknight added a comment. OK, I've posted two follow-up changes now. https://reviews.llvm.org/D95487 fixes the issue with mangleTemplateArg given expressions -- this turned out to be a larged-scoped problem than I had thought, affecting manglings other than just that used the matrix extension.

[PATCH] D95488: Itanium Mangling: In 'enable_if', omit X/E around .

jyknight created this revision. jyknight added reviewers: rsmith, rjmccall. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang enable_if extension is mangled as an , which is supposed to contain . However, we were unconditio

[PATCH] D95487: Itanium Mangling: Fix handling of in .

jyknight created this revision. Herald added a subscriber: kristof.beyls. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, we were emitting an extraneous X .. E in around an if the template argument was constructed fro

[PATCH] D93922: Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

jyknight updated this revision to Diff 319422. jyknight retitled this revision from "Mangle `__alignof__` differently than `alignof`." to "Itanium Mangling: Mangle `__alignof__` differently than `alignof`.". jyknight added a comment. Minor updates. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f721476d10c: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC (authored by dexonsmith). Repository: rG LLVM Github Mon

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8afabff6b11c: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream (authored by dexonsmith). Repository: rG LLVM Github Monorepo

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seem reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/ https://reviews.llvm.org/D94596 ___

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > steveire wrote: > > > > aaron.ball

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + rnk wrote: > akhuang wrote: > > rnk wrote: > > > I think I would prefer to have this return a number. I think

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

rnk added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + akhuang wrote: > rnk wrote: > > I think I would prefer to have this return a number. I think CGDebugInfo > > sho

[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93260/new/ https://reviews.llvm.org/D93260 ___

[PATCH] D95459: Add helper functionality for parsing different attribute syntaxes in arbitrary order

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me! (welcome to wait for more eyes, if you like) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95459/new/ https://reviews.llvm.org/D95459 __

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93249/new/ https://reviews.llvm.org/D93249 ___

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + MaskRay wrote: > This can be added below `-fprofile-exclude-files=` I considered it but that's in the GCOV section and this flag only applies to the LLVM i

[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93248/new/ https://reviews.llvm.org/D93248 __

[PATCH] D95479: [clang-format] Avoid considering include directive as a template closer.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95479/new/ https://reviews.llvm.org/D95479 ___ cfe-commits mailing list cfe-commi

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

mibintc created this revision. mibintc added reviewers: erichkeane, rnk. mibintc requested review of this revision. Herald added a project: clang. Fix https://bugs.llvm.org/show_bug.cgi?id=48848 by removing assertion Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95482 Files:

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: llvm/lib/IR/Instruction.cpp:580 +if (auto *CB = dyn_cast(this)) + return objcarc::hasRetainRVOrClaimRVAttr(CB); +return false; fhahn wrote: > ahatanak wrote: > > fhahn wrote: > > > rjmccall wrote: > > > > n

[PATCH] D95479: [clang-format] Avoid considering include directive as a template closer.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Confirmed on our end this fixes our issue. Thanks for addressing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95479/new/

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov updated this revision to Diff 319400. mizvekov added a comment. added tests adds test that will catch original bug also adds some tests on default equality/relational operators this last one would have caught the issue of not accepting equality operator for function pointers, had I not

[PATCH] D95479: [clang-format] Avoid considering include directive as a template closer.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, leonardchan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug introduced in D93839 where: #include na

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

leonardchan added a comment. In D93839#2523703 , @curdeius wrote: > That's definitely an unintended behaviour. Please file a bug and possibly > mark it as release blocker for LLVM 12. Either a fix will be there soon, or > we'll revert. > > FYI, simple re

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

curdeius added a comment. That's definitely an unintended behaviour. Please file a bug and possibly mark it as release blocker for LLVM 12. Either a fix will be there soon, or we'll revert. FYI, simple reproduce: verifyFormat("#include \n" "namespace rep {}", St

[PATCH] D94820: Support for instrumenting only selected files or functions

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + This can be added below `-fprofile-exclude-files=` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34b60d8a5684: Add -fbinutils-version= to gate ELF features on the specified binutils version (authored by MaskRay). Repository: rG LLVM Github Mon

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added a comment. In D94820#2523461 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/32075/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for the heads up, I suspect it m

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319379. akhuang added a comment. Avoid using getLambdaId function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clang/AST/Mangle.h clang/lib/

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + rnk wrote: > I think I would prefer to have this return a number. I think CGDebugInfo > should be responsibl

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 319378. MaskRay added a comment. Add llc validity check and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added a comment. Herald added a reviewer: jansvoboda11. ping :) Is there any more feedback on the implementation inside ProcessCharEscape()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a comment. In D94472#2523053 , @Bigcheese wrote: > In D94472#2519838 , @jansvoboda11 > wrote: > >> In D94472#2508018 , @dexonsmith >> wrote: >> >>> `strict

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2523439 , @rsmith wrote: > Clang side looks good to me. > > On the LLVM side, is it intended that invalid `-binutils-version` values are > silently accepted? Yes. In `llvm/tools/llc/llc.cpp`, there is no validity check.

[PATCH] D94820: Support for instrumenting only selected files or functions

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/32075/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.ll

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG189f311130da: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid… (authored by MaskRay). Repository: rG LLVM Github Monore

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

rsmith accepted this revision. rsmith added a comment. Clang side looks good to me. On the LLVM side, is it intended that invalid `-binutils-version` values are silently accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://r

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rG31d375f178c2: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/ne

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/references.cl:29 +void foo(); +void test(void (&par)()) { + void (&loc)(); Anastasia wrote: > oops, I thought this was covered in my patch. I will see if there is a quick > fix and if not I w

[PATCH] D95017: [clang-format] add case aware include sorting

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. MyDeveloperDay wrote: > curdeius wro

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia updated this revision to Diff 319369. Anastasia added a comment. Improved diagnostics to cover more cases. NOTE that this now also contains similar improvements for the pointers to member functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95442/new/ https://reviews.llv

[PATCH] D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver

jrmuizel added a comment. Actually, this may just be a local configuration issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83250/new/ https://reviews.llvm.org/D83250 ___ cfe-commits mailing list cfe

[PATCH] D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver

jrmuizel added a comment. This seems to have broken compilation for me on 10.15. The stdio.h from the 10.15 SDK there's the following usage: #if TARGET_OS_EMBEDDED #define __swift_unavailable_on(osx_msg, ios_msg) __swift_unavailable(ios_msg) #else #define __swift_unavailable_on(osx_msg,

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

rnk added a comment. I see a potential issue, but I think this looks good otherwise. Comment at: clang/lib/AST/ItaniumMangle.cpp:210 +if (Number == 0) + return getAnonymousStructId(Lambda); +return Number; This has the potential to create a situati

[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4edf35f11a9e: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=318257&id=319359#toc Repository: rG LLVM Git

[PATCH] D95338: [clangd] FindTarget resolves base specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG7730599c4164: [clangd] FindTarget resolves base specifier (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95338/new/ https://reviews.l

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGd92413a45e20: [clangd] Selection handles CXXBaseSpecifier (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95231/new/ https://reviews.l

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319348. akhuang marked an inline comment as done. akhuang added a comment. change to function returning a number, fill in ItaniumMangle function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

leonardchan added a comment. Hi. Up until this point, we've noticed that this patch can produce different formatted files depending on amount of whitespace. For example, given (A): #include namespace fuzzing {} `clang-format` with this patch would produced (B): #include namespace fuz

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added inline comments. Comment at: clang/include/clang/AST/CXXInheritance.h:77 - CXXBasePath() = default; + /// Additional data stashed on the base path by its consumers. + union { rsmith wrote: > rjmccall wrote: > > rsmith wrote: > > > rjmccall wro

[PATCH] D95459: Add helper functionality for parsing different attribute syntaxes in arbitrary order

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, jyknight, rjmccall. aaron.ballman requested review of this revision. In Clang today, we parse the different attribute syntaxes (`__attribute__`, `__declspec`, and `[[]]`) in a fairly rigid order. This leads to c

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap created this revision. Conanap added reviewers: nemanjai, saghir, PowerPC. Conanap added projects: LLVM, clang, PowerPC. Herald added a subscriber: kbarton. Conanap requested review of this revision. Previously related differential (exploit xxsplti32dx for vectors) here: https://reviews.l

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM I think, it would be good to get input from other reviewers Comment at: clang/unittests/Format/FormatTest.cpp:13696 " }\n" -

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 319337. MaskRay marked 6 inline comments as done. MaskRay added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files: clang/docs/ReleaseN

[PATCH] D95451: [clangd] references: decls of overrides of x are refs to x, not decls

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:1406 + Req.Limit = Limit; + auto QueryIndex = [&](bool AllowAttributes) { +if (Req.IDs.empty() || !Inde

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a comment. @hliao -- Can you take a look at https://bugs.llvm.org/show_bug.cgi?id=48866. This patch may be relevant there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

Bigcheese added a comment. In D94472#2519838 , @jansvoboda11 wrote: > In D94472#2508018 , @dexonsmith > wrote: > >> `strict` mode additionally uses the `GeneratedArgs1` to fill >> CompilerInvocation, indirectly c

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c03f7d7d04c: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target… (authored by tianshilei1992). Repository: rG LLVM Github Mo

[PATCH] D95017: [clang-format] add case aware include sorting

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. curdeius wrote: > kentsommer wrote: > >

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

MaskRay added a comment. In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean all

[PATCH] D95075: [hip] Fix `` compilation on Windows with VS2019.

MaskRay added a comment. In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean all

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

MaskRay added a comment. In your commit the message has just `Reviewers:`. The `Reviewers:` list does not necessarily mean all the people on the list have acknowledged the patch so `Reviewers:` is mostly useless. Many people agree that both `Reviewed:` & `Differential Revision:` should be prese

[PATCH] D95229: [clangd] Treat optional field type mismatches as soft failures

kadircet updated this revision to Diff 319321. kadircet marked 4 inline comments as done. kadircet added a comment. As discussed offline, only treat "null" fields as missing, rather than allowing type mismatches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95451: [clangd] references: decls of overrides of x are refs to x, not decls

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This requires a second index query for re

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 319315. whisperity added a comment. - Added a fallback case to also diagnose when Clang parsed the two types to be canonically the same (we will elaborate a few cases of such equivalences later, such as `typedef`s) - Fixed Clang-Format and Clang-Tidy wa

[PATCH] D95423: [clangd] Add std::size_t to StdSymbol mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG9190f17a7cc5: [clangd] Add std::size_t to StdSymbol mapping (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95423/new/ https://reviews

[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:81 case diag::err_func_def_incomplete_result: + case diag::err_field_incomplete_or_sizeless: // Incomplete type diagnostics should have a QualType argument for the what

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319309. abhina.sreeskantharajan added a comment. Fix CI: Other projects like flang also do not specify LLVM_HOST_TRIPLE. If this is not specified, set the triple to an empty string. I also added one more error code %errc_EISDIR and updated th

[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Unfortunately this treats overr

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/references.cl:24 +void templ() { + // FIXME: We miss to diagnose the reference to function. + T loc; //expected-error{{declaration of reference variable 'loc' requires an initializer}} I hav

[PATCH] D95417: [NFC] Disallow unused prefixes under clang/test/CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0d009a88f2: [NFC] Disallow unused prefixes under clang/test/CodeGen (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95417/new/ https:

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, sameeranjoshi, SouraVX, tskeith, kiranktp, AMDChirag. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

fhahn added inline comments. Comment at: llvm/lib/IR/Instruction.cpp:580 +if (auto *CB = dyn_cast(this)) + return objcarc::hasRetainRVOrClaimRVAttr(CB); +return false; ahatanak wrote: > fhahn wrote: > > rjmccall wrote: > > > nikic wrote: > > > > This

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: llvm/lib/IR/Instruction.cpp:580 +if (auto *CB = dyn_cast(this)) + return objcarc::hasRetainRVOrClaimRVAttr(CB); +return false; fhahn wrote: > rjmccall wrote: > > nikic wrote: > > > This change looks pretty

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

uweigand added a comment. In D82862#2513044 , @rnk wrote: > In D82862#2512908 , @uweigand wrote: > >> So why do you want GNU inline asm for clang-cl anyway? I thought the whole >> point of clang-cl was to be comp

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. References to functions are less permissive than pointers to functions and therefore some use cases could be allowed for example: - For

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. On further digging as to how pointer-to-members are handled in StaticAnalyzer, I discovered that in `BasicValueFactory::accumCXXBase() for the example given in my test produces the two `CXXBaseSpecifier` for the pointer-to-member. At line 195, one base specifier is add

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 319284. FreddyYe added a comment. refine clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inl

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 319282. FreddyYe added a comment. If Clobber is edx only, don't change "={eax}" to "=&{eax}". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGe

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman added a comment. Pinging the reviewers to help with the naming questions. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + steveire wrote: > aaron.ballman wrote: > > ste

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan requested review of this revision. abhina.sreeskantharajan marked 4 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-354 +if (re.match(r's390x-.*-zos', triple)): +

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319276. abhina.sreeskantharajan added a comment. Herald added subscribers: mgorny, emaste. This patch makes the following changes: - Define LLVM_HOST_TRIPLE for lld tests. (This was the project that didn't have host defined.) - Change %err_no

[PATCH] D95408: [Sema][C] members of anonymous struct inherit QualType

aaron.ballman added a comment. I know we don't have to deal with `restrict` because that qualifies a pointer (so there's no way to use it with an anonymous struct), but are there others? There's `DeclSpec::TQ_unaligned` (which has no corresponding qualifier in `Qualifiers::TQ` despite the comme

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

This revision was automatically updated to reflect the committed changes. ZarkoCA marked an inline comment as done. Closed by commit rG028d7a36681f: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SI

  1   2   >