[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651 + auto Results = + completions("int main() { abs^ }", {func("absl"), func("absb")}); EXPECT_THAT(Results.Completions, sorry, I didn't infer the motivat

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! this looks like a nice improvement! Comment at: clang/test/CodeCompletion/member-access.cpp:88 + TemplateClass &relatedField; + BaseTemplate &relatedFunction(); + -

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

aeubanks added a comment. This makes sense to me, we need to add the PassBuilder callbacks in both the prelink/normal and postlink steps, and those are separated. Comment at: llvm/include/llvm/LTO/Config.h:54 + /// For adding passes that run by opt. + std::function OptPassBu

[clang] 984cfdc - [clang][cli] Fix gcc warning (NFC)

Author: Yang Fan Date: 2021-02-11T12:38:09+08:00 New Revision: 984cfdc6ee8b4550238dccf212d786c4ded49cf7 URL: https://github.com/llvm/llvm-project/commit/984cfdc6ee8b4550238dccf212d786c4ded49cf7 DIFF: https://github.com/llvm/llvm-project/commit/984cfdc6ee8b4550238dccf212d786c4ded49cf7.diff LOG:

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

Szelethus added reviewers: NoQ, vsavchenko. Szelethus added a comment. Looks like a neat checker! I guess the only question is the function matching, and I don't dislike it in its current state. @martong, do you have any thoughts on this? On another note, have you checked this on some projects

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl updated this revision to Diff 322894. yaxunl added a comment. handle launch kernel by API and launch kernel in function pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86376/new/ https://reviews.llvm.org/D86376 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/lib/CodeGen/C

[PATCH] D96478: [clang][cli] Fix gcc warning (NFC)

nullptr.cpp updated this revision to Diff 322896. nullptr.cpp added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96478/new/ https://reviews.llvm.org/D96478 Files: clang/lib/Frontend/TestModuleFileExtension.cpp Index: cla

[PATCH] D96478: [clang][cli] Fix gcc warning (NFC)

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC warning: /llvm-project/clang/lib/Frontend/TestModuleFileExtension.cpp:131:20: warning: ‘llvm::raw_ostream& clang::operator<<(llvm::raw_os

[PATCH] D96389: [analyzer] Update static analyzer to be support sarif-html

This revision was automatically updated to reflect the committed changes. Closed by commit rG2407eb08a574: [analyzer] Update static analyzer to be support sarif-html (authored by Daniel Hwang , committed by haowei). Herald added a project: clang. Herald added a subscriber: cfe-c

[clang] 2407eb0 - [analyzer] Update static analyzer to be support sarif-html

Author: Daniel Hwang Date: 2021-02-10T18:34:53-08:00 New Revision: 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f URL: https://github.com/llvm/llvm-project/commit/2407eb08a5748bc2613e95fa449fc1cae6f4ff8f DIFF: https://github.com/llvm/llvm-project/commit/2407eb08a5748bc2613e95fa449fc1cae6f4ff8f.diff

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552314 , @curdeius wrote: > Please regroup tests and add release notes. Regroup tests - by that I think you meant all your 4 remarks about the tests. So I've done 3/4 :D Release

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552232 , @HazardyKnusperkeks wrote: > Apart from my comments, this looks good to me and I really wonder why it > hasn't been pushed. (I would directly use it!) I don't know, may

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 322880. kuzkry added a comment. Sorted code alphabetically as suggested by @HazardyKnusperkeks and applied almost all fixes proposed by @curdeius (entry in release notes + some changes in unit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak reopened this revision. ahatanak added a comment. This revision is now accepted and ready to land. In D92808#2555737 , @dexonsmith wrote: > In D92808#2552354 , @rjmccall wrote: > >> The ultimate code-genera

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. Ping @abidh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D93023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[libunwind] 77fecc0 - [NFC][libunbind] Fix Sphinx error during CMake invocation

Author: xgupta Date: 2021-02-11T06:52:24+05:30 New Revision: 77fecc07955f51db3f184ba10d3f5fcd1f3f152d URL: https://github.com/llvm/llvm-project/commit/77fecc07955f51db3f184ba10d3f5fcd1f3f152d DIFF: https://github.com/llvm/llvm-project/commit/77fecc07955f51db3f184ba10d3f5fcd1f3f152d.diff LOG: [

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 322867. ahatanak added a comment. Fix two bugs which were discovered. - Fix bug in `replaceUsesOfNonProtoConstant`. - Teach SCCP not to replace the return of a "clang.arc.rv" call with a constant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

MaskRay added a comment. In D96203#2548529 , @echristo wrote: > In D96203#2548495 , @aaron.ballman > wrote: > >> In D96203#2548471 , @mibintc wrote: >> >>> In D96203#2546856

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish added a comment. I don't see a way to do this with weak symbols, and an install script would be yet-another moving part that we'd have to make on end-user systems. How about this: once we reach a point where we don't support the old LLVM anymore, libc can make crt1.o be the same as crt1

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

dexonsmith added a comment. In D92808#2552354 , @rjmccall wrote: > The ultimate code-generation consequences of this feature aren't very > generic, so we shouldn't let ourselves get caught up designing an extremely > general feature that ultimately eithe

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 added a comment. In D89274#211 , @sunfish wrote: > It's to ensure that older LLVM works with newer WASI libc, and newer clang > works with older WASI libc. New-style commands require [lld support]. We can > assume that if clang is updated, lld

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1549 + Conf.OptPassBuilderHook = [&](PassBuilder &PB) { +addSanitizers(TargetTriple, CGOpts, LOpts, PB); + }; I can't find where this is defined. Comment at: l

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added a comment. Maybe we want these options in llvm 12 as well? (+ Release note) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 ___ cfe-commits mailin

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish added a comment. It's to ensure that older LLVM works with newer WASI libc, and newer clang works with older WASI libc. New-style commands require [lld support]. We can assume that if clang is updated, lld has the requisite support. That said, I'm open to other ideas here. [lld support

[PATCH] D96130: Correct swift_bridge duplicate attribute warning logic

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96130/new/ https://reviews.llvm.org/D96130 __

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 ___

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

vitalybuka added a comment. In D96320#2554493 , @aeubanks wrote: > This seems like the wrong fix to me. > ThinLTO only runs the simplification pipeline pre-link, then runs it again > plus the optimization pipeline. The optimization pipeline is the only pl

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

jdoerfert added a comment. Seems reasonable to me and makes things simpler. @atmnpatel Any thoughts? Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } fhahn wrote: > jdoerfert wro

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka added a comment. Test will follow if you agree with approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 ___ cfe-commits mailing list cfe-commits@

[PATCH] D96456: [ThinLTO] Add Config::OptPassBuilderHook

vitalybuka created this revision. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang needs to register sanitizer at OptimizerLastEPCallback. Nowever

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 added a comment. Why not just use crt1.o in both cases?If you are going to prefer crt1-command.o in all cases then a toolchain would have no reason to ever ship crt1.o would it? (since it would always be ignored?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D96328: [Clang, NewPM] Add KMSan support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6051f52acf5: [Clang, NewPM] Add KMSan support (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D96328?vs=322643&id=322

[clang] b6051f5 - [Clang, NewPM] Add KMSan support

Author: Vitaly Buka Date: 2021-02-10T14:07:49-08:00 New Revision: b6051f52acf5e735478dba87da9a7657bdc249f9 URL: https://github.com/llvm/llvm-project/commit/b6051f52acf5e735478dba87da9a7657bdc249f9 DIFF: https://github.com/llvm/llvm-project/commit/b6051f52acf5e735478dba87da9a7657bdc249f9.diff L

[clang] 228f00b - [NFC] Simplify test

Author: Vitaly Buka Date: 2021-02-10T13:57:36-08:00 New Revision: 228f00bd75d953545eb2492156d776fdac211a24 URL: https://github.com/llvm/llvm-project/commit/228f00bd75d953545eb2492156d776fdac211a24 DIFF: https://github.com/llvm/llvm-project/commit/228f00bd75d953545eb2492156d776fdac211a24.diff L

[PATCH] D96427: Support multi-configuration generators correctly in several config files

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a bot that should (?) be testing this configuration: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ Repository: rG LLVM Github M

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:26 +/// assembler flag appearing last (latter wins). +// RUN: %clang -target arm-linux-gnueabi -### -mimplicit-it=never -Wa,-mimplicit-it=always %S/Inputs/wildcard1.c 2>&1 | FileChe

[clang-tools-extra] bda5e57 - [clangd] Remove redundant -fno-delayed-template-parsing in tests. NFCI

Author: Sam McCall Date: 2021-02-10T22:20:23+01:00 New Revision: bda5e57742237dc38350e59892cf4220ae0de486 URL: https://github.com/llvm/llvm-project/commit/bda5e57742237dc38350e59892cf4220ae0de486 DIFF: https://github.com/llvm/llvm-project/commit/bda5e57742237dc38350e59892cf4220ae0de486.diff LO

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers updated this revision to Diff 322807. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reorder test checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https://reviews.llvm.org/D96285

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:147 +No = 2, // No loop is assumed to be finite. + }; + jdoerfert wrote: > Can we have different names? > > `FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc8365f8082: [clangd] Remove support for pre-standard semanticHighlighting notification (authored by sammccall). Changed prior to commit: https:/

[clang-tools-extra] 4dc8365 - [clangd] Remove support for pre-standard semanticHighlighting notification

Author: Sam McCall Date: 2021-02-10T22:09:03+01:00 New Revision: 4dc8365f80823d8042ba4bdc3278de7a42619c24 URL: https://github.com/llvm/llvm-project/commit/4dc8365f80823d8042ba4bdc3278de7a42619c24 DIFF: https://github.com/llvm/llvm-project/commit/4dc8365f80823d8042ba4bdc3278de7a42619c24.diff LO

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322803. fhahn added a comment. adjust naming of enum members as suggested, thanks! I think it cannot be an enum class unfortunately because the CodeGenOption machinery seems to use regular enums/unsigneds. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall updated this revision to Diff 322802. sammccall added a comment. Rebase, now the feature parity stuff is in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95576/new/ https://reviews.llvm.org/D95576 Files: clang-tools-extra/clangd/Clangd

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } jdoerfert wrote: > Can you modify the documentation to talk about what loops must make progress, > th

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 322791. fhahn added a comment. Herald added a subscriber: jfb. Document reasoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/ https://reviews.llvm.org/D96418 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + The trailing comment markers don't really add much. Comment at: clang-tools-e

[PATCH] D96439: [clangd][WIP] Introduce DiagnosticAugmentationModule

kadircet updated this revision to Diff 322755. kadircet added a comment. - Integrate with parseinputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96439/new/ https://reviews.llvm.org/D96439 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 322754. kadircet added a comment. - Changes to propagate moduleset into clangd(lsp)server Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96244/new/ https://reviews.llvm.org/D96244 Files: clang-tools-extra/cl

[PATCH] D96439: [clangd][WIP] Introduce DiagnosticAugmentationModule

kadircet added a comment. Note that this doesn't handle the execution yet, it is mostly to demonstrate the idea and to get some early feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96439/new/ https://reviews.llvm.org/D96439 _

[PATCH] D96439: [clangd] Introduce DiagnosticAugmentationModule

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. A module interface to enable custom contrib

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 322746. ldionne retitled this revision from "[libc++] Fix tuple assignment from type derived from a tuple-like" to "[libc++] Fix tuple assignment from types derived from a tuple-like". ldionne edited the summary of this revision. ldionne added a comment. Hera

[PATCH] D96244: [clangd][RFC] Introudce Plugins

kadircet updated this revision to Diff 322744. kadircet added a comment. - Rename Plugin to Module - Have a ModuleSet that enables type-safe traversal of existing modules (with questions about implementation options) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

spatel added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9305 + * 1. The elements are reassociable when using fadd/fmul intrinsics; + * 2. There's no nan and signed zero in the elements when using fmin/max + intrinsics; If I understand correctl

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet updated this revision to Diff 322743. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96245/new/ https://reviews.llvm.org/D96245 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89274/new/ https://reviews.llvm.org/D89274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e8afba6f176: [clang] Add support for attribute 'swift_async_error' (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D96175?vs=322152&id=32

[clang] 1e8afba - [clang] Add support for attribute 'swift_async_error'

Author: Erik Pilkington Date: 2021-02-10T13:18:13-05:00 New Revision: 1e8afba6f176653abcbda4f0485d9419c8407afb URL: https://github.com/llvm/llvm-project/commit/1e8afba6f176653abcbda4f0485d9419c8407afb DIFF: https://github.com/llvm/llvm-project/commit/1e8afba6f176653abcbda4f0485d9419c8407afb.dif

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

aeubanks added a comment. This seems like the wrong fix to me. ThinLTO only runs the simplification pipeline pre-link, then runs it again plus the optimization pipeline. The optimization pipeline is the only place that OptimizerLastEPCallback should run (aside from the -O0 pipeline). Basically,

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 322724. saiislam added a comment. Added support for optional TargetID during unbundling of archives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 Files: clang/doc

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

svenvh added a comment. In D96178#2551449 , @Anastasia wrote: > @svenvh We haven't looked into address spaces in details when adding this. I > wonder what behavior would make sense for new/delete? Do we plan to allow > new/delete in named address spaces

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 322713. rsanthir.quic added a comment. alphabetized check in NeonEmitter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 Files: clang/include/clang/Basic/arm_neon.td clang/include/clang/Basic/arm_n

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. @labrinea could you commit this when you have some time please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for losing this. > LMK if you think it makes sense to move some of this logic in AST.cpp > (clangd). objcContainerLocalScope seems like it would be useful to generalize > support

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added a comment. This looks great, that turned out to be a lot cleaner than I expected. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1717 + FilenameStrs[0] = getCurrentDirname(); + FilenameRefs[0] = FilenameStrs[0]; for (const auto &Entry : FileEntries) { -

[PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. Herald added a reviewer: JDevlieghere. Heral

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

apazos added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2118 Record *R = Def->getRecord(); -if (R->getValueAsBit("isVCVT_N")) { +if (R->getValueAsBit("isVXAR")) { + //VXAR takes an immediate in the range [0, 63] Consider a

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10314 + switch (kind) { + case clang::CK_IntegralToPointer: // [[fallthrough]]; + case clang::CK_FunctionToPointerDecay: { cjdb wrote: > aaron.ballman wrote: > > > Done, but why?

[clang] b86a763 - Revert "Revert "[clang][driver] Only warn once about invalid library values""

Author: Tom Weaver Date: 2021-02-10T16:40:07Z New Revision: b86a763afb9a1f55f4b234ce97320917ead6ac7f URL: https://github.com/llvm/llvm-project/commit/b86a763afb9a1f55f4b234ce97320917ead6ac7f DIFF: https://github.com/llvm/llvm-project/commit/b86a763afb9a1f55f4b234ce97320917ead6ac7f.diff LOG: Re

[clang] a743702 - Revert "[clang][driver] Only warn once about invalid library values"

Author: Tom Weaver Date: 2021-02-10T16:37:34Z New Revision: a743702a1f4880e4492196b1ce9a9a63e0b4c075 URL: https://github.com/llvm/llvm-project/commit/a743702a1f4880e4492196b1ce9a9a63e0b4c075 DIFF: https://github.com/llvm/llvm-project/commit/a743702a1f4880e4492196b1ce9a9a63e0b4c075.diff LOG: Re

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. Friendly ping, I think this is still worth merging in even without the QName changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 __

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:147 +No = 2, // No loop is assumed to be finite. + }; + Can we have different names? `FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind::No` implies. May

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a reviewer: alexfh_. segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list cfe-commits@

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } Can you modify the documentation to talk about what loops must make progress, this is the code be

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov added a comment. Thanks for review. Just to be clear: can I proceed with this? Or we should discuss it first? As I see possible this change can be abandoned after discussion. Moreover,  I see nothing about address space of void pointer in OpenCL C spec. For example (OpenCL C 2.2, Cla

[PATCH] D96150: [OpenCL][Docs] Describe internals of TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Ok, this looks like a good start. Later we can add a bit more information/guidance on how to add new function specifically how to specify parameter or return types, overloads, and attri

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 322696. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clan

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2554186 , @aaron.ballman wrote: > In D93630#2506604 , @aaron.ballman > wrote: > >> In D93630#2504758 , @vsavchenko >> wrote: >> >>> I

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 322695. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files: clan

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D93630#2506604 , @aaron.ballman wrote: > In D93630#2504758 , @vsavchenko > wrote: > >> I'll

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

aaron.ballman added a comment. In D96215#2550227 , @NoQ wrote: > In D96215#2548492 , @aaron.ballman > wrote: > >> Should structured bindings be treated similarly as well (not necessarily as >> part of this patch)?

[PATCH] D96279: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96279/new/ https://reviews.llvm.org/D96279 ___

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added a comment. The change looks good, could we test the diagnostic that is added? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 322689. timwoj added a comment. Rebased on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/UnwrappedLineForm

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

probinson added a comment. > the driver had a redundant pass-through of the option I could've sworn it worked to remove that, but it didn't when I rebased, so that's gone from the final patch (i.e, the explicit pass-through in the driver is still there). It's a functionally separate topic anyw

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h:12 -void abort(void); -void _Exit(int); -void quick_exit(int); +typedef int size_t; I think this is causing some test failures: https://revie

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : RecursiveASTVisitor(), IgnoreMacros(IgnoreMacros){}; + Is a default base

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 322685. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files: clan

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea2d4fa4811: Avoid conflicts between debug-info and pseudo-probe profiling (authored by probinson). Changed prior to commit: https://reviews.llvm

[clang] 5ea2d4f - Avoid conflicts between debug-info and pseudo-probe profiling

Author: Paul Robinson Date: 2021-02-10T07:09:18-08:00 New Revision: 5ea2d4fa481160c9843b8651df265ce1fbfd9316 URL: https://github.com/llvm/llvm-project/commit/5ea2d4fa481160c9843b8651df265ce1fbfd9316 DIFF: https://github.com/llvm/llvm-project/commit/5ea2d4fa481160c9843b8651df265ce1fbfd9316.diff

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1923 + if (Arg *A = Args.getLastArg(OPT_save_temps_EQ)) +Opts.SaveTempsFilePrefix = xbolva00 wrote: > Not needed Removed, thanks! Repository: rG LLVM Github Monorepo CH

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322683. fhahn added a comment. Remove accidentally copied code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 Files: clang/include/clang/Basic/CodeGenOptions.def cl

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1923 + if (Arg *A = Args.getLastArg(OPT_save_temps_EQ)) +Opts.SaveTempsFilePrefix = Not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

sammccall updated this revision to Diff 322681. sammccall added a comment. Also handle parens and unresolved calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96376/new/ https://reviews.llvm.org/D96376 Files: clang-tools-extra/clangd/unittests

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322679. fhahn added a comment. Add description for options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 Files: clang/include/clang/Basic/CodeGenOptions.def clang/

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn created this revision. fhahn added reviewers: jdoerfert, rjmccall, xbolva00, atmnpatel, aaron.ballman, rsmith. Herald added subscribers: dexonsmith, dang. Herald added a reviewer: jansvoboda11. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn created this revision. fhahn added reviewers: jdoerfert, rjmccall, xbolva00, atmnpatel, aaron.ballman, rsmith. fhahn requested review of this revision. Herald added a project: clang. Currently Clang does not add mustprogress to inifinite loops with a known constant condition, matching C11 b

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

JackKemp99 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

  1   2   >