[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard updated this revision to Diff 323222. rprichard added a comment. Rebase and fix merge conflict in gn file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 Files:

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

rprichard updated this revision to Diff 323221. rprichard edited the summary of this revision. rprichard added a comment. Update libunwind/src/BUILD.gn for macro name change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96538/new/ https://reviews.llvm.org/D96538

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79401b43ce4e: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode (authored by Pushpinder Singh pushpinderdhaliwa...@gmail.com, committed

[clang] 79401b4 - [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

Author: Pushpinder Singh Date: 2021-02-12T00:42:41-05:00 New Revision: 79401b43ce4e3aa856c50e78b38327e3ff4ae9eb URL: https://github.com/llvm/llvm-project/commit/79401b43ce4e3aa856c50e78b38327e3ff4ae9eb DIFF:

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 323218. ahatanak retitled this revision from "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR" to "[ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting

[PATCH] D96573: [Clang][ASan] Teach Clang to not emit ASan module destructors when compiling with `-mkernel` or `-fapple-kext`.

delcypher created this revision. delcypher added reviewers: arphaman, kubamracek, yln, aralisza, kcc, vitalybuka. delcypher requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://71609176 Repository: rG LLVM Github Monorepo

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 323213. delcypher added a comment. clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher created this revision. delcypher added reviewers: arphaman, kubamracek, yln, aralisza, kcc, vitalybuka. Herald added subscribers: dexonsmith, dang. Herald added a reviewer: jansvoboda11. delcypher requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3cd3a3c9152: Partially Revert scan-view: Remove Reporter.py and associated AppleScript… (authored by tstellar). Changed prior to commit:

[clang] e3cd3a3 - Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

Author: Tom Stellard Date: 2021-02-11T19:10:46-08:00 New Revision: e3cd3a3c91524c957e06bb0170343548f02b6842 URL: https://github.com/llvm/llvm-project/commit/e3cd3a3c91524c957e06bb0170343548f02b6842 DIFF: https://github.com/llvm/llvm-project/commit/e3cd3a3c91524c957e06bb0170343548f02b6842.diff

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

aeubanks added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks.

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1328 +CodeGenOpts.ThinLTOIndexFile.empty()) { + // This is testing distributed ThinLTO PostLink. O0 called optimized in + // PreLink. vitalybuka wrote: > tejohnson

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1328 +CodeGenOpts.ThinLTOIndexFile.empty()) { + // This is testing distributed ThinLTO PostLink. O0 called optimized in + // PreLink. tejohnson wrote: > I don't

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 323202. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files:

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added inline comments. Comment at: clang/test/Analysis/free.c:84 + // expected-warning@-1{{Argument to free() is a block, which is not memory allocated by malloc()}} + // expected-warning@-2{{attempt to call free on non-heap object : block expression}} }

[PATCH] D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

aykevl added a comment. I checked this, and it seems good to me although I would like someone else to also take a look. In D86547#2287353 , @atrosinenko wrote: > In D86547#2284095 , @MaskRay wrote: > >> The

[clang] 686b65f - [Msan, NewPM] Reduce size of msan binaries

Author: Vitaly Buka Date: 2021-02-11T16:07:18-08:00 New Revision: 686b65f85f22c70e082753cd05e8572d22e3991c URL: https://github.com/llvm/llvm-project/commit/686b65f85f22c70e082753cd05e8572d22e3991c DIFF: https://github.com/llvm/llvm-project/commit/686b65f85f22c70e082753cd05e8572d22e3991c.diff

[PATCH] D96406: [Msan, NewPM] Reduce size of msan binaries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG686b65f85f22: [Msan, NewPM] Reduce size of msan binaries (authored by vitalybuka). Changed prior to commit:

[PATCH] D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls

aykevl added a comment. This looks good to me, although I would like someone else to take a look as well. I can confirm that these changes fix an issue on AVR: this patch (together with D86547 ) make `__floatsisf` correct on AVR while it would previously do

[clang] f2f59d2 - [NFC] Extract function which registers sanitizer passes

Author: Vitaly Buka Date: 2021-02-11T15:29:48-08:00 New Revision: f2f59d2a060788f17040ad924ee2d11da0e215c8 URL: https://github.com/llvm/llvm-project/commit/f2f59d2a060788f17040ad924ee2d11da0e215c8 DIFF: https://github.com/llvm/llvm-project/commit/f2f59d2a060788f17040ad924ee2d11da0e215c8.diff

[PATCH] D96481: [NFC] Extract function which registers sanitizer passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2f59d2a0607: [NFC] Extract function which registers sanitizer passes (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added a comment. FYI, https://reviews.llvm.org/D17444 captures some of the history here. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + <<

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c05fc39145: [WebAssembly] Use the new crt1-command.o if present. (authored by sunfish). Changed prior to commit:

[clang] f9c05fc - [WebAssembly] Use the new crt1-command.o if present.

Author: Dan Gohman Date: 2021-02-11T14:44:37-08:00 New Revision: f9c05fc391458e455e8e4d4108a7f270f2f7bedc URL: https://github.com/llvm/llvm-project/commit/f9c05fc391458e455e8e4d4108a7f270f2f7bedc DIFF: https://github.com/llvm/llvm-project/commit/f9c05fc391458e455e8e4d4108a7f270f2f7bedc.diff

[PATCH] D96244: [clangd] Introduce Modules

sammccall added a comment. I'm a little bit nervous about adding this with *no* usage, but it keeps the patch size down :-) Comment at: clang-tools-extra/clangd/Module.cpp:1 +//===--- Module.cpp - Main clangd server code *- C++-*-===// +//

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:261 + diags.getCustomDiagID(clang::DiagnosticsEngine::Error, + "Use of `-fdefault-double-8` requires `-fdefault-real-8`"); + diags.Report(diagID);

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323156. dgoldman marked an inline comment as done. dgoldman added a comment. - Support protocols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files:

[clang] 60bed4a - Replace deprecated %T in 2 tests.

Author: Hafiz Abid Qadeer Date: 2021-02-11T22:21:21Z New Revision: 60bed4ab57d562d5770cc9c24a8fcb243208f5e5 URL: https://github.com/llvm/llvm-project/commit/60bed4ab57d562d5770cc9c24a8fcb243208f5e5 DIFF: https://github.com/llvm/llvm-project/commit/60bed4ab57d562d5770cc9c24a8fcb243208f5e5.diff

[PATCH] D93023: Replace deprecated %T in 2 tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG60bed4ab57d5: Replace deprecated %T in 2 tests. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG61cca0f2e5bb: [AArch64] Adding Neon Sm3 Sm4 Intrinsics (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/

[clang] 61cca0f - [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

Author: Pengxuan Zheng Date: 2021-02-11T14:20:20-08:00 New Revision: 61cca0f2e5bbb6045bb27b822e34cd39c9c1acb1 URL: https://github.com/llvm/llvm-project/commit/61cca0f2e5bbb6045bb27b822e34cd39c9c1acb1 DIFF:

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323151. dgoldman added a comment. - Move over to AST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:64 +static llvm::StringRef getNameForObjCInterface(const ObjCInterfaceDecl *ID) { + return ID ? ID->getName() : "<>"; dgoldman wrote: > sammccall

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:64 +static llvm::StringRef getNameForObjCInterface(const ObjCInterfaceDecl *ID) { + return ID ? ID->getName() : "<>"; sammccall wrote: > this function's name doesn't really

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323141. dgoldman marked 7 inline comments as done. dgoldman added a comment. - Address review comments Will move over to AST.cpp in next update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The goal is to allow the LSP

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added a comment. Two minor missing items: - Please include a binary test that verifies llvm-cov can prepare a report for a binary containing a Version6 coverage blob (for compatibility testing). - Please also include a short blurb in docs/CoverageMappingFormat.rst explaining the format

[PATCH] D96406: [Msan, NewPM] Reduce size of msan binaries

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM, please add a TODO for more passes Comment at: clang/lib/CodeGen/BackendUtil.cpp:1291 + // general purpose optimization passes. +

[PATCH] D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

ymandel created this revision. ymandel added a reviewer: alexfh. Herald added a subscriber: xazax.hun. ymandel requested review of this revision. Herald added a project: clang. Currently, all include insertions are directed to the main file. However, Transformer rules can specify alternative

[clang] 7b48326 - NFCI. With the move to the new pass manager by default, sanitize-coverage.c is now passing on ARM.

Author: Douglas Yung Date: 2021-02-11T13:18:18-08:00 New Revision: 7b4832648a6339c798f1f72bbc88b1ee41e9a338 URL: https://github.com/llvm/llvm-project/commit/7b4832648a6339c798f1f72bbc88b1ee41e9a338 DIFF: https://github.com/llvm/llvm-project/commit/7b4832648a6339c798f1f72bbc88b1ee41e9a338.diff

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

ArturGainullin created this revision. ArturGainullin added reviewers: bader, elizabethandrews. Herald added subscribers: Anastasia, ebevhan, yaxunl. ArturGainullin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM as initial step, but it would be good to adjust the name as Duncan suggested before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. In D92808#2557132 , @fhahn wrote: > Another thing I noticed that there's verifier support missing. I think we > should at least check that only a single `clang.arc.rv` bundle is specified >

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 323107. ahatanak added a comment. Address all review comments except for the ones about the bundle name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files:

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 323106. phosek marked 2 inline comments as done. phosek added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. I have addressed all the comments and fixed all tests. I'm happy to slice this into multiple patches if you

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak marked 3 inline comments as done. ahatanak added a comment. In D92808#2557634 , @dexonsmith wrote: > In D92808#2555868 , @ahatanak wrote: > >> For example, if SCCP just does a normal RAUW on the following

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG573348ab9b28: [clangd] Retire the cross-file-rename command-line flag. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 573348a - [clangd] Retire the cross-file-rename command-line flag.

Author: Haojian Wu Date: 2021-02-11T20:28:50+01:00 New Revision: 573348ab9b281221e0e78376c233d1898ed0bf68 URL: https://github.com/llvm/llvm-project/commit/573348ab9b281221e0e78376c233d1898ed0bf68 DIFF: https://github.com/llvm/llvm-project/commit/573348ab9b281221e0e78376c233d1898ed0bf68.diff

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D93023 ___ cfe-commits mailing list

[PATCH] D96363: Mark output as text if it is really text

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 ___ cfe-commits mailing list

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 323093. abhina.sreeskantharajan added a comment. Thanks for reviewing! Addressing inline comments by adding /*Binary*/ comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

dexonsmith added a comment. In D92808#2556542 , @fhahn wrote: > @dexonsmith @rjmccall What do you think? Would you be happy with iterating > on the suggestions in tree? I don't feel strongly either way; happy for it to land as-is (bugs fixed) and

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur accepted this revision. Meinersbur added a comment. Thank you for the clarification. It would be great if that could be communicated in the summary/commit message. It's sounds like emitting `llvm.loop.vectorize.predicate.enable` when vectorization is disabled is the motivation

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

hokein updated this revision to Diff 323084. hokein added a comment. fix failure tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96495/new/ https://reviews.llvm.org/D96495 Files: clang-tools-extra/clangd/refactor/Rename.h

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

hokein added a comment. In D96495#2556897 , @njames93 wrote: > Those test failures look related. oh, right. the failure tests rely on the default cross-file flag, fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ https://reviews.llvm.org/D96248

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

dexonsmith added a comment. In D92808#2555868 , @ahatanak wrote: > For example, if SCCP just does a normal RAUW on the following call, which is > taken from the example I posted, > > %r = call i8* @foo() [ "clang.arc.rv"(i64 1, i8* %r) ] > > will

[PATCH] D96427: Support multi-configuration generators correctly in several config files

teemperor added a comment. In D96427#2555251 , @JDevlieghere wrote: > LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a > bot that should (?) be testing this configuration: >

[PATCH] D95928: [OpenMP] Delay more diagnostics of potentially non-emitted code

jdoerfert added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95928/new/ https://reviews.llvm.org/D95928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Ok so we can see this as an interm thing. I think I'm OK with that. Could you add a comment about that, or at least say why we want to support both the old crt1 and the new crt1-command at

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa680bc3a31d3: [clang][Arm] Fix handling of -Wa,-implicit-it= (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a680bc3 - [clang][Arm] Fix handling of -Wa,-implicit-it=

Author: Nick Desaulniers Date: 2021-02-11T10:51:25-08:00 New Revision: a680bc3a31d36d321ccf3801bdcff74d58842bfa URL: https://github.com/llvm/llvm-project/commit/a680bc3a31d36d321ccf3801bdcff74d58842bfa DIFF:

[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. This looks fine to me. Thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96487/new/ https://reviews.llvm.org/D96487

[PATCH] D95772: [DebugInfo] Normalize paths by removing unnecessary dots

phosek added a comment. In D95772#2534103 , @dblaikie wrote: > Does this address @rnk's feedback about symlinks? ( > https://reviews.llvm.org/D87657#2296028 ) It doesn't, I think if we want to handle that case, we'd need to use `sys::fs::real_path`

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

dmgreen added a comment. Thanks for your comments. This patch is not intended to have no consequence - it's just not being communicated well in the commit message. The problem at the moment, with mainline clang, is that specifying: #pragma clang loop vectorize_width(4)

[PATCH] D96363: Mark output as text if it is really text

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with two inline nits. Comment at: clang/lib/Frontend/Rewrite/FrontendActions.cpp:188 std::unique_ptr OS = - CI.createDefaultOutputFile(true,

[PATCH] D96507: [clangd] Move command handlers into a map in ClangdLSPServer. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:587 + std::vector Commands; + llvm::copy(CommandHandlers.keys(), std::back_inserter(Commands));

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

aaron.ballman added a comment. In D94621#2554228 , @segoon wrote: > alexfh, aaron.ballman, hi! Any comments on the patch? Have you run this check over large real-world code bases beyond Yandex.Taxi? I think this is likely to be a maintenance burden

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen added inline comments. Comment at: llvm/CMakeLists.txt:656 + list(APPEND CMAKE_REQUIRED_LIBRARIES proc) +endif() + thakis wrote: > also, any reason to not do this in `llvm/cmake/config-ix.cmake` where all the > other checks like this are? No, I just

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2556586 , @njames93 wrote: > How does this handle a macro where the argument has complex code. > > MACRO(if (...) {}); I agree that macro arguments should account to the complexity. However, with this change macro

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:41 +/* WinAPI */ +"CreateThread", // +"CreateRemoteThread", // Missing the `::` in front of all of these identifiers.

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. In D96090#2551664 , @ASDenysPetrov wrote: > Updated. Unlinked parent revision D95799 > from the stack. Made corresponding changes in this patch. > @steakhal I did it. The changes should be

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski added inline comments. Comment at: flang/tools/f18/f18.cpp:541 driver.debugNoSemantics = true; -} else if (arg == "-funparse") { +} else if (arg == "-funparse" || arg == "-fdebug_unparse") { driver.dumpUnparse = true; tskeith

[PATCH] D96427: Support multi-configuration generators correctly in several config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova). Repository: rG LLVM Github

[clang] ed98676 - Support multi-configuration generators correctly in several config files

Author: Stella Stamenova Date: 2021-02-11T09:32:20-08:00 New Revision: ed98676fa4833bb80632fc7c9db10c3328d78485 URL: https://github.com/llvm/llvm-project/commit/ed98676fa4833bb80632fc7c9db10c3328d78485 DIFF:

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski updated this revision to Diff 323054. awarzynski added a comment. Fix typo in f18.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 Files: clang/include/clang/Driver/Options.td

[PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova updated this revision to Diff 323053. stella.stamenova edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96427/new/ https://reviews.llvm.org/D96427 Files: clang/test/Unit/lit.site.cfg.py.in

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. Hi, guys! Does anyone can review this item, except @steakhal (thanks him)? Please, look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90157/new/ https://reviews.llvm.org/D90157 ___ cfe-commits mailing list

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323052. massberg marked 2 inline comments as done. massberg added a comment. Add test cases showing that when IgnoreMacros is set to 'true', also macro arguments are ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 323047. ldionne added a comment. Fix segfault on GCC and a few incorrect checks in the type traits. I reduced the GCC segfault and it appears to have been fixed on GCC trunk, so I won't be filing a bug report. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D96519: [Clang][OpenMP] Fixed an issue that `target team` is emitted incorrectly

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ABataev, grokos. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. To illustrate how complicated interpreting the vectorize pragma has become in the mid-end: TransformationMode llvm::hasVectorizeTransformation(Loop *L) { Optional Enable = getOptionalBoolLoopAttribute(L, "llvm.loop.vectorize.enable"); if (Enable

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. In D94779#2556274 , @dmgreen wrote: > This makes sense to me. If the user specifies the pragma then we send that > through to the vectorizer, whatever it is. As much as `vectorize_width(1) > interleave_count(4)

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. Thanks for the review (here and D96304 )! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https://reviews.llvm.org/D96285

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:356 +#cmakedefine HAVE_PROC_PID_RUSAGE 1 + thakis wrote: > Any reason to use `#cmakedefine` instead of `cmakedefine01` here? This type > of check usually uses `#cmakedefine01`

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh updated this revision to Diff 323040. svenvh added a comment. Add test for new diagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/OpenCLBuiltins.td

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/CMakeLists.txt:656 + list(APPEND CMAKE_REQUIRED_LIBRARIES proc) +endif() + also, any reason to not do this in `llvm/cmake/config-ix.cmake` where all the other checks like this are? Repository: rG LLVM Github

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:356 +#cmakedefine HAVE_PROC_PID_RUSAGE 1 + Any reason to use `#cmakedefine` instead of `cmakedefine01` here? This type of check usually uses `#cmakedefine01` in this file.

[PATCH] D96049: [Timer] On macOS count number of executed instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e3b9aba609f: [Timer] On macOS count number of executed instructions (authored by ahoppen, committed by teemperor). Repository: rG LLVM Github

[clang-tools-extra] 7e3b9ab - [Timer] On macOS count number of executed instructions

Author: Alex Hoppen Date: 2021-02-11T17:26:37+01:00 New Revision: 7e3b9aba609f7f6c944baa319f0a61041ccdc707 URL: https://github.com/llvm/llvm-project/commit/7e3b9aba609f7f6c944baa319f0a61041ccdc707 DIFF: https://github.com/llvm/llvm-project/commit/7e3b9aba609f7f6c944baa319f0a61041ccdc707.diff

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2553325 , @tbaeder wrote: > In D95536#2552258 , @aaron.ballman > wrote: > >> In D95536#2551332 , @tbaeder wrote: >> >>> Any update

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1066 PassBuilder::OptimizationLevel Level) { +if (CodeGenOpts.OptimizationLevel == 0) { + if (!CodeGenOpts.ThinLTOIndexFile.empty())

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. The new review: https://reviews.llvm.org/D96515 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.llvm.org/D78979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96483: [flang][driver] Add options for unparsing

tskeith added inline comments. Comment at: flang/tools/f18/f18.cpp:541 driver.debugNoSemantics = true; -} else if (arg == "-funparse") { +} else if (arg == "-funparse" || arg == "-fdebug_unparse") { driver.dumpUnparse = true; This should be

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia created this revision. Anastasia added reviewers: svenvh, arsenm. Herald added subscribers: dang, ebevhan, yaxunl. Herald added a reviewer: jansvoboda11. Anastasia requested review of this revision. Herald added a subscriber: wdng. See original RFC:

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. Another thing I noticed that there's verifier support missing. I think we should at least check that only a single `clang.arc.rv` bundle is specified (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Verifier.cpp#L3191). We should probably also enforce that the

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal updated this revision to Diff 323025. steakhal added a comment. Actually, somehow I messed up something previously. Now, the diff contains the latest version. Sorry for the inconvenience! Rebased on top of 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

steakhal updated this revision to Diff 323024. steakhal added a comment. Nothing changed. Rebased on top of 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93223/new/

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman marked 2 inline comments as not done. aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >