[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

lebedev.ri added a comment. It would be better to split this into two parts. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:540 + if (!FlagBasicIncrements) { +return; Drop `{}` Comment at: c

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Who is going to commit? Comment at: clang/include/clang/AST/StmtOpenMP.h:651-677 + static bool + doForAllLoops(Stmt *CurStmt, bool TryImperfectlyNestedLoops, +

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.h:24-26 +/// * `FlagBasicIncrements`- if set to `true`, additional to flagging +// functions exceeding the threshold also every piece of code (loops, if +//

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert added a comment. friendly ping, also D95928 . These were supposed to be backported into 12 :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95912/new/ https://reviews.llvm.org/D95912

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur marked 6 inline comments as done. Meinersbur added a subscriber: rsmith. Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:94 // been "emitted" to the outside, thus, modifications are still sensible. - if (CGM.getLangOpts().OpenMPI

[PATCH] D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:108 + Diag << Inserter.createIncludeInsertion( + Result.SourceManager->getFileID(T.Range.getBegin()), T.Replacement); break; Can this b

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. I just pushed the patch with an slight addition to the summary motivitating why always emitting the predicate metadata: https://github.com/llvm/llvm-project/commit/74ddacd30de54e19b28218bc8563bd0f34f32cad Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

This revision was automatically updated to reflect the committed changes. Closed by commit rG74ddacd30de5: [Clang] Ensure vector predication loop metadata is always emitted when pragma… (authored by malharJ, committed by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 74ddacd - [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Author: Malhar Date: 2021-02-13T17:35:54-06:00 New Revision: 74ddacd30de54e19b28218bc8563bd0f34f32cad URL: https://github.com/llvm/llvm-project/commit/74ddacd30de54e19b28218bc8563bd0f34f32cad DIFF: https://github.com/llvm/llvm-project/commit/74ddacd30de54e19b28218bc8563bd0f34f32cad.diff LOG: [

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 323568. fhahn added a comment. Rebased on top of 51bf4c0e6d4c , which added -ffinite-loops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9641

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. Not sure who can review this, but looking through blame it seems like maybe @aaronpuchert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754 __

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

steveire added a comment. In D96082#2550468 , @LukasHanel wrote: > In D96082#2549943 , @steveire wrote: > >> In D96082#2545807 , @LukasHanel >> wrote: >> >>> Hi, thanks for

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, we need to run this on a large code base to ensure it doesn't make mistakes in real code, but I think this looks good. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta added a comment. Thank @awarzynski for reviewing and explaining the details. I somehow missed it. Should be fixed by https://github.com/llvm/llvm-project/commit/d1ef9a63a68850bbe8cd8877f69c41833804c8dc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] d1ef9a6 - [NFC][Docs] Fix RAVFrontendAction doc's CMakeLists.txt for shared build

Author: Shivam Gupta Date: 2021-02-13T19:48:49+05:30 New Revision: d1ef9a63a68850bbe8cd8877f69c41833804c8dc URL: https://github.com/llvm/llvm-project/commit/d1ef9a63a68850bbe8cd8877f69c41833804c8dc DIFF: https://github.com/llvm/llvm-project/commit/d1ef9a63a68850bbe8cd8877f69c41833804c8dc.diff

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG022920c25b8e: [clangd] Retire clang-tidy-checks flag. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D96508?vs=323011&id=323553#toc Repository: rG LLVM Github Monorepo CHA

[clang-tools-extra] 022920c - [clangd] Retire clang-tidy-checks flag.

Author: Nathan James Date: 2021-02-13T14:14:22Z New Revision: 022920c25b8eb90b0bd0d209a9d0f836743a21bb URL: https://github.com/llvm/llvm-project/commit/022920c25b8eb90b0bd0d209a9d0f836743a21bb DIFF: https://github.com/llvm/llvm-project/commit/022920c25b8eb90b0bd0d209a9d0f836743a21bb.diff LOG:

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

steveire updated this revision to Diff 323551. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96138/new/ https://reviews.llvm.org/D96138 Files: clang-tools-extra/clang-tidy/readability/DeleteNullPointerCheck.cpp

[PATCH] D96139: [clang-tidy] Simplify inaccurate erase check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2f920b987f3: [clang-tidy] Simplify inaccurate erase check (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D96139?vs

[clang-tools-extra] f2f920b - [clang-tidy] Simplify inaccurate erase check

Author: Stephen Kelly Date: 2021-02-13T13:51:27Z New Revision: f2f920b987f3810863b9d0160cbb52df3fa2ab6f URL: https://github.com/llvm/llvm-project/commit/f2f920b987f3810863b9d0160cbb52df3fa2ab6f DIFF: https://github.com/llvm/llvm-project/commit/f2f920b987f3810863b9d0160cbb52df3fa2ab6f.diff LOG:

[PATCH] D96223: [clang-tidy] Simplify static assert check

This revision was automatically updated to reflect the committed changes. Closed by commit rG1709bb8c7395: [clang-tidy] Simplify static assert check (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D96223?vs=322000&id=323549#toc Repository: rG LLVM Github Monorep

[clang-tools-extra] 1709bb8 - [clang-tidy] Simplify static assert check

Author: Stephen Kelly Date: 2021-02-13T13:49:01Z New Revision: 1709bb8c7395418236ec94fe3b9d91fed746452b URL: https://github.com/llvm/llvm-project/commit/1709bb8c7395418236ec94fe3b9d91fed746452b DIFF: https://github.com/llvm/llvm-project/commit/1709bb8c7395418236ec94fe3b9d91fed746452b.diff LOG:

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

awarzynski added a comment. Hi @xgupta , thank you for working on this! It's quite easy to miss dependencies when building with `BUILD_SHARED_LIBS=Off` (i.e. with the default setting - static libs). IIUC, that's what happened here. This example clearly requires the following: - `ASTConsumer` i

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. the LGTM, please mark your comments as done when done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://reviews.llvm.org/D94661 ___ cfe-commits mailing lis

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added a comment. I added the changes to the langref in https://reviews.llvm.org/D96646 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 ___ cfe-commits maili

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

whisperity added a comment. In D96607#2561287 , @njames93 wrote: > I don't see the use case you suggest as a strong enough motivation for this, > clang-format does this job very well and we shouldn't be reinventing the > wheel here. Can you turn all mec

Re: [PATCH] D96244: [clangd] Introduce Modules

oops, d25fbaa4a4a1284e998f545d45280e976c29cc85 should fix the issue. On Sat, Feb 13, 2021 at 2:54 PM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added a comment. > > In D96244#2558345 , @sammccall > wrote: > > > I'm a little

[clang-tools-extra] d25fbaa - [clangd] Fix unsued private field warning

Author: Kadir Cetinkaya Date: 2021-02-13T13:20:15+01:00 New Revision: d25fbaa4a4a1284e998f545d45280e976c29cc85 URL: https://github.com/llvm/llvm-project/commit/d25fbaa4a4a1284e998f545d45280e976c29cc85 DIFF: https://github.com/llvm/llvm-project/commit/d25fbaa4a4a1284e998f545d45280e976c29cc85.dif

[PATCH] D96244: [clangd] Introduce Modules

RKSimon added a comment. In D96244#2558345 , @sammccall wrote: > I'm a little bit nervous about adding this with *no* usage, but it keeps the > patch size down :-) Indeed - this has broken at least one buildbot (http://lab.llvm.org:8011/#/builders/57) d

[PATCH] D96611: [analyzer][tests] Fix issue comparison script

This revision was automatically updated to reflect the committed changes. Closed by commit rG94a1a5d25f55: [analyzer][tests] Fix issue comparison script (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96611/new/ https://revie

[clang] 94a1a5d - [analyzer][tests] Fix issue comparison script

Author: Valeriy Savchenko Date: 2021-02-13T13:58:47+03:00 New Revision: 94a1a5d25f5546019fc5feeb24d924b09b9d27e4 URL: https://github.com/llvm/llvm-project/commit/94a1a5d25f5546019fc5feeb24d924b09b9d27e4 DIFF: https://github.com/llvm/llvm-project/commit/94a1a5d25f5546019fc5feeb24d924b09b9d27e4.d

[libunwind] f042fd4 - [libunwind][cmake] Add an option to enable/disable tests

Author: Kristina Bessonova Date: 2021-02-13T12:49:48+02:00 New Revision: f042fd46b527bea97dfa1e09558700173b70405e URL: https://github.com/llvm/llvm-project/commit/f042fd46b527bea97dfa1e09558700173b70405e DIFF: https://github.com/llvm/llvm-project/commit/f042fd46b527bea97dfa1e09558700173b70405e.

[clang] 39db16e - [test] Make ELF tests less reliant on the lexicographical order of non-local symbols

Author: Fangrui Song Date: 2021-02-13T01:01:06-08:00 New Revision: 39db16e75bd85f9c85a9df1c92a92920006b31b3 URL: https://github.com/llvm/llvm-project/commit/39db16e75bd85f9c85a9df1c92a92920006b31b3 DIFF: https://github.com/llvm/llvm-project/commit/39db16e75bd85f9c85a9df1c92a92920006b31b3.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:908 +CodeGenerator *CodeGenAction::getCodeGenerator() const { + return BEConsumer->getCodeGenerator(); @rjmccall, we were wondering if there is a better way to ask CodeGen to s

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added inline comments. Comment at: clang/include/clang/Frontend/FrontendAction.h:238 /// objects, and run statistics and output file cleanup code. - void EndSourceFile(); + virtual void EndSourceFile(); teemperor wrote: > I think this and the

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 323531. v.g.vassilev marked 21 inline comments as done. v.g.vassilev added a comment. Address more review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/C