[PATCH] D97042: [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

dexonsmith added a comment. In D97042#2576372 , @dexonsmith wrote: > Agreed; LGTM. To be more explicit, here's how I confirmed this is dead code: `warn_drv_libstdcxx_not_found` is the only warning in `DiagGroup<"stdlibcxx-not-found">` and it's only

[PATCH] D97042: [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Agreed; LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97042/new/ https://reviews.llvm.org/D97042

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith added a comment. In D96847#2574408 , @jansvoboda11 wrote: > That's a bit nicer. > > Not sure if `RemarkPattern` is a good name now, as it may represent an > optimization remark that doesn't have any pattern associated with it. > How about

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. > I guess I was confused by the function name Haha, two hardest problems in computer science. :) Changed it to `S.Diags.overloadCandidatesShown(ShownOverloads);` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar updated this revision to Diff 325158. jlebar added a comment. Rename noteNumOverloadCandidatesShown -> overloadCandidatesShown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754 Files:

[clang] 501b4fe - Fixed failing test

Author: Dávid Bolvanský Date: 2021-02-20T07:11:42+01:00 New Revision: 501b4fe4ed7f5de2ae00cbc9da87a5b1141ec47a URL: https://github.com/llvm/llvm-project/commit/501b4fe4ed7f5de2ae00cbc9da87a5b1141ec47a DIFF:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 325155. yubing marked 5 inline comments as done. yubing added a comment. Small fix for some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files:

[clang] ee51c42 - Reduce the number of attributes attached to each function

Author: Dávid Bolvanský Date: 2021-02-20T06:57:47+01:00 New Revision: ee51c42e0060fc98b499312e51a96bc7cf4bcc18 URL: https://github.com/llvm/llvm-project/commit/ee51c42e0060fc98b499312e51a96bc7cf4bcc18 DIFF:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 325152. yubing added a comment. Address the commments above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:211-212 +IRBuilderBase , DomTreeUpdater , +LoopInfo , Value *Row, Value *Col, +

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT created this revision. oToToT added reviewers: jdoerfert, sammccall, ilya-biryukov. oToToT added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

phosek accepted this revision. phosek added a comment. LGTM I'd also suggest renaming `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and `LIBCXX_HERMETIC_STATIC_LIBRARY` to `LIBCXXABI_HIDE_SYMBOLS` and `LIBCXX_HIDE_SYMBOLS` respectively in a follow up change to maintain consistency. Repository: rG

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - maybe the test could be rolled into whatever file is already testing -Wmissing-prototype and the existing special case for "main"? Do you need me to commit this, or can

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325136. tianshilei1992 added a comment. Use CUDA 9.1 for failure test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files:

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325133. tianshilei1992 added a comment. Update to CUDA 9.2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files:

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

ikudrin added a comment. In D96865#2575486 , @gregmiller wrote: > Do you have any suggestions on why we would start seeing above failures after > you commit? Was passing before. From my understanding, the areas seem to be perfectly unrelated.

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

rprichard added a comment. For reference, I know of four ways that LLVM's libunwind is currently linked into programs: - Fuchsia/Windows (i.e. Clang's default behavior): it's part of libc++, e.g.: - Fuchsia: -

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

steven_wu accepted this revision. steven_wu added a comment. My main concern is just that weak alias for libc++abi that never worked for Darwin :) LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu created this revision. zequanwu added reviewers: vsk, efriedma, rnk, pirama. Herald added a subscriber: lxfind. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This solves the problems that D85036

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. Added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 325114. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/no-warn-missing-prototype-efi.c Index:

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu created this revision. zequanwu added reviewers: akhuang, thakis, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97098 Files:

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

danalbert added a comment. It sounds like everyone is happy here but the tools. Could we get a libunwind reviewer (preferably @compnerd, since his review is the red one) to LGTM this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/

[PATCH] D97095: [ASTMatchers] Fix hasUnaryOperand matcher for postfix operators

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97095 Files:

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:90 + } else if (T->isWideCharType()) +Out << "L'" << reinterpret_cast(Val.getLimitedValue(WCHAR_MAX)) +<< "'"; `getLimitedValue` doesn't return a pointer, and the host

[PATCH] D97001: [Coverage] Normalize compilation dir as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3275b18f8979: [Coverage] Normalize compilation dir as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3275b18 - [Coverage] Normalize compilation dir as well

Author: Petr Hosek Date: 2021-02-19T15:29:03-08:00 New Revision: 3275b18f8979ab750e3674f28e7f82c7ef37d2a3 URL: https://github.com/llvm/llvm-project/commit/3275b18f8979ab750e3674f28e7f82c7ef37d2a3 DIFF: https://github.com/llvm/llvm-project/commit/3275b18f8979ab750e3674f28e7f82c7ef37d2a3.diff

[PATCH] D97001: [Coverage] Normalize compilation dir as well

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001 ___

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325101. vvereschaka added a comment. Updated diff in according of the Lint/clang-format recommendations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 Files:

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik updated this revision to Diff 325100. shafik added a comment. Herald added subscribers: usaxena95, kadircet. Fixing tests that I missed before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 Files:

[PATCH] D97001: [Coverage] Normalize compilation dir as well

phosek updated this revision to Diff 325099. phosek added a comment. Test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

craig.topper added a comment. Is this change specific to fixed vectors declared with arm_sve_vector_bits or any of the subclasses of VectorType? If it allows the others, how do we know for sure that there are enough bits in the scalable type for the fixed vector. I ask because RISCV is also

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added a comment. @sepavloff would you add more persons in additional to the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 ___

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka created this revision. vvereschaka added a reviewer: sepavloff. vvereschaka added a project: clang. vvereschaka requested review of this revision. Herald added a subscriber: cfe-commits. Added supporting CC_PRINT_PROC_STAT and CC_PRINT_PROC_STAT_FILE environment variables to trigger

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG55448ab540de: [AArch64] Adding Neon Polynomial vadd Intrinsics (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/

[clang] 55448ab - [AArch64] Adding Neon Polynomial vadd Intrinsics

Author: Christopher Tetreault Date: 2021-02-19T14:48:12-08:00 New Revision: 55448ab540ded21bb2880e52efcf22e07603a096 URL: https://github.com/llvm/llvm-project/commit/55448ab540ded21bb2880e52efcf22e07603a096 DIFF:

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

ctetreau accepted this revision. ctetreau added a comment. LGTM. I'll land it for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

Quuxplusone added inline comments. Comment at: libcxx/include/tuple:971 +_VSTD::get<0>(*this) = _VSTD::forward<_Up1>(__pair.first); +_VSTD::get<1>(*this) = _VSTD::forward<_Up2>(__pair.second); +return *this; Oh, late-breaking nit: I would

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

Quuxplusone accepted this revision. Quuxplusone added a comment. Suggested some ways to improve test coverage, and continued bikeshedding on the SFINAE ;) but there's no reason to hold this up AFAIC. Comment at: libcxx/include/tuple:58 tuple& operator=(const tuple&); -

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

ldionne added a comment. In D93003#2567088 , @steven_wu wrote: > In D93003#2566906 , @rprichard wrote: > >> Maybe this is blocked on someone from Apple reviewing the Mach-O parts? > > This is fine with me for how

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

gregmiller added a comment. Hello, We are seeing failures like below: -- Note: Google Test filter = ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 [==] Running 1 test from 1 test case. [--] Global test environment

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:184 + SourceLocation NewLoc = SM.getLocForStartOfFile(SM.getMainFileID()) + .getLocWithOffset(InputCount + 2); + teemperor wrote: > The `+

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 325071. v.g.vassilev marked 8 inline comments as done. v.g.vassilev added a comment. Address comments from Raphael and Stefan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, tskeith, sscalpone, clementval, AMDChirag, SouraVX. Herald added subscribers: jansvoboda11, dang, jfb. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0923a60ea70f: [clang] Emit type metadata on available_externally vtables for WPD (authored by tejohnson). Repository: rG LLVM Github Monorepo

[clang] 0923a60 - [clang] Emit type metadata on available_externally vtables for WPD

Author: Teresa Johnson Date: 2021-02-19T12:42:34-08:00 New Revision: 0923a60ea70f884d2f170f65d0faa494a25af231 URL: https://github.com/llvm/llvm-project/commit/0923a60ea70f884d2f170f65d0faa494a25af231 DIFF:

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson updated this revision to Diff 325065. tejohnson added a comment. Add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96919/new/ https://reviews.llvm.org/D96919 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. This patch has no effect if the OpenMP IR builder is not enabled, and it's disabled by default. Is that right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. Herald added a subscriber: frasercrmck. Looking back at this I'm not so sure if it was beneficial to divert from the generic behavior and print each function for each prefix. Having a function only in one run line but not the other should work perfectly fine as long

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5355 + Expr *Cond, *Inc; + VarDecl *CounterDecl, *LVDecl; + if (auto *For = dyn_cast(AStmt)) { jdenny wrote: > `CounterDecl` is the declaration of the "loop iteration variable" based on

[PATCH] D97001: [Coverage] Normalize compilation dir as well

vsk added a comment. Would it be straightforward to test this, like we do other filename encodings in abspath.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 +// analysis. +if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable);

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, yaxunl. Herald added a subscriber: ebevhan. Anastasia requested review of this revision. Add documentation that explains how to extend clang with new extensions/features. The guidelines also detail clang's position

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added a comment. Thank you for reviewing this @DavidSpickett ! If you get a chance could you commit this for me? I do not have commit access yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > I think core and

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 +// analysis. +if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable); davidxl wrote: > Is it better to guard it with with if >

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 325036. whisperity retitled this revision from "[clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'" to "[clang-tidy] Suppress reports to similarly used parameters in

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 +// analysis. +if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable); Is it better to guard it with with if

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson updated this revision to Diff 325041. tejohnson added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96919/new/ https://reviews.llvm.org/D96919 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 325039. ldionne added a comment. Fix GCC issues. I swear I had done the same fix locally previously, but I must have messed something up with Git or `arc diff`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 325034. rsanthir.quic added a comment. rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. In D85176#2572661 , @saugustine wrote: > This commit introduced an unused variable warning when built without asserts. > (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 >

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) I think core and optional core features

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1770 - if (!VTable->isDeclarationForLinker()) + if (!VTable->isDeclarationForLinker() || + CGM.getCodeGenOpts().WholeProgramVTables) { Can you add some comment here -- also

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson added a comment. In D96919#2575037 , @davidxl wrote: > So in this case, the virtual call in user code is resolved to a strong > definition in the shared library even though user code also has a derived > class defined? In other words, the

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2884 +Tok.setKind(tok::kw__Static_assert); +Tok.setIdentifierInfo(getIdentifierInfo("_Static_assert")); +MI->AddTokenToBody(Tok); rsmith wrote: > Do we need to give the

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 325029. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files:

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl added a comment. So in this case, the virtual call in user code is resolved to a strong definition in the shared library even though user code also has a derived class defined? In other words, the library provides another overrider definition as the final overrider? Repository: rG

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 325027. rsanthir.quic added a comment. Windows builds were failing due to missing builtins in Intrinsics map CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 Files:

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a368ae3b78d: [CUDA] fix builtin constraints for PTX 7.2 (authored by tra, committed by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/

[clang] 1a368ae - [CUDA] fix builtin constraints for PTX 7.2

Author: Artem Belevich Date: 2021-02-19T09:57:21-08:00 New Revision: 1a368ae3b78dd7a364e8f17658fddaf86b1e98db URL: https://github.com/llvm/llvm-project/commit/1a368ae3b78dd7a364e8f17658fddaf86b1e98db DIFF:

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \ +//

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

rupprecht added a comment. This fixes a build error we're seeing, so I'd like to land this in a bit if that's OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:24 +//its behavior explicitly is deprecated. Therefore the default +//value if false. // avail - minimum OpenCL version supporting it. typo

[PATCH] D97060: [OpenCL] Add ndrange builtin functions to TableGen

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add ndrange builtin functions to TableGen. Also ensure all kernel enqueue

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

This revision was automatically updated to reflect the committed changes. nikic marked an inline comment as done. Closed by commit rG71a8e4e7d6b9: [MemCopyOpt] Enable MemorySSA by default (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[clang] 71a8e4e - [MemCopyOpt] Enable MemorySSA by default

Author: Nikita Popov Date: 2021-02-19T18:06:25+01:00 New Revision: 71a8e4e7d6b947c8b954ec0763ff7969b3879d7b URL: https://github.com/llvm/llvm-project/commit/71a8e4e7d6b947c8b954ec0763ff7969b3879d7b DIFF: https://github.com/llvm/llvm-project/commit/71a8e4e7d6b947c8b954ec0763ff7969b3879d7b.diff

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

zatrazz updated this revision to Diff 325004. zatrazz retitled this revision from "EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)" to "EntryExitInstrumenter: Enable at all optimization levels (PR49143)". zatrazz edited the summary of this revision.

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; Anastasia wrote: >

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. Thanks! I review is shortly. As for now, I also was doing some refactoring: https://reviews.llvm.org/D97058. Check-clang passes, as I see there are no conflicts for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: jfb, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no need to check for enabled pragma for core or

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/test/Flang-Driver/flarge_sizes.f90:1 +! Ensure argument -flarge-sizes works as expected. +! TODO: Add checks when actual codegen is possible for this family awarzynski wrote: > Could you add a `NOOPTION` variant

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324997. arnamoy10 added a comment. Added a missing option test for `-flarge-sizes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \ +//

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis created this revision. joechrisellis added reviewers: c-rhodes, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. In D96771#2571855 , @Anastasia wrote: > This is only the initial patch and for the moment the primary goal is to > remove the need for the flag at least from the clang perspective. Shorter compiler invocation is always nice!

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia created this revision. Anastasia added reviewers: azabaznov, svenvh, mantognini. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. Currently, extension pragma is always added when new OpenCL option (extension or feature) is added to the

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7459-7460 "capture-default specified">; + def note_lambda_variable_capture_fixit : Note< +"capture variable %0 by %select{value|reference}1">; + def

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 324981. njames93 added a comment. Restrict availability of default capture fixit based on init captures already specified. `[=, A]() {}` and `[&, ]() {}` are both invalid as explicit captures can't be specified with the same type as default capture. So we

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov added a comment. This is just a note for me to correctly rebase it in the future: https://reviews.llvm.org/D96090?vs=321602=322422#toc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 ___

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

tskeith added inline comments. Comment at: flang/test/Flang-Driver/fdefault.f90:4 + +! REQUIRES: new-flang-driver + awarzynski wrote: > tskeith wrote: > > Can't this work with the f18 driver too? That's the best way to ensure they > > are consistent. > I think

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl updated this revision to Diff 324971. yaxunl marked 3 inline comments as done. yaxunl added a comment. refactor CGCUDARuntime interface not to expose transformManagedVar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96195/new/ https://reviews.llvm.org/D96195 Files:

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; Btw, I am

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal wrote: > This patch preserves all previous reports as expected. If this patch is technically full-baked and does not bring any harm, can we approve this it as well to move forward? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 324964. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Rebased revision on top of the main branch. Minor improvements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090

  1   2   >