[PATCH] D96195: [HIP] Fix managed variable linkage

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:107 + /// Transform managed variables in device compilation. + virtual void transformManagedVars() = 0; };

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

jonpa added a comment. In D97125#2578853 , @kpn wrote: > System/Z's TEST DATA CLASS instruction covers most (all?) of the possible FP > value states. You might want to subscribe, or add as a reviewer, jonpa just > to make sure everyone stays in sync.

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

nikic added a comment. @uabelho Thanks for the report! This issue should be resolved by https://github.com/llvm/llvm-project/commit/4125afc35723b490556f7a38f7835f0914f70292. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94376/new/

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. I think we should also add tests for half Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 ___ cfe-commits mailing list

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5616c5b8664b: [clang] Tweaked fixit for static assert with no message (authored by njames93). Changed prior to commit:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski requested changes to this revision. awarzynski added a comment. This revision now requires changes to proceed. Hi @arnamoy10 , thanks for the patch! Both `ieee_arithmetic.mod` and `iso_fortran_env.mod` look like copies of similar files from `/tools/flang/include/flang`. Could you

[clang] 5616c5b - [clang] Tweaked fixit for static assert with no message

Author: Nathan James Date: 2021-02-22T17:43:53Z New Revision: 5616c5b8664b54671e699e5c45178f11cbb680b3 URL: https://github.com/llvm/llvm-project/commit/5616c5b8664b54671e699e5c45178f11cbb680b3 DIFF: https://github.com/llvm/llvm-project/commit/5616c5b8664b54671e699e5c45178f11cbb680b3.diff LOG:

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki created this revision. miyuki added a reviewer: rsmith. Herald added subscribers: dexonsmith, lebedev.ri, martong, arphaman, kbarton, hiraditya, mgorny, nemanjai. Herald added a reviewer: lebedev.ri. miyuki requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D97161: Improve diagnostic for ignored GNU 'used' attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGbccdf6b232f6: Improve diagnostic for ignored GNU used attribute (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97161/new/

[clang] bccdf6b - Improve diagnostic for ignored GNU 'used' attribute

Author: Fangrui Song Date: 2021-02-22T09:18:13-08:00 New Revision: bccdf6b232f67aa4e91f18d49700308f2815ca09 URL: https://github.com/llvm/llvm-project/commit/bccdf6b232f67aa4e91f18d49700308f2815ca09 DIFF: https://github.com/llvm/llvm-project/commit/bccdf6b232f67aa4e91f18d49700308f2815ca09.diff

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. When `__cl_clang_function_pointers` extension is enabled clang should allow obtaining the function address. FYI, taking function

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

aeubanks added a comment. code looks good, just some test nits Comment at: llvm/test/Transforms/EntryExitInstrumenter/mcount.ll:1 -; RUN: opt -passes="function(ee-instrument),cgscc(inline),function(post-inline-ee-instrument)" -S < %s | FileCheck %s +; RUN: opt --O0

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 + +New checks +^^ Please rebase from trunk. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:79 + +Finds calls to ``new`` that may throw

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12055 + if (auto *SourceVT = dyn_cast(Source)) { +if (Target->isSizelessBuiltinType()) { + auto SourceVectorKind = SourceVT->getVectorKind(); c-rhodes wrote: > I suppose

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis updated this revision to Diff 325461. joechrisellis marked an inline comment as done. joechrisellis added a comment. Address @c-rhodes's comment. - use `isVLSTBuiltinType` instead of `isSizelessBuiltinType`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:695 + if (Insert.empty() && FixIt.InsertFromRange.isValid()) { +bool InvalidInsert = false; +Insert = Lexer::getSourceText(FixIt.InsertFromRange, SM, *LangOpts,

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:552 Result.newText = FixIt.CodeToInsert; + if (Result.newText.empty() && FixIt.InsertFromRange.isValid()) { +bool Invalid = false; oh btw, i think the condition should

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

kadircet added a comment. mostly LG, can you also add some tests? Comment at: clang-tools-extra/clangd/Diagnostics.cpp:695 + if (Insert.empty() && FixIt.InsertFromRange.isValid()) { +bool InvalidInsert = false; +Insert =

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal > I would like @NoQ or someone else to also review this. Oh, I would be very pleased if our colleagues pay attention to my recent patches. But seems you are the only who helps me with this stuff  CHANGES SINCE LAST ACTION

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 added a comment. In D97132#2578992 , @aaron.ballman wrote: >> Fix potential crash if macros are used, Now we just don't try to emit a fix. > > Can you add a test case that covers this change? I can try, but I'm not sure of the exact cause of

[PATCH] D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ABataev, grokos, ye-luo. Herald added subscribers: guansong, yaxunl, mgorny. tianshilei1992 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin updated this revision to Diff 325455. darwin added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

aaron.ballman added a comment. > Fix potential crash if macros are used, Now we just don't try to emit a fix. Can you add a test case that covers this change? Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:105 + return

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 325453. balazske added a comment. Rebase, improved documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files:

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; svenvh wrote: >

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman added inline comments. Comment at: clang/test/FixIt/fixit-static-assert.cpp:2-3 +// RUN: %clang_cc1 -std=c++14 %s -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s +// Ensure no warnings are emitted in c++17. +// RUN: %clang_cc1 -std=c++17 %s -Werror

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > Anastasia wrote: > >

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 325452. njames93 marked an inline comment as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files:

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/test/FixIt/fixit-static-assert.cpp:2-3 +// RUN: %clang_cc1 -std=c++14 %s -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s +// Ensure no warnings are emitted in c++17. +// RUN:

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. FYI, I would even be ok if we remove the need for enabling non-core features too but it is also fine to start from just core features. Thanks! Comment at: clang/lib/Sema/Sema.cpp:360 setOpenCLExtensionForType(Context.DoubleTy, "cl_khr_fp64");

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

This revision was automatically updated to reflect the committed changes. Closed by commit rG76151acf893a: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 76151ac - [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

Author: Shilei Tian Date: 2021-02-22T11:00:33-05:00 New Revision: 76151acf893ac7bdaf460fdfe8a8494cf477157a URL: https://github.com/llvm/llvm-project/commit/76151acf893ac7bdaf460fdfe8a8494cf477157a DIFF: https://github.com/llvm/llvm-project/commit/76151acf893ac7bdaf460fdfe8a8494cf477157a.diff

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 325449. ldionne added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106 Files: libcxx/include/tuple

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity, mgorny. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne added a comment. I think we should be pretty much good to go now. Will let CI run just in case. Comment at: libcxx/include/tuple:971 +_VSTD::get<0>(*this) = _VSTD::forward<_Up1>(__pair.first); +_VSTD::get<1>(*this) = _VSTD::forward<_Up2>(__pair.second);

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 325445. ldionne marked 6 inline comments as done. ldionne added a comment. Address Arthur's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106 Files:

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:861 + SourceLocation EndExprLoc) { + if

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

kpn added a comment. System/Z's TEST DATA CLASS instruction covers most (all?) of the possible FP value states. You might want to subscribe, or add as a reviewer, jonpa just to make sure everyone stays in sync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97191: [clang][NFC] Reorder CXXCtorInitializer members

This revision was automatically updated to reflect the committed changes. Closed by commit rGdaeb70be0bd4: [clang][NFC] Reorder CXXCtorInitializer members (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97191/new/

[clang] daeb70b - [clang][NFC] Reorder CXXCtorInitializer members

Author: Nathan James Date: 2021-02-22T15:25:33Z New Revision: daeb70be0bd42fbed66c03b4c5f9940ffba88ce9 URL: https://github.com/llvm/llvm-project/commit/daeb70be0bd42fbed66c03b4c5f9940ffba88ce9 DIFF: https://github.com/llvm/llvm-project/commit/daeb70be0bd42fbed66c03b4c5f9940ffba88ce9.diff LOG:

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. In D96090#2574526 , @ASDenysPetrov wrote: > @steakhal wrote: > >> This patch preserves all previous reports as expected. Even with or without Z3 refutation. > If this patch is technically full-baked and does not bring any

[PATCH] D97191: [clang][NFC] Reorder CXXCtorInitializer members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97191/new/ https://reviews.llvm.org/D97191

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

JonChesterfield accepted this revision. JonChesterfield added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 ___ cfe-commits mailing list

[PATCH] D97191: [clang][NFC] Reorder CXXCtorInitializer members

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Swapping the order of Init and MemberOrEllipsisLocation removes 8 bytes (20%) of padding on 64bit

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2578765 , @thakis wrote: > In D96515#2578666 , @Anastasia wrote: > >> In D96515#2578629 , @thakis wrote: >> >>> Looks like this breaks

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. In D96877#2578756 , @ye-luo wrote: > In D96877#2578752 , @tianshilei1992 > wrote: > >> In D96877#2578748 , @ye-luo wrote: >> >>> to me this

[clang-tools-extra] b71add9 - [pp-trace] Fix test for OpenCL pragmas.

Author: Anastasia Stulova Date: 2021-02-22T14:28:45Z New Revision: b71add9777bed67e05206fa1fdb665f3e21a13ab URL: https://github.com/llvm/llvm-project/commit/b71add9777bed67e05206fa1fdb665f3e21a13ab DIFF: https://github.com/llvm/llvm-project/commit/b71add9777bed67e05206fa1fdb665f3e21a13ab.diff

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

thakis added a comment. In D96515#2578666 , @Anastasia wrote: > In D96515#2578629 , @thakis wrote: > >> Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt >> >> Please take a look, and revert

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo added a comment. In D96877#2578752 , @tianshilei1992 wrote: > In D96877#2578748 , @ye-luo wrote: > >> to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc >> as a solution for forward

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. In D96877#2578748 , @ye-luo wrote: > to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as > a solution for forward compatibility until a clean solution lands. We’ll have newer version LLVM like

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo added a comment. to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as a solution for forward compatibility until a clean solution lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added a comment. I think we might not this patch. We’re gonna not support old version of CUDA anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 added a comment. If there is no objection, I’ll merge it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 ___ cfe-commits mailing list

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 updated this revision to Diff 325428. njames93 added a comment. Fix potential crash if macros are used, Now we just don't try to emit a fix. Fix issue where FixIt for member initializers would be inserted at the start of the constructor decl due to implicit member initializers confusing

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

gregmiller added a comment. Hello, we are seeing failures like below: Note: Google Test filter = ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

goncharov added a comment. I have relanded this in https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d . My apologies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 325425. ABataev added a comment. Temp update, not finished yet. Still WIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files:

[clang] 3b148d6 - Revert "Revert "Revert "Implement nullPointerConstant() using a better API."""

Author: Mikhail Goncharov Date: 2021-02-22T14:37:03+01:00 New Revision: 3b148d6f991181a1b8f089c4bc2126e1a6c1212d URL: https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d DIFF:

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

njames93 added a comment. In D61989#2578687 , @DmitryPolukhin wrote: > Everyone please speak up if there is a good reason to limit this check to the > main file only. The only possible reason I can see to limit to main file only is if the header is

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

DmitryPolukhin added a comment. @shixiao do you have plans to keep working on this diff? If not, do you have any objections if I send for review a similar diff that will eliminate the check `Sources.isInMainFile` and will rely on generic header filtration mechanism in clang-tidy? We have

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a subscriber: klimek. Anastasia added a comment. In D96515#2578666 , @Anastasia wrote: > In D96515#2578629 , @thakis wrote: > >> Looks like this breaks tests:

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2578629 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for pointing this out. I think the

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added a comment. In D97053#2575791 , @craig.topper wrote: > Is this change specific to fixed vectors declared with arm_sve_vector_bits or > any of the subclasses of VectorType? If it allows the others, how do we know > for sure that there are

[PATCH] D96838: Add GNU attribute 'retain'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2655 + +def Retain : InheritableAttr { + let Spellings = [GCC<"retain">]; MaskRay wrote: > aaron.ballman wrote: > > Should this be a target-specific attribute as it only has

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

goncharov added a comment. Hi @steveire! Sorry but I reverted this revert. Could you please give some context of "discussed elsewhere" and "pre-existing unit test for the matcher"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/

[PATCH] D96777: [clang][driver] Set the input type to Fortran when reading from stdin

hans added a comment. In D96777#2578473 , @awarzynski wrote: > In D96777#2578153 , @SouraVX wrote: > >> Thanks! for the patch. >> This code touches some of the `clang` part, Anyway changes are pretty >>

[clang] ba1d954 - Revert "Revert "Implement nullPointerConstant() using a better API.""

Author: Mikhail Goncharov Date: 2021-02-22T13:43:42+01:00 New Revision: ba1d9546ee389ce1d2e8f353ae777a65f647d508 URL: https://github.com/llvm/llvm-project/commit/ba1d9546ee389ce1d2e8f353ae777a65f647d508 DIFF:

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/

[PATCH] D97161: Improve diagnostic for ignored GNU 'used' attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you, that's a much better diagnostic than the original! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97161/new/

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3ef15a6ec5: [OpenCL] Add builtin declarations by default. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cf3ef15 - [OpenCL] Add builtin declarations by default.

Author: Anastasia Stulova Date: 2021-02-22T12:24:16Z New Revision: cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce URL: https://github.com/llvm/llvm-project/commit/cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce DIFF: https://github.com/llvm/llvm-project/commit/cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce.diff

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

DavidSpickett added inline comments. Comment at: clang/test/CodeGen/aarch64-neon-range-checks.c:31 vsm3tt2bq_u32(a, b, c, 0); + +void test_range_check_xar(uint64x2_t a, uint64x2_t b) { I added a "}" here. Please run ninja check-clang and/or check-llvm before

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c25efcbd322: [AArch64] Adding SHA3 Intrinsics support (authored by rsanthir.quic, committed by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D96381?vs=324711=325416#toc

[clang] 2c25efc - [AArch64] Adding SHA3 Intrinsics support

Author: Ryan Santhiraraja Date: 2021-02-22T12:09:20Z New Revision: 2c25efcbd322c58b62e592a8265ef83803f0e7b9 URL: https://github.com/llvm/llvm-project/commit/2c25efcbd322c58b62e592a8265ef83803f0e7b9 DIFF: https://github.com/llvm/llvm-project/commit/2c25efcbd322c58b62e592a8265ef83803f0e7b9.diff

[PATCH] D97119: [flang][driver] Add options for -std=2018

awarzynski added a comment. Hi @arnamoy10 , thank for working on this! I suggest making it more explicit that the new option is about _enabling standard conformance checks_. So e.g. `enableConformanceChecks` rather than `setStandard` (or `set_EnableConformanceChecks` if the member variable is

[PATCH] D96719: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dc7f0c2ecc0: [clang-tidy] Add new check concurrency-thread-canceltype-asynchronous and… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 7dc7f0c - [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

Author: Balázs Kéri Date: 2021-02-22T12:42:20+01:00 New Revision: 7dc7f0c2ecc05b9a9c73e89facec24ad6d325cae URL: https://github.com/llvm/llvm-project/commit/7dc7f0c2ecc05b9a9c73e89facec24ad6d325cae DIFF: https://github.com/llvm/llvm-project/commit/7dc7f0c2ecc05b9a9c73e89facec24ad6d325cae.diff

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis updated this revision to Diff 325410. joechrisellis added a comment. Address comments. - @c-rhodes: remove test; it is probably not necessary. - @craig.topper: add better constraints for when we do/don't bail out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. Is this obsolete with the change to devicertl cmake? Would prefer abandon to land if so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877

[PATCH] D97138: [Driver] replace argc_ with argc

awarzynski requested changes to this revision. awarzynski added a comment. This revision now requires changes to proceed. Thank you for submitting this @achieveartificialintelligence ! The aim of these changes is to improve the consistency of the code-base with respect to the coding standards

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

steveire added a comment. In D96114#2548029 , @klimek wrote: > Can you explain the change and the before/after a bit more? Thanks! I'm not sure. Can you ask a more-specific question? Did you read the link that Nathan posted? Is the unit test unclear?

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire added a comment. Good catch! Updated the docs generating script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 ___ cfe-commits mailing list

[clang] b5b3243 - Regenerate documentation

Author: Stephen Kelly Date: 2021-02-22T11:07:45Z New Revision: b5b3243bf783f07415c5e2838fa1a948e126f643 URL: https://github.com/llvm/llvm-project/commit/b5b3243bf783f07415c5e2838fa1a948e126f643 DIFF: https://github.com/llvm/llvm-project/commit/b5b3243bf783f07415c5e2838fa1a948e126f643.diff

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire updated this revision to Diff 325409. steveire added a comment. Update dump script Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 Files: clang/docs/tools/dump_ast_matchers.py

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. Looks fine to me. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:466-467 + return; +OS << "Obtained null inner pointer from"; +checkAndPrettyPrintRegion(OS, ThisRegion); + })); You should emit a

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. In D96847#2576369 , @dexonsmith wrote: > In D96847#2574408 , @jansvoboda11 > wrote: > >> That's a bit nicer. >> >> Not sure if `RemarkPattern` is a good name now, as it may represent

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 325408. jansvoboda11 added a comment. Comment wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 325407. jansvoboda11 added a comment. Rename `RemarkPattern` to `OptRemark`, simplify the API usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files:

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

awarzynski added a comment. Thanks for reviewing @SouraVX ! I did update that comment before merging. Hopefully it _will_ make sense when we come back to it at later time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96864/new/

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGd81f633fe28f: [flang][driver] Add -Xflang and make -test-io a frontend-only flang (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D96864?vs=324287=325405#toc Repository:

[clang] d81f633 - [flang][driver] Add -Xflang and make -test-io a frontend-only flang

Author: Andrzej Warzynski Date: 2021-02-22T10:11:43Z New Revision: d81f633fe28fd23108b4dc8c25548f1653ba0cd2 URL: https://github.com/llvm/llvm-project/commit/d81f633fe28fd23108b4dc8c25548f1653ba0cd2 DIFF: https://github.com/llvm/llvm-project/commit/d81f633fe28fd23108b4dc8c25548f1653ba0cd2.diff

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rG38b185832e04: [analyzer][CTU] API for CTU macro expansions (authored by steakhal, committed by Balazs Benics balazsben...@sigmatechnology.se). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 38b1858 - [analyzer][CTU] API for CTU macro expansions

Author: Balazs Benics Date: 2021-02-22T11:12:22+01:00 New Revision: 38b185832e04ed0588c43161f5c3a8c0ce267497 URL: https://github.com/llvm/llvm-project/commit/38b185832e04ed0588c43161f5c3a8c0ce267497 DIFF: https://github.com/llvm/llvm-project/commit/38b185832e04ed0588c43161f5c3a8c0ce267497.diff

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c58fb6ba04e: [analyzer] Create MacroExpansionContext member in AnalysisConsumer (authored by steakhal, committed by Balazs Benics balazsben...@sigmatechnology.se). Repository: rG LLVM Github Monorepo

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e3071007b4c: [analyzer] Introduce MacroExpansionContext to libAnalysis (authored by steakhal, committed by Balazs Benics balazsben...@sigmatechnology.se). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7c58fb6 - [analyzer] Create MacroExpansionContext member in AnalysisConsumer

Author: Balazs Benics Date: 2021-02-22T11:12:14+01:00 New Revision: 7c58fb6ba04e28e594587bb27f13849cc1f2d305 URL: https://github.com/llvm/llvm-project/commit/7c58fb6ba04e28e594587bb27f13849cc1f2d305 DIFF: https://github.com/llvm/llvm-project/commit/7c58fb6ba04e28e594587bb27f13849cc1f2d305.diff

[clang] 6e30710 - [analyzer] Introduce MacroExpansionContext to libAnalysis

Author: Balazs Benics Date: 2021-02-22T11:11:57+01:00 New Revision: 6e3071007b4c9438d2ae49476de87db30d6d24e9 URL: https://github.com/llvm/llvm-project/commit/6e3071007b4c9438d2ae49476de87db30d6d24e9 DIFF: https://github.com/llvm/llvm-project/commit/6e3071007b4c9438d2ae49476de87db30d6d24e9.diff

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

steveire updated this revision to Diff 325398. steveire added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97158/new/ https://reviews.llvm.org/D97158 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D97138: [Driver] replace argc_ with argc

jhenderson resigned from this revision. jhenderson added a comment. In general, I don't work on the clang side. As such, I don't know the norms surrounding this sort of change in this area, and don't feel comfortable reviewing. You should look at getting reviewers who do work in that part of

<    1   2   3   >