[clang-tools-extra] 8080ea4 - [clangd] Enable reflection for clangd-index-server

Author: Kirill Bobyrev Date: 2021-03-10T09:07:39+01:00 New Revision: 8080ea4c4b8c456c72c617587cc32f174b3105c1 URL: https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1 DIFF: https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1.diff

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329553. kbobyrev marked an inline comment as done. kbobyrev added a comment. Enabled server reflection in https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov updated this revision to Diff 329554. azabaznov added a comment. Corrected some mistakes, added a test for diagnosing undeclared identifiers when a extension is unsupported. Generally leaving the change as it is as completely removing pragma may break backward compatibility now: let's

[clang] ea8e5b8 - [NFC] Remove duplicate isNoBuiltinFunc method

Author: serge-sans-paille Date: 2021-03-10T09:18:55+01:00 New Revision: ea8e5b87acba4b7dad749d697a3969901652b97a URL: https://github.com/llvm/llvm-project/commit/ea8e5b87acba4b7dad749d697a3969901652b97a DIFF: https://github.com/llvm/llvm-project/commit/ea8e5b87acba4b7dad749d697a3969901652b97a.d

[PATCH] D98175: [NFC] Remove duplicate isNoBuiltinFunc method

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8e5b87acba: [NFC] Remove duplicate isNoBuiltinFunc method (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D98175: [NFC] Remove duplicate isNoBuiltinFunc method

serge-sans-paille added a comment. That was a very convincing argument :-) tag added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98175/new/ https://reviews.llvm.org/D98175 ___ cfe-commits mailing list

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:332-340 if (Changes[ScopeStart - 1].Tok->is(TT_FunctionDeclarationName) || (ScopeStart > Start + 1 && Changes[ScopeStart - 2].Tok->is(TT_FunctionDeclarationName)) || +

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 329559. massberg added a comment. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://reviews.llvm.org/D98070 Files: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComp

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. There are some side effects: because -D is passed as command line options, it has `` in its filename, so `isWrittenInBuiltinFile` will not match it (`isWrittenInBuiltinFile` can match other built-in macros)... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov updated this revision to Diff 329560. azabaznov added a comment. Replaced atomic_double implicit definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058 Files: clang/include/clang/Basic/Diagn

[PATCH] D46443: [libc++] Add missing cstdalign header

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > curdeius wrote: > > curdeius wrot

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Service.proto:13 +import "google/protobuf/empty.proto"; import "Index.proto"; sammccall wrote: > question of style, but unless there's a concrete benefit I'd suggest just > defi

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Service.proto:16 +message MonitoringInfoReply { optional string info = 1; } + sammccall wrote: > kadircet wrote: > > i am not sure if having more structure here immediately vs. i

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

lebedev.ri added a comment. Please also add a test with global `IgnoreMacros=1` and `readability-function-cognitive-complexity.IgnoreMacros` unset. (The code is correct as-is, global `IgnoreMacros` should not affect the check here.) I'm also somewhat worried about forward compatibility. If in f

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. In D93938#2614825 , @HazardyKnusperkeks wrote: > If the bugs are (very) similar, I could live with one fix for both. Otherwise > you should fix the other bug first, if its blocking this change. The only thing linking the bugs is

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 329574. Max_S added a comment. Updating D98237 : [clang-format] Option for empty lines after an access modifier. - Added additional verification tests - Added expected formating tests - Changed comment to reflect the new logic

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. In D98237#2614844 , @HazardyKnusperkeks wrote: > I would like additional tests: > > - With at least 2 empty lines > - With 0-2 empty lines without `verifyFormat` to demonstrate what is kept, > added, and removed. Thank you for rev

[clang] 6f912a2 - [OpenCL] Set calling convention for -fdeclare-opencl-builtins

Author: Sven van Haastregt Date: 2021-03-10T10:03:57Z New Revision: 6f912a2cd49150813ee467c079201b5ce3dfbbca URL: https://github.com/llvm/llvm-project/commit/6f912a2cd49150813ee467c079201b5ce3dfbbca DIFF: https://github.com/llvm/llvm-project/commit/6f912a2cd49150813ee467c079201b5ce3dfbbca.diff

[PATCH] D98039: [OpenCL] Set calling convention for -fdeclare-opencl-builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f912a2cd491: [OpenCL] Set calling convention for -fdeclare-opencl-builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98039/new/ h

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284 (!PreviousLine->InPPDirective || !RootToken.HasUnescapedNewline)) -Newlines = std::min(1u, Newlines); +Newlines = Style.EmptyLinesAfterAccessModifier + 1u;

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm added a comment. @SjoerdMeijer @dmgreen Thanks for your reviews, I will be looking into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 ___ cfe-

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1495 let DecoderNamespace = "Fallback"; + let Defs = [NZCV]; } SjoerdMeijer wrote: > dmgreen wrote: > > SjoerdMeijer wrote: > > > dmgreen wrote: > > > > SjoerdMeij

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. Just out of interest and we are supposed to ask for this but can you point to public style guide that uses this style. (actually I don't mind if other formatting tools have this capability and you highlight it, like astyle or editorConfig etc) From my perspect

[PATCH] D98329: [clangd] Add cache for FID to Header mappings

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D98242

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn updated this revision to Diff 329596. fhahn added a comment. rebase & added a matrix_types_scalar_division feature, which allows users to check if the current version of clang is new enough to support it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( everton.constantino wrote: > Shouldn't a test for half floating point be added here as well? Thanks for taking a loo

[clang] 57e149d - [analyzer][docs][NFC] Fix typo in checkers.rst

Author: Balazs Benics Date: 2021-03-10T12:42:23+01:00 New Revision: 57e149d386286031e0fd118acf162056ce9d4795 URL: https://github.com/llvm/llvm-project/commit/57e149d386286031e0fd118acf162056ce9d4795 DIFF: https://github.com/llvm/llvm-project/commit/57e149d386286031e0fd118acf162056ce9d4795.diff

[clang] 0dc0e2a - [analyzer][NFC] Add more tests for ArrayBoundCheckerV2

Author: Balazs Benics Date: 2021-03-10T12:42:23+01:00 New Revision: 0dc0e2a9ab3cc6be3d4012ea861f54e69854472d URL: https://github.com/llvm/llvm-project/commit/0dc0e2a9ab3cc6be3d4012ea861f54e69854472d DIFF: https://github.com/llvm/llvm-project/commit/0dc0e2a9ab3cc6be3d4012ea861f54e69854472d.diff

[PATCH] D97936: [analyzer][docs][NFC] Fix typo in checkers.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rG57e149d38628: [analyzer][docs][NFC] Fix typo in checkers.rst (authored by Balazs Benics ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 0e0ea9f - [analyzer][CTU][NFC] Add an extra regression test

Author: Balazs Benics Date: 2021-03-10T12:42:24+01:00 New Revision: 0e0ea9ffb8027b2e785b383d66b06bbd92dc7a46 URL: https://github.com/llvm/llvm-project/commit/0e0ea9ffb8027b2e785b383d66b06bbd92dc7a46 DIFF: https://github.com/llvm/llvm-project/commit/0e0ea9ffb8027b2e785b383d66b06bbd92dc7a46.diff

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dc0e2a9ab3c: [analyzer][NFC] Add more tests for ArrayBoundCheckerV2 (authored by Balazs Benics ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] bcc6624 - [analyzer] Crash fix for alpha.cplusplus.IteratorRange

Author: Adam Balogh Date: 2021-03-10T12:42:24+01:00 New Revision: bcc662484a95c95f7d193e6a791fc5d1c4a2c74f URL: https://github.com/llvm/llvm-project/commit/bcc662484a95c95f7d193e6a791fc5d1c4a2c74f DIFF: https://github.com/llvm/llvm-project/commit/bcc662484a95c95f7d193e6a791fc5d1c4a2c74f.diff L

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e0ea9ffb802: [analyzer][CTU][NFC] Add an extra regression test (authored by Balazs Benics ). Repository: rG LLVM

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc662484a95: [analyzer] Crash fix for alpha.cplusplus.IteratorRange (authored by baloghadamsoftware, committed by Balazs Benics ). Changed prior to commit: https://rev

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

thakis added a comment. The test doesn't pass: http://45.33.8.238/linux/41341/step_7.txt I think you just need to say `rm -rf` instead of `rm -r` on line 3 (?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96586/new/ https://reviews.llvm.org/D9658

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia updated this revision to Diff 329602. Anastasia added a comment. Added sentence to elaborate the meaning of "useful". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97072/new/ https://reviews.llvm.org/D97072 Files: clang/docs/OpenCLSupport.rst clang/lib/Driver/Types.cpp I

[PATCH] D82900: [analyzer][Z3-refutation] Add statistics tracking invalidated bug report classes

steakhal abandoned this revision. steakhal added a comment. It might be useful in the future, but right now, I'm not interested in upstreaming this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82900/new/ https://reviews.llvm.org/D82900

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

steakhal abandoned this revision. steakhal added a comment. It might be useful in the future, but right now, I'm not interested in upstreaming this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82856/new/ https://reviews.llvm.org/D82856 ___

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM with the latest elaboration on "useful". It seems you accidentally added unrelated changes to Types.cpp to this review, so please take care not to commit those. CHANGES SINCE LAST ACTI

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia updated this revision to Diff 329605. Anastasia added a comment. Fixed patch reupload issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97072/new/ https://reviews.llvm.org/D97072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst ==

[clang] a94ac46 - [analyzer][CTU][NFC] Fix "Add an extra regression test"

Author: Balazs Benics Date: 2021-03-10T13:07:49+01:00 New Revision: a94ac467c2974d9afe68f3fe6cff27bd19bcfad0 URL: https://github.com/llvm/llvm-project/commit/a94ac467c2974d9afe68f3fe6cff27bd19bcfad0 DIFF: https://github.com/llvm/llvm-project/commit/a94ac467c2974d9afe68f3fe6cff27bd19bcfad0.diff

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

steakhal added a comment. In D96586#2616292 , @thakis wrote: > The test doesn't pass: http://45.33.8.238/linux/41341/step_7.txt > > I think you just need to say `rm -rf` instead of `rm -r` on line 3 (?) I hope a94ac467c2974d9afe68f3fe6cff27bd19bcfad0

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG523d7bc6f427: [flang][driver] Add `-fdebug-dump-parsing-log` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D97457?vs

[clang] 523d7bc - [flang][driver] Add `-fdebug-dump-parsing-log`

Author: Andrzej Warzynski Date: 2021-03-10T12:09:16Z New Revision: 523d7bc6f427f9ae32e54dbf1764826cfb269d21 URL: https://github.com/llvm/llvm-project/commit/523d7bc6f427f9ae32e54dbf1764826cfb269d21 DIFF: https://github.com/llvm/llvm-project/commit/523d7bc6f427f9ae32e54dbf1764826cfb269d21.diff

[PATCH] D93164: [AST] Add generator for source location introspection

njames93 added a comment. This is almost ready but a few more points need addressing. Running clang-format over the inc file is pointless and just extends compilation time while adding an unnecessary dependency on clang-format. The inc file should likely live in the include build directory, All t

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia updated this revision to Diff 329617. Anastasia added a comment. Added corrections from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98076/new/ https://reviews.llvm.org/D98076 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ===

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:214 +- Added ``global_device`` and ``global_host`` address spaces for USM + allocations. + svenvh wrote: > Perhaps one more point to mention: > `

[PATCH] D98321: [NFC] Unify FIME with FIXME in comments

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thanks for the fix! I'll get it landed for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98321/new/ https://reviews.llvm.org/D9

[clang-tools-extra] 481079e - [NFC] Unify FIME with FIXME in comments

Author: Jinzheng Tu Date: 2021-03-10T14:00:51+01:00 New Revision: 481079e2841f1d7aafbbd627e7028bcc632a4ef7 URL: https://github.com/llvm/llvm-project/commit/481079e2841f1d7aafbbd627e7028bcc632a4ef7 DIFF: https://github.com/llvm/llvm-project/commit/481079e2841f1d7aafbbd627e7028bcc632a4ef7.diff L

[clang-tools-extra] 99b01cf - Revert "[clangd] Enable reflection for clangd-index-server"

Author: Kadir Cetinkaya Date: 2021-03-10T14:12:37+01:00 New Revision: 99b01cf28db9db1a3ec0e25367bd325b7aca6d43 URL: https://github.com/llvm/llvm-project/commit/99b01cf28db9db1a3ec0e25367bd325b7aca6d43 DIFF: https://github.com/llvm/llvm-project/commit/99b01cf28db9db1a3ec0e25367bd325b7aca6d43.dif

[PATCH] D98321: [NFC] Unify FIME with FIXME in comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481079e2841f: [NFC] Unify FIME with FIXME in comments (authored by b1f6c1c4, committed by alexfh). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D98296: [clang-tidy] Simplify readability checks to not need ignoring* matchers

njames93 added a comment. Please address the format issues. Comment at: clang-tools-extra/clang-tidy/readability/UniqueptrDeleteReleaseCheck.cpp:45 callee( memberExpr(hasObjectExpression(allOf( any

[PATCH] D98337: Add support for digit separators in C2x

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, jyknight, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. WG14 adopted N2626 at the meetings this week. This proposal adds support for using `'` as a digit separator in a numeric

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97871: Update diagnostic groups for pre-compat warnings

aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97871/new/ https://reviews.llvm.org/D97871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D98338: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://llvm.org/PR9492. Repository: rG LLVM Github Mo

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, but maybe give this another 24h before landing in case there are any remaining concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D9677

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2615926 , @azabaznov wrote: > Corrected some mistakes, added a test for diagnosing undeclared identifiers > when an extension is unsupported. Generally leaving the change as it is as > completely removing pragma may b

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Although some further improvements seem to be necessary they can be done separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang] 25951c5 - [AArch64] Add missing intrinsics for scalar FP rounding

Author: Jingu Kang Date: 2021-03-10T13:22:29Z New Revision: 25951c5ab8e9d8e4040de163f06c444c73314551 URL: https://github.com/llvm/llvm-project/commit/25951c5ab8e9d8e4040de163f06c444c73314551 DIFF: https://github.com/llvm/llvm-project/commit/25951c5ab8e9d8e4040de163f06c444c73314551.diff LOG: [A

[PATCH] D98269: [AArch64] Add missing intrinsics for scalar fp rounding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25951c5ab8e9: [AArch64] Add missing intrinsics for scalar FP rounding (authored by jaykang10). Herald added a project: clang. Herald added a subscrib

[clang-tools-extra] 7044f1d - [clangd] Use Dirty Filesystem for cross file rename.

Author: Nathan James Date: 2021-03-10T13:41:29Z New Revision: 7044f1d875e37a5badd4e59ee84b56faf7432f68 URL: https://github.com/llvm/llvm-project/commit/7044f1d875e37a5badd4e59ee84b56faf7432f68 DIFF: https://github.com/llvm/llvm-project/commit/7044f1d875e37a5badd4e59ee84b56faf7432f68.diff LOG:

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7044f1d875e3: [clangd] Use Dirty Filesystem for cross file rename. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95043/new/ https://

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/device-use-host-var.cu:41 *out = global_const_var; + *out = global_const_struct_var.x; tra wrote: > I do not think it should be allowed. We end up instant

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

steakhal added a comment. I would suggest **not** merging this patch. Circumventing the `assume` machinery could cause potential crashes. By tracking equivalence classes and whatnot, our solver is becoming more and more capable. Doing a bifurcation, then realizing that the current path is infea

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 329632. yaxunl marked an inline comment as done. yaxunl added a comment. Follow C++ about ODR-use of variables. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Sema/SemaExpr.cpp clang/tes

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. > Ok, addressing in a separate patch is reasonable, but why do you think that > we will break backward compatibility? My current worry is that the > implementation is so messy and inconsistent that it will take us longer time > if we do the incremental steps. Also, we

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. In D98237#2616193 , @MyDeveloperDay wrote: > Just out of interest and we are supposed to ask for this but can you point to > public style guide that uses this style. (actually I don't mind if other > formatting tools have this c

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

steakhal added a comment. I'm looking forward to this patch. Comment at: clang/test/Analysis/string.c:367-373 +void *func_strcpy_no_assertion(); +char ***ptr_strcpy_no_assertion; +void strcpy_no_assertion() { + *(unsigned char **)ptr_strcpy_no_assertion = (unsigned char *)(fu

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

vsavchenko created this revision. vsavchenko added reviewers: steakhal, NoQ, xazax.hun, ASDenysPetrov. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

vsavchenko added a comment. @steakhal I personally don't see any fundamental problems with this patch Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:878 + // Integer is known to be non-zero or zero only. + auto truth = State->isNonNull(V); + if (truth.

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. In D96090#2607387 , @ASDenysPetrov wrote: > Actually many cases don't need to know an exact **original** type. Some cases > can extract the //type// from `SVal` (`SymbolVal`, `ConcreteInt`) Other cases > need it from outside (`

[PATCH] D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98253/new/ https://reviews.llvm.org/D98253 ___

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske updated this revision to Diff 329647. balazske added a comment. rebase, split the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 Files: clang/lib/AST/Expr.cpp clang/unittests/Tooling

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. Thanks for the comprehensive summary. I don't have many other suggestions in mind but I would like to add a few thoughts. We could always consider writing the tests manually from scratch too. But it doesn't feel like a good cost/benefit trade-off. Regarding 2 and 4 I

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:214 +- Added ``global_device`` and ``global_host`` address spaces for USM + allocations. + Anastasia wrote: > svenvh wrote: > > Perhaps one more point to mention: > > ``` > > - Allow pointer-

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

njames93 updated this revision to Diff 329649. njames93 added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clang

[PATCH] D77923: OpenCL: Fix some missing predefined macros

Anastasia added a comment. Herald added a subscriber: dexonsmith. FYI there has been a related spec change that makes this functionality optional in the offline compilation: https://github.com/KhronosGroup/OpenCL-Docs/pull/522/files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77923/n

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:575 return CB(InpAST.takeError()); -auto Selections = tweakSelection(Sel, *InpAST); +// FIXME: Should we use the dirty fs here? +auto FS = TFS.view(llvm::None); --

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

steakhal added a comment. In D97874#2616660 , @vsavchenko wrote: > @steakhal I personally don't see any fundamental problems with this patch Then, I guess, it should be fine :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97874/new/ https://re

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:214 +- Added ``global_device`` and ``global_host`` address spaces for USM + allocations. + svenvh wrote: > Anastasia wrote: > > svenvh wrote: > > > Perhaps one more point to mention: > > >

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:214 +- Added ``global_device`` and ``global_host`` address spaces for USM + allocations. + Anastasia wrote: > svenvh wrote: > > Anastasia wrote: > > > svenvh wrote: > > > > Perhaps one more po

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. In D97183#2615096 , @NoQ wrote: >> why does this not work? > > How does this not work? What does it say? Sorry, my bad! I had made a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. Your view, @steakhal? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

kubamracek accepted this revision. kubamracek added a comment. Looks good! By the way, Apple Clang releases also build compiler-rt this way, so it would be worth checking with @arphaman that he's okay with the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:214 +- Added ``global_device`` and ``global_host`` address spaces for USM + allocations. + svenvh wrote: > Anastasia wrote: > > svenvh wrote: > > > Anastasia wrote: > > > > svenvh wrote: >

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski accepted this revision. awarzynski added a comment. Thank you for addressing my comments and for working on this! I've left one small suggestion, but that's a [nit]. Comment at: clang/test/Driver/cxx_for_opencl.cppcl:1 +// RUN: %clang %s -Xclang -verify -fsyntax-onl

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:639 + # We want LLD for LTO, but LLD does not support SystemZ, so disable + # LTO here and use the installed system linker + if ("${LLVM_NATIVE_ARCH}" MATCHES "SystemZ") I guess you're u

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 329666. whisperity edited the summary of this revision. whisperity added reviewers: hokein, njames93. whisperity added a comment. - Massively refactored and modernised the implementation - Removed spaghetti code related to the check options and made their s

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. The changes introduc

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh added a comment. In D97869#2616772 , @Anastasia wrote: > Regarding 2 and 4 I think we should drive towards deprecation of `opencl-c.h` > as it is a maintenance overhead but we could convert it into a test instead? Perhaps you misunderstood option

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

svenvh accepted this revision. svenvh added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ReleaseNotes.rst:214 +- Added ``global_device`` and ``global_host`` address spaces for USM + allocations. + Anastasia wrote: > sv

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 329680. njames93 added a comment. Tweak the prepare method to just check for methods that need implementations, this saves some work that could be deferred to the apply method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. You're testing it with the help of an alpha checker. Is this checker doing something special that we don't do normally? In particular, both array bound checkers that we have are very likely to be re

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. We should have a test that references the entire interface so we realize if something breaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

scanon added a comment. Is there a mechanism to instruct the sanitizer to ignore a specific expression or function? From a cursory reading, I am mildly concerned about a deluge of false positives from primitives that compute exact (or approximate) residuals; these are acting to eliminate or pre

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 329686. yaxunl added a comment. minor bug fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CodeGenCUDA/device-use-host-var.cu clang/test/SemaCUDA/device-

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

kiranchandramohan added a comment. Herald added subscribers: dcaballe, cota. Ping @llitchev. Would you have time to take this forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91556/new/ https://reviews.llvm.org/D91556 ___

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

cchen added a comment. I think some existing Clang OpenMP codegen tests will break if they are testing against `__kmpc_push_target_tripcount`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 __

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jhuber6 added a comment. In D98358#2617152 , @cchen wrote: > I think some existing Clang OpenMP codegen tests will break if they are > testing against `__kmpc_push_target_tripcount`. I'm working on fixing the tests, I also forgot to include it in the `ex

  1   2   3   >