[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:317 void getShouldNotAlwaysLeaveANote() { std::unique_ptr P; // expected-note {{Default constructed smart pointer 'P' is null}} ---

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 332147. RedDocMD added a comment. Fixed up the git history Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.c

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

aybassiouny created this revision. aybassiouny added reviewers: curdeius, Wawha, MyDeveloperDay, HazardyKnusperkeks. aybassiouny added a project: clang-format. aybassiouny requested review of this revision. Herald added a project: clang. **Summary** `CompactNamespaces` config stops work when `Al

[clang] c2f9086 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

Author: Fangrui Song Date: 2021-03-20T21:37:49-07:00 New Revision: c2f9086b6184a132ec8cac7edeb620813796e1e8 URL: https://github.com/llvm/llvm-project/commit/c2f9086b6184a132ec8cac7edeb620813796e1e8 DIFF: https://github.com/llvm/llvm-project/commit/c2f9086b6184a132ec8cac7edeb620813796e1e8.diff

[PATCH] D99005: [clang] WIP: Implement P2266

Quuxplusone added a comment. Conspicuously missing: tests for `decltype(auto)` return types, tests for `co_return`. Personally I'd rather see these new p2266-related tests go in a separate test file, not appended to the existing file, so as to keep each test file relatively simpler and shorter

[PATCH] D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator

nullptr.cpp updated this revision to Diff 332145. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. - Warn on both declarations and definitions - Add check for parameter passing - Add options `CheckParamPassing` and `ExpensiveToCopySize` Repository: rG LLVM Github M

[clang] 56700e9 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

Author: Fangrui Song Date: 2021-03-20T21:32:55-07:00 New Revision: 56700e937903969a4a95f68c59e38e35d1ea URL: https://github.com/llvm/llvm-project/commit/56700e937903969a4a95f68c59e38e35d1ea DIFF: https://github.com/llvm/llvm-project/commit/56700e937903969a4a95f68c59e38e35d1ea.diff

[clang] 0ad0c47 - [Driver] Gnu.cpp: remove unneeded -L detection hack for -mx32

Author: Fangrui Song Date: 2021-03-20T20:12:45-07:00 New Revision: 0ad0c476efdbc6b8e933edc32e6f943ed3a33b0d URL: https://github.com/llvm/llvm-project/commit/0ad0c476efdbc6b8e933edc32e6f943ed3a33b0d DIFF: https://github.com/llvm/llvm-project/commit/0ad0c476efdbc6b8e933edc32e6f943ed3a33b0d.diff

[clang] 775a294 - [Driver] Gnu.cpp: remove unneeded -L detection for libc++

Author: Fangrui Song Date: 2021-03-20T18:56:40-07:00 New Revision: 775a294820caefdce4e60603eaac0a071dd72765 URL: https://github.com/llvm/llvm-project/commit/775a294820caefdce4e60603eaac0a071dd72765 DIFF: https://github.com/llvm/llvm-project/commit/775a294820caefdce4e60603eaac0a071dd72765.diff

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 332140. mizvekov added a comment. - Removed special flag, now is enabled on -std=c++2b - Always enabled for coroutines - Ran test suite - Some relevant test files updated to also run c++2b - Some new tests added Repository: rG LLVM Github Monorepo CHANGE

[clang] 06d6b14 - [Driver] Gnu.cpp: remove unneeded -L lib/gcc/$triple/$version/../../../$triple

Author: Fangrui Song Date: 2021-03-20T18:50:14-07:00 New Revision: 06d6b1471eb809aaad0681e1eb88727ac8225d47 URL: https://github.com/llvm/llvm-project/commit/06d6b1471eb809aaad0681e1eb88727ac8225d47 DIFF: https://github.com/llvm/llvm-project/commit/06d6b1471eb809aaad0681e1eb88727ac8225d47.diff

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2639844 , @vvereschaka wrote: > Hi @MaskRay, > > sorry, but these changes break the `Clang::gcc-toolchain.cpp` test on the > ARMv7/AArch64 cross builders: > > - https://lab.llvm.org/buildbot/#/builders/119/builds/2807 (A

[clang] 1fe1e99 - [test] Delete "-internal-isystem" "/usr/local/include"

Author: Fangrui Song Date: 2021-03-20T15:24:02-07:00 New Revision: 1fe1e996e987426e5d6352dabef358fc4ae619e5 URL: https://github.com/llvm/llvm-project/commit/1fe1e996e987426e5d6352dabef358fc4ae619e5 DIFF: https://github.com/llvm/llvm-project/commit/1fe1e996e987426e5d6352dabef358fc4ae619e5.diff

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. Hi @MaskRay, sorry, but these changes break the `Clang::gcc-toolchain.cpp` test on the ARMv7/AArch64 cross builders: - https://lab.llvm.org/buildbot/#/builders/119/builds/2807 (Aarch64) - https://lab.llvm.org/buildbot/#/builders/60/builds/2416 (ARMv7) Repository:

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov added a comment. In D99005#2639501 , @aaronpuchert wrote: > For coroutines I have D68845 . The current > code is wrong, and not trivial to fix. We have never properly implemented > P1825

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. No-no, `TrackControlDependencyCondBRVisitor`'s purpose is completely different. It tracks symbols that didn't necessarily participate in the report but participated in conditional statements that lexically surround the report. It's used for explaining how did we got ourselv

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Maybe refer to http://wg21.link/p0418 directly in the commit message? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98995/new/ https://reviews.llvm.org/D98995 _

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

NoQ added inline comments. Comment at: clang/test/Analysis/PR49642.c:1 +// RUN: %clang --analyze -Xclang -analyzer-checker=core %s + vsavchenko wrote: > NoQ wrote: > > Why not the usual `%clang_analyze_cc1`? Your approach only adds driver > > testing which doesn

[clang] f628ba0 - [test] Fix Driver/gcc-toolchain.cpp if CLANG_DEFAULT_RTLIB is compiler-rt

Author: Fangrui Song Date: 2021-03-20T13:24:49-07:00 New Revision: f628ba0b55b117dc68f9cb3be58189c05910660c URL: https://github.com/llvm/llvm-project/commit/f628ba0b55b117dc68f9cb3be58189c05910660c DIFF: https://github.com/llvm/llvm-project/commit/f628ba0b55b117dc68f9cb3be58189c05910660c.diff

[PATCH] D98945: [BranchProbability] move options for 'likely' and 'unlikely'

This revision was automatically updated to reflect the committed changes. Closed by commit rGee8b53815ddf: [BranchProbability] move options for 'likely' and 'unlikely' (authored by spatel). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[clang] ee8b538 - [BranchProbability] move options for 'likely' and 'unlikely'

Author: Sanjay Patel Date: 2021-03-20T14:46:46-04:00 New Revision: ee8b53815ddf6f6f94ade0068903cd5ae843fafa URL: https://github.com/llvm/llvm-project/commit/ee8b53815ddf6f6f94ade0068903cd5ae843fafa DIFF: https://github.com/llvm/llvm-project/commit/ee8b53815ddf6f6f94ade0068903cd5ae843fafa.diff

[PATCH] D98775: [AST] Add introspection support for Decls

steveire updated this revision to Diff 332119. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98775/new/ https://reviews.llvm.org/D98775 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG188405bc192d: [AST] Ensure that an empty json file is generated if compile errors (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang] 188405b - [AST] Ensure that an empty json file is generated if compile errors

Author: Stephen Kelly Date: 2021-03-20T18:08:01Z New Revision: 188405bc192df54fbf048ddd3da071c9fff4d0d1 URL: https://github.com/llvm/llvm-project/commit/188405bc192df54fbf048ddd3da071c9fff4d0d1 DIFF: https://github.com/llvm/llvm-project/commit/188405bc192df54fbf048ddd3da071c9fff4d0d1.diff LOG:

[clang] e92faa7 - [test] Fix Driver/gcc-toolchain.cpp if CLANG_DEFAULT_CXX_STDLIB is libc++

Author: Fangrui Song Date: 2021-03-20T11:06:44-07:00 New Revision: e92faa77b4b7e425fc29574c0273b3904ee2b0a6 URL: https://github.com/llvm/llvm-project/commit/e92faa77b4b7e425fc29574c0273b3904ee2b0a6 DIFF: https://github.com/llvm/llvm-project/commit/e92faa77b4b7e425fc29574c0273b3904ee2b0a6.diff

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added a comment. Got it, thanks for all the info! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96403/new/ https://reviews.llvm.org/D96403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99018: [clang][flang] Moke the definition of `-module-dir` restricted to Flang

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks. I do not know why `FlangOption and FC1 Options` needs be in `clang/include/clang/Driver/Options.td` but perhaps that is how things work:) Repository: rG LLVM Github Monorepo CHAN

[clang] dc3b438 - Revert "Revert "[Driver] Drop obsoleted Ubuntu 11.04 gcc detection""

Author: Fangrui Song Date: 2021-03-20T09:57:05-07:00 New Revision: dc3b438c8f34a54ba9648c97a02764319bd1aca8 URL: https://github.com/llvm/llvm-project/commit/dc3b438c8f34a54ba9648c97a02764319bd1aca8 DIFF: https://github.com/llvm/llvm-project/commit/dc3b438c8f34a54ba9648c97a02764319bd1aca8.diff

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

steakhal added inline comments. Comment at: clang/test/Analysis/pthreadlock_state.c:55 + // CHECK-NEXT: "mtx: conj_$11{int, LC1, S1874, #1}", + // CHECK-NEXT: "" + // CHECK-NEXT:]} Out of curiosity, what is the purpose of this 'empty' line? I've

[PATCH] D98774: [AST] De-duplicate empty node introspection

steveire marked an inline comment as done. steveire added a comment. @thakis Do you have any more on this? Can we de-duplicate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98774/new/ https://reviews.llvm.org/D98774 __

[PATCH] D99018: [clang][flang] Moke the definition of `-module-dir` restricted to Flang

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `-module-dir` is a Flang specific option and should not be visibl

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl added a comment. In D95007#2638955 , @MaskRay wrote: > Should `-cuid=` be `--cuid=`? For the existing clang options, there seem to be no rule or convention whether to use - or --. For example, -rtlib= Compiler runtime library to use

[PATCH] D98867: [HIP] Fix ROCm detection

yaxunl updated this revision to Diff 332104. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98867/new/ https://reviews.llvm.org/D98867 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/tes

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! In the summary you refer to `-fdebug-module-writer`. Could you please update before merging this? Comment at: flang/lib/Fronten

[PATCH] D98867: [HIP] Fix ROCm detection

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:267-268 +// rocm-{major}.{minor}.{subMinor}[-{build}] +auto Loc = StringRef(VerStr).rfind('_'); +if (Loc != StringRef::npos) + VerStr[Loc] =

[PATCH] D99005: [clang] WIP: Implement P2266

aaronpuchert added a comment. For coroutines I have D68845 . The current code is wrong, and not trivial to fix. We have never properly implemented P1825 and will probably just go with P2266 uncond

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. In D98278#2639481 , @zero9178 wrote: > Changes in this patch are based on this one https://reviews.llvm.org/D97472. > In the discussion there it was deemed not a good solution to use case > insensitive comparison as that would m

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2638005 , @mstorsjo wrote: > In D98278#2637866 , @zero9178 wrote: > >> In D98278#2637826 , @mstorsjo wrote: >> >>> Btw, while this change

[clang] 243333e - Revert "[Driver] Drop obsoleted Ubuntu 11.04 gcc detection"

Author: David Zarzycki Date: 2021-03-20T07:29:01-04:00 New Revision: 24ef3ec6c1e3910eb442177c2e2e927e6a87 URL: https://github.com/llvm/llvm-project/commit/24ef3ec6c1e3910eb442177c2e2e927e6a87 DIFF: https://github.com/llvm/llvm-project/commit/24ef3ec6c1e3910eb442177c2e2e927e6a87.diff

Re: [clang] bdf39e6 - [Driver] Drop obsoleted Ubuntu 11.04 gcc detection

This is failing on my Fedora 33 (x6-64) box. I'm going to revert this. If you need help debugging this, please let me know. Here is the relevant info: FAIL: Clang :: Driver/gcc-toolchain.cpp (6552 of 75252) TEST 'Clang :: Driver/gcc-toolchain.cpp' FAILED **

[PATCH] D98338: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd92d61dbc4: [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 4dd92d6 - [clang-tidy] Fix bugprone-terminating-continue when continue appears inside a switch

Author: Nathan James Date: 2021-03-20T10:59:37Z New Revision: 4dd92d61dbc4b3c51a98e1d0bfccabed24759ba9 URL: https://github.com/llvm/llvm-project/commit/4dd92d61dbc4b3c51a98e1d0bfccabed24759ba9 DIFF: https://github.com/llvm/llvm-project/commit/4dd92d61dbc4b3c51a98e1d0bfccabed24759ba9.diff LOG:

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added a comment. Please fix the style issues and update the patch with full context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface, or use `arc`) Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:20 +// zbr extension +TARG