[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 333659. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT added inline comments. Comment at: clang/test/AST/ast-dump-array-json.cpp:6 + +// CHECK: "mangledName": "_ZN1A4TestE", +// CHECK: "mangledName": "_ZN1A4TestE", rsmith wrote: > oToToT wrote: > > yaxunl wrote: > > > I am not sure if this test tests the code

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow

[PATCH] D99455: [AST] Store regular ValueDecl* in BindingDecl

aaronpuchert created this revision. aaronpuchert added reviewers: riccibruno, rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We were always storing a regular ValueDecl* as decomposition declaration and haven't been usi

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653949 , @MaskRay wrote: > In D99426#2653869 , > @abhina.sreeskantharajan wrote: > >> In D99426#2653725 , @MaskRay wrote:

[PATCH] D99005: [clang] WIP: Implement P2266

Quuxplusone added a comment. Data points: I've run this new Clang in `-std=c++2b` mode over my employer's (medium-sized, not too crazy) C++17 codebase, and also built Clang with Clang. Neither one required any source-code changes to deal with p2266. (The C++17 codebase did need about 10 identic

[clang] bb88a5a - [clang][cli] Round-trip cc1 arguments in assert builds

Author: Jan Svoboda Date: 2021-03-27T17:24:03+01:00 New Revision: bb88a5aeee6839caf2f09cd025099d63c15bfb11 URL: https://github.com/llvm/llvm-project/commit/bb88a5aeee6839caf2f09cd025099d63c15bfb11 DIFF: https://github.com/llvm/llvm-project/commit/bb88a5aeee6839caf2f09cd025099d63c15bfb11.diff L

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb88a5aeee68: [clang][cli] Round-trip cc1 arguments in assert builds (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev requested review of this revision. Herald added a project: clang. This adds support for C++2b z/uz suffixes for size_t literals (P0330). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D994

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333677. alexreinking added a comment. Use PACKAGE_VERSION instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/modules/CMakeLists.txt lld/C

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

nrieck created this revision. nrieck requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes left pointer alignment after pointer qualifiers of operators. Currently "operator void const*()" is formatted with a space between const a

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn added a comment. FYI I filed https://bugs.llvm.org/show_bug.cgi?id=49738 and https://bugs.llvm.org/show_bug.cgi?id=49739 for improving fast-math handling in the lowering pass and support for `pargma fp`, in case you are interested. @everton.constantino out of curiosity, what architecture

[PATCH] D98296: [clang-tidy] Simplify readability checks to not need ignoring* matchers

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/DeletedDefaultCheck.cpp:31 isMoveAssignmentOperator()), -isDefault

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

MaskRay added a comment. > It might make sense to do the llvm-readobj portions of this patch in a > separate review, since they are somewhat independent. +1. Patches touching BinaryFormat/llvm-readobj/yaml2obj/etc part and others (MC/CodeGen/etc) are often required to do BinaryFormat/llvm-read

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 333681. AntonBikineev added a comment. Fix failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files: clang/include/clang/Basic/DiagnosticCommonKinds.

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM -

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333683. alexreinking added a comment. Drop *ConfigVersion.cmake files from `CMakeFiles` tree CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/mod

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333687. alexreinking added a comment. Remove unused version variables (that were used in a previous revision) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333688. alexreinking added a comment. Update & wrap commit message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/modules/CMakeLists.txt lld/

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. But please wait for @mydeveloperday's review too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D9

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2958 // Space between the type and the * in: // operator void*() // operator char*() Nit: you might add `operator void const/volatile*()` to the list. Repository:

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Comment at: flang/cmake/modules/CMakeLists.txt:15 # Generate FlangConfig.cmake for the build tree. +include(CMakePackageConfigHelpers) + Instead of including this multiple times, please add it to `AddLLVM.cmake`. That file is use

[PATCH] D97513: [CMake] Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333690. alexreinking retitled this revision from "Add ConfigVersion.cmake files" to "[CMake] Add ConfigVersion.cmake files". alexreinking added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. As requested, move instances

[PATCH] D97513: [CMake] Add ConfigVersion.cmake files

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'll commit this on Wednesday if none of the other reviewers object by then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D9751

[clang] c61ae6e - Deduplicate branches and adjust comment [NFC]

Author: Aaron Puchert Date: 2021-03-27T23:08:43+01:00 New Revision: c61ae6e6d597984e6ff7d012dce4dfd59c05d792 URL: https://github.com/llvm/llvm-project/commit/c61ae6e6d597984e6ff7d012dce4dfd59c05d792 DIFF: https://github.com/llvm/llvm-project/commit/c61ae6e6d597984e6ff7d012dce4dfd59c05d792.diff

[PATCH] D98296: [clang-tidy] Simplify readability checks to not need ignoring* matchers

steveire updated this revision to Diff 333696. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98296/new/ https://reviews.llvm.org/D98296 Files: clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.

[clang] 19e4569 - [Driver] Remove an unneeded multiarch library path which ends with ../../..

Author: Fangrui Song Date: 2021-03-27T15:46:06-07:00 New Revision: 19e45696f5a58b8609c057257ed3645aee6f4a7d URL: https://github.com/llvm/llvm-project/commit/19e45696f5a58b8609c057257ed3645aee6f4a7d DIFF: https://github.com/llvm/llvm-project/commit/19e45696f5a58b8609c057257ed3645aee6f4a7d.diff

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'. WIP.

Meinersbur created this revision. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, martong, arphaman, zzheng, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sste

[clang] 87a9f42 - [Driver] Remove an incorrect library path for multilib

Author: Fangrui Song Date: 2021-03-27T16:36:21-07:00 New Revision: 87a9f42fc1cb8c6484a9625619b6202abcb2f9a7 URL: https://github.com/llvm/llvm-project/commit/87a9f42fc1cb8c6484a9625619b6202abcb2f9a7 DIFF: https://github.com/llvm/llvm-project/commit/87a9f42fc1cb8c6484a9625619b6202abcb2f9a7.diff

[clang] dcaa029 - [test] Add UNSUPPORTED: system-windows to linux-ld.c

Author: Fangrui Song Date: 2021-03-27T16:46:30-07:00 New Revision: dcaa0293c1068cf0b06c4e4304d3290ca3e7d5e3 URL: https://github.com/llvm/llvm-project/commit/dcaa0293c1068cf0b06c4e4304d3290ca3e7d5e3 DIFF: https://github.com/llvm/llvm-project/commit/dcaa0293c1068cf0b06c4e4304d3290ca3e7d5e3.diff

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov updated this revision to Diff 333707. mizvekov added a comment. Cleaned up implementation, not WIP anymore, ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/

[PATCH] D95745: Support unwinding from inline assembly

Amanieu added a comment. The new operand to InlineAsm needs to be handled in llvm/lib/Transforms/Utils/ValueMapper.cpp otherwise you will end up with a bug similar to https://bugs.llvm.org/show_bug.cgi?id=45291. Some tests with other unwinding models such as SJLJ and SEH would be nice. =

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie updated this revision to Diff 333708. OikawaKirie added a comment. In D83660#2597025 , @steakhal wrote: > I'm somewhat bothered that this patch is not landed yet. :| > > I made a **crude** mock to trigger the bug using `LD_PRELOAD`. F15707493: