[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri added a comment. In D80344#2673148 , @asmith wrote: > In D80344#2671157 , @lebedev.ri > wrote: > >> It would be good for @rjmccall / @rsmith / etc to actually finish reviewing >> this and accept it. >>

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

usaxena95 added a comment. Clangd was seen to be crashing on Objective C/C++ files. It could not be reproduced but inspection of coredump showed that the `expandedTokens` returned arrayref with begin > end (negative length). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. Hey Florian and John, Thanks for your reviews so far. Just checked the build. Addressed all previous comments and the build is looking good too except for one thing. For open cl tests, it is failing with this curious `error: initializer element is not a compile-time

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

oToToT created this revision. oToToT added reviewers: sammccall, kadircet. oToToT added a project: clang. oToToT requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. D97493 separate target creation

[clang] 0aa0458 - [CGCall] Annotate `this` argument with alignment

Author: Roman Lebedev Date: 2021-04-07T11:02:01+03:00 New Revision: 0aa0458f1429372038ca6a4edc7e94c96cd9a753 URL: https://github.com/llvm/llvm-project/commit/0aa0458f1429372038ca6a4edc7e94c96cd9a753 DIFF: https://github.com/llvm/llvm-project/commit/0aa0458f1429372038ca6a4edc7e94c96cd9a753.diff

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0aa0458f1429: [CGCall] Annotate `this` argument with alignment (authored by lebedev.ri). Changed prior to commit: https

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. Okay interesting I should have posted before. Seems like when I move `MatrixCast` to the bottom of OperationKinds.def, and do nothing else, the matrix-cast CodeGen fails with this error. It is somehow not able to assign correct cast type. + /tmp/build/bin/clang -c

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

azabaznov added a comment. Thanks for working on this! Looks good to me in general. I have a small comment. Comment at: clang/lib/Sema/SemaExprMember.cpp:343 if (HasRGBA || (*compStr && IsRGBA(*compStr))) { - if (S.getLangOpts().OpenCL && S.getLangOpts().OpenCLVersion

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM AFAIK the MIPS LLVM-based toolchain mentioned in D13340 have not been implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added a comment. Thank you guys for investigating it! In D69726#2671734 , @vsavchenko wrote: > 2. The analyzer doesn't explain why it thinks that `guc_malloc` returns null > pointer. I find it alarming that it might assume it for all the wrong

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

HazardyKnusperkeks added a comment. While the fix seems to be right, I don't think we should change the LLVM style (and possibly other styles). So my suggestion is to apply the fix, but actually change the style so that it behaves like before, so that braces of enums are wrapped. And maybe add

[clang] e018698 - [clang, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-07T09:43:58+01:00 New Revision: e018698bec363637f0da25b68da9ba8c3192d1cb URL: https://github.com/llvm/llvm-project/commit/e018698bec363637f0da25b68da9ba8c3192d1cb DIFF: https://github.com/llvm/llvm-project/commit/e018698bec363637f0da25b68da9ba8c3192d1cb.

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGe018698bec36: [clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.ll

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

dmgreen added a comment. Hello. We've received reports that this is bloating codesize of some code, quite a lot in places. There is an example in https://godbolt.org/z/66TEKa1xK. Essentially the glomming together of reads/writes into i32's (in our case) helps to reduce the total number of loads

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

uabelho added a comment. I wrote https://bugs.llvm.org/show_bug.cgi?id=49859 about a miscompile that started occuring when turning on memoryssa again in DSE. I suspect that licm doesn't keep memoryssa updated properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 2829094 - Reland [InstCombine] Fold `((X - Y) - Z)` to `X - (Y + Z)` (PR49858)

Author: Roman Lebedev Date: 2021-04-07T12:06:25+03:00 New Revision: 2829094a8e252d04f13aabdf6f416c42a06af695 URL: https://github.com/llvm/llvm-project/commit/2829094a8e252d04f13aabdf6f416c42a06af695 DIFF: https://github.com/llvm/llvm-project/commit/2829094a8e252d04f13aabdf6f416c42a06af695.diff

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

svenvh added a comment. In D99969#2671931 , @Anastasia wrote: > The code formating check reported an issue though... My bad, will fix before committing. Comment at: clang/lib/Sema/SemaExprMember.cpp:343 if (HasRGBA || (*compStr &&

[clang] 35bc756 - [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

Author: Sven van Haastregt Date: 2021-04-07T10:16:41+01:00 New Revision: 35bc7569f8ad8e76d36560386bbc45ca40716410 URL: https://github.com/llvm/llvm-project/commit/35bc7569f8ad8e76d36560386bbc45ca40716410 DIFF: https://github.com/llvm/llvm-project/commit/35bc7569f8ad8e76d36560386bbc45ca40716410.

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35bc7569f8ad: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] cd824a4 - [clang][Syntax] Handle invalid source range in expandedTokens.

Author: Utkarsh Saxena Date: 2021-04-07T11:19:01+02:00 New Revision: cd824a48cccb000655498e2d52129adfda25f49b URL: https://github.com/llvm/llvm-project/commit/cd824a48cccb000655498e2d52129adfda25f49b DIFF: https://github.com/llvm/llvm-project/commit/cd824a48cccb000655498e2d52129adfda25f49b.diff

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd824a48cccb: [clang][Syntax] Handle invalid source range in expandedTokens. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 335761. pdhaliwal marked 10 inline comments as done. pdhaliwal added a comment. Addressed review comments. RE test: Since the tool is contingent on the results of HSA API call, adding a test which would always PASS on all the systems with different AMD GPU

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. On the testing perspective, the tool Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:208 assert(GPUArch.startswith("gfx") && "Unsupported sub arch"); + assert(!GPUArch.empty() && "Unable to detect system GPU"); JonChest

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille added a comment. Reading through the source, it's relatively clear that `-arch` is specific to the Mach0 format, but -target seems applicable to OSX too, see https://godbolt.org/z/j8jvjbo84 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/ne

[PATCH] D99190: [SYCL] Add design document for SYCL mode

Naghasan accepted this revision. Naghasan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 335750. mgartmann retitled this revision from "[clang-tidy] misc-std-stream-objects-outside-main: a new check" to "[clang-tidy] misc-avoid-std-io-outside-main: a new check". mgartmann added a comment. - Added two new matchers to flag uses of `stdio.h`/`csd

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3001 DS.getStorageClassSpec() == clang::DeclSpec::SCS_typedef && -!DS.hasTypeSpecifier() && GetLookAheadToken(1).is(tok::less)) +!DS.hasTypeSpecifier() && NextToken().is(tok::less))

[PATCH] D100028: [docs] Update clazy's URL in the external Clang examples page

sergio.martins created this revision. sergio.martins added reviewers: kfunk, silvas, rizsotto.mailinglist. sergio.martins requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've moved away from Phabricator. Repository: rG LLVM Github Mono

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 335767. balazske added a comment. Fix a crash, update documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 Files: clang-tools-extra/clang-tidy/bugprone/Bug

[PATCH] D100028: [docs] Update clazy's URL in the external Clang examples page

kfunk added a comment. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100028/new/ https://reviews.llvm.org/D100028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 335768. ASDenysPetrov retitled this revision from "[analyzer] Handle intersections and adjacency in RangeSet::Factory::add function" to "[analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency". ASDenysPetrov added

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { benshi001 wrote: > Anasta

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added a comment. In D99037#2673367 , @SaurabhJha wrote: > Hey Florian and John, > > Thanks for your reviews so far. Just checked the build. Addressed all > previous comments and the build is looking good too except for one thing. For > open cl test

[clang-tools-extra] 43637c0 - Fix crash when an invalid URI is parsed and error handling is attempted

Author: crr0004 Date: 2021-04-07T12:32:33+02:00 New Revision: 43637c0dfeebcf4a4fcbb331f1094662e8882430 URL: https://github.com/llvm/llvm-project/commit/43637c0dfeebcf4a4fcbb331f1094662e8882430 DIFF: https://github.com/llvm/llvm-project/commit/43637c0dfeebcf4a4fcbb331f1094662e8882430.diff LOG:

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/Frontend/CompilerInstance.cpp:109 + // other side of CUDA/OpenMP/SYCL compilation. + if (!hasAuxTarget() && + (getLangOpts().CU

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const

[clang] 4821c15 - [analyzer] Fix body farm for Obj-C++ properties

Author: Valeriy Savchenko Date: 2021-04-07T13:44:43+03:00 New Revision: 4821c15691bab9efaef871c957a8ba73697cdda9 URL: https://github.com/llvm/llvm-project/commit/4821c15691bab9efaef871c957a8ba73697cdda9 DIFF: https://github.com/llvm/llvm-project/commit/4821c15691bab9efaef871c957a8ba73697cdda9.d

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

This revision was automatically updated to reflect the committed changes. Closed by commit rG4821c15691ba: [analyzer] Fix body farm for Obj-C++ properties (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99194/new/ https://rev

[clang] 77f1e09 - [-Wcompletion-handler] Don't recognize init methods as conventional

Author: Valeriy Savchenko Date: 2021-04-07T13:50:01+03:00 New Revision: 77f1e096e8a0a0f37a4c5f8a0bacc7c60f44f0a1 URL: https://github.com/llvm/llvm-project/commit/77f1e096e8a0a0f37a4c5f8a0bacc7c60f44f0a1 DIFF: https://github.com/llvm/llvm-project/commit/77f1e096e8a0a0f37a4c5f8a0bacc7c60f44f0a1.d

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

This revision was automatically updated to reflect the committed changes. vsavchenko marked an inline comment as done. Closed by commit rG77f1e096e8a0: [-Wcompletion-handler] Don't recognize init methods as conventional (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

oToToT added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:109 + // other side of CUDA/OpenMP/SYCL compilation. + if (!hasAuxTarget() && + (getLangOpts().CUDA || getLangOpts().OpenMPIsDevice || kadircet wrote: > can we just do `!getA

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

hokein added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:630 + f(t); + // CalleeType in getCallReturntype is Overload and dependent +} balazske wrote: > hokein wrote: > > CalleeType is not a specific term in `getCallReturnType`, just

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

steakhal abandoned this revision. steakhal added a comment. In D99658#2671747 , @NoQ wrote: > I mean, the extent of an `ElementRegion` //is// the size of a single element. > The reason why our intrinsic isn't doing what you expect is because we > represe

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

kadircet added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:109 + // other side of CUDA/OpenMP/SYCL compilation. + if (!hasAuxTarget() && + (getLangOpts().CUDA || getLangOpts().OpenMPIsDevice || oToToT wrote: > kadircet wrote: > > c

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

oToToT updated this revision to Diff 335778. oToToT added a comment. Simply use `!getAuxTarget()` to check the existence of AuxTarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100024/new/ https://reviews.llvm.org/D100024 Files: clang/lib/Fr

[clang] f0e102c - [analyzer][NFC] Add tests for extents

Author: Balazs Benics Date: 2021-04-07T13:43:19+02:00 New Revision: f0e102c1a39f0f7e9e309b27916533b8fefd9be7 URL: https://github.com/llvm/llvm-project/commit/f0e102c1a39f0f7e9e309b27916533b8fefd9be7 DIFF: https://github.com/llvm/llvm-project/commit/f0e102c1a39f0f7e9e309b27916533b8fefd9be7.diff

[PATCH] D99959: [analyzer][NFC] Add tests for extents

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e102c1a39f: [analyzer][NFC] Add tests for extents (authored by Balazs Benics ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 6951b72 - [clang] Speedup line offset mapping computation

Author: serge-sans-paille Date: 2021-04-07T14:04:32+02:00 New Revision: 6951b72334bbe4c189c71751edc1e361d7b5632c URL: https://github.com/llvm/llvm-project/commit/6951b72334bbe4c189c71751edc1e361d7b5632c DIFF: https://github.com/llvm/llvm-project/commit/6951b72334bbe4c189c71751edc1e361d7b5632c.d

[PATCH] D99409: [clang] Speedup line offset mapping computation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6951b72334bb: [clang] Speedup line offset mapping computation (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscrib

[clang] 7ca4dd8 - [Clang] Extend test coverage for -f[no-]finite-loops options.

Author: Florian Hahn Date: 2021-04-07T13:15:49+01:00 New Revision: 7ca4dd82175c9571e8251dfcd452b9ba0fb59280 URL: https://github.com/llvm/llvm-project/commit/7ca4dd82175c9571e8251dfcd452b9ba0fb59280 DIFF: https://github.com/llvm/llvm-project/commit/7ca4dd82175c9571e8251dfcd452b9ba0fb59280.diff

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D99409: [clang] Speedup line offset mapping computation

RKSimon added a comment. @serge-sans-paille Please can you look at the clang-ppc buildbot breakages: http://lab.llvm.org:8011/#/builders/52/builds/6108 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99409/new/ https://reviews.llvm.org/D99409 _

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:796 + bool EmitBoolCondBranch = !C || !C->isOne(); + bool CondIsConst = C; const SourceRange &R = S.getSourceRange(); lebedev.ri wrote: > I think, if we really want to give this a name, pe

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 335786. fhahn added a comment. rebased after pre-committing additional RUN lines in 7ca4dd82175c . Also adjusts a variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D99995: [OpenMP51] Initial support for marked directive and filter clause

ABataev added a comment. `marked`->`masked` Comment at: clang/include/clang/AST/OpenMPClause.h:8244 + + /// Set condition. + void setThreadID(Expr *TID) { ThreadID = TID; } condition? Comment at: clang/include/clang/AST/OpenMPClause.h:8270-

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 335685. Ericson2314 added a comment. Fix error, remove more CMAKE_INSTALL_LIBDIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-do

[PATCH] D100022: [clang][NFC] Fix method names not in accordance with coding style requirement

benshi001 created this revision. benshi001 added a reviewer: Anastasia. Herald added subscribers: frasercrmck, phosek, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I think with this last revision this diff might finally be ready! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 ___ cfe-commits mai

[PATCH] D100022: [clang][NFC] Fix method names not in accordance with coding style requirement

benshi001 added a comment. It seems the class `ToolChain` and its sub classes also have other methods not in accordance with the coding style. But fixing all of them really needs big effort. Can we fix addClangSystemIncludeArgs first, and then let https://reviews.llvm.org/D97669 pass ? Repo

[clang] fc1117d - [clang] Check AuxTarget exists when creating target in CompilerInstance

Author: oToToT Date: 2021-04-07T20:58:48+08:00 New Revision: fc1117df5b875b922ec4d4417404b26abaceaf7b URL: https://github.com/llvm/llvm-project/commit/fc1117df5b875b922ec4d4417404b26abaceaf7b DIFF: https://github.com/llvm/llvm-project/commit/fc1117df5b875b922ec4d4417404b26abaceaf7b.diff LOG: [

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1117df5b87: [clang] Check AuxTarget exists when creating target in CompilerInstance (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[clang] b83a445 - [flang][driver] Add support for `-cpp/-nocpp`

Author: Andrzej Warzynski Date: 2021-04-07T13:01:52Z New Revision: b83a4450c216879d76d78c21a2a0b864fdc2eb3d URL: https://github.com/llvm/llvm-project/commit/b83a4450c216879d76d78c21a2a0b864fdc2eb3d DIFF: https://github.com/llvm/llvm-project/commit/b83a4450c216879d76d78c21a2a0b864fdc2eb3d.diff

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb83a4450c216: [flang][driver] Add support for `-cpp/-nocpp` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D99292?vs=

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski added a comment. As there have been no new comments and this patch has already been accepted, I decided to merge it without waiting for more reviews. Please leave post-commit comments if I missed anything and I will address them. Thank you all for reviewing! Repository: rG LLVM G

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:420-421 + // We should also allow defensive initialization of structs. + if (const auto *ILE = + dyn_cast(E->IgnoreParenCasts())) {

[PATCH] D99262: [analyzer] Fix dead store checker false positive

steakhal accepted this revision. steakhal added a comment. Looks good. Thank you. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:420-421 + // We should also allow defensive initialization of structs. + if (const auto *ILE = +

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko added a comment. In D99262#2673825 , @steakhal wrote: > Looks good. Thank you. I guess it will do for PODs, but for regular C++ types we have an early exit until we learn about side effects from constructors. Repository: rG LLVM Github Mon

Re: [PATCH] D99409: [clang] Speedup line offset mapping computation

On Wed, Apr 07, 2021 at 12:48:01PM +, Simon Pilgrim via Phabricator wrote: > RKSimon added a comment. > > @serge-sans-paille Please can you look at the clang-ppc buildbot breakages: > http://lab.llvm.org:8011/#/builders/52/builds/6108 I'm on it. __

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and sto

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko updated this revision to Diff 335795. vsavchenko added a comment. Support nested init lists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99262/new/ https://reviews.llvm.org/D99262 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresCh

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader added a comment. In D99488#2671906 , @Anastasia wrote: > LGTM! Thanks for working on this. The expected sematic seems fairly clear now. Thanks for review! I also fixed external hyperlinks formatting. > We might add a few more details while refining

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

yaxunl added a comment. LGTM about AMDGPU toolchain change. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D99409: [clang] Speedup line offset mapping computation

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/36495/step_7.txt (takes a bit to load, since many tests are broken) Please take a look, and please revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D99409: [clang] Speedup line offset mapping computation

thakis added a comment. Here too: http://lab.llvm.org:8011/#/builders/127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99409/new/ https://reviews.llvm.org/D99409 ___ cfe-commits mailing list cfe-commits

[PATCH] D99409: [clang] Speedup line offset mapping computation

thakis added a comment. Oh, looks like someone already reported a breakage over an hour ago. I'll revert for now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99409/new/ https://reviews.llvm.org/D99409 _

[clang] c22b09d - Revert "[clang] Speedup line offset mapping computation"

Author: Nico Weber Date: 2021-04-07T09:42:11-04:00 New Revision: c22b09debddbaa00be3418b47ca33446ee8a8319 URL: https://github.com/llvm/llvm-project/commit/c22b09debddbaa00be3418b47ca33446ee8a8319 DIFF: https://github.com/llvm/llvm-project/commit/c22b09debddbaa00be3418b47ca33446ee8a8319.diff LO

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

lebedev.ri added a comment. Thank you! Some more thoughts. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + SourceLocToDebugLoc(R.getEnd()), + loopMustProgress(CondIsConst)); fhahn wrote: > lebedev.ri wrote: > > Now this doesn't

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5066 +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } MaskRay wrote: > Does this introduce an option in the CC1 command line

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. I'm happy with this as-is. @jdoerfert is this close enough to what you expected when we discussed this offline? Adding it directly to AMDGPU.h was a good suggestion. Makes it easy for other amdgpu language drivers to pick it up. That it's a binary on disk also

[PATCH] D99409: [clang] Speedup line offset mapping computation

serge-sans-paille added a comment. Thanks @thakis, inestigating the issue is likely to take some time as it seems to be arch or system dependent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99409/new/ https://reviews.llvm.org/D99409

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

jdoerfert added a comment. no strong opinion rn, I would add tests though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing list cfe-commits

[PATCH] D99409: [clang] Speedup line offset mapping computation

thakis added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1262 + unsigned char n) { + return ((x - ~0UL / 255 * (n + 1)) & ~x & + (x & ~0UL / 255 * 127) + ~0UL / 255 * (127 - (m - 1))) & UL is

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. We'll have slightly indirect testing once this is used to enable D99656 . There are two pieces that can be tested: 1/ The clang handling. That we can test with a minor change. Add a command line argument to clang that specifies t

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rsmith, efriedma, vsk, filcab, vitalybuka. lebedev.ri added projects: LLVM, clang, Sanitizers. Herald added subscribers: jansvoboda11, dexonsmith, dang. lebedev.ri requested review of this revision. Herald added subscribe

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335820. awarzynski added a comment. Add DocBrief descriptions in Options.td I added the descriptions so that it's documented what the options are intended for and to avoid confusion in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and sto

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. In D99353#2672503 , @protze.joachim wrote: > In D99353#2669046 , @awarzynski > wrote: > >> Btw, how important are these aliases for you? > > It's just not obvious from `flang --help` th

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

wenlei added subscribers: weiwang, wenlei. wenlei added a comment. Does this help non-distributed ThinLTO as well? cc: @weiwang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/new/ https://reviews.llvm.org/D99554 __

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 335839. mgartmann added a comment. Corrected check's entry in `list.rst` after renaming the check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-tool

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 335840. khchen added a comment. align implementation to https://github.com/riscv/rvv-intrinsic-doc/pull/77. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clan

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen created this revision. Herald added subscribers: danielkiss, kristof.beyls. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes an issue with the SVE prefetch and qinc/qdec intrinsics that take an `enum` arg

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 335846. khchen marked 4 inline comments as done. khchen added a comment. address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 Files: clang/include

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen added a comment. The fact that Clang chooses to (explicitly) forget about a builtin in SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't fully understand how the builtin mechanism is supposed to work. @rsmith and @tambre, git history showed me you have more expe

[PATCH] D99409: [clang] Speedup line offset mapping computation

serge-sans-paille added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1262 + unsigned char n) { + return ((x - ~0UL / 255 * (n + 1)) & ~x & + (x & ~0UL / 255 * 127) + ~0UL / 255 * (127 - (m - 1))) &

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 _

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 _

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

arichardson added a comment. I believe adding the default triple is causing the wrong linker to be selected for me when compiling with -m32, so I'd be happy for this code to be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ http

[clang] df59850 - [HIP] Fix rocm-detect.hip test path

Author: Aaron En Ye Shi Date: 2021-04-07T17:20:59Z New Revision: df59850038d800e8e8b062a5fc2e3d4ed624b526 URL: https://github.com/llvm/llvm-project/commit/df59850038d800e8e8b062a5fc2e3d4ed624b526 DIFF: https://github.com/llvm/llvm-project/commit/df59850038d800e8e8b062a5fc2e3d4ed624b526.diff LO

[PATCH] D100045: [HIP] Fix rocm-detect.hip test path

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf59850038d8: [HIP] Fix rocm-detect.hip test path (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D100045?vs

  1   2   >