[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f173c0c42d0: [clang][AVR] Support variable decorator __flash (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D96853?vs=334336=336593#toc Repository: rG LLVM Github

[clang] 4f173c0 - [clang][AVR] Support variable decorator '__flash'

Author: Ben Shi Date: 2021-04-10T11:23:55+08:00 New Revision: 4f173c0c42d02b14ab388a826ef0d463a07d7953 URL: https://github.com/llvm/llvm-project/commit/4f173c0c42d02b14ab388a826ef0d463a07d7953 DIFF: https://github.com/llvm/llvm-project/commit/4f173c0c42d02b14ab388a826ef0d463a07d7953.diff LOG:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:854 if (Ex && !Ex->isTypeDependent()) { +NRVOResult NRVORes = IsThrownVarInScope ? getNRVOResult(Ex) : NRVOResult(); + mizvekov wrote: > aaronpuchert wrote: > > Any reason why

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1585-1586 InitializedEntity Entity = InitializedEntity::InitializeVariable(GroDecl); - ExprResult Res = S.PerformMoveOrCopyInitialization(Entity, nullptr, GroType, -

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1585-1586 InitializedEntity Entity = InitializedEntity::InitializeVariable(GroDecl); - ExprResult Res = S.PerformMoveOrCopyInitialization(Entity, nullptr, GroType, -

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aaronpuchert added a comment. Didn't really check for correctness yet, just a superficial review. I like the idea, splitting the functionality up definitely helps understanding this. Comment at: clang/include/clang/Sema/Sema.h:4733 + +bool isMoveEligible() const { return

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

jyknight added a comment. The OpenJDK bug was UB in the OpenJDK code: https://bugs.openjdk.java.net/browse/JDK-8229258 already fixed in JDK14. (But not backported to JDK 11 LTS, which is the version Brooks found an error in above.) They probably need to backport that patch. My only confusion

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

jyknight added a comment. It seems like there's a bug with vtable thunks getting the wrong information. This appears to be a pre-existing bug, but this change has caused it to start actively breaking code. Test case: class Base1 { virtual void Foo1(); }; class Base2 {

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 336567. jamieschmeiser added a comment. Respond to review comments: Do not issue warning for nullptr - nullptr in C++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files:

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added inline comments. Comment at: clang/test/Sema/pointer-addition.c:34 + f = (char*)(f - (char*)0); // expected-warning {{performing pointer arithmetic on a null pointer has undefined behavior}} + f = (char*)((char*)0 - (char*)0); // expected-warning

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

vitalybuka added a reviewer: vitalybuka. vitalybuka added a comment. Smaller incremental patches are highly encouraged. But I assume it's WIP. In the first I'd recommend to try to land clang pieces and leave llvm and compiler-rt parts unchanged. And I can with interactive session next week.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @rjmccall, @rsmith, ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- marked an inline comment as not done. Qix- added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4100-4102 + // directly. The recording happens here because this is the only place + // where user-defined (via plugins) attributes are parsed, and thus + //

[clang] 3d81653 - [OpenMP51][DOCS] Claimed masked construct and report current patch, NFC.

Author: cchen Date: 2021-04-09T15:21:13-05:00 New Revision: 3d816537df2c99cdb151a86249da58f4529ec17d URL: https://github.com/llvm/llvm-project/commit/3d816537df2c99cdb151a86249da58f4529ec17d DIFF: https://github.com/llvm/llvm-project/commit/3d816537df2c99cdb151a86249da58f4529ec17d.diff LOG:

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- marked 3 inline comments as done. Qix- added a comment. So I went back and checked and I remember why I didn't add explicit support for GNU/declspec attributes - they actually perform symbol lookups in the surrounding scope. I believe there's an issue right now with plugins that GNU-style

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

asavonic created this revision. Herald added subscribers: danielkiss, kristof.beyls. asavonic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If target ABI requires coercion to a larger type, higher bits of the resulting value are supposed

[PATCH] D100197: Enable creation of large response file on z/OS

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100197/new/ https://reviews.llvm.org/D100197

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Anastasia wrote: >

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 336543. bader marked 32 inline comments as done. bader added a comment. Applied code review suggestions. Rebased on ToT and updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:697-699 + } else if (VD && dyn_cast(VD->getType())) { +// Call is: obj->*method_ptr or obj.*method_ptr +const auto *MPT = VD->getType()->castAs(); I'm not certain if I should

[clang] 1a43fd2 - [OpenMP51] Initial support for masked directive and filter clause

Author: cchen Date: 2021-04-09T14:00:36-05:00 New Revision: 1a43fd27691c6ae5c3d725ca7c6f4fd19357f4b8 URL: https://github.com/llvm/llvm-project/commit/1a43fd27691c6ae5c3d725ca7c6f4fd19357f4b8 DIFF: https://github.com/llvm/llvm-project/commit/1a43fd27691c6ae5c3d725ca7c6f4fd19357f4b8.diff LOG:

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a43fd27691c: [OpenMP51] Initial support for masked directive and filter clause (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

cchen updated this revision to Diff 336537. cchen added a comment. Fix lit-test failure for dispatch_ast_print and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5/new/ https://reviews.llvm.org/D5 Files:

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added a comment. In D99790#2680366 , @brooksmoses wrote: > In D99790#2678674 , @lebedev.ri > wrote: > >> In D99790#2678384 , @brooksmoses >> wrote: >> >>> In

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick updated this revision to Diff 336533. nick edited the summary of this revision. nick added reviewers: njames93, steveire. nick added a comment. Rebased. Now using native `cxxBaseSpecifier` and `hasDirectBase`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

brooksmoses added a comment. In D99790#2678674 , @lebedev.ri wrote: > In D99790#2678384 , @brooksmoses > wrote: > >> In any case, thanks for the quick reply, and I'll figure out a small >> reproducer if we find

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added inline comments. Comment at: clang/test/Sema/pointer-addition.c:34 + f = (char*)(f - (char*)0); // expected-warning {{performing pointer arithmetic on a null pointer has undefined behavior}} + f = (char*)((char*)0 - (char*)0); // expected-warning

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- planned changes to this revision. Qix- marked 5 inline comments as done. Qix- added inline comments. Comment at: clang/examples/PrintAttributeTokens/CMakeLists.txt:3-10 +if( NOT MSVC ) # MSVC mangles symbols differently, and + # PrintAttributeTokens.export

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10724 + // Subtracting from a null pointer should produce a warning. + if (LHS.get()->IgnoreParenCasts()->isNullPointerConstant( + Context, Expr::NPC_ValueDependentIsNotNull))

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1176-1210 + // If command line flags such as -m32, etc. changed parts of the triple that + // are not just changes to normalization, we also need to update the raw + // triple string that is used to find

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tianshilei1992 added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/new/ https://reviews.llvm.org/D98902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] dc4abca - Handle alloc_size attribute on function pointers

Author: Alex Richardson Date: 2021-04-09T18:49:38+01:00 New Revision: dc4abca7662b74467c2b6bceb7e8b046ae04b8a0 URL: https://github.com/llvm/llvm-project/commit/dc4abca7662b74467c2b6bceb7e8b046ae04b8a0 DIFF:

[PATCH] D55212: Handle alloc_size attribute on function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4abca7662b: Handle alloc_size attribute on function pointers (authored by arichardson). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D55212?vs=177519=336519#toc

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added a comment. @vsavchenko Thank you for a proposed solution. It looks much easier to understand and maintain. Great! I will take it into account. > Well, that is a nice exercise for "two pointer" problems, but can we please > talk about the actual use case for it? I'm

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:1 +//===--- IdDependentBackwardBranchCheck.cpp - clang-tidy *- C++ -*-===// +// `*- C++ -*` is not necessary for `.cpp` files.

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 336512. ffrankies added a comment. Addressed comments by @Eugene.Zelenko and the automated - Fixed header comments and include guard style - Removed unnecessary comments in `getLoopType()` - changed `IDDependencyRecord() {}` to `IDDependencyRecord() =

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:636-637 + + if (!CE->getCalleeDecl()) { +assert(hasUncompilableErrorOccurred() && "expected previous error"); +return false; aaron.ballman wrote: > This worries me slightly -- not

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336511. haberman marked 9 inline comments as done. haberman added a comment. - Simplified some casts and type declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added a comment. In D100046#2674311 , @sdesmalen wrote: > The fact that Clang chooses to (explicitly) forget about a builtin in > SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't > fully understand how the builtin

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 336500. jamieschmeiser added a comment. Respond to review comments: add requested test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336497. Holman added a comment. Fix clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

[PATCH] D100120: [RISCV][Clang] Add all RVV Mask intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100120/new/ https://reviews.llvm.org/D100120

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 added a comment. Thank you for your reviews. I will work on your comments and write back soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100092/new/ https://reviews.llvm.org/D100092 ___

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

arichardson updated this revision to Diff 336483. arichardson added a comment. - Fix Windows path regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100054/new/ https://reviews.llvm.org/D100054 Files: clang/include/clang/Driver/Driver.h

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add functionality to assign extensions to types in `OpenCLBuiltins.td` and

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. Thanks for the patch! Would you mind sharing the experimental data/results you obtained for this patch? Additionally, could you submit this patch to FuzzBench for an independent evaluation? Thanks, Matt Repository: rG LLVM

Re: [PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

Seems like the new build is passing. Can you please commit it on my behalf if it looks okay to you? Thanks a lot for your help in this patch. Saurabh On Fri, Apr 9, 2021 at 12:37 PM Saurabh Jha via Phabricator < revi...@reviews.llvm.org> wrote: > SaurabhJha added a comment. > > In

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

This revision was automatically updated to reflect the committed changes. Closed by commit rG18192228602c: [clang] tests: cleanup, update and add some new ones (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/

[clang] 1819222 - [clang] tests: cleanup, update and add some new ones

Author: Matheus Izvekov Date: 2021-04-09T17:24:08+02:00 New Revision: 18192228602c6a8093fb0eefa863ab854dd03e59 URL: https://github.com/llvm/llvm-project/commit/18192228602c6a8093fb0eefa863ab854dd03e59 DIFF:

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. So, we only need D99988 and this one (D100148 ) now and the LLVM package will finally build on Debian without any additional tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen updated this revision to Diff 336454. steffenlarsen added a comment. Following changes: - Changed the type in the names of the intrinsics and builtins. - Changed use of `IntrNoMem` to `IntrInaccessibleMemOnly`. - Added `PTX70` as a requirement to the builtins. CHANGES SINCE LAST

[clang] f9264ac - [HIP] Workaround ICE compiling SemaChecking.cpp with gcc 5

Author: Yaxun (Sam) Liu Date: 2021-04-09T10:40:07-04:00 New Revision: f9264ac0fdb7b58d1eb088ea91af0fee48816033 URL: https://github.com/llvm/llvm-project/commit/f9264ac0fdb7b58d1eb088ea91af0fee48816033 DIFF:

[PATCH] D100197: Enable creation of large response file on z/OS

SeanP created this revision. SeanP added reviewers: abhina.sree, hubert.reinterpretcast, muiez. SeanP requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most text processing commands (eg. grep, awk) have a maximum line length limit on z/OS.

[PATCH] D100172: Fix static code analysis concerns with uninitialized variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d7cb79416ad: RISCVABIInfo::classifyArgumentType: Fix static analyzer warnings with… (authored by Manna, committed by RKSimon). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 5d7cb79 - RISCVABIInfo::classifyArgumentType: Fix static analyzer warnings with uninitialized variables warnings - NFCI

Author: Soumi Manna Date: 2021-04-09T15:23:32+01:00 New Revision: 5d7cb79416adee00cf52be12ee42692dd19d4acb URL: https://github.com/llvm/llvm-project/commit/5d7cb79416adee00cf52be12ee42692dd19d4acb DIFF: https://github.com/llvm/llvm-project/commit/5d7cb79416adee00cf52be12ee42692dd19d4acb.diff

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske added a subscriber: Eugene.Zelenko. balazske added a comment. In D97960#2611531 , @Eugene.Zelenko wrote: > I think call stack may be useful for other checks too. May be code should be > moved to utilities? Yes it is useful for other checks,

[clang-tools-extra] b9b708e - [clangd] Log a message when gRPC support is off, but remote-index is configured

Author: Kadir Cetinkaya Date: 2021-04-09T15:52:51+02:00 New Revision: b9b708eef8cb7bcb073361283cd573beb04992a9 URL: https://github.com/llvm/llvm-project/commit/b9b708eef8cb7bcb073361283cd573beb04992a9 DIFF:

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added reviewers: rsmith, erichkeane. aaron.ballman added a comment. Thank you for this patch, I think it's really useful functionality for plugin authors! Adding some additional reviewers for more opinions on the changes in the preprocessor. Comment at:

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added a comment. @tra Thank you for the feedback! I think I see what you're getting at, but I am not quite understanding how it would work for these builtins and intrinsics. I have added some comments to the corresponding The comment about `IntrInaccessibleMemOnly` I agree with

[PATCH] D100144: [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

This revision was automatically updated to reflect the committed changes. Closed by commit rG25942d7c49ed: [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 25942d7 - [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

Author: Yaxun (Sam) Liu Date: 2021-04-09T09:23:41-04:00 New Revision: 25942d7c49ed37a6fa9b291423bb0a22ae77e32d URL: https://github.com/llvm/llvm-project/commit/25942d7c49ed37a6fa9b291423bb0a22ae77e32d DIFF:

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:398 +auto CLVer = Opts.OpenCLCPlusPlus ? 200 : Opts.OpenCLVersion; +if (CLVer >= 300) { + auto = getSupportedOpenCLOpts(); Anastasia wrote: > azabaznov wrote: > > Anastasia

[PATCH] D100187: [OPENMP]Fix PR49115: Incorrect results for scan directive.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice, jyu2. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. For combined worksharing directives need to emit the temp

[PATCH] D99501: ignore -flto= options recognized by GCC

fhahn added a comment. In D99501#2679394 , @doko wrote: > here in the same place, or in a different merge request? This one is closed now I think, so a new review would be ideal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added a comment. Mostly just nits from me, but the attribute portions look good to me. Comment at: clang/include/clang/AST/IgnoreExpr.h:127 + if (CCE && CCE->isElidable() && !isa(CCE)) { +auto NumArgs = CCE->getNumArgs(); +if ((NumArgs == 1 ||

[PATCH] D99501: ignore -flto= options recognized by GCC

doko added a comment. here in the same place, or in a different merge request? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99501/new/ https://reviews.llvm.org/D99501 ___ cfe-commits mailing list

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 336417. abhina.sreeskantharajan added a comment. Accidentally added dependent patch in this one. Removing that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 336416. abhina.sreeskantharajan added a comment. Rebase + fix CharLiteralParser endian issue by saving the char to a char variable first and then creating a StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100129: Tiny format fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG92498264269c: [clang] Tiny format fix (authored by urnathan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100129/new/ https://reviews.llvm.org/D100129

[clang] 9249826 - [clang] Tiny format fix

Author: Nathan Sidwell Date: 2021-04-09T05:19:51-07:00 New Revision: 92498264269c86fd0f5645d184d9f7e1c0c3acdf URL: https://github.com/llvm/llvm-project/commit/92498264269c86fd0f5645d184d9f7e1c0c3acdf DIFF:

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

aaron.ballman accepted this revision. aaron.ballman added a comment. This continues to LGTM, so I'm accepting it. If @alexfh has any remaining concerns, hopefully he can raise them quickly or we can handle them post-commit. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 3b4936b - [clangd] Add --check-lines to restrict --check to specific lines

Author: Adam Czachorowski Date: 2021-04-09T13:47:20+02:00 New Revision: 3b4936ba290594cda4e53169958fe11c83119657 URL: https://github.com/llvm/llvm-project/commit/3b4936ba290594cda4e53169958fe11c83119657 DIFF:

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2679131 , @fhahn wrote: > In D99037#2678848 , @SaurabhJha > wrote: > >> In D99037#2678779 , @fhahn wrote: >> >>> >> >> Will create a

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 336395. SaurabhJha added a comment. Replace `matrices` with `matrixes` in comments and rewrite the comment about element types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

gandhi21299 updated this revision to Diff 336249. gandhi21299 added a comment. - enclosing classes in PPCCallLowering,h within the llvm namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 Files:

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

gandhi21299 added a comment. @arsenm Yea, I am sorry about that. Looks like I am still not using arc properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 ___

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

arsenm added a comment. Attached wrong diff? There are a lot of unrelated files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 ___ cfe-commits mailing list

[PATCH] D100072: [AMDGPU] Allow -amdgpu-unsafe-fp-atomics to ignore denorm mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG189310a140fa: [AMDGPU] Allow -amdgpu-unsafe-fp-atomics to ignore denorm mode (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Sorry for the delay! Looks like this doesn't have any drawbacks for any other debuggers, but helps dbx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added a comment. In D99037#2678848 , @SaurabhJha wrote: > In D99037#2678779 , @fhahn wrote: > >> > > Will create a new patch to address your last comments Can you directly update this one? I'll commit it

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

whisperity added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98635/new/ https://reviews.llvm.org/D98635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] af67deb - [OpenCL] Simplify InsertOCLBuiltinDeclarationsFromTable

Author: Sven van Haastregt Date: 2021-04-09T11:54:15+01:00 New Revision: af67deb005cae4e87109d8ad534446b300351483 URL: https://github.com/llvm/llvm-project/commit/af67deb005cae4e87109d8ad534446b300351483 DIFF:

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

njames93 added a comment. I'd argue this check isn't following the enforcement specified in the relevant guideline: Enforcement: Warn when a variable modified inside the for-statement is declared outside the loop and not being used outside the loop. All this is checking is that there is a

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good! Comment at: clang/lib/AST/Expr.cpp:1386 QualType CalleeType = Callee->getType(); + if (const auto *FnTypePtr = CalleeType->getAs()) {

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136 ___ cfe-commits mailing list

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz accepted this revision. glaubitz added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ glaubitz wrote: > Do we need want to run the test for i386

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ glaubitz wrote: > Do we need want to run the test for

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added inline comments. Comment at: clang/test/Driver/sanitizer-ld.c:309 // CHECK-UBSAN-LINUX: "-lpthread" // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \ Do we need want to run the test for i386 anymore?

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Thanks, this finally fixes the build for me. I wasn't aware that there was a `getArchNameForCompilerRTLib()` function in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. In D97462#2678889 , @jansvoboda11 wrote: > In D97462#2677130 , @arichardson > wrote: > >> I just merged this commit into our CHERI fork and noticed some failing tests >> due to round

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2677130 , @arichardson wrote: > I just merged this commit into our CHERI fork and noticed some failing tests > due to round tripping: > We add some additional CodeGenOptions and LangOptions, but are not including

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2678779 , @fhahn wrote: > Will create a new patch to address your last comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 336353. pdhaliwal marked an inline comment as done. pdhaliwal added a comment. Fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files:

[PATCH] D100150: [Sanitizers] Add a flag -f[no-]sanitize-merge-traps

jansvoboda11 added a comment. The `CodeGen` tests you added are failing pre-merge checks. This is most likely because we recently (D97462 ) started verifying that all all CC1 command line options can be serialized from a `CompilerInvocation` instance. To

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. > LGTM, thanks for working on this! Thanks so much Florian. Can you please also commit this on my behalf as I don't have commit access? Cheers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 336351. pdhaliwal added a comment. Added tests for the failing cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files:

  1   2   >