[PATCH] D100696: Fixed typos

curdeius accepted this revision as: curdeius. curdeius added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/ https://reviews.llvm.org/D100696 ___ cfe-commits mailing li

[PATCH] D100696: Fixed typos

xgupta requested changes to this revision. xgupta added a comment. This revision now requires changes to proceed. Thanks @jnyfah for the patch! It looks you need to rebase your branch to llvm upstream main branch. Because polly/docs/ReleaseNotes.rst is recently change. Now its contain nothing se

[PATCH] D100696: Fixed typos

xgupta accepted this revision. xgupta added a comment. This revision now requires review to proceed. Oh sorry, Your patch is correct. I misunderstand something :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/ https://reviews.llvm.org/D1

[PATCH] D100696: Fixed typos

xgupta added a comment. Actually, I am not able to apply this patch with `arc patch D100696`. Created and checked out branch arcpatch-D100696. Checking patch polly/docs/ReleaseNotes.rst... error: while searching for: .. warning:: These release notes are for the next release of Polly and it de

[PATCH] D100696: Fixed typos

xgupta added a comment. @jnyfah If you are missing something I am just telling you the steps - 1. First fork the llvm github repository 2. git clone https://github.com/jynfah/llvm-project 3. git checkout -b type-fix 4. make changes to files. 5. git diff > mypatch.patch 6. git commit -m "fix typo

[PATCH] D100696: Fixed typos

Meinersbur added inline comments. Comment at: polly/docs/ReleaseNotes.rst:9 - These release notes are for the next release of Polly and it describes + These release notes are for the next release of Polly and describe the new features that have recently been committed to o

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just a few nits before landing please. Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:172-176 + if (TypeLocBase && Node->getName() == "getLocalS

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10070

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. cc @r Comment at: clang/include/clang/Basic/CodeGenOptions.h:391 std::vector SanitizeCoverageBlocklistFiles; + std::string StackUsageOutput; Nit: comment? Like one in TargetOptions.h Repository: rG LLVM Github Monorepo CHANG

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

njames93 updated this revision to Diff 338294. njames93 marked 4 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files: clang-tools-ext

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 added a comment. Some key points, 1. This patch fixes the bug https://bugs.llvm.org/show_bug.cgi?id=31530 . 2. The test builtins.cpp is disabled on AVR, due to uint16_t is defined to unsigned short. The underlying reason is that the system's libc/stdint.h is used instead of avr-libc'

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 added a comment. Though the disabled test builtins.cpp can pass after my another patch https://reviews.llvm.org/D97669, it will still fail on llvm build machines, since there are no avr-libc installed on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D100658: [RISCV] Apply __clang_riscv_builtin_alias to overloaded builtins.

khchen added a comment. I think you also need to handle `PermuteOperands` field ? `PermuteOperands` performs the order permutation for non-masked and masked intrinsics when the operand order is diff

[PATCH] D98814: [CUDA][HIP] Mark device var used by host only

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:31-33 +// Check device-used static device var is not in llvm.compiler.used. +// CHECK-DAG: @_ZL2u4 +static __device__ int u4; tra wro

[PATCH] D100705: Fixed Typos

jnyfah created this revision. jnyfah added a reviewer: xgupta. jnyfah added a project: LLVM. jnyfah requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo

[PATCH] D98783: [AMDGPU] Add GlobalDCE before internalization pass

This revision was automatically updated to reflect the committed changes. Closed by commit rG3597f02fd5c6: [AMDGPU] Add GlobalDCE before internalization pass (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 3597f02 - [AMDGPU] Add GlobalDCE before internalization pass

Author: Yaxun (Sam) Liu Date: 2021-04-17T11:25:25-04:00 New Revision: 3597f02fd5c62f7c49c71b92e467128ffe2cf9cd URL: https://github.com/llvm/llvm-project/commit/3597f02fd5c62f7c49c71b92e467128ffe2cf9cd DIFF: https://github.com/llvm/llvm-project/commit/3597f02fd5c62f7c49c71b92e467128ffe2cf9cd.dif

[clang] d5c0f00 - [CUDA][HIP] Mark device var used by host only

Author: Yaxun (Sam) Liu Date: 2021-04-17T11:25:25-04:00 New Revision: d5c0f00e216aa6797499bb4c8aacac930d8a819b URL: https://github.com/llvm/llvm-project/commit/d5c0f00e216aa6797499bb4c8aacac930d8a819b DIFF: https://github.com/llvm/llvm-project/commit/d5c0f00e216aa6797499bb4c8aacac930d8a819b.dif

[PATCH] D98814: [CUDA][HIP] Mark device var used by host only

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGd5c0f00e216a: [CUDA][HIP] Mark device var used by host only (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.or

[clang] 12a1f1d - [Pragma] Added support for GCC unroll/nounroll

Author: Dávid Bolvanský Date: 2021-04-17T17:29:55+02:00 New Revision: 12a1f1d9d7e4f7ce416d0602d18991973986dfb5 URL: https://github.com/llvm/llvm-project/commit/12a1f1d9d7e4f7ce416d0602d18991973986dfb5 DIFF: https://github.com/llvm/llvm-project/commit/12a1f1d9d7e4f7ce416d0602d18991973986dfb5.dif

[clang] 6823af0 - [HIP] Support hipRTC in header

Author: Yaxun (Sam) Liu Date: 2021-04-17T11:34:52-04:00 New Revision: 6823af0ca858b54e09e5be61a19d067ccd0bd6b7 URL: https://github.com/llvm/llvm-project/commit/6823af0ca858b54e09e5be61a19d067ccd0bd6b7 DIFF: https://github.com/llvm/llvm-project/commit/6823af0ca858b54e09e5be61a19d067ccd0bd6b7.dif

[PATCH] D100652: [HIP] Support hipRTC in header

This revision was automatically updated to reflect the committed changes. Closed by commit rG6823af0ca858: [HIP] Support hipRTC in header (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100652/new/

[clang] ebc6608 - [AST] Remove args from LocationCall

Author: Stephen Kelly Date: 2021-04-17T17:21:55+01:00 New Revision: ebc6608fb79057eaed27435d62d5dea0979bd9d3 URL: https://github.com/llvm/llvm-project/commit/ebc6608fb79057eaed27435d62d5dea0979bd9d3 DIFF: https://github.com/llvm/llvm-project/commit/ebc6608fb79057eaed27435d62d5dea0979bd9d3.diff

[PATCH] D100688: [AST] Remove args from LocationCall

This revision was automatically updated to reflect the committed changes. Closed by commit rGebc6608fb790: [AST] Remove args from LocationCall (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100688/new/ https://reviews.llvm

[PATCH] D100705: Fixed Typos

Mordante accepted this revision as: Mordante. Mordante added a comment. Thanks for your contribution. Next time, please provide a patch with more context. The instructions can be found at https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. LGTM, but please wait for

[clang] 21bef4e - [NFC] Fixed Typos

Author: Jennifer Chukwu Date: 2021-04-17T22:02:23+05:30 New Revision: 21bef4e11e48d5d4bff7a23babbd420e86dd420a URL: https://github.com/llvm/llvm-project/commit/21bef4e11e48d5d4bff7a23babbd420e86dd420a DIFF: https://github.com/llvm/llvm-project/commit/21bef4e11e48d5d4bff7a23babbd420e86dd420a.dif

[PATCH] D100705: Fixed Typos

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21bef4e11e48: [NFC] Fixed Typos (authored by jnyfah, committed by

[PATCH] D100705: Fixed Typos

xgupta added a subscriber: curdeius. xgupta added a comment. Nice work @jnyfah! @Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100696: Fixed typos

xgupta added a comment. @jnyfah you may close this revision. changes are committed by https://reviews.llvm.org/rG21bef4e11e48d5d4bff7a23babbd420e86dd420a. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/ https://reviews.llvm.org/D100696

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song updated this revision to Diff 338323. yonghong-song added a comment. - add checking CGDebugInfo pointer. In my original patch but got lost in the revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ https://reviews.llv

[PATCH] D100705: Fixed Typos

Mordante added a comment. In D100705#2696708 , @xgupta wrote: > Nice work @jnyfah! > > @Mordante Review is already accepted by @curdeius in > https://reviews.llvm.org/D100696. And actually, I see your message after > committing the patch. In general wh

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. I did some debugging on why DeclRefExpr evaluated not to be a Function pointer. Here is what I got. I made the following clang change to dump out the pointer to the emited value ('&foo'): diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp ind

[PATCH] D100705: Fixed Typos

xgupta added a comment. Thanks, @Mordante for the tips, I remember from next time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100705/new/ https://reviews.llvm.org/D100705 ___ cfe-commits mailing lis

[clang] 141945f - [AST] Enable AST node introspection on WIN32

Author: Stephen Kelly Date: 2021-04-17T18:59:35+01:00 New Revision: 141945f950e2f3fd58bc6db3afb5d3b10cb2b0c9 URL: https://github.com/llvm/llvm-project/commit/141945f950e2f3fd58bc6db3afb5d3b10cb2b0c9 DIFF: https://github.com/llvm/llvm-project/commit/141945f950e2f3fd58bc6db3afb5d3b10cb2b0c9.diff

[clang] 488a19d - [clang-scan-deps] Support double-dashes in clang command lines

Author: Sylvain Audi Date: 2021-04-17T14:22:51-04:00 New Revision: 488a19d00cbaec479f8c5c298556d2246978f9e6 URL: https://github.com/llvm/llvm-project/commit/488a19d00cbaec479f8c5c298556d2246978f9e6 DIFF: https://github.com/llvm/llvm-project/commit/488a19d00cbaec479f8c5c298556d2246978f9e6.diff

[clang] bb26fa8 - [clang-scan-deps] Add support for clang-cl

Author: Sylvain Audi Date: 2021-04-17T14:22:51-04:00 New Revision: bb26fa8c286bf524ed9235c3e293ad22ecf3e984 URL: https://github.com/llvm/llvm-project/commit/bb26fa8c286bf524ed9235c3e293ad22ecf3e984 DIFF: https://github.com/llvm/llvm-project/commit/bb26fa8c286bf524ed9235c3e293ad22ecf3e984.diff

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

This revision was automatically updated to reflect the committed changes. Closed by commit rG488a19d00cba: [clang-scan-deps] Support double-dashes in clang command lines (authored by saudi, committed by aganea). Changed prior to commit: https://reviews.llvm.org/D95099?vs=318304&id=338329#toc R

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26fa8c286b: [clang-scan-deps] Add support for clang-cl (authored by saudi, committed by aganea). Changed prior to commit: https://reviews.llvm.org/D92191?vs=318553&id=338330#toc Repository: rG LLVM

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 338334. xbolva00 marked 5 inline comments as done. xbolva00 added a comment. Updated, addressed review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 338336. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd68942f1d79: [AST] Add TypeLoc support to node introspection (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D100516?vs=338049&id=338342#toc Repository: rG LLVM Github

[clang] dd68942 - [AST] Add TypeLoc support to node introspection

Author: Stephen Kelly Date: 2021-04-17T22:58:02+01:00 New Revision: dd68942f1d79986267a58c9a9924522680d5c82b URL: https://github.com/llvm/llvm-project/commit/dd68942f1d79986267a58c9a9924522680d5c82b DIFF: https://github.com/llvm/llvm-project/commit/dd68942f1d79986267a58c9a9924522680d5c82b.diff

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire added inline comments. Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:172-176 + if (TypeLocBase && Node->getName() == "getLocalSourceRange") +continue; + if ((ASTClass->getName() == "PointerLikeTypeLoc" || + ASTClass->getName()

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added subscribers: mgrang, mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the GetLocations API to take instances by const-ref. This class

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind

mizvekov created this revision. Herald added subscribers: lxfind, martong. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This clenaup patch: - Refactors a bunch of duplicates of getDecltypeForParenthesizedExpr into a common imp

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind

mizvekov updated this revision to Diff 338352. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100713/new/ https://reviews.llvm.org/D100713 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Sema/Sema.h

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind

aaronpuchert added a comment. It seems that using `is*Value` and the introduction of `getDecltypeForParenthesizedExpr` could be two separate changes. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5845 + if (!To->isRValue()) { +QualType T = Self.Context.getDecltypeForParenthe

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5845 + if (!To->isRValue()) { +QualType T = Self.Context.getDecltypeForParenthesizedExpr(To); InitializedEntity Entity = InitializedEntity::InitializeTemporary(T); aaronpuchert w

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

njames93 updated this revision to Diff 338356. njames93 added a comment. Rebase and remove Args from comparison. Add quick check for skippig common prefix calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100638/new/ https://reviews.llvm.org/D10