[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda added a comment. I'm new here. I was told to take small steps. This will eventually effect compiler-rt and llvm. I took the smallest possible step. What I had previously: https://reviews.llvm.org/D99630 And was told it was too large. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks added a comment. Actually, the InstCombine transform allows LoopFullUnrollPass to unroll the copy loop which results in a bunch of stores. Previously during LoopFullUnrollPass we wouldn't see the global within the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

HsiangKai updated this revision to Diff 339879. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

HsiangKai updated this revision to Diff 339876. HsiangKai added a comment. Use new defined intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

HsiangKai updated this revision to Diff 339875. HsiangKai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100821/new/ https://reviews.llvm.org/D100821 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5917 if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) BE->getBlockDecl()->setDoesNotEscape(); We need to be checking that the parameter type is a block

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks added a comment. Looking at one of the examples in llvm-test-suite that regressed, this seems to be regressing some very simple code: void f(double *a) { double c[20] = { 0.1051, 0.0157, 0.0185, 0.0089, 0.0219, 0.0141, 0.0097, 0.0758, 0.0168, 0.1188, 0.1635,

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

rjmccall added a comment. Test looks good, thanks. Comment at: clang/lib/CodeGen/CGCall.cpp:2060 +case Builtin::BIstrndup: + RetAttrs.addAlignmentAttr(Context.getTargetInfo().getNewAlign() / +

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8bce8399631: [X86] Enable compilation of user interrupt handlers. (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e8bce83 - [X86] Enable compilation of user interrupt handlers.

Author: Wang, Pengfei Date: 2021-04-23T11:43:57+08:00 New Revision: e8bce83996313ed3f4f5fce43107530d49fc3b64 URL: https://github.com/llvm/llvm-project/commit/e8bce83996313ed3f4f5fce43107530d49fc3b64 DIFF: https://github.com/llvm/llvm-project/commit/e8bce83996313ed3f4f5fce43107530d49fc3b64.diff

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

nemanjai created this revision. nemanjai added reviewers: cebowleratibm, hubert.reinterpretcast, bmahjour, PowerPC. Herald added subscribers: shchenz, kbarton. nemanjai requested review of this revision. Herald added a project: clang. There are some interfaces in altivec.h that are not

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HsiangKai marked an inline comment as done. Closed by commit rG14cc1cb22230: [RISCV] Implement the vneg.v builtin. (authored by HsiangKai). Changed prior to commit:

[clang] 14cc1cb - [RISCV] Implement the vneg.v builtin.

Author: Hsiangkai Wang Date: 2021-04-23T11:40:18+08:00 New Revision: 14cc1cb22230de433bb9eb35624355a6d0bef2d2 URL: https://github.com/llvm/llvm-project/commit/14cc1cb22230de433bb9eb35624355a6d0bef2d2 DIFF:

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100776/new/ https://reviews.llvm.org/D100776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

HsiangKai added a comment. In D100821#2707667 , @rogfer01 wrote: > I can reproduce the crash above in my computer, so something is definitely > off. > > Looks like we emit this > > case RISCV::BI__builtin_rvv_vmmv_m_b8: > case

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

HsiangKai added a comment. @aaron.ballman, could you help me to review it again? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 ___ cfe-commits

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2786e673c7d6: [IR][sanitizer] Add module flag frame-pointer and set it for cc1 -mframe… (authored by MaskRay). Repository: rG LLVM Github

[clang] 2786e67 - [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

Author: Fangrui Song Date: 2021-04-22T18:07:30-07:00 New Revision: 2786e673c7d67ffca531ef38d679620ee3048a1e URL: https://github.com/llvm/llvm-project/commit/2786e673c7d67ffca531ef38d679620ee3048a1e DIFF: https://github.com/llvm/llvm-project/commit/2786e673c7d67ffca531ef38d679620ee3048a1e.diff

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

MaskRay updated this revision to Diff 339833. MaskRay added a comment. improve doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101016/new/ https://reviews.llvm.org/D101016 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

MaskRay added a comment. Chatted offline, vitalybuka said I can go ahead with existing ack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101016/new/ https://reviews.llvm.org/D101016 ___ cfe-commits

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

joerg added a comment. This review doesn't make sense to me. Why add a flag that isn't affecting anything? Why add a flag that isn't even tested? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda created this revision. kda added a reviewer: vitalybuka. Herald added subscribers: jansvoboda11, dexonsmith, dang. kda requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. introduce flag

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added a comment. General question about SIMD intrinsics: So we make dedicated wasm intrinsics only for the cases there are not general intrinsics people can use instead? Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec,

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

penzn accepted this revision. penzn added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101112/new/ https://reviews.llvm.org/D101112

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield updated this revision to Diff 339824. JonChesterfield added a comment. - simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ https://reviews.llvm.org/D101095 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. Live again as of 15be0c41d2e5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949

[clang] 15be0c4 - Reapply "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Jon Chesterfield Date: 2021-04-23T01:07:16+01:00 New Revision: 15be0c41d2e59fb4599c9aebf21ede498c61f51d URL: https://github.com/llvm/llvm-project/commit/15be0c41d2e59fb4599c9aebf21ede498c61f51d DIFF:

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield updated this revision to Diff 339820. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ https://reviews.llvm.org/D101095 Files: clang/lib/Driver/ToolChains/Clang.cpp

[clang] 40beb1f - CWG2076: Permit implicit conversions within a single level of braces

Author: Richard Smith Date: 2021-04-22T16:49:39-07:00 New Revision: 40beb1f84a3d72ea39fcee1dcb66c3cefb5d5644 URL: https://github.com/llvm/llvm-project/commit/40beb1f84a3d72ea39fcee1dcb66c3cefb5d5644 DIFF: https://github.com/llvm/llvm-project/commit/40beb1f84a3d72ea39fcee1dcb66c3cefb5d5644.diff

[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100819/new/ https://reviews.llvm.org/D100819

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGb49337bbb9de: [RISCV] [1/2] Add IR intrinsic for Zbp extension (authored by LevyHsu, committed by craig.topper). Changed prior to commit: https://reviews.llvm.org/D100830?vs=339150=339818#toc

[clang] b49337b - [RISCV] [1/2] Add IR intrinsic for Zbp extension

Author: Levy Hsu Date: 2021-04-22T16:34:51-07:00 New Revision: b49337bbb9de63e4696cb1fc1d2809d2823ab460 URL: https://github.com/llvm/llvm-project/commit/b49337bbb9de63e4696cb1fc1d2809d2823ab460 DIFF: https://github.com/llvm/llvm-project/commit/b49337bbb9de63e4696cb1fc1d2809d2823ab460.diff

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cdb9873b210: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2cdb987 - [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

Author: Jon Chesterfield Date: 2021-04-23T00:24:42+01:00 New Revision: 2cdb9873b2105eb07ce323edbe6c431a6c79e523 URL: https://github.com/llvm/llvm-project/commit/2cdb9873b2105eb07ce323edbe6c431a6c79e523 DIFF:

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101077/new/ https://reviews.llvm.org/D101077

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG8baba6890de7: [HIP] Support overloaded math functions for hipRTC (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 8baba68 - [HIP] Support overloaded math functions for hipRTC

Author: Yaxun (Sam) Liu Date: 2021-04-22T19:06:51-04:00 New Revision: 8baba6890de74d33beb75646ebcbf168e949d578 URL: https://github.com/llvm/llvm-project/commit/8baba6890de74d33beb75646ebcbf168e949d578 DIFF:

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1576 -unsigned tools::getOrCheckAMDGPUCodeObjectVersion( -const Driver , const llvm::opt::ArgList , bool Diagnose) { +static llvm::opt::Arg * +getAMDGPUCodeObjectArgument(const

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield updated this revision to Diff 339810. JonChesterfield added a comment. - whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101077/new/ https://reviews.llvm.org/D101077 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield updated this revision to Diff 339807. JonChesterfield added a comment. - factor out last arg wins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101077/new/ https://reviews.llvm.org/D101077 Files:

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield updated this revision to Diff 339806. JonChesterfield added a comment. This revision is now accepted and ready to land. - factor out last arg wins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101117/new/

[clang] af91065 - Revert "[AST] Enable AST node introspection on Apple"

Author: Stephen Kelly Date: 2021-04-22T23:54:16+01:00 New Revision: af91065ce5e6fd3069029ba9d077f2b21bacb545 URL: https://github.com/llvm/llvm-project/commit/af91065ce5e6fd3069029ba9d077f2b21bacb545 DIFF: https://github.com/llvm/llvm-project/commit/af91065ce5e6fd3069029ba9d077f2b21bacb545.diff

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield abandoned this revision. JonChesterfield added a comment. Abandoning this. Unacceptably ugly, will revise D101077 in a slightly different direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl added a comment. In D101117#2710368 , @JonChesterfield wrote: > I'm not very pleased with this. There's too much state to move around when > representing the failure and the control flow is probably harder to read than > it was in the original.

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. nice. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101117/new/ https://reviews.llvm.org/D101117

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added a comment. I'm not very pleased with this. There's too much state to move around when representing the failure and the control flow is probably harder to read than it was in the original. May take another pass at it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1626 } else { - auto Remnant = - StringRef(CodeObjArg->getValue()).getAsInteger(0, CodeObjVer); - if (Diagnose && - (Remnant || CodeObjVer <

[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield created this revision. JonChesterfield added a reviewer: yaxunl. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang.

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. In D99949#2710273 , @davezarzycki wrote: > I removed all HSA/ROCM via the package manager and everything is fine now. > Have you considered using __has_include() instead of CMake? It seems to be > supported by all

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. I think this is good to go. Later anybody can build improvements on top of this patch and maybe work on some more powerful “dead stores” warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. I removed all HSA/ROCM via the package manager and everything is fine now. Have you considered using __has_include() instead of CMake? It seems to be supported by all contemporary compilers, even MSVC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

dschuff added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ out of

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. Looks good in terms of false positives on Chrome. This did uncover a lot of issues, although many of them are due to only using some variable in some config with `#ifdef` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101049: [AST] Add DeclarationNameInfo to node introspection

steveire updated this revision to Diff 339793. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 Files: clang/include/clang/Tooling/NodeIntrospection.h

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:586-587 _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif #endif Nit: I'd add `// ` here for consistency. CHANGES SINCE LAST ACTION

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds new intrinsics for

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

ychen added a comment. That sounds like less powerful optimizations due to the GlobalsAA movement. If adding a GlobalsAA plus D100917 is a win overall, that should work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 907409a - [AST] Enable AST node introspection on Apple

Author: Stephen Kelly Date: 2021-04-22T22:19:21+01:00 New Revision: 907409a536cd66a09a91ee28e1f6f8bcc7127bc7 URL: https://github.com/llvm/llvm-project/commit/907409a536cd66a09a91ee28e1f6f8bcc7127bc7 DIFF: https://github.com/llvm/llvm-project/commit/907409a536cd66a09a91ee28e1f6f8bcc7127bc7.diff

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks updated this revision to Diff 339782. aeubanks added a comment. Herald added subscribers: cfe-commits, steven_wu. Herald added a project: clang. add test use CFGAnalyses uncovered another place in updateCGAndAnalysisManager() to change depends on D101017

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1626 } else { - auto Remnant = - StringRef(CodeObjArg->getValue()).getAsInteger(0, CodeObjVer); - if (Diagnose && - (Remnant || CodeObjVer <

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 339778. mbenfield added a comment. Fix test warning-wall.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield marked 4 inline comments as done. mbenfield added a comment. In D100581#2705780 , @xbolva00 wrote: > Meanwhile I collected some interesting testcases from gcc bugzilla (reported > as false positives), please try: >

[clang] d5f433d - Revert "Re-land "[Driver] Support default libc++ library location on Darwin""

Author: Petr Hosek Date: 2021-04-22T14:04:24-07:00 New Revision: d5f433d3302eedd455889d581d8312715289b582 URL: https://github.com/llvm/llvm-project/commit/d5f433d3302eedd455889d581d8312715289b582 DIFF: https://github.com/llvm/llvm-project/commit/d5f433d3302eedd455889d581d8312715289b582.diff

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

nikic added a comment. @aeubanks It seems like this has non-trivial impact on code size (http://llvm-compile-time-tracker.com/compare.php?from=a62cbd9a0211d08bace8794b435996890feb44d4=7805d7f72c337bfcc2fbc2dc9d2b9ac23474d5d9=size-text), so probably the compile-time change is a side-effect of

[PATCH] D101108: [PR49761] Fix variadic arg handling in matcher

chrish_ericsson_atx created this revision. chrish_ericsson_atx requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Mishandling of variadic arguments in a function call caused a crash (runtime assert fail) in

[PATCH] D101106: [HIP] Fix overloaded function for _Float16

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Specializes `__hip::is_arithmetic<_Float16>` so that overloaded functions with `_Float16` arguments resolve properly in a similar way as standard C++ header. https://reviews.llvm.org/D101106

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl updated this revision to Diff 339773. yaxunl added a comment. make it NFC for non-hipRTC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100794/new/ https://reviews.llvm.org/D100794 Files: clang/lib/Headers/__clang_hip_cmath.h clang/lib/Headers/__clang_hip_runtime_wrapper.h

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; krasimir wrote: > penagos wrote: > >

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks added a comment. this seems to have some compile time improvements? http://llvm-compile-time-tracker.com/compare.php?from=a62cbd9a0211d08bace8794b435996890feb44d4=7805d7f72c337bfcc2fbc2dc9d2b9ac23474d5d9=instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101077: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1592-1598 + if (auto *CodeObjArg = + Args.getLastArg(options::OPT_mcode_object_v3_legacy, + options::OPT_mno_code_object_v3_legacy, +

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

ychen accepted this revision. ychen added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101016/new/ https://reviews.llvm.org/D101016 ___ cfe-commits mailing list

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

MaskRay added inline comments. Comment at: llvm/docs/LangRef.rst:7019 + function will get the ``uwtable`` function attribute. + Objective-C Garbage Collection Module Flags Metadata I'll add: These metadata correspond to a few function attributes with

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/IR/Function.cpp:333 Function *Function::createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, nickdesaulniers

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

MaskRay updated this revision to Diff 339760. MaskRay marked an inline comment as done. MaskRay added a comment. Herald added a subscriber: jdoerfert. use enum. add doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101016/new/

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo marked an inline comment as done. mstorsjo added a comment. Any further comments on this one, or is tolerable in this form? I'd prefer to not move the unescaping to shared code for now (as the exact definition of what it should do is a bit open). Repository: rG LLVM Github Monorepo

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:309 +}; +template <> struct is_arithmetic<_Float16> { + enum { value = 1 }; This changes the overloading behavior of math functions with _Float16 arguments since previously we use

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri updated this revision to Diff 339757. lebedev.ri added a comment. @rsmith i was able to make some forward progress here. What do you think about this? (I haven't updated all tests because i don't want to waste hours doing that if this is still wrong) Repository: rG LLVM Github

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#2707677 , @jansvoboda11 wrote: > The fact that tests pass in assert builds without the argument generation > suggests the feature doesn't have sufficient test coverage. Currently, the > flag will be dropped during

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. When find_package can find rocr, but it sets up include paths that don't work with it, I think that constitutes a broken rocr install. At least, one that is difficult to use from cmake. The packages are meant to deal with that sort of thing which suggests the

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 339753. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. In D99949#2709785 , @JonChesterfield wrote: > It's not obvious to me why any of those stages would get a different result > for the search for rocr. Do you do things with chroot/jails to ensure > isolation for some of

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. It's not obvious to me why any of those stages would get a different result for the search for rocr. Do you do things with chroot/jails to ensure isolation for some of them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. ahatanak requested review of this revision. In the following example, the block passed to the function is marked as `noescape`, which is incorrect as the `noescape` attribute

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

jdoerfert added a comment. In D91054#2708924 , @AMDChirag wrote: > In D91054#2708873 , @jdoerfert wrote: > >> What is missing or not working in the IRBuilder impl that prevents us from >> turning it on by default?

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. In D99949#2709673 , @JonChesterfield wrote: > That's interesting. The various permutations I have on disk are also all > path/include/hsa/hsa.h. The existing in tree use of hsa.h is the amdgpu > plugin, which uses

[clang] 24c1ed3 - Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Jon Chesterfield Date: 2021-04-22T19:39:37+01:00 New Revision: 24c1ed3b34f7602b955e52cd8a362f4e27eb5f20 URL: https://github.com/llvm/llvm-project/commit/24c1ed3b34f7602b955e52cd8a362f4e27eb5f20 DIFF:

[clang] d71ee39 - Add support of the next Ubuntu (Ubuntu 21.10 - Impish Idri)

Author: Sylvestre Ledru Date: 2021-04-22T20:38:28+02:00 New Revision: d71ee3993fe7decab00c3083438e13f81bd49f02 URL: https://github.com/llvm/llvm-project/commit/d71ee3993fe7decab00c3083438e13f81bd49f02 DIFF:

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabf3ca61e323: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment… (authored by xbolva00). Repository: rG LLVM Github

[clang] abf3ca6 - [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Author: Dávid Bolvanský Date: 2021-04-22T20:35:41+02:00 New Revision: abf3ca61e3235681f26d0f527b8e2763dd4c0c62 URL: https://github.com/llvm/llvm-project/commit/abf3ca61e3235681f26d0f527b8e2763dd4c0c62 DIFF:

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. That's interesting. The various permutations I have on disk are also all path/include/hsa/hsa.h. The existing in tree use of hsa.h is the amdgpu plugin, which uses `#include "hsa.h"` and `#include `, which seems unlikely to be correct. I'm going to patch this

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dexonsmith marked an inline comment as done. Closed by commit rGd4ee603c8f21: Coverage: Document how to collect a profile without a filesystem (authored by

[clang] d4ee603 - Coverage: Document how to collect a profile without a filesystem

Author: Duncan P. N. Exon Smith Date: 2021-04-22T11:29:39-07:00 New Revision: d4ee603c8f21b4ae722c2a34d4dfa54b7abeeb16 URL: https://github.com/llvm/llvm-project/commit/d4ee603c8f21b4ae722c2a34d4dfa54b7abeeb16 DIFF:

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. What matter isn't "convergent" in itself, it is how it restricts transformations: if you know that all the control flow is always uniform, are there still restriction on any transformation in presence of convergent instructions? If not, then the "target approach"

[PATCH] D98746: [clang][amdgpu] Use implicit code object default

JonChesterfield added a comment. Revision at D101095 implements the suggestion above. The argument is passed to llc whenever an argument was passed to clang. Front end tests / device runtime libraries that are happy with the default can then build without the

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia added a comment. Just a few nitpicks otherwise it looks great! Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:364 + +def warn_opencl_not_supported_core_feature : Warning< + "%0 is a core feature in this OpenCL version but not supported on this

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield added a comment. Diff created relative to D101077 , not relative to main. Iiuc that will work out fine if the NFC lands first. Comment at: clang/test/Driver/hip-code-object-version.hip:55 // RUN: %s 2>&1 | FileCheck

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield created this revision. JonChesterfield added reviewers: yaxunl, t-tye, kzhuravl, ronlieb, b-sumner, pdhaliwal. Herald added subscribers: pengfei, tpr, dstuttard. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 updated this revision to Diff 339734. xbolva00 added a comment. Use suggested flag names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79714/new/ https://reviews.llvm.org/D79714 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. And if it helps: $ sudo find / -xdev -name hsa.h /usr/include/hsa/hsa.h /opt/rocm-3.10.0/include/hsa/hsa.h /opt/rocm-4.0.0/include/hsa/hsa.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/

  1   2   3   >