[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

2021-04-26 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for tracking it down, and sorry for the delay. I thought the crash was fix in https://reviews.llvm.org/D99145. Thinking more about it, this is a recovery-expr crash, see my comment below. Comment at: clang/lib/Sema/SemaChecking.cpp:4543 //

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

2021-04-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1482 Bind.method("textDocument/semanticTokens/full/delta", this, ::onSemanticTokensDelta); -

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG645c5f27a84d: [RISCV] Implement the pseudo compare builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100823?vs=339879=340444#toc Repository: rG LLVM Github

[PATCH] D100822: [RISCV] Implement the vfabs.v/vfneg.v builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb3fca7e110: [RISCV] Implement the vfabs.v/vfneg.v builtin. (authored by HsiangKai). Changed prior to commit:

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

2021-04-26 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4b2434172cc1: [RISCV] Implement the vmmv.m/vmnot.m builtin. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D100821?vs=339875=340442#toc Repository: rG LLVM Github

[clang] bfb3fca - [RISCV] Implement the vfabs.v/vfneg.v builtin.

2021-04-26 Thread Hsiangkai Wang via cfe-commits
Author: Hsiangkai Wang Date: 2021-04-26T15:38:31+08:00 New Revision: bfb3fca7e110a367c9589495575913d83bea7095 URL: https://github.com/llvm/llvm-project/commit/bfb3fca7e110a367c9589495575913d83bea7095 DIFF:

[clang] 4b24341 - [RISCV] Implement the vmmv.m/vmnot.m builtin.

2021-04-26 Thread Hsiangkai Wang via cfe-commits
Author: Hsiangkai Wang Date: 2021-04-26T15:38:31+08:00 New Revision: 4b2434172cc15ccd32c5c9110a3a4df18b8fba5e URL: https://github.com/llvm/llvm-project/commit/4b2434172cc15ccd32c5c9110a3a4df18b8fba5e DIFF:

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

2021-04-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D98726#2714215 , @RedDocMD wrote: > I think something is wrong about the way we are investigating this or I don't > understand the `MallocChecker`. > The following doesn't yield a bug report! => https://godbolt.org/z/Y57G7zE5j

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

2021-04-26 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D100739#2713579 , @ychen wrote: > In D100739#2711698 , @ChuanqiXu > wrote: > >>> This is an alternative to D97915 which >>> missed proper

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

2021-04-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:163-165 + ProgramStateManager = N->getState()->getStateManager(); + MemRegionManager = StateMgr.getRegionManager(); + return MRMgr.getVarRegion(VD,

[PATCH] D100742: [clangd] Parameter hints for dependent calls

2021-04-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a reviewer: sammccall. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:264 +// FIXME: This one does not work yet. +A::static_member($par3[[t]]); } This is an interesting case.

[PATCH] D100742: [clangd] Parameter hints for dependent calls

2021-04-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 340439. nridge added a comment. Herald added a subscriber: cfe-commits. Add some more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100742/new/ https://reviews.llvm.org/D100742 Files:

[PATCH] D100852: [analyzer] Track leaking object through stores

2021-04-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:636 if (isa(R)) - Result.push_back(R); + Result.emplace_back(R,

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

2021-04-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:967-968 + + // While looking for the last var bindings, we can still find + // `AllocFirstBinding` to be one of them. In situations like this, + // it

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

2021-04-26 Thread Marco Gartmann via Phabricator via cfe-commits
mgartmann added a comment. Friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2   3