[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

cjdb created this revision. cjdb added reviewers: rsmith, gbiv, aaron.ballman, manojgupta. Herald added a reviewer: george.burgess.iv. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [namespace.std]/p6 indicates that taking the address

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2727787 , @ychen wrote: > In D97915#2727759 , @ChuanqiXu wrote: > >> May I ask a question may be too simple? What if the user specify the >> alignment for promise (or any other

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2727974 , @ChuanqiXu wrote: > In D100739#2727808 , @ychen wrote: > >> In D100739#2718528 , @ChuanqiXu >> wrote: >> >>> In D100739#271851

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2727808 , @ychen wrote: > In D100739#2718528 , @ChuanqiXu > wrote: > >> In D100739#2718514 , @ychen wrote: >> >>> Oh, right now C++

[PATCH] D99599: [NewPM] Add an option to dump pass structure

phosek added a comment. It looks like the `BarrierNoop` pass is inserted under `-O0` when any extension is registered . We enable Polly in our toolchain so tha

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur added a comment. testcase That is, something that calls createOffloadMaptypes/createOffloadMapnames independently of any front-end. Can be as simply as calling it and checking tha

[PATCH] D101595: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

Meinersbur created this revision. Meinersbur added reviewers: ye-luo, JonChesterfield, ABataev, patricklyster, kkwli0. Meinersbur added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald adde

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2718528 , @ChuanqiXu wrote: > In D100739#2718514 , @ychen wrote: > >> Oh, right now C++ coroutine standard is written in the way that the aligned >> new is not searched by the fr

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 341756. ychen added a comment. - Add missed `Shape.CoroRawFramePtrOffsets.clear();` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.c

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2727759 , @ChuanqiXu wrote: > May I ask a question may be too simple? What if the user specify the > alignment for promise (or any other local variables) to 128 or even 256? > Since it looks like all the discuss before as

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. May I ask a question may be too simple? What if the user specify the alignment for promise (or any other local variables) to 128 or even 256? Since it looks like all the discuss before assumes that the largest alignment requirement is 64. Repository: rG LLVM Githu

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; nickdesaulniers wrote: > xbolva00 wrote: > > nickdesa

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; -

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus requested review of this revision. roligugus added a comment. @JakeMerdichAMD, @MyDeveloperDay Sorry to bother with a re-review. Did not know how to ask this. Jake accepted this patch last August and it has been sitting in "ready to land" since then. I was assuming that it'll automatic

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 341742. nickdesaulniers added a comment. - remove extra whitespace, use xbolva00's sugguestion text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files: c

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

dexonsmith added a comment. In D101506#2724746 , @MaskRay wrote: > Perhaps split the migration part from the `OpenFlags` removal part. I thought > about deleting the aliases too but refrained because I noticed our internal > code base needs migration. >

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2727432 , @mbenfield wrote: > In D100581#2727357 , @dblaikie > wrote: > >> > > > >> Got a link/examples of cases GCC does and doesn't warn about? I'd assume >> it'd have som

[PATCH] D101338: [MS] Preserve base register %rbx around cpuid

pengfei added a comment. In D101338#2726759 , @rnk wrote: > Seems reasonable, thanks. > > We really ought to solve the general problem one day. It is kind of > pig-headed that the backend just picks two arbitrary CSRs, the base and frame > pointers, and

[PATCH] D101338: [MS] Preserve base register %rbx around cpuid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c7db7d8ce7: [MS] Preserve base register %rbx around cpuid (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D101338?vs=34

[clang] e0c7db7 - [MS] Preserve base register %rbx around cpuid

Author: Wang, Pengfei Date: 2021-04-30T10:16:25+08:00 New Revision: e0c7db7d8ce780df5129b4d0f5bbf145271ef14f URL: https://github.com/llvm/llvm-project/commit/e0c7db7d8ce780df5129b4d0f5bbf145271ef14f DIFF: https://github.com/llvm/llvm-project/commit/e0c7db7d8ce780df5129b4d0f5bbf145271ef14f.diff

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:131-133 + "invalid argument '-mno-amdgpu-ieee' only allowed with floating point options " + "which do not honor NaNs, e.g. '-fno-honor-nans', '-ffast-math', " + "'-ffinite-math-only',

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. In D101566#2727312 , @dblaikie wrote: > I think it'd be good to gather that data first before committing it to Clang > - that's usually what we try to do to justify the warning. Well, except that this isn't a new warning. B

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

rsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3115 D.Diag(diag::err_drv_invalid_value_with_suggestion) - << A->getOption().getName() << Value - << "valid arguments to '-mstack-protector-guard=' are:tls global"; + << A->g

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; nickdesaulniers wrote: > xbolva00 wrote: > > invalid

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; xbolva00 wrote: > invalid value '%1' in '%0',

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2727460 , @aeubanks wrote: > regarding adding these to a warning group in a separate change, it's easier > to revert a smaller second change that adds this to warning groups, and > easier to iterate upon in tree when

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; invalid value '%1' in '%0', value must be '%2' or gre

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. regarding adding these to a warning group in a separate change, it's easier to revert a smaller second change that adds this to warning groups, and easier to iterate upon in tree when there are discovered issues it's not dead code if it has tests Repository: rG LLVM

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. While I appreciate the flexibility afforded by %select; I find the suggestions unreadable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 ___

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 341711. nickdesaulniers added a comment. - fix flang diag placeholders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files: clang/include/clang/Basic/Diag

[PATCH] D101387: remove single quotes around sugguestion diagnostic

nickdesaulniers updated this revision to Diff 341709. nickdesaulniers added a comment. - rework diags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files: clang/include/clang/Basic/DiagnosticDriverKin

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. Will also make a new revision tomorrow with these warnings added to the appropriate groups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2727357 , @dblaikie wrote: > > Got a link/examples of cases GCC does and doesn't warn about? I'd assume it'd > have something to do with the triviality or non-triviality of certain > operations of the nonscalar

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. I'm happy to retest with a few Linux kernel builds...tomorrow! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___ cfe-commits

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-note-tags.cpp:16 +int test_note(int x, int y) { +__single_val_1(x); // expected-note{{Applied constraint: The 1st arg should be within the range [1, 1]}} +return y / (1 -

[PATCH] D101589: [AST] Add Concept-related locations to node introspection

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgrang. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This would be less complicated if the ReturnTypeRequirement were not a nested c

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG809435e390e9: [Sema] Don't set BlockDecl's DoesNotEscape bit if the parameter type of (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] 809435e - [Sema] Don't set BlockDecl's DoesNotEscape bit if the parameter type of

Author: Akira Hatanaka Date: 2021-04-29T16:19:48-07:00 New Revision: 809435e390e91355f64bee0142a65c4fe6e9f488 URL: https://github.com/llvm/llvm-project/commit/809435e390e91355f64bee0142a65c4fe6e9f488 DIFF: https://github.com/llvm/llvm-project/commit/809435e390e91355f64bee0142a65c4fe6e9f488.diff

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. >> I've removed these warnings from the diagnostic groups -Wextra But to remove all false positives, you need reports from users of -Wextra. Otherwise this would be dead code with no users. I suggest to leave it in groups. Now you can ask folks to try this patch with

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Ping on this - have you had a chance to look at this false positive? On Sat, Apr 3, 2021 at 4:29 PM David Blaikie wrote: > > Looks like this has a false positive (that's firing on some mlir code, > committed a workaround in 499571ea835daf786626a0db1e12f890b6cd8f8d ) > like this: > > $ cat test.c

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2727330 , @mbenfield wrote: > Another try at these warnings, using the implementation strategy outlined by > rsmith. > > A couple other notes: > > - At the moment I've removed these warnings from the diagnostic groups

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 341695. mbenfield added a comment. Another try at these warnings, using the implementation strategy outlined by rsmith. A couple other notes: - At the moment I've removed these warnings from the diagnostic groups -Wextra and -Wunused. It was suggested by

[PATCH] D101502: [ObjC][ARC] Don't enter the cleanup scope if the initializer expression isn't an ExprWithCleanups

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e1d9ebd46b8: [ObjC][ARC] Don't enter the cleanup scope if the initializer expression (authored by ahatanak). Changed prior to commit: https://rev

[clang] 2e1d9eb - [ObjC][ARC] Don't enter the cleanup scope if the initializer expression

Author: Akira Hatanaka Date: 2021-04-29T16:04:30-07:00 New Revision: 2e1d9ebd46b826b06f0a5882e992e3d84335f268 URL: https://github.com/llvm/llvm-project/commit/2e1d9ebd46b826b06f0a5882e992e3d84335f268 DIFF: https://github.com/llvm/llvm-project/commit/2e1d9ebd46b826b06f0a5882e992e3d84335f268.diff

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added a comment. In D101566#2727244 , @aaronpuchert wrote: > In D101566#2726820 , @dblaikie > wrote: > >> Along time ago Clang had a fairly strong aversion to implementing "off by >> default" warnings

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

MaskRay added a comment. I've fixed Halide and sent patches for https://github.com/JuliaLang/julia/pull/40666 & https://github.com/rust-lang/rust/pull/84724 & https://github.com/GPUOpen-Drivers/llpc/pull/1232 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101209/new/ https://reviews.llvm.org/D101209 ___

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. In D101566#2726820 , @dblaikie wrote: > Along time ago Clang had a fairly strong aversion to implementing "off by > default" warnings ([...]) because they would tend to go unused and > unmaintained. That was a valid reason

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341683. dgoldman added a comment. Fix casing warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D101572: Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`.

steveire added a reviewer: stephenkelly. steveire added a comment. According to llvm-project/clang/include/clang/AST$ git grep "TypeSourceInfo.*const" there are lots of other classes with `TypeSourceInfo` accessors which could be supported here. Should any others be supported? Is something sp

[PATCH] D100914: [clang] Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. This is the same as https://reviews.llvm.org/D80172, right? LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100914/new/ https://reviews.llvm.o

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

rnk added a subscriber: chandlerc. rnk added a comment. I should add that I started to think this way after @chandlerc asked me to capitalize "Clang" in some slides for a presentation I was giving years ago. I didn't invent this convention, other people already follow it. Repository: rG LLVM

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

rnk added a comment. This is what I said back in 2018 on the bug: > I think you're right, we generally try to capitalize "Clang" when referring > to the project and use lower case when talking about the command name. People > do the same thing with "GCC" and "gcc". We're not always consistent t

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. Recommitted with a fix for the M1 openMP issue: To https://github.com/llvm/llvm-project.git 3aaac01aab2f..6b938d2ead2c main -> main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100807/new

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2720277 , @thakis wrote: > In D100807#2719873 , @arphaman > wrote: > >> We have M1 CI running internally but it's post >> commit only right now

[clang] 6b938d2 - Recommit "[clang][driver] Use the provided arch name for a Darwin target triple

Author: Alex Lorenz Date: 2021-04-29T15:00:40-07:00 New Revision: 6b938d2ead2cb0465436496c0171c7d750e11773 URL: https://github.com/llvm/llvm-project/commit/6b938d2ead2cb0465436496c0171c7d750e11773 DIFF: https://github.com/llvm/llvm-project/commit/6b938d2ead2cb0465436496c0171c7d750e11773.diff L

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 341652. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726845 , @ABataev wrote: > In D99432#2726588 , @estewart08 > wrote: > >> In D99432#2726391 , @ABataev wrote: >> >>> In D99432#2726337

[PATCH] D101572: Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`.

SilensAngelusNex created this revision. SilensAngelusNex requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101572 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang

[clang] 74d9a76 - [CMake] Stop using c++ subdirectory for libc++ on Win to ARM Linux cross builds. NFC

Author: Vladimir Vereschaka Date: 2021-04-29T14:23:33-07:00 New Revision: 74d9a76ad3f55c16982ceaa8b6b4a6b7744109b1 URL: https://github.com/llvm/llvm-project/commit/74d9a76ad3f55c16982ceaa8b6b4a6b7744109b1 DIFF: https://github.com/llvm/llvm-project/commit/74d9a76ad3f55c16982ceaa8b6b4a6b7744109b1

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a subscriber: rnk. xgupta added a comment. In D101352#2726406 , @jrtc27 wrote: > I'm not convinced by these changes? Yes, I also thought first, clang man page can't be incorrect/inconsistent. I think @rnk can suggest the changes as he has a

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added a comment. @h-joo , seems we had a comment race :D cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 ___ cfe-commits mailing list cfe-commi

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:158 std::string ReferencesText; -bool SymbolsInOrder = true; -for (unsigned i = 0, e = Indices.size(); i != e; ++i) { - JsModuleReference Reference = References[Indices[i]]; -

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:252 + SmallVector + sortModuleReferences(SmallVector &References) { +// Sort module references. `References` seem read-only. Can you make it `const Smallvector &`? ===

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726588 , @estewart08 wrote: > In D99432#2726391 , @ABataev wrote: > >> In D99432#2726337 , @estewart08 >> wrote: >> >>> In D99432#2726060

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

shafik added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:589 + TheTarget->createMCObjectFileInfo( + /*PIC*/ false, Ctx)); + Ctx.setObjectFileInfo(MOFI.get()); `/*PIC=*/false` Comment at: llvm/tools/llvm-mca/llvm

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

rjmccall added a comment. Seems conceptually okay, given that we have an option to control it. Comment at: clang/lib/CodeGen/CGStmt.cpp:796 + bool EmitBoolCondBranch = !C || !C->isOne(); + bool CondIsConst = C; const SourceRange &R = S.getSourceRange(); fh

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

shafik added inline comments. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:909 + new llvm::MCContext(llvm::Triple(triple), asm_info_up.get(), + reg_info_up.get(), nullptr, subtarget_info_up.get())); if (!context_up) --

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added subscribers: respindola, doug.gregor. dblaikie added a comment. Along time ago Clang had a fairly strong aversion to implementing "off by default" warnings (though clearly weak-vtables was an exception to that - it's a pretty esoteric warning even at the best of times/without this

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

steveire added a comment. I implemented something like this recently too. The code I was trying to refactor was something like auto ii = 0; for (ii = 0; ii < thing.size(); ++ii) { // code } // code for (ii = 0; ii < thing.size(); ++ii) { // code } // code for (ii

[PATCH] D101338: [MS] Preserve base register %rbx around cpuid

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, thanks. We really ought to solve the general problem one day. It is kind of pig-headed that the backend just picks two arbitrary CSRs, the base and frame pointers, and doesn't bot

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implicit instantiations of template classes with virtual methods might cause the vtable (and al

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101564/new/ https://reviews.llvm.org/D101564

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

jdenny created this revision. jdenny added reviewers: jhuber6, jdoerfert. Herald added subscribers: guansong, yaxunl. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. This patch fixes a bug from D89802 .

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. In D99381#2723563 , @vitalybuka wrote: > In D99381#2721619 , @phosek wrote: > >> What I think @vitalybuka meant is keeping >> `sanitizer_platform_limits_fuchsia.h` as you had it, but in

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan updated this revision to Diff 341610. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 Files: compiler-rt/lib/hwasan/hwasan_interceptors.cpp compil

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726391 , @ABataev wrote: > In D99432#2726337 , @estewart08 > wrote: > >> In D99432#2726060 , @ABataev wrote: >> >>> In D99432#2726050

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. Output from `clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1`: Pass Arguments: -tti -targetlibinfo Target Transform Information Target Library Information

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2705 } - if (FormatTok->Tok.is(tok::l_brace)) { + if (FormatTok->Tok.is(tok::equal)) { +nextToken(); MyDeveloperDay wrote: > shouldn't this be > > ```FormatTo

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aeubanks created this revision. Herald added a reviewer: aaron.ballman. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101561 Files: clang/include/clang/Basic/Att

[clang] 2d42b2e - [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

Author: Dan Liew Date: 2021-04-29T11:55:42-07:00 New Revision: 2d42b2ee7bafe76d6b2c792b73f7371cb1cf8d94 URL: https://github.com/llvm/llvm-project/commit/2d42b2ee7bafe76d6b2c792b73f7371cb1cf8d94 DIFF: https://github.com/llvm/llvm-project/commit/2d42b2ee7bafe76d6b2c792b73f7371cb1cf8d94.diff LOG:

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d42b2ee7baf: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix. (authored by delcypher). Repository: rG LLVM Github

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher added a comment. @jansvoboda11 I'm going to land this patch as is (with your nit fixed). If you would like me to add an alias please follow up with me and I can put up a patch to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher updated this revision to Diff 341596. delcypher added a comment. Rename def too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101491/new/ https://reviews.llvm.org/D101491 Files: clang/docs/ClangCommandLineReference.rst clang/include

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. For coroutine `f0` in `test/CodeGenCoroutines/coro-alloc.cpp` The allocation looks like this: ; Function Attrs: noinline nounwind optnone mustprogress define dso_local void @f0() #0 { entry: %0 = alloca %struct.global_new_delete_tag, align 1 %1 = alloca %stru

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies marked an inline comment as done. ffrankies added a comment. @Eugene.Zelenko @aaron.ballman Are there any more changes that need to be made to this check or comments that need to be addressed? Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranch

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 341592. ychen added a comment. - fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCoroutine.cpp c

[PATCH] D101479: [Driver] Support libc++ in MSVC

rnk added a comment. The test doesn't seem to pass on Jenkins. Maybe we need a REQUIRES line or a fake sysroot or something for the test. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1332 + + auto AddLibcxxIncludePath = [&](StringRef Path) { +std::string Version = det

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 341591. ychen added a comment. - fix a bug. ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Code

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

jrtc27 added a comment. I'm not convinced by these changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 341589. clementval added a comment. Fix global variable names. Separator comes from OpenMP runtime information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Fil

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726337 , @estewart08 wrote: > In D99432#2726060 , @ABataev wrote: > >> In D99432#2726050 , @estewart08 >> wrote: >> >>> In D99432#2726025

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. In D99599#2726252 , @evgeny777 wrote: > @haowei What are LLVM configuration options? Also please send output from > > /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager > -fdebug-pass-structure -O0 -S -emit-llvm

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2726060 , @ABataev wrote: > In D99432#2726050 , @estewart08 > wrote: > >> In D99432#2726025 , @ABataev wrote: >> >>> In D99432#2726019

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher added a comment. In D101491#2725348 , @jansvoboda11 wrote: > In D101491#2724025 , @delcypher > wrote: > >> @jansvoboda11 Should I use the the alias feature so that the old >> `-fsanitize-address-destr

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. Hm ... I see BarrierNoop pass being added before `annotation-remarks`. Why's that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99599/new/ https://reviews.llvm.org/D99599 ___

[PATCH] D98300: [TLS] Initialization functions of dynamic TLS variables cannot be in a comdat (fix for PR48030)

wolfgangp added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98300/new/ https://reviews.llvm.org/D98300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This allows us to

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. @haowei What are LLVM configuration options? Also please send output from /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null

  1   2   >