[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively updated this revision to Diff 342121. tlively added a comment. - squash to include all changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101684/new/ https://reviews.llvm.org/D101684 Files: clang/lib/Headers/wasm_simd128.h clang/tes

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. A

[PATCH] D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

ggeorgakoudis created this revision. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101683 File

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl updated this revision to Diff 342111. yaxunl marked an inline comment as done. yaxunl added a comment. updated help text and test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 Files: clang/include/clang/Basic/CodeGenOptions.def clan

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Darwin.

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:401 return "aix"; + case llvm::Triple::Darwin: +return "darwin"; Should this also apply to `llvm::Triple::MacOSX` , `iOS`, and other Darwin OSes? Repository: rG LLVM Github M

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3186 + "gathering quiet and propagate signaling NaN inputs per IEEE 754-2008 " + "(AMDGPU only)">, + NegFlag>, Group; arsenm wrote: > Maybe

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Darwin.

delcypher created this revision. delcypher added reviewers: arphaman, dexonsmith, kubamracek, aralisza, yln. delcypher requested review of this revision. Herald added a project: clang. When the Darwin target triple included the OS version number this would cause `ToolChain::getCompilerRTPath()` to

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. FWIW `gcc` does not warn in this case regardless of any cast: void f() { int x; x = 0; sizeof(x); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[clang] 8fc5f07 - [clang][driver][darwin] use the deployment target version as the SDK version

Author: Alex Lorenz Date: 2021-04-30T18:54:02-07:00 New Revision: 8fc5f07fc0aee95ff9f79e91035d115690177dc1 URL: https://github.com/llvm/llvm-project/commit/8fc5f07fc0aee95ff9f79e91035d115690177dc1 DIFF: https://github.com/llvm/llvm-project/commit/8fc5f07fc0aee95ff9f79e91035d115690177dc1.diff L

[clang] bfd60b3 - [PowerPC] Add floating point overloads for vec_sldw

Author: Nemanja Ivanovic Date: 2021-04-30T20:29:03-05:00 New Revision: bfd60b36f825c299971bb0c2bf973031e2e0fc09 URL: https://github.com/llvm/llvm-project/commit/bfd60b36f825c299971bb0c2bf973031e2e0fc09 DIFF: https://github.com/llvm/llvm-project/commit/bfd60b36f825c299971bb0c2bf973031e2e0fc09.di

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a subscriber: rnk. thakis added a comment. > ! In D99741#2721669 , @craig.topper > wrote: > We're preparing a patch to remove to stop testing both rv32 and rv64 on > every test. That should reduce the time by half. What is an acceptable numb

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. casting to void is the normal way to get around these warnings, these new warnings should also not diagnose anything with a cast to void Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3da07d216dd: [PowerPC] Provide fastmath sqrt and div functions in altivec.h (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES

[clang] c3da07d - [PowerPC] Provide fastmath sqrt and div functions in altivec.h

Author: Nemanja Ivanovic Date: 2021-04-30T19:17:48-05:00 New Revision: c3da07d216dd20fbdb7302fd085c0a59e189ae3d URL: https://github.com/llvm/llvm-project/commit/c3da07d216dd20fbdb7302fd085c0a59e189ae3d DIFF: https://github.com/llvm/llvm-project/commit/c3da07d216dd20fbdb7302fd085c0a59e189ae3d.di

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2730743 , @nickdesaulniers wrote: > Testing Diff 342071 on the mainline Linux kernel, just building x86_64 > defconfig triggers 19 instances of this warning; all look legit. ;) > > In D100581#2730708

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. In D100581#2730760 , @mbenfield wrote: > In D100581#2730557 , > @nickdesaulniers wrote: > >> I see lots of instances from the kernel that look like this when reduced: > > > >> But

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2730557 , @nickdesaulniers wrote: > I see lots of instances from the kernel that look like this when reduced: > But adding a new warning flags to a handful of existing tests' RUN lines is > unusual. These tests

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:3186 + "gathering quiet and propagate signaling NaN inputs per IEEE 754-2008 " + "(AMDGPU only)">, + NegFlag>, Group;

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added a comment. In D101566#2730555 , @aaronpuchert wrote: > So I tried this in two code bases, both of which don't have `-Wweak-vtables` > enabled though. > > In the first (~500 TUs) there were a couple of interesting finds. But they > are ha

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. Testing Diff 342071 on the mainline Linux kernel, just building x86_64 defconfig triggers 19 instances of this warning; all look legit. ;) In D100581#2730708 , @dblaikie wrote: > In D100581#2730557

[PATCH] D101654: [HIP] Fix device lib selection

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-device-libs.hip:165 +// FAST: "-mlink-builtin-bitcode" "{{.*}}oclc_daz_opt_off.bc" +// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_unsafe_math_on.bc" +// FAST-SAME: "-mlin

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. The additions of `-Wno-unused-but-set-variable` to: - clang/test/SemaObjC/foreach.m - clang/test/SemaCXX/sizeless-1.cpp - clang/test/SemaCXX/shift.cpp - clang/test/SemaCXX/goto.cpp - clang/test/Sema/vector-gcc-compat.cpp - clang/test/Sema/vector-gcc-compat.c - cla

[PATCH] D101654: [HIP] Fix device lib selection

MaskRay added inline comments. Comment at: clang/test/Driver/hip-device-libs.hip:165 +// FAST: "-mlink-builtin-bitcode" "{{.*}}oclc_daz_opt_off.bc" +// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_unsafe_math_on.bc" +// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_finite_on

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dblaikie added a comment. In D100581#2730557 , @nickdesaulniers wrote: > I see lots of instances from the kernel that look like this when reduced: > > $ cat foo.c > int page; > int put_page_testzero(int); > void foo (void) { > int zeroed; >

[PATCH] D101248: [RISCV] [1/2] Add IR intrinsic for Zbm extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101248/new/ https://reviews.llvm.org/D101248 ___

[PATCH] D101614: [clang-tidy][NFC] Simplify a lot of bugprone-sizeof-expression matchers

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp:87 const auto IntegerExpr = ignoringParenImpCasts(integerLiteral()); - const auto ConstantExpr = expr(ignoringParenImpCasts( + const auto ConstantExpr = ignoringParenI

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 342071. mbenfield added a comment. Count a non-ODR use as a reference, so that examples like that of nickdesaulniers don't warn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm

[PATCH] D101672: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

dexonsmith added a comment. Just fixed a typo in the description, where the second paragraph should start: > The extra cases where this is set are all some version of a fatal error, > and the only client of the field, shouldBuildGlobalModuleIndex, seems > to be unreachable in that case. (and now

[PATCH] D101672: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, Bigcheese, rsmith. Herald added a subscriber: arphaman. dexonsmith requested review of this revision. Herald added a project: clang. DisableGeneratingGlobalModuleIndex was being set by CompilerInstance::findOrCompileModule

[PATCH] D101671: Modules: Remove an extra early return, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, Bigcheese. dexonsmith requested review of this revision. Herald added a project: clang. Remove an early return from an `else` block that's immediately followed by an equivalent early return after the `else` block. Reposi

[PATCH] D101670: Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, Bigcheese, rsmith. Herald added a subscriber: arphaman. dexonsmith requested review of this revision. Herald added a project: clang. Rename CompilerInstance's ModuleBuildFailed field to DisableGeneratingGlobalModuleIndex,

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. I see lots of instances from the kernel that look like this when reduced: $ cat foo.c int page; int put_page_testzero(int); void foo (void) { int zeroed; zeroed = put_page_testzero(page); ((void)(sizeof(( long)(!zeroed; } $ clang -c -Wa

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. So I tried this in two code bases, both of which don't have `-Wweak-vtables` enabled though. In the first (~500 TUs) there were a couple of interesting finds. But they are hard to fix, even where explicit instantiations were already there: the corresponding instan

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

dexonsmith created this revision. dexonsmith added reviewers: jansvoboda11, Bigcheese, rsmith. dexonsmith requested review of this revision. Herald added a project: clang. 5cca622310c10fdf6f921b6cce26f91d9f14c762 (https://revi

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 342037. mbenfield added a comment. Correct struct and vector behavior. gcc doesn't warn for any structs in C++. However, it _does_ warn for vector types. Those warnings are sometimes masked by other errors, leading to my earlier belief that it is inconsis

[PATCH] D101429: PR45879: Use LValue object to evaluate active union members

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This change is not correct. The language rules only apply to particular syntactic forms, so we need to check for those exact syntactic forms here. Repository: rG LLVM Github Monor

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2729975 , @tra wrote: > What will happen with this patch in the following scenarios: > > - `--offload_arch=A -S -o out.s` > - `--offload_arch=A --offload-arch=B -S -o out.s` > > I would expect the first case to produce a

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. Apparently arc and/or Phabricator doesn't like my attempt to split this review into two separate commits. Next revision will have only one commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews

[PATCH] D101654: [HIP] Fix device lib selection

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-device-libs.hip:117 +// Test -fast-math +// RUN: %clang -### -target x86_64-linux-gnu \ +// RUN: --cuda-gpu-arch=gfx900 \ MaskRay wrote: > You can pack more

[clang] 82e99f5 - [OpenMP] Fix second debug name from map clause

Author: Joel E. Denny Date: 2021-04-30T16:26:59-04:00 New Revision: 82e99f50351dd83d854f45bab3d91d4e6ad6450e URL: https://github.com/llvm/llvm-project/commit/82e99f50351dd83d854f45bab3d91d4e6ad6450e DIFF: https://github.com/llvm/llvm-project/commit/82e99f50351dd83d854f45bab3d91d4e6ad6450e.diff

[PATCH] D101564: [OpenMP] Fix second debug name from map clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG82e99f50351d: [OpenMP] Fix second debug name from map clause (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101564/new/ https://reviews

[PATCH] D101572: Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`.

steveire added a comment. In D101572#2730012 , @SilensAngelusNex wrote: > Yes, the motivation for adding these is so I can use clang-transformer to > refactor a bunch of constructor calls to call a static factory method instead. > > // Before > ns::

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aeubanks added a comment. I'm first testing out if there are even noticeable benefits to doing this, then if there are I'll put something together to post to cfe-dev. https://crbug.com/1028731 for some background. I'm aware of trivial_abi and will consider wrapping this up into that, although w

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; nickdesaulniers wrote: > xbolva00 wrote: > > nickdesa

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

rsmith added a comment. In D101598#2729865 , @ldionne wrote: > Just for posterity, what we discussed is that since there is a list of > addressable functions in the standard, we should explore adding a warning to > Clang that fires whenever somebody tak

[PATCH] D101654: [HIP] Fix device lib selection

MaskRay added inline comments. Comment at: clang/test/Driver/hip-device-libs.hip:117 +// Test -fast-math +// RUN: %clang -### -target x86_64-linux-gnu \ +// RUN: --cuda-gpu-arch=gfx900 \ You can pack more arguments on one line. Fewer line wraps actually make a

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aaron.ballman added a comment. Some more background information on the idea would be helpful -- this strikes me as something that should probably start out as an RFC on cfe-dev (and maybe libcxx-dev?) to discuss the high-level goals and approaches, before doing much prototype work. Note: some r

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

pmatos added a comment. A quick note - apparently phab felt that since I accepted the revision, it's now ready to land. Probably obvious but I accepted expecting @tlively comments to be addressed first. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

pmatos accepted this revision. pmatos added a comment. This revision is now accepted and ready to land. This looks good to me - I will rebase D95425 on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:28-31 + hasOperatorName("="), hasOperatorName("*="), hasOperatorName("/="), + hasOperatorName("%="), hasOperatorName("+="), hasOperatorName("-="), +

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:876 UnusedLocalTypedef, UnusedValue, UnusedVariable, -UnusedPropertyIvar]>, +UnusedButSetVariable, UnusedPrope

[PATCH] D101654: [HIP] Fix device lib selection

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: dang. yaxunl requested review of this revision. Choose optimized device lib bitcode by fp options for performance. https://reviews.llvm.org/D101654 Files: clang/include/clang/Driver/Options.td clang/lib/C

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added a comment. @FarisRehman when I run `llvm-lit -vv flang/test/Driver/fixed-line-length.f90` I see: UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1) This is with `-DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt;flang"` used, and a `flang` binary produced. Does `R

[PATCH] D101595: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

Meinersbur planned changes to this revision. Meinersbur added a comment. Will fix the failed `required_codegen.cpp` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101595/new/ https://reviews.llvm.org/D101595 __

[PATCH] D101572: Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`.

SilensAngelusNex added a comment. Yes, the motivation for adding these is so I can use clang-transformer to refactor a bunch of constructor calls to call a static factory method instead. // Before ns::Foo x(1); auto y = ns::Foo(1, 2); // After auto x = ns::Foo::Make(1); auto y = n

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Ready for rereview. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< +"invalid value '%1' in '%0', expected '%1' to be '%2' or greater">;

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

xbolva00 added a comment. In D101598#2729865 , @ldionne wrote: > Just for posterity, what we discussed is that since there is a list of > addressable functions in the standard, we should explore adding a warning to > Clang that fires whenever somebody t

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. What will happen with this patch in the following scenarios: - `--offload_arch=A -S -o out.s` - `--offload_arch=A --offload-arch=B -S -o out.s` I would expect the first case to produce a plain text assembly file. With this patch the second case will produce a bundle. With s

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added a comment. Nice! I think that splitting this out of the change that adds reference types is a good idea. Regarding the FIXME in the test, is it the case that the globals are also not emitted in the binary format, or is it just the assembly output that is broken? ===

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

dexonsmith added a comment. In D101506#2729839 , @MaskRay wrote: > Perhaps give us and other projects one week or longer ... Sure thing; I'll try committing next week some time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101506/new/ https:/

[PATCH] D101650: Support: Stop using F_{None,Text,Append} compatibility synonyms, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG518d955f9dd2: Support: Stop using F_{None,Text,Append} compatibility synonyms, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

ldionne added a comment. Just for posterity, what we discussed is that since there is a list of addressable functions in the standard, we should explore adding a warning to Clang that fires whenever somebody takes the address of a function in namespace `std`, except if it's an addressable funct

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added a comment. Friendly reminder that I need someone to land this for me as I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2798 + (f32 (fpround f64:$A)), (f32 (fpround f64:$A, + (v4f32 (XXSPLTW (COPY_TO_REGCLASS (XSCVDPSP f64:$A), VSRC), 0))>; def : Pat<(v4f32 (build_vector

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Perhaps give us and other projects one week or longer ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101506/new/ https://reviews.llvm.org/D101506 ___

[PATCH] D101650: Support: Stop using F_{None,Text,Append} compatibility synonyms, NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101650/new/ https://reviews.llvm.org/D101650 _

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

dexonsmith updated this revision to Diff 341966. dexonsmith edited the summary of this revision. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D101506 -- that updates all in-tree users, and now this is just removing the API. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2729573 , @tra wrote: > CUDA compilation currently errors out if `-o` is used when more than one > output would be produced. > E.g. > > % bin/clang++ -x cuda --offload-arch=sm_60 --offload-arch=sm_70 > --cuda-path=$H

[PATCH] D101650: Support: Stop using F_{None,Text,Append} compatibility synonyms, NFC

dexonsmith created this revision. dexonsmith added a reviewer: MaskRay. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, bmahjour, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 341965. mbenfield added a comment. A second commit with UnusedButSetParameter and UnusedButSetVariable into groups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. @krisb Thanks for the review. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [&TemplateInfo, this]

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab19d84ce85: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https:

[clang] cab19d8 - [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

Author: Scott Linder Date: 2021-04-30T17:11:50Z New Revision: cab19d84ce85cbceec7fde515cc686d6a83a5f9d URL: https://github.com/llvm/llvm-project/commit/cab19d84ce85cbceec7fde515cc686d6a83a5f9d DIFF: https://github.com/llvm/llvm-project/commit/cab19d84ce85cbceec7fde515cc686d6a83a5f9d.diff LOG:

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Should the diagnostic be backed out until then? Roman On Fri, Apr 30, 2021 at 7:52 PM Christopher Di Bella via cfe-commits wrote: > > Sorry, not yet. I'll talk with my TL to see if I can get some time allotted > for this in the next few weeks. > > On Thu, 29 Apr 2021 at 16:13, David Blaikie wr

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Just some minor nits from me, but otherwise LG! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:66 + + auto CheckVaList = []

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341953. dgoldman marked 2 inline comments as done. dgoldman added a comment. Remove unnecessary null check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: c

[PATCH] D52524: Add -Wpoison-system-directories warning

aaron.ballman added a comment. In D52524#2721073 , @sbc100 wrote: > Would it make sense to have this apply to system library paths too? i.e. > `-L/usr/local/lib`. > > We have a bespoke mechanism in emscripten right now that is a bit more > flexible but

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked 5 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:433 +scopeModifier(const NamedDecl *D, const HighlightingsBuilder &HB) { + if (!D) +return llvm::None; kadircet wrote: >

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Sorry, not yet. I'll talk with my TL to see if I can get some time allotted for this in the next few weeks. On Thu, 29 Apr 2021 at 16:13, David Blaikie wrote: > Ping on this - have you had a chance to look at this false positive? > > On Sat, Apr 3, 2021 at 4:29 PM David Blaikie wrote: > > > > L

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341947. dgoldman marked an inline comment as done. dgoldman added a comment. Split defaultLibrary check to separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

cjdb abandoned this revision. cjdb added a comment. A different path forward was discussed with @ldionne and @zoecarver. Will experiment this other way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101598/new/ https://reviews.llvm.org/D101598 __

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. CUDA compilation currently errors out if `-o` is used when more than one output would be produced. E.g. % bin/clang++ -x cuda --offload-arch=sm_60 --offload-arch=sm_70 --cuda-path=$HOME/local/cuda-10.2 zz.cu -c -E #... preprocessed output from host and 2 GPU compilati

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/attr-no-address.cpp:47-48 +void address_test() { + void (*fp1)() = &std::one_overload; + // expected-error@-1{{cannot take address of 'std::one_overload' because functions in namespace 'std' are not addressable}

[PATCH] D101530: clang: Update comments on another libstdc++ HACK

This revision was automatically updated to reflect the committed changes. Closed by commit rGe90792d8c78b: [clang] Update comments on another libstdc++ HACK (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGE

[clang] e90792d - [clang] Update comments on another libstdc++ HACK

Author: Nathan Sidwell Date: 2021-04-30T09:29:26-07:00 New Revision: e90792d8c78bac79a1a39f245e222684ea24c7c0 URL: https://github.com/llvm/llvm-project/commit/e90792d8c78bac79a1a39f245e222684ea24c7c0 DIFF: https://github.com/llvm/llvm-project/commit/e90792d8c78bac79a1a39f245e222684ea24c7c0.diff

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

dgoldman created this revision. dgoldman added reviewers: sammccall, benlangmuir. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. We now make

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:765 +R = StateMgr.getStoreManager().castRegion(ER, CastTy); +return loc::MemRegionVal(R); + } bjope wrote: > This caused some problems with asserti

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval added a comment. In D101503#2727906 , @Meinersbur wrote: > testcase > > > That is, something that calls createOffloadMaptypes/createOffloa

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 341938. clementval marked 5 inline comments as done. clementval added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Files: c

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

zoecarver added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5972 + Although opt-in, the attribute poisons the entire overload set, meaning that only one overload + needs the attribute per set (although such usage is discouraged). Until there is confiden

[clang] a27af1d - [analyzer] Fix assertion in SVals.h

Author: Vince Bridgers Date: 2021-04-30T11:00:43-05:00 New Revision: a27af1d8166cc8cebd6ecfed94042852922d8239 URL: https://github.com/llvm/llvm-project/commit/a27af1d8166cc8cebd6ecfed94042852922d8239 DIFF: https://github.com/llvm/llvm-project/commit/a27af1d8166cc8cebd6ecfed94042852922d8239.diff

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGa27af1d8166c: [analyzer] Fix assertion in SVals.h (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:72 + set(COMPILER_RT_INSTALL_PATH "" CACHE PATH +"Prefix where built compiler-rt artifacts should be installed, comes before CMAKE_INSTALL_PREFIX.") option(COMPILER_RT_INCLUDE_TESTS "Ge

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 updated this revision to Diff 341929. DNS320 added a comment. Removed a link to the ES.26 C++ Core Guideline in the documentation part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100092/new/ https://reviews.llvm.org/D100092 Files: clan

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. @vabridgers Thank you for a good catch! The fix looks fairly reasonable for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1016

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur added a comment. In D101503#2729385 , @jdoerfert wrote: > I assume clang tests apply here. It replaces clang functionality after all. The policy so far was to have LLVM functionality tested in LLVM itself. See https://reviews.llvm.org/D91470#

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. This is now approved and passing CI, and I have also normalized the quoting @compnerd asked about (in I hope a satisfactory way). Should I be pinging someone to land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

jdoerfert added a comment. I assume clang tests apply here. It replaces clang functionality after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 ___ cfe-c

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 341925. kbobyrev added a comment. Inline gRPC deadline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd/index/remote/CMakeLists.txt

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

olestrohm added inline comments. Comment at: clang/test/SemaOpenCLCXX/reinterpret-cast.clcpp:1 +// RUN: %clang_cc1 %s -pedantic -verify -fsyntax-only + Anastasia wrote: > Btw I assume your patch also allows reinterpret_cast between vectors? What > happens if we

  1   2   >