[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added a comment. I think this patch is ready to go: running the test-suite on an ARM machine didn't complain anything. Well, but one thing that I'm concerned about is that from tomorrow I'll not be online for about three weeks. :( I'd like to find someone who reverts this patch if

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

MaskRay added inline comments. Comment at: clang/test/Driver/print-resource-dir.c:3 +// RUN:-resource-dir=%S/Inputs/resource-dir \ +// RUN: | FileCheck %s -check-prefix=PRINT-RESOURCE-DIR +// PRINT-RESOURCE-DIR: Inputs{{/|\\}}resource-dir You can

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the SIMD builtin load

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek updated this revision to Diff 342950. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101813/new/ https://reviews.llvm.org/D101813 Files: clang/test/Driver/immediate-options.c

[PATCH] D101883: [WebAssembly] Update SIMD builtin function operand types

tlively updated this revision to Diff 342946. tlively added a comment. - Remove (incorrect) const pointer changes. Will fix them and put them in a separate revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101883/new/

[PATCH] D101883: [WebAssembly] Update SIMD builtin function operand types

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `const` to the pointer

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. In D101684#2737842 , @penzn wrote: > I think there is another dimension to this aside from project composition - > intrinsics have a tendency to "interact" with their surroundings, and it > better to capture the IR rather than

[PATCH] D99755: Remove `clang/runtime`

Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 abandoned this revision. Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a subscriber: compnerd. Ericson2314 added a comment. @compnerd Would you like to review this one too (which the other you approved needs)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

penzn added a comment. I think there is another dimension to this aside from project composition - intrinsics have a tendency to "interact" with their surroundings, and it better to capture the IR rather than the end result. Even if we can verify that simple calls produce instructions we

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 8 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 342927. pirama added a comment. Leave two empty lines after filter_symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files:

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama created this revision. pirama added reviewers: MyDeveloperDay, srhines. pirama requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes PR46992. Git stores symlinks as text files and we should not format them even if they have

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 342921. nickdesaulniers added a comment. - prefer addDef, explicit register kills Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files:

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

MaskRay created this revision. MaskRay added reviewers: craig.topper, jrtc27, luismarques, serge-sans-paille. Herald added subscribers: StephenFan, vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook. MaskRay requested review of this revision.

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1914-1915 + BuildMI(MBB, MI, DL, get(AArch64::LDRXui)) + .addReg(Reg, getKillRegState(false)) + .addReg(Reg, RegState::Define) +

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

tlively added inline comments. Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:351 IO.enumCase(ID, "scalable-vector", TargetStackID::ScalableVector); +IO.enumCase(ID, "object", TargetStackID::Object); IO.enumCase(ID, "noalloc", TargetStackID::NoAlloc);

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG956cae2f09b2: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64 Depends on D101872

MaskRay created this revision. MaskRay added reviewers: dmgreen, efriedma, peter.smith. Herald added subscribers: danielkiss, s.egerton, simoncook, kristof.beyls. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2737531 , @tlively wrote: > At just under 4 seconds on my machine, it's certainly not one of the quickest > clang lit tests, but neither is it one of the slowest. It looks like there > are many that take tens of

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:20 +; RUN: --stack-protector-guard-offset=-1 -o - | \ +; RUN: FileCheck --check-prefix=CHECK

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 342905. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebase, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru created this revision. qdelacru added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. qdelacru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Having nested macros

[PATCH] D101868: Adds a formatter for aligning arrays of structs

feg208 created this revision. feg208 added reviewers: tinloaf, djasper, klimek, curdeius. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a new formatter to arrange array of struct initializers into neat columns

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. At just under 4 seconds on my machine, it's certainly not one of the quickest clang lit tests, but neither is it one of the slowest. It looks like there are many that take tens of seconds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101867: [clang][test] Update -fc++-abi tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0277a24f4bba: [clang][test] Update -fc++-abi tests (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0277a24 - [clang][test] Update -fc++-abi tests

Author: Leonard Chan Date: 2021-05-04T15:53:00-07:00 New Revision: 0277a24f4bbac284ba7a2ace7eeefdf6305e7f69 URL: https://github.com/llvm/llvm-project/commit/0277a24f4bbac284ba7a2ace7eeefdf6305e7f69 DIFF: https://github.com/llvm/llvm-project/commit/0277a24f4bbac284ba7a2ace7eeefdf6305e7f69.diff

[PATCH] D101867: [clang][test] Update -fc++-abi tests

leonardchan updated this revision to Diff 342891. leonardchan added a comment. Forgot the pipe in cxx-abi-flag.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 Files:

[PATCH] D101867: [clang][test] Update -fc++-abi tests

leonardchan updated this revision to Diff 342889. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-abi-flag.cpp

[PATCH] D101867: [clang][test] Update -fc++-abi tests

echristo added a comment. Couple cleanups, but should be better now. Thanks! -eric Comment at: clang/test/Driver/cxx-abi-flag.cpp:3 +// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \ +// RUN: |& FileCheck %s -check-prefix=ITANIUM +// RUN: %clang

[PATCH] D101867: [clang][test] Update -fc++-abi tests

leonardchan created this revision. leonardchan added a reviewer: echristo. leonardchan added a project: clang. Herald added a subscriber: phosek. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101867 Files:

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks for making this happen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101849/new/ https://reviews.llvm.org/D101849

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:9 function(gen_decision_forest model filename cpp_class) - set(model_compiler

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

hvdijk marked an inline comment as done. hvdijk added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7 # namespace-qualified class name. +set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR}) function(gen_decision_forest model filename

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

hvdijk updated this revision to Diff 342881. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101851/new/ https://reviews.llvm.org/D101851 Files: clang-tools-extra/clangd/quality/CompletionModel.cmake Index:

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

echristo added inline comments. Comment at: clang/test/Frontend/invalid-cxx-abi.cpp:1 +// These should succeed. +// RUN: %clang -c -fc++-abi=itanium %s Following up on an offline conversation :) This should be a driver test rather than (what it ended up being)

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45 +// Treat lambda capture by reference as a form of taking a reference. +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() &&

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7 # namespace-qualified class name. +set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR}) function(gen_decision_forest model filename cpp_class) nit: Directly

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. how's the runtime of this test compared to others in clang? Is it worth splitting it up to improve test execution parallelism? (I'm guessing /probably not/ (guess while the file is long, it's relatively simple for the compiler compared to some other non-trivial

[PATCH] D101862: [clang-format] Rename common types between C#/JS

exv created this revision. exv added a reviewer: curdeius. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is based on https://reviews.llvm.org/D101860 Repository: rG LLVM Github Monorepo

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

exv created this revision. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff is based on https://reviews.llvm.org/D101702. This fixes two errors: Previously, clang-format was splitting up type identifiers from the nullable ?.

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Preferably a new one unless it's something really minor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. I have completed two other formatting fixes related to C# 8 nullables since my last commit. Should I create a new review request for those or update this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45 +// Treat lambda capture by reference as a form of taking a reference. +return llvm::any_of(LE->captures(), [Var](const LambdaCapture ) { + return C.capturesVariable() &&

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added a comment. In D100934#2735955 , @jansvoboda11 wrote: > In D100934#2733857 , @dexonsmith > wrote: > >> Given that there are four different things being done in this commit, it >> sounds naively

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added a comment. In D96215#2735546 , @njames93 wrote: > Just my $0.02, We shouldn't worry too much about pathological cases like > that. I imagine that code would almost never appear in the wild. And for > cases where you don't have access to

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ updated this revision to Diff 342844. NoQ added a comment. Unforget to add `-fblocks` to the bugprone-redundant-branch-condition checks. Thanks pre-commit testing! - it wasn't failing on my machine, I guess it's enabled by default on darwin. CHANGES SINCE LAST ACTION

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

hvdijk created this revision. hvdijk added reviewers: sammccall, usaxena95. hvdijk added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgorny. hvdijk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. The current code

[clang] 6c3a107 - Mark Basic/TargetCXXABI.def as textual in the module map.

Author: Adrian Prantl Date: 2021-05-04T12:52:52-07:00 New Revision: 6c3a10760da3707186d5204bd9283e99344fa90f URL: https://github.com/llvm/llvm-project/commit/6c3a10760da3707186d5204bd9283e99344fa90f DIFF: https://github.com/llvm/llvm-project/commit/6c3a10760da3707186d5204bd9283e99344fa90f.diff

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

hvdijk added a comment. Herald added a subscriber: pengfei. There is a risk of bitcode incompatibilities with this change, but we already have that the code we generate now is incompatible with GCC and results in crashes that way too, I don't think there's a perfect fix, I'd like it if we

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2736970 , @estewart08 wrote: > In D99432#2728788 , @ABataev wrote: > >> In D99432#2726997 , @estewart08 >> wrote: >> >>> In

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis created this revision. Herald added subscribers: jfb, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2728788 , @ABataev wrote: > In D99432#2726997 , @estewart08 > wrote: > >> In D99432#2726845 , @ABataev wrote: >> >>> In D99432#2726588

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv marked an inline comment as done. exv added a comment. Eliza Velasquez Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

martong added a comment. Thank you for this patch! Could you please provide a lit test that ignites the over and over parsing behaviour? I think you need to create two files and the second one should contain parser error(s). Comment at:

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. In D101702#2736886 , @exv wrote: > According to the wiki, it seems like someone who has commit access must now > submit this change. Yes, I'll land it. Please provide "Name " for commit attribution if it differs from the info

[PATCH] D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG92f2c39f915a: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 92f2c39 - [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-05-04T12:06:03-07:00 New Revision: 92f2c39f915adc8f71be02d2604df4916069c9d4 URL: https://github.com/llvm/llvm-project/commit/92f2c39f915adc8f71be02d2604df4916069c9d4 DIFF:

[PATCH] D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

This revision was automatically updated to reflect the committed changes. Closed by commit rG313ee609e16b: [OpenMP] Fix non-determinism in clang task codegen (lastprivates) (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 313ee60 - [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

Author: Giorgis Georgakoudis Date: 2021-05-04T11:56:31-07:00 New Revision: 313ee609e16b93a7d81cd595f8cffdb408390495 URL: https://github.com/llvm/llvm-project/commit/313ee609e16b93a7d81cd595f8cffdb408390495 DIFF:

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv marked an inline comment as done. exv added a comment. According to the wiki, it seems like someone who has commit access must now submit this change. Comment at: clang/lib/Format/FormatTokenLexer.cpp:102 + +// FIXME: Investigate what token type gives the correct

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342813. exv marked an inline comment as done. exv added a comment. - Remove obsolete comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files:

[clang] 9c72a21 - Fix for test failure caused by 84c475437267e7fffedc40029ce274b099d8f8f3.

Author: Leonard Chan Date: 2021-05-04T11:45:32-07:00 New Revision: 9c72a210b58f19632af0e91679da7aa63f51ad7a URL: https://github.com/llvm/llvm-project/commit/9c72a210b58f19632af0e91679da7aa63f51ad7a DIFF: https://github.com/llvm/llvm-project/commit/9c72a210b58f19632af0e91679da7aa63f51ad7a.diff

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1971823ecb9e: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on… (authored by delcypher). Repository: rG LLVM Github

[clang] 1971823 - [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

Author: Dan Liew Date: 2021-05-04T11:28:26-07:00 New Revision: 1971823ecb9eaa077554a5d268a44c7cb75eccce URL: https://github.com/llvm/llvm-project/commit/1971823ecb9eaa077554a5d268a44c7cb75eccce DIFF: https://github.com/llvm/llvm-project/commit/1971823ecb9eaa077554a5d268a44c7cb75eccce.diff

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

delcypher marked an inline comment as done. delcypher added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:408 default: return getOS(); } arphaman wrote: > It might be cleaner to do a check for `isOSDarwin` here, as that will help > with

[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

delcypher updated this revision to Diff 342809. delcypher edited the summary of this revision. delcypher added a comment. Use `isOSDarwin()` instead of explicitly checking Darwin OS enum values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dc0f2b593d: [Format] Dont sort includes if DisableFormat is true (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/

[clang] 61dc0f2 - [Format] Don't sort includes if DisableFormat is true

Author: Nathan James Date: 2021-05-04T19:04:12+01:00 New Revision: 61dc0f2b593da149a4c0cea67819cd7bdbdd50b8 URL: https://github.com/llvm/llvm-project/commit/61dc0f2b593da149a4c0cea67819cd7bdbdd50b8 DIFF: https://github.com/llvm/llvm-project/commit/61dc0f2b593da149a4c0cea67819cd7bdbdd50b8.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

This revision was automatically updated to reflect the committed changes. Closed by commit rG84c475437267: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 84c4754 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Author: Leonard Chan Date: 2021-05-04T10:52:13-07:00 New Revision: 84c475437267e7fffedc40029ce274b099d8f8f3 URL: https://github.com/llvm/llvm-project/commit/84c475437267e7fffedc40029ce274b099d8f8f3 DIFF: https://github.com/llvm/llvm-project/commit/84c475437267e7fffedc40029ce274b099d8f8f3.diff

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGb451ecd86e13: [Clang][AArch64] Disable rounding of return values for AArch64 (authored by asavonic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b451ecd - [Clang][AArch64] Disable rounding of return values for AArch64

Author: Andrew Savonichev Date: 2021-05-04T20:29:01+03:00 New Revision: b451ecd86e13ec6ef47caf37f62977645c4f748e URL: https://github.com/llvm/llvm-project/commit/b451ecd86e13ec6ef47caf37f62977645c4f748e DIFF:

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:234 +FEM_Extended, +/// Use the default float eval method specified by Target +FEM_TargetDefault mibintc wrote: >

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

mtrofin added a comment. In D100917#2736702 , @aeubanks wrote: > In D100917#2735651 , @nikic wrote: > >> An unfortunate side-effect of this change is that NewPM uses even more >> memory. tramp3d-v4 is up 20% in

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:138-150 +template struct disjunction; +template struct disjunction : public T {}; +template struct disjunction { + using type = + typename std::conditional>::type;

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1c729c56829: [clang-tidy][NFC] Update tests and Default options to use boolean value (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks added a comment. In D100917#2735651 , @nikic wrote: > An unfortunate side-effect of this change is that NewPM uses even more > memory. tramp3d-v4 is up 20% in max-rss >

[clang-tools-extra] e1c729c - [clang-tidy][NFC] Update tests and Default options to use boolean value

Author: Nathan James Date: 2021-05-04T18:17:56+01:00 New Revision: e1c729c56829d3b9502b9ac2439003f87231db50 URL: https://github.com/llvm/llvm-project/commit/e1c729c56829d3b9502b9ac2439003f87231db50 DIFF: https://github.com/llvm/llvm-project/commit/e1c729c56829d3b9502b9ac2439003f87231db50.diff

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 342792. mibintc added a comment. I rebased the patch and responded to review comments from @aaron.ballman and @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex updated this revision to Diff 342790. SilensAngelusNex retitled this revision from "Make `hasTypeLoc` matcher support nodes of type `CXXFunctionalCastExpr` and `CXXTemporaryObjectExpr`." to "Make `hasTypeLoc` matcher support more node types.". SilensAngelusNex added a comment.

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Thanks! Looks good to me in general. See a comment. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1

[PATCH] D100983: [OpenCL] Fix optional image types

azabaznov accepted this revision. azabaznov added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

MaskRay added subscribers: vitalybuka, MaskRay. MaskRay added a comment. I think @vitalybuka has concrete suggestion on the naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101832/new/ https://reviews.llvm.org/D101832

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone added a comment. In D79714#2735455 , @Abpostelnicu wrote: > I'm seeing here something very strange, if the user provided copy assignment > operator is provided but is = delete and the copy constructor is default this > warning will still

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 updated this revision to Diff 342778. njames93 added a comment. Add test case demonstrating new behvaiour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 Files: clang/lib/Format/Format.cpp

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. > Could you explain why -debug-pass-manager doesn't fit your use case? I wanted to have something similar to -debug-pass=Structure, because the above is too verbose and lacks identation. What's the problem with this one, anyway? Repository: rG LLVM Github Monorepo

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. In D99599#2735582 , @evgeny777 wrote: >> I've already run into having to update these two golden file tests twice > > I think you can just reduce the tests. No need to revert the entire change, > unless there is a replacement

[PATCH] D101630: [HIP] Fix device-only compilation

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:977 NegFlag>; +defm hip_bundle_device_output : BoolFOption<"hip-bundle-device-output", EmptyKPM, DefaultTrue, + PosFlag, jansvoboda11 wrote: > The TableGen marshalling

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia created this revision. Anastasia added reviewers: svenvh, olestrohm. Herald added subscribers: ebevhan, kerbowa, yaxunl, nhaehnle, jvesely, jholewinski. Anastasia requested review of this revision. Bitfields result in struct/union layout that is implementation dependent and therefore

[PATCH] D101781: Fix assert on the variable which is used in omp clause is not marked as used

This revision was automatically updated to reflect the committed changes. Closed by commit rG5285748c2c76: Fix assert on the variable which is used in omp clause is not marked (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added a comment. In D101030#2736508 , @jdoerfert wrote: > I'll wait for @ggeorgakoudis to update the tests with the script, then I'll > adjust all clang tests again. FWIW, this also fixes an issue in OpenMC where > declare target triggered

[clang] 5285748 - Fix assert on the variable which is used in omp clause is not marked

Author: Jennifer Yu Date: 2021-05-04T09:07:35-07:00 New Revision: 5285748c2c764c1d7fb3f882ba9f11ed79f676a1 URL: https://github.com/llvm/llvm-project/commit/5285748c2c764c1d7fb3f882ba9f11ed79f676a1 DIFF: https://github.com/llvm/llvm-project/commit/5285748c2c764c1d7fb3f882ba9f11ed79f676a1.diff

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a subscriber: ggeorgakoudis. jdoerfert added a comment. I'll wait for @ggeorgakoudis to update the tests with the script, then I'll adjust all clang tests again. FWIW, this also fixes an issue in OpenMC where declare target triggered this:

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 ___ cfe-commits mailing list

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert marked 7 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E);

  1   2   >