[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie added a comment. In D101763#2741629 , @steakhal wrote: > Okay, so you 'just' want an indication for the given open call. What about > using `strace`? > `strace -e trace=openat %clang_cc1 ... 2>&1 | grep '"invocations.yaml"' | > FileCheck

[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

OikawaKirie added a comment. In D102062#2744267 , @steakhal wrote: > On second thought the current behavior is reasonable. The behavior of all CTU affairs are related to the `ctu-dir` rather than CWD, such as loading the external function map file and

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:275-276 + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) + return createDAGLinearizer(IS, OptLevel);

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. I see. LGTM, but let's wait one or more days to see if others object it. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:275-276 + return

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) +

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan updated this revision to Diff 343800. TaoPan added a comment. Move test back to clang/test/CodeGen/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 Files: clang/test/CodeGen/pre-ra-sched.c

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343795. pzheng added a comment. Minor update to some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 7 inline comments as done. pzheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + MaskRay wrote: > CC1

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a subscriber: aaron.ballman. dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > dblaikie wrote: > > >

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343794. pzheng added a comment. Addess @MaskRay's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 accepted this revision. estewart08 added a comment. This revision is now accepted and ready to land. LGTM as a temporary workaround until SPMD properly assigns team private variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D101911#2738994 , @ABataev wrote: > Hi Ethan, try this patch if it fixes the issue. Tested this on gfx906 and v100, the main reproducer now passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f65f42dd37a: Make `hasTypeLoc` matcher support more node types. (authored by SilensAngelusNex, committed by stephenkelly). Changed prior to

[clang] 1f65f42 - Make `hasTypeLoc` matcher support more node types.

Author: Weston Carvalho Date: 2021-05-08T00:35:22+01:00 New Revision: 1f65f42dd37ab6a950d3ec110e3efca0ace1b615 URL: https://github.com/llvm/llvm-project/commit/1f65f42dd37ab6a950d3ec110e3efca0ace1b615 DIFF:

[clang] 0ad4948 - NFC: Move TypeList implementation up the file

Author: Weston Carvalho Date: 2021-05-08T00:35:13+01:00 New Revision: 0ad494838b8576de14144776490faa710fa2a099 URL: https://github.com/llvm/llvm-project/commit/0ad494838b8576de14144776490faa710fa2a099 DIFF:

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei updated this revision to Diff 343780. haowei added a comment. Rebase the change to resolve presubmit errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100139/new/ https://reviews.llvm.org/D100139 Files:

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) +

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) +

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a comment. In D101030#2745429 , @gregmiller wrote: > Hello, We are maintaining a downstream version of the monorepo based on the > LLVM main branch. We have not transitioned to the new PM yet. In a recent > attempt to merge the latest

[PATCH] D102093: [NewPM] Move analysis invalidation/clearing logging to instrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f7131002b6a: [NewPM] Move analysis invalidation/clearing logging to instrumentation (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] 6f71310 - [NewPM] Move analysis invalidation/clearing logging to instrumentation

Author: Arthur Eubanks Date: 2021-05-07T15:25:31-07:00 New Revision: 6f7131002b6a821fc9b245ec5179910f171e3358 URL: https://github.com/llvm/llvm-project/commit/6f7131002b6a821fc9b245ec5179910f171e3358 DIFF:

[PATCH] D101797: [NewPM] Hide pass manager debug logging behind -debug-pass-manager-verbose

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Need a test for pass managers debug output. Comment at: llvm/test/Other/pass-pipeline-parsing.ll:145 ; RUN: opt -disable-output -debug-pass-manager

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, cebowleratibm, sfertile. Herald added subscribers: shchenz, nemanjai. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The default Altivec ABI was

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

craig.topper added inline comments. Comment at: llvm/test/CodeGen/Generic/pre-ra-sched.c:1 +// RUN: clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s You can't run clang from an llvm

[PATCH] D102093: [NewPM] Move analysis invalidation/clearing logging to instrumentation

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102093/new/ https://reviews.llvm.org/D102093 ___

[PATCH] D102093: [NewPM] Move analysis invalidation/clearing logging to instrumentation

aeubanks created this revision. aeubanks added reviewers: asbirlea, ychen. Herald added subscribers: dexonsmith, steven_wu, zzheng, hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We're trying to move

[clang] 167906c - [BareMetal] Ensure that sysroot always comes after library paths

Author: Petr Hosek Date: 2021-05-07T14:42:02-07:00 New Revision: 167906c10932f5eda97b480ee084b17746c362e7 URL: https://github.com/llvm/llvm-project/commit/167906c10932f5eda97b480ee084b17746c362e7 DIFF: https://github.com/llvm/llvm-project/commit/167906c10932f5eda97b480ee084b17746c362e7.diff

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

gregmiller added a comment. Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay updated this revision to Diff 343758. MaskRay added a comment. Don't affect -DBUILD_SHARED_LIBS=on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 Files: clang/tools/clang-shlib/CMakeLists.txt

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek requested changes to this revision. phosek added inline comments. This revision now requires changes to proceed. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") +

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-Bsymbolic-functions") +endif()

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a comment. In D102090#2745331 , @tstellar wrote: > Does this change mean that LD_PRELOAD will no longer work? Are there any > other downsides to adding these flags? The downside is that it will behave more like Windows dll and Mach-O

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-Bsymbolic-functions") +endif()

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay updated this revision to Diff 343755. MaskRay added a comment. Set global CMAKE_SHARED_LINKER_FLAGS instead. This additional makes -DBUILD_SHARED_LIBS=on builds (dev only; not recommended for packagers) faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

alex1701c added a comment. Any update on this topic? I really like this feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90996/new/ https://reviews.llvm.org/D90996 ___ cfe-commits mailing list

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

tstellar added a comment. Does this change mean that LD_PRELOAD will no longer work? Are there any other downsides to adding these flags? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090

[clang] f97ada2 - Revert "[BareMetal] Ensure that sysroot always comes after library paths"

Author: Petr Hosek Date: 2021-05-07T13:38:04-07:00 New Revision: f97ada27aaf64207a2ffad937ce3ccf009e81bd8 URL: https://github.com/llvm/llvm-project/commit/f97ada27aaf64207a2ffad937ce3ccf009e81bd8 DIFF: https://github.com/llvm/llvm-project/commit/f97ada27aaf64207a2ffad937ce3ccf009e81bd8.diff

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Paul-C-Anagnostopoulos wrote: > > jansvoboda11 wrote: > > >

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

rnk added a comment. I went ahead and implemented my suggested changes and pushed this with attribution. Thanks for the fix! Comment at: clang/lib/CodeGen/CGException.cpp:1966 StartFunction(GlobalDecl(), RetTy, Fn, FnInfo, Args,

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4adc49a1c98: [SEH] Fix regression with SEH in noexpect functions

[clang] c4adc49 - [SEH] Fix regression with SEH in noexpect functions

Author: Olivier Goffart Date: 2021-05-07T13:27:59-07:00 New Revision: c4adc49a1c988e6ea8a340b6245525ef5599812c URL: https://github.com/llvm/llvm-project/commit/c4adc49a1c988e6ea8a340b6245525ef5599812c DIFF:

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b00b34b8a05: [BareMetal] Ensure that sysroot always comes after library paths (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6b00b34 - [BareMetal] Ensure that sysroot always comes after library paths

Author: Petr Hosek Date: 2021-05-07T13:21:07-07:00 New Revision: 6b00b34b8a05896f79b18a1963811299b83d5b21 URL: https://github.com/llvm/llvm-project/commit/6b00b34b8a05896f79b18a1963811299b83d5b21 DIFF: https://github.com/llvm/llvm-project/commit/6b00b34b8a05896f79b18a1963811299b83d5b21.diff

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 343750. ASDenysPetrov added a comment. Minor comment fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. Missed a request in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___ cfe-commits mailing list

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 343748. feg208 marked an inline comment as done. feg208 added a comment. Oops missed a request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files:

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 343747. feg208 added a comment. Added more tests and addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files:

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 marked 4 inline comments as done. feg208 added a comment. I think I have all the tests and requested review comments rolled up Comment at: clang/unittests/Format/FormatTest.cpp:16352 +template +auto createStylesImpl( curdeius wrote: >

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc04c66d705b4: [RISCV] Consider scalar types for required extensions. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102051/new/

[clang] c04c66d - [RISCV] Consider scalar types for required extensions.

Author: Hsiangkai Wang Date: 2021-05-08T04:06:45+08:00 New Revision: c04c66d705b4f6e95a6325ef6d6c647ebc622165 URL: https://github.com/llvm/llvm-project/commit/c04c66d705b4f6e95a6325ef6d6c647ebc622165 DIFF:

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay created this revision. Herald added subscribers: pengfei, mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In an ELF shared object, a default visibility defined symbol is preemptible by default.

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 343743. NeHuang added a comment. Addressed review comment for the diagnostic message and update the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Is it better to split the patch? For example, the new alloc/free shared can be in a separate patch, and the globalization can be in another one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 343731. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Now, with ever-so-slightly better formatting (the rest of the formatting issues are either matching existing style or a fight between my clang-format and CI's

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e9c39a3f982: [WebAssembly] Use functions instead of macros for const SIMD intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo

[clang] 1e9c39a - [WebAssembly] Use functions instead of macros for const SIMD intrinsics

Author: Thomas Lively Date: 2021-05-07T11:50:19-07:00 New Revision: 1e9c39a3f982fe2f50cd19c74be8b64dfba4baad URL: https://github.com/llvm/llvm-project/commit/1e9c39a3f982fe2f50cd19c74be8b64dfba4baad DIFF: https://github.com/llvm/llvm-project/commit/1e9c39a3f982fe2f50cd19c74be8b64dfba4baad.diff

[PATCH] D102086: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

craig.topper created this revision. craig.topper added reviewers: evandro, HsiangKai, arcbbb, frasercrmck, rogfer01, khchen. Herald added subscribers: StephenFan, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

tlively added a comment. In D102018#2743818 , @aheejin wrote: > So what prevented us from using functions when we were using `_Static_assert` > and why is it now possible to use functions? From inside a function, the parameter never looks like a

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

kastiglione added a comment. @Tyker in case you didn't see my previous message, I'm curious if you'd be willing to take a look at the bug. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain , + const ArgList , protze.joachim wrote: > JonChesterfield

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + dyung wrote: > jubnzv wrote: > > probinson wrote: > > >

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:136 + +RangeSet RangeSet::Factory::unite(RangeSet LHS, RangeSet RHS) { + if (LHS.isEmpty()) vsavchenko wrote: > I'd prefer `merge` There are common namings

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 343714. ASDenysPetrov added a comment. Updated the patch due to comments. Added more tests. Simplified and improved solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files:

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

protze.joachim added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain , + const ArgList , JonChesterfield wrote: > lebedev.ri wrote:

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

craig.topper added a comment. LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102051/new/ https://reviews.llvm.org/D102051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex added a comment. I don't have commit access; you can go ahead and submit it. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101572/new/ https://reviews.llvm.org/D101572

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. In D101873#2743987 , @peter.smith wrote: > Thanks for the update. > > With the clarification that this isn't breaking aarch64 long range thunks > now, and we are not considering Arm then I'm happy for this to happen if the >

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2733761 , @tra wrote: > In D101630#2730273 , @yaxunl wrote: > >> How about an option -fhip-bundle-device-output. If it is on, device output >> is bundled no matter how many GPU

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-bool.c:11 +// RUN:-target-feature +altivec -fsyntax-only %s + +__vector bool char bc; nemanjai wrote: > Do we not want the test case to provide a similar define to what `stdbool.h`

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 343696. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Teresa's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked an inline comment as done. yaxunl added a comment. In D99683#2683308 , @tejohnson wrote: > To do what I suggested in the prior comment, you'd probably want to add a new > index-wide flag (since we don't read IR in the thin link). See for

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 343695. pmatos added a comment. Making the linter happy... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssembly.cpp

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548 +def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet supported on AIX">; + This neatly avoids the problem of diagnostics not starting

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

aaron.ballman added a reviewer: hubert.reinterpretcast. aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added a comment. I think the changes look good to me, but I'm not a floating-point expert either. Adding @hubert.reinterpretcast for his floating-point expertise.

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 343685. pmatos added a comment. - Simplifies some of code in the middle-end. - Removes setComdat and adds setWeak Small improvements to address comments in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3254-3265 + Token MacroNameTok; + ReadMacroName(MacroNameTok); + + // Error reading macro name? If so, diagnostic already issued. + if

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 343683. NeHuang added a comment. Update the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 343680. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

JonChesterfield added a comment. A thought - we need to keep return 0 for success, but could return a different integer for each failure mode. That would be useful when guessing why it failed. Orthogonal to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos marked 7 inline comments as done. pmatos added inline comments. Comment at: llvm/lib/CodeGen/MachineOperand.cpp:1174 + } else +OS << ", opaque "; if (getAlign() != getBaseAlign()) tlively wrote: > Is there a test that demonstrates this printing?

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM, thanks. I think this leaves us totally sure the clang build will succeed with a best effort chance of having a working amdgpu ident tool afterwards. Repository: rG

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported.cl:11 +#ifndef BITFIELDS_EXT +// expected-error@-2 {{bit-fields are not supported in OpenCL}} +#endif svenvh wrote: > The extension has "bitfields" in the name but most diagnostics

[clang] 25bbff6 - [PowerPC] Provide MMA builtins for compatibility

Author: Ahsan Saghir Date: 2021-05-07T09:10:16-05:00 New Revision: 25bbff632d018d178272a61c0732203d53d3a2e3 URL: https://github.com/llvm/llvm-project/commit/25bbff632d018d178272a61c0732203d53d3a2e3 DIFF: https://github.com/llvm/llvm-project/commit/25bbff632d018d178272a61c0732203d53d3a2e3.diff

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25bbff632d01: [PowerPC] Provide MMA builtins for compatibility (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 9 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:181 IdentifierInfo *Ident__is_target_environment;// __is_target_environment + IdentifierInfo *Ident__FLT_EVAL_METHOD__;//

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

pdhaliwal updated this revision to Diff 343668. pdhaliwal added a comment. Added fallback in case __has_include is not defined or header is not found anywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102067/new/

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang created this revision. Herald added a reviewer: aaron.ballman. NeHuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add front end diagnostics to report error for unimplemented TLS models set by - compiler option `-ftls-model` -

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 343666. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 Files: clang/docs/LanguageExtensions.rst

[PATCH] D100604: [PowerPC] Improve codegen for int-to-fp conversion of subword vector extract

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100604/new/ https://reviews.llvm.org/D100604 ___ cfe-commits mailing list

[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a crash caused by Lexers being invalidated at code completion points in

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

JonChesterfield added a comment. Logic doesn't look quite right to me. If the compiler supports has_include, but neither of those headers exist, we fall through to main() which won't compile. How about: #if defined(__has_include) #if __has_include("hsa.h") #define HSA_FOUND 1 //

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Ah, yes. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102065/new/ https://reviews.llvm.org/D102065

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 343656. ZarkoCA added a comment. - update test cases to contain `_Bool` as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 Files:

  1   2   >