[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

This revision was automatically updated to reflect the committed changes. Closed by commit rG976a3e5f6141: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched (authored by TaoPan, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 976a3e5 - [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

Author: Pan, Tao Date: 2021-05-17T11:25:15+08:00 New Revision: 976a3e5f61415e784c85b341180eac300cc8b7a5 URL: https://github.com/llvm/llvm-project/commit/976a3e5f61415e784c85b341180eac300cc8b7a5 DIFF: https://github.com/llvm/llvm-project/commit/976a3e5f61415e784c85b341180eac300cc8b7a5.diff LOG:

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#2762120 , @jrtc27 wrote: > In D71387#2762115 , @khchen wrote: > >> In D71387#1820995 , @efriedma wrote: >> >>> Okay. Please let me know if

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Passed many CodeGen related test suites over the weekend. It landed in.. commit 9ca9be098fedb14182c50c9dd700f3fa91c8d4c7 (HEAD -> main) Author: Ten Tzen Date: Sun May 16 18:12:47 2021 -0700 [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1 Repository

[PATCH] D102586: [Clang] Do not discard arguments for non-builtin CXX11-style attributes

Till created this revision. Till requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When parsing unkown CXX11-style attributes, clang discards the argument lists, propably to skip over non-c++ expressions. However, it seems like this has not

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu created this revision. myhsu added reviewers: echristo, craig.topper. Herald added a subscriber: hiraditya. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds supports for inline assembly operands

[PATCH] D102583: -fno-semantic-interposition: Don't set dso_local on GlobalVariable

MaskRay created this revision. MaskRay added reviewers: foutrelis, rnk, serge-sans-paille, xbolva00. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `clang -fpic -fno-semantic-interposition` may set dso_local on variables for -fpic

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

MaskRay added a comment. .ll -> .s tests should be placed in llvm/test/CodeGen/SystemZ, not in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91628/new/ https://reviews.llvm.org/D91628 ___ cfe-commi

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2762134 , @hubert.reinterpretcast wrote: > In D96033#2762056 , @v.g.vassilev > wrote: > >> IIUC, AIX has a default `fno-integrated-as` and I am still puzzled (and >> cannot

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

njames93 added a comment. This is going to be very noisey for codebases that use a do...while macro: #define MACRO() do { Something(); With(); Multiple(); Statements(); } while (false) Maybe you should ignore do statements that are in macro expansions as well as potentially do statements wit

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rG833e9b2ea7a7: [BPF] add support for 32 bit registers in inline asm (authored by alessandrod, committed by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 833e9b2 - [BPF] add support for 32 bit registers in inline asm

Author: Alessandro Decina Date: 2021-05-16T11:01:47-07:00 New Revision: 833e9b2ea7a7290f8833d524c8f8865558c1016a URL: https://github.com/llvm/llvm-project/commit/833e9b2ea7a7290f8833d524c8f8865558c1016a DIFF: https://github.com/llvm/llvm-project/commit/833e9b2ea7a7290f8833d524c8f8865558c1016a.d

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn added a comment. In D102489#2761195 , @dyung wrote: > The test added in this commit was failing on the PS4 bot > (https://lab.llvm.org/buildbot/#/builders/139/builds/4059). I've reverted the > change in 59b419adc6e608db8d7c31efcc37f34c0b57b7d0 >

[clang] 803c52d - Recommit "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."

Author: Florian Hahn Date: 2021-05-16T18:49:53+01:00 New Revision: 803c52d0dba929652280a38dcf90c491ab33d03b URL: https://github.com/llvm/llvm-project/commit/803c52d0dba929652280a38dcf90c491ab33d03b DIFF: https://github.com/llvm/llvm-project/commit/803c52d0dba929652280a38dcf90c491ab33d03b.diff

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd29f7f1a7b47: [clang] Fix ternary operator in the second for loop statement (authored by danlark, committed by rsmith). Repository: rG LLVM Github

[clang] d29f7f1 - [clang] Fix ternary operator in the second for loop statement

Author: Danila Kutenin Date: 2021-05-16T10:42:52-07:00 New Revision: d29f7f1a7b47345289d63318e7b2a28cc56e169d URL: https://github.com/llvm/llvm-project/commit/d29f7f1a7b47345289d63318e7b2a28cc56e169d DIFF: https://github.com/llvm/llvm-project/commit/d29f7f1a7b47345289d63318e7b2a28cc56e169d.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2762056 , @v.g.vassilev wrote: > IIUC, AIX has a default `fno-integrated-as` and I am still puzzled (and > cannot find the relevant code) what is the program action kind for AIX in > that case (`frontend

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

jrtc27 added a comment. In D71387#2762115 , @khchen wrote: > In D71387#1820995 , @efriedma wrote: > >> Okay. Please let me know if you want me to review anything. > > Hi all, > We had encoded the target-abi into mo

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#1820995 , @efriedma wrote: > Okay. Please let me know if you want me to review anything. Hi all, We had encoded the target-abi into module now, but I feel it does not make sense to support overwrite ABI option and data

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

jrtc27 added inline comments. Comment at: clang/test/Driver/lto.c:81-90 +// Need to pass -target-abi in RISC-V target. +// RUN: %clang -target riscv64-unknown-elf %s -fuse-ld=gold -flto \ +// RUN: -mabi=lp64f -### 2>&1 | FileCheck %s --check-prefix=RISCV +// RUN: %clang -target

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen updated this revision to Diff 345712. khchen added a comment. Herald added a subscriber: vkmr. Pass -target-abi option into LTO codegenerator base on D102582 patch. please see D102582 for more detal. Repository: rG

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

xbolva00 added inline comments. Comment at: llvm/include/llvm/IR/MatrixBuilder.h:245 + Intrinsic::getDeclaration(getModule(), Intrinsic::assume); + B.CreateCall(TheFn->getFunctionType(), TheFn, {Cmp}, Name); +} B.CreateAssumption(Cmp) may work w

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

yonghong-song added a comment. Sure. I will merge the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102118/new/ https://reviews.llvm.org/D102118 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

xbolva00 added inline comments. Comment at: llvm/include/llvm/IR/MatrixBuilder.h:242 +auto *Cmp = B.CreateICmpULT(Idx, NumElts); +if (!isa(Cmp)) { + Function *TheFn = Prefer early exit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2761581 , @hubert.reinterpretcast wrote: > In D96033#2761428 , > @hubert.reinterpretcast wrote: > >> If you have some ideas, please let me know. Meanwhile, I am trying out

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

zhouyizhou updated this revision to Diff 345710. zhouyizhou added a comment. I use git diff -U9 instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102577/new/ https://reviews.llvm.org/D102577 Files: clang/lib/Sema/TreeTransform.h Index: clang/lib/Sema/TreeTransform.h ===

[clang] 656296b - Reapply [CaptureTracking] Do not check domination

Author: Nikita Popov Date: 2021-05-16T15:46:31+02:00 New Revision: 656296b1c2eca127cb48612227fa5f381c81b53b URL: https://github.com/llvm/llvm-project/commit/656296b1c2eca127cb48612227fa5f381c81b53b DIFF: https://github.com/llvm/llvm-project/commit/656296b1c2eca127cb48612227fa5f381c81b53b.diff

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:114 + + Checks if a do-while loop exists and flags it. + Please highlight do-while with double back-ticks. Comment at: clang-tools-extra/docs/clang-tidy

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

zhouyizhou created this revision. zhouyizhou added reviewers: sepavloff, craig.topper, rsmith, klimek, doug.gregor. Herald added a subscriber: pengfei. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi,

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 345703. fhahn added a comment. Undo unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGExprS

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 345702. fhahn added a comment. Herald added a subscriber: hiraditya. Thanks for taking a look! I added a phase ordering test and updated the pipeline tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

DNS320 created this revision. DNS320 added reviewers: aaron.ballman, njames93, alexfh. DNS320 added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. DNS320 requested review of this revision. This simple check flags do-while statements according

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod added a comment. In D102118#2761476 , @yonghong-song wrote: > LGTM except one minor issue. Please do address the nit before merging. Thanks! Done, thanks for the review! I don't have commit access so someone will have to merge this for me :

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod updated this revision to Diff 345680. alessandrod added a comment. Remove unused global from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102118/new/ https://reviews.llvm.org/D102118 Files: clang/lib/Basic/Targets/BPF.cpp cla

[PATCH] D102125: [Matrix] Implement static cast for matrix types

This revision was automatically updated to reflect the committed changes. Closed by commit rGecb235d94014: [Matrix] Implement static cast for matrix types (authored by SaurabhJha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102125/new/ https://re

[clang] ecb235d - [Matrix] Implement static cast for matrix types

Author: Saurabh Jha Date: 2021-05-16T08:09:12+01:00 New Revision: ecb235d94014903ec60e1539e6f0105ea6a4b089 URL: https://github.com/llvm/llvm-project/commit/ecb235d94014903ec60e1539e6f0105ea6a4b089 DIFF: https://github.com/llvm/llvm-project/commit/ecb235d94014903ec60e1539e6f0105ea6a4b089.diff L