[PATCH] D103941: [CMake] Don't use libc++ by default on Windows yet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb413e44200e7: [CMake] Don't use libc++ by default on Windows yet (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] b413e44 - [CMake] Don't use libc++ by default on Windows yet

Author: Petr Hosek Date: 2021-06-08T23:57:14-07:00 New Revision: b413e44200e715c254fa9a41f6a86f8761c9b362 URL: https://github.com/llvm/llvm-project/commit/b413e44200e715c254fa9a41f6a86f8761c9b362 DIFF: https://github.com/llvm/llvm-project/commit/b413e44200e715c254fa9a41f6a86f8761c9b362.diff LO

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing created this revision. Herald added a subscriber: dang. tianqing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.t

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 added a comment. In D103878#2807034 , @MaskRay wrote: > How do the new tests provide additional coverage? For these tests, 1. there is no tests for mabi=ilp32e, and my patch covers that. 2. the tests in riscv-abi.c will show default abi change

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

hokein added a comment. In D103825#2805760 , @adamcz wrote: > FYI The ArgTy.isNull() check is sufficient to fix this. The > Arg->containsErrors() is not - it's false in this case, since it seems > CXXDefaultArgExpr with RecoveryExpr inside seems to not

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/test/Driver/riscv-arch.c:45 + +// CHECK-ILP32: "-target-feature" "+m" +// CHECK-ILP32-SAME: "-target-feature" "+f" MaskRay wrote: > I suggest the style used in lin

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 updated this revision to Diff 350788. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ https://reviews.llvm.org/D103878 Files: clang/test/Driver/riscv-abi.c clang/test/Driver/riscv-arch.c Index: clang/test/Driver/riscv-arch.c ==

[PATCH] D103941: [CMake] Don't use libc++ by default on Windows yet

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ has issues when used with -fno-exceptions and vcruntime, don't use i

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

MaskRay added a comment. How do the new tests provide additional coverage? Comment at: clang/test/Driver/riscv-arch.c:45 + +// CHECK-ILP32: "-target-feature" "+m" +// CHECK-ILP32-SAME: "-target-feature" "+f" I suggest the style used in linux-cross.cpp Jus

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

efriedma added a comment. > In practice, the frozen element won't be used in most of the cases; the > middle-end's demanded elements analysis will trigger instcombine to almost > always remove the freeze. Well, in the cases it gets removed, it doesn't really matter what we use. It's likely if

[clang] e488800 - Fix LIT test failure encountered on AIX

Author: Chris Bowler Date: 2021-06-08T23:56:42-04:00 New Revision: e48880078a49faeacb28fd5478948fd674d7350b URL: https://github.com/llvm/llvm-project/commit/e48880078a49faeacb28fd5478948fd674d7350b DIFF: https://github.com/llvm/llvm-project/commit/e48880078a49faeacb28fd5478948fd674d7350b.diff

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350774. feg208 added a comment. Fixes from clang-tidy checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst clang/do

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 350767. andrewjcg added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/Inputs/implicit

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added a comment. In D103874#2806519 , @efriedma wrote: > I noted the cases where it looks like the undef->poison change might actually > impact code using compiler intrinsic functions that have external > specifications. The relevant specificati

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +#include "Before/Mapping.h" This include will fail if modules weren't used. The include name itself doesn't exist and relies on the header map to rem

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. We were hitting this in our build environment when mixing header maps with clang module maps, where the use of the former would prevent properly associated an included header with it's module via the module map. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg created this revision. Herald added a subscriber: wenlei. andrewjcg updated this revision to Diff 350757. andrewjcg added a comment. andrewjcg edited the summary of this revision. andrewjcg added reviewers: bruno, rsmith. andrewjcg published this revision for review. Herald added a projec

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:236 +Prev = Prev->Previous; +assert(Prev); + } MyDeveloperDay wrote: > curdeius wrote: > > MyDeveloperDay wrote: > > > Do we need to worry about `Prev` ever being

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

rsmith added a comment. This will diagnose unused values in unreachable code in constant-evaluated contexts; that doesn't seem quite right. For example, in: void f() { new double[false ? (1, 2) : 3][false ? (1, 2) : 3]; } ... we'll diagnose that the `1` is unused in only one of the two

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 added a comment. How to formulate the default abi and arch is still under discussion. https://github.com/riscv/riscv-toolchain-conventions/issues/13 But the tests can be added first, for contrast of future changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ ht

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu updated this revision to Diff 350756. Nuu added a comment. Minor updates. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 updated this revision to Diff 350755. benshi001 retitled this revision from "[RISCV][clang] Improve deduction of default ABI for some special archs" to "[clang][RISCV][test] Add more tests of the -mabi and -march options". benshi001 edited the summary of this revision. CHANGES SINCE LA

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.org/D103720 __

[clang] 294efbb - Reland "[AMDGPU] Add gfx1013 target"

Author: Brendon Cahoon Date: 2021-06-08T21:15:35-04:00 New Revision: 294efbbd3e3d55671ef8b220c231a2807c38eefe URL: https://github.com/llvm/llvm-project/commit/294efbbd3e3d55671ef8b220c231a2807c38eefe DIFF: https://github.com/llvm/llvm-project/commit/294efbbd3e3d55671ef8b220c231a2807c38eefe.diff

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + +uptr kHighMemEnd; +uptr kHighMemBeg; These need comments about what they are and why they need to exist as runtime variables at all. Comment at: compil

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen created this revision. ychen added reviewers: aaron.ballman, rsmith. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC/MSVC diagnoses in such cases, probably it makes sense to do the same for Clang. https://godbolt.org/z/7zxb8

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan added a comment. Let me know if these functions should be split up or can land together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 ___ cfe-com

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added a comment. yep, I'll look into it, probably sometime tomorrow-- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 ___ cfe-commits mailing list cfe-c

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350746. feg208 added a comment. This alters the array alignment to allow for left alignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFo

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, charco. leonardchan added a project: Sanitizers. Herald added subscribers: jfb, mgorny, dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This contains all the definitions

[PATCH] D102736: Fix tmp files being left on Windows builds.

dyung added a comment. Hi Amy, after your change, the compile time for one of our internal test files went from about 1 second to 30 seconds. I have put a repro and the details in PR50628, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

leonardchan added a comment. Oh, actually @pcc was right on closer inspection. This is a misunderstanding on my end. So the `{{bt:...}}}` comes from constexpr const char *kFormatFrame = "{{{bt:%u:%p}}}"; defined in `sanitizer_symbolizer_fuchsia.h` and this is only used in the definition for

[PATCH] D103934: clang/darwin: use response files with ld64

keith created this revision. keith added a reviewer: thakis. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This crasher was fixed with Xcode 13.0 beta 1 / ld64 705. This is an updated revert of https://reviews.llvm.org/D92357 Repo

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5662 switch (ET) { case ET_IsLValueExpr: return E->isLValue(); + case ET_IsRValueExpr: rsmith wrote: > Hm, I wonder if this it's correct t

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3588 + case VK_PRValue: +S.Kind = SK_CastDerivedToBaseRValue; +break; rsmith wrote: > Would be nice to rename this `SK_` enumerator as a fo

[PATCH] D103933: [clang] NFC: rename SK_CastDerivedToBaseRValue to SK_CastDerivedToBasePRValue

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow up to the "rvalue-to-prvalue" rename at D103720 . Signed-off-by: Matheus Izvekov Depends on D103

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov updated this revision to Diff 350729. mizvekov added a comment. Implement rsmith's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.org/D103720 Files: clang-tools-extra/clang-tidy/misc/Uniquept

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. Hi Nick, From the backend prospective, this looks fine but you'll want someone to look at the front end part before landing that change. Cheers, -Quentin Repository: rG LLVM Github

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

rsmith added a comment. I think this is worth doing -- "rvalue" is at least ambiguous and, in C++-specific cases, confusing and wrong. Saying "prvalue" in C-specific parts of clang may also be a bit surprising, but it's unambiguous and still meaningful. I think we shouldn't consider adding an

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx updated this revision to Diff 350722. chrish_ericsson_atx added a comment. Refreshed previously-reverted changeset and re-tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/ https://reviews.llvm.org/D88174 Files:

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers updated this revision to Diff 350719. nickdesaulniers added a comment. - add CHECK to llvm/test/Linker/warn-stack-frame.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103928/new/ https://reviews.llvm.org/D103928 Files: clang/in

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers added inline comments. Comment at: clang/include/clang/Driver/Options.td:2575-2581 // These "special" warning flags are effectively processed as f_Group flags by the driver: // Just silence warnings about -Wlarger-than for now. def Wlarger_than_EQ : Joined<["-

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: tejohnson, rsmith. Herald added subscribers: dexonsmith, dang, pengfei, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. -Wf

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

efriedma added a comment. I noted the cases where it looks like the undef->poison change might actually impact code using compiler intrinsic functions that have external specifications. The relevant specifications say the elements in question are "undefined", without really specifying what tha

[PATCH] D103611: Correct the behavior of va_arg checking in C++

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/ https://reviews.llvm.org/D103611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D103926: [CMake][Fuchsia] Disable vcruntime for first stage as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1683dbf0ddb2: [CMake][Fuchsia] Disable vcruntime for first stage as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 1683dbf - [CMake][Fuchsia] Disable vcruntime for first stage as well

Author: Petr Hosek Date: 2021-06-08T13:44:24-07:00 New Revision: 1683dbf0ddb28c829926b18065f692ee670693fc URL: https://github.com/llvm/llvm-project/commit/1683dbf0ddb28c829926b18065f692ee670693fc DIFF: https://github.com/llvm/llvm-project/commit/1683dbf0ddb28c829926b18065f692ee670693fc.diff LO

Re: [clang] e6629be - [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

On Tue, Jun 8, 2021 at 11:43 AM Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Jun 07, 2021 at 07:04:36PM -0700, via cfe-commits wrote: > > > > Author: =Jake Egan > > Date: 2021-06-07T22:04:18-04:00 > > New Revision: e6629be31e67190f0a524f009752d73410894560 > > >

[PATCH] D103926: [CMake][Fuchsia] Disable vcruntime for first stage as well

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using vcruntime is breaking libc++ headers so don't use it. Repository:

[clang] 211e584 - Revert "[AMDGPU] Add gfx1013 target"

Author: Brendon Cahoon Date: 2021-06-08T16:29:41-04:00 New Revision: 211e584fa2a4c032e4d573e7cdbffd622aad0a8f URL: https://github.com/llvm/llvm-project/commit/211e584fa2a4c032e4d573e7cdbffd622aad0a8f DIFF: https://github.com/llvm/llvm-project/commit/211e584fa2a4c032e4d573e7cdbffd622aad0a8f.diff

[PATCH] D88220: [C++20] P1825R0: More implicit moves

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) { Quuxplu

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

aaron.ballman added a comment. I haven't had the chance to give this a thorough review yet, but I do have some high level questions. > Also added support for the %l16(c|s) and %l32(c|s) conversion specifier for > char16_t and char32_t types in C and C++, which should soon be accepted by > ISO

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350700. mibintc added a comment. I corrected error in LangRef documentation that @pengfei pointed out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files: llvm/doc

[clang] a7142f5 - Partially revert the Fuchsia changes to avoid the use of PIC

Author: Petr Hosek Date: 2021-06-08T13:03:26-07:00 New Revision: a7142f5c91ba0e4dbe6dbd36e3f4ac6ccd33a418 URL: https://github.com/llvm/llvm-project/commit/a7142f5c91ba0e4dbe6dbd36e3f4ac6ccd33a418 DIFF: https://github.com/llvm/llvm-project/commit/a7142f5c91ba0e4dbe6dbd36e3f4ac6ccd33a418.diff LO

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

leonardchan added a comment. In D103564#2806292 , @thakis wrote: > this breaks tests: http://45.33.8.238/linux/48401/step_10.txt > > ` // CHECK: #0 {{.*}} in {{.*}}free{{.*}} {{.*}}hwasan_interceptors.cpp` > > vs > > ` 13: #0 0x5647a467e9a0 in

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a5afb466553: [CMake][Fuchsia] Use PIC for Fuchsia runtimes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2a5afb4 - [CMake][Fuchsia] Use PIC for Fuchsia runtimes

Author: Petr Hosek Date: 2021-06-08T12:30:27-07:00 New Revision: 2a5afb466553ae4e185d7fa50c9b8df9fe62ecda URL: https://github.com/llvm/llvm-project/commit/2a5afb466553ae4e185d7fa50c9b8df9fe62ecda DIFF: https://github.com/llvm/llvm-project/commit/2a5afb466553ae4e185d7fa50c9b8df9fe62ecda.diff LO

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

thakis added a comment. this breaks tests: http://45.33.8.238/linux/48401/step_10.txt ` // CHECK: #0 {{.*}} in {{.*}}free{{.*}} {{.*}}hwasan_interceptors.cpp` vs ` 13: #0 0x5647a467e9a0 in free ../../compiler-rt/lib/hwasan/hwasan_allocation_functions.cpp:75:3 ` need to update the p

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

phosek added a comment. In D103919#2806198 , @leonardchan wrote: > Should `_LLVM_ENABLE_PIC ON` also be added for the multilibs? It should be propagated automatically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov added a comment. In D103720#2806147 , @aaron.ballman wrote: > (esp if someone in the future wants to add `Expr::isRValue()` with the C++ > meaning of prvalue || xvalue). @rsmith actually suggested we add `isRValue` as a second step here, and I

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

eugenis added a comment. In D103845#2806211 , @leonardchan wrote: > I think the newline gets added to the frame description only if > `Symbolizer::GetOrInit()->SymbolizePC(pc)` is nonnull, so if it fails then no > newline is added. This makes sense to

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

pcc added a comment. In D103845#2806211 , @leonardchan wrote: > In D103845#2804441 , @pcc wrote: > >> This isn't how the output looks on Android. Are you sure this isn't a >> Fuchsia-specific bug in the output f

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944b3c53aec5: [NFC][compiler-rt][hwasan] Move allocation functions into their own file (authored by leonardchan). Repository: rG LLVM Github Monor

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171 } // namespace __hwasan +#else // #if !SANITIZER_FUCHSIA +namespace __hwasan { vitalybuka wrote: > mcgrathr wrote: > > blank lines around `#else` and `#endif` lin

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

leonardchan updated this revision to Diff 350682. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103564/new/ https://reviews.llvm.org/D103564 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/l

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

leonardchan added a comment. In D103845#2804441 , @pcc wrote: > This isn't how the output looks on Android. Are you sure this isn't a > Fuchsia-specific bug in the output formatting? I think the newline gets added to the frame description only if `Symb

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Should `_LLVM_ENABLE_PIC ON` also be added for the multilibs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103919/new/ https://review

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e8506debae3: [SystemZ][z/OS] Pass OpenFlags when creating tmp files (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo C

[clang] 0e8506d - [SystemZ][z/OS] Pass OpenFlags when creating tmp files

Author: Abhina Sreeskantharajan Date: 2021-06-08T14:45:34-04:00 New Revision: 0e8506debae3ad534b4eecfa922fc6281506a635 URL: https://github.com/llvm/llvm-project/commit/0e8506debae3ad534b4eecfa922fc6281506a635 DIFF: https://github.com/llvm/llvm-project/commit/0e8506debae3ad534b4eecfa922fc6281506

[PATCH] D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disabling PIC globally also disabled PIC for runtimes which was undesirable

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

aaron.ballman added a comment. Thank you for the terminology cleanup! I'm not opposed to the changes, but I am wondering whether the churn is worth it given that the nomenclature will still be confusing for those thinking about non-C++ based languages (esp if someone in the future wants to add

[PATCH] D103918: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf673365e1ce1: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] f673365 - [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain

Author: Petr Hosek Date: 2021-06-08T11:25:17-07:00 New Revision: f673365e1ce16293075c18d03cd2f1ae6264289f URL: https://github.com/llvm/llvm-project/commit/f673365e1ce16293075c18d03cd2f1ae6264289f DIFF: https://github.com/llvm/llvm-project/commit/f673365e1ce16293075c18d03cd2f1ae6264289f.diff LO

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2d0c16e91f3: [clang] p1099 using enum part 2 (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[clang] b2d0c16 - [clang] p1099 using enum part 2

Author: Nathan Sidwell Date: 2021-06-08T11:11:46-07:00 New Revision: b2d0c16e91f39def3646b71e5afebfaea262cca1 URL: https://github.com/llvm/llvm-project/commit/b2d0c16e91f39def3646b71e5afebfaea262cca1 DIFF: https://github.com/llvm/llvm-project/commit/b2d0c16e91f39def3646b71e5afebfaea262cca1.diff

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

ychen added a comment. In D103885#2805988 , @aaron.ballman wrote: > In D103885#2805758 , @ychen wrote: > >> We could use a table to avoid the warning and speed the build a little bit. >> https://reviews.llvm.org

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

jyknight added a comment. Won't this change cause weird effects with LTO, when you're merging multiple TUs' global_ctors arrays before emitting? Won't this end up reversing the order of the files, as well as the order of the functions within a single file? That does not seem likely to be expect

[PATCH] D103918: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to use llvm-otool in our build. Repository: rG LLVM Github Mono

[PATCH] D103916: [CMake] Only include LTO on Apple targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde98da2eced7: [CMake] Only include LTO on Apple targets (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] de98da2 - [CMake] Only include LTO on Apple targets

Author: Petr Hosek Date: 2021-06-08T11:00:01-07:00 New Revision: de98da2eced72eee791a93b076b70a7b22175abc URL: https://github.com/llvm/llvm-project/commit/de98da2eced72eee791a93b076b70a7b22175abc DIFF: https://github.com/llvm/llvm-project/commit/de98da2eced72eee791a93b076b70a7b22175abc.diff LO

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3787ee457173: reland [IR] make -stack-alignment= into a module attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 3787ee4 - reland [IR] make -stack-alignment= into a module attr

Author: Nick Desaulniers Date: 2021-06-08T10:59:46-07:00 New Revision: 3787ee457173c3612aac4c9b1a2b6d6ab0202616 URL: https://github.com/llvm/llvm-project/commit/3787ee457173c3612aac4c9b1a2b6d6ab0202616 DIFF: https://github.com/llvm/llvm-project/commit/3787ee457173c3612aac4c9b1a2b6d6ab0202616.di

[PATCH] D103917: [analyzer] Extract InterestingLValueHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. I've retested with all backends enabled; all green now. Changes added to: - llvm/lib/Target/Mips/MipsCallLowering.cpp - llvm/lib/Target/Mips/MipsTargetMachine.cpp - llvm/test/CodeGen/Mips/stack-alignment.ll Planning to recommit now. Repository: rG LLVM Github

[PATCH] D103916: [CMake] Only include LTO on Apple targets

phosek updated this revision to Diff 350662. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103916/new/ https://reviews.llvm.org/D103916 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/F

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Making the order of constructors independent of UseInitArray seems obviously good in any case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103495/new/ https://reviews.ll

[PATCH] D103916: [CMake] Only include LTO on Apple targets

phosek created this revision. phosek added reviewers: haowei, leonardchan. Herald added subscribers: inglorion, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We only need libLTO when using ld64. Repository: rG LLVM Gith

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers updated this revision to Diff 350660. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added subscribers: atanasyan, sdardis. - fixes for MIPS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1030

[PATCH] D103849: Fix undeduced type when instanciating template member

aaron.ballman edited subscribers, added: cfe-commits; removed: rsmith. aaron.ballman added a comment. Adding the mailing lists to the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-c

[PATCH] D103914: [analyzer] Extract ArrayIndexHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103885: [clang] Suppress warnings for tautological comparison in generated macro code

aaron.ballman added a comment. In D103885#2805758 , @ychen wrote: > We could use a table to avoid the warning and speed the build a little bit. > https://reviews.llvm.org/D98110 That's an interesting approach, thank you for sharing it! I wonder how use

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103909/new/ https://reviews.llvm.org/D103909 __

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze marked an inline comment as done and an inline comment as not done. zukatsinadze added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:947 + +} // end "alpha.cert.env" + balazske wrote: > I have multiple issues wi

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 350656. zukatsinadze marked 2 inline comments as done. zukatsinadze added a comment. @balazske Thanks for the comments! Updated diff after suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked an inline comment as done. bcahoon added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471 + "true", + "Encoding format GFX10_A" +>; foad wrote: > I realise you're just following the precedent set by GFX10_B, but is this > termin

[PATCH] D103663: [AMDGPU] Add gfx1013 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea10a86984ea: [AMDGPU] Add gfx1013 target (authored by bcahoon). Changed prior to commit: https://reviews.llvm.org/D103663?vs=350468&id=350640#toc

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171 } // namespace __hwasan +#else // #if !SANITIZER_FUCHSIA +namespace __hwasan {

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

wolfgangp added a comment. In D103495#2804685 , @MaskRay wrote: > > Can you check whether clang/lib/CodeGen/CGDeclCXX.cpp:507 needs any comment > update? > The subject "Don't put ordered dynamic initializers of static variables into > global_ctors"

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

wolfgangp updated this revision to Diff 350644. wolfgangp retitled this revision from "[static initializers] Don't put ordered dynamic initializers of static variables into global_ctors" to "[static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.".

  1   2   >