[PATCH] D103917: [analyzer] Extract InterestingLValueHandler

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2156 -class DefaultExpressionHandler final : public ExpressionHandler { +// TODO: extract it into more handl

[PATCH] D103914: [analyzer] Extract ArrayIndexHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Nice and clean, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103914/new/ https://reviews.llvm.org/D103914 __

[PATCH] D103902: [analyzer] Extract NilReceiverHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I'm loving it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103902/new/ https://reviews.llvm.org/D103902 ___

[PATCH] D103677: [analyzer] Extract ControlDependencyHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2114 &getParentTracker(), InputNode); - Result.FoundSomethingToTrack = true; + return

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2047 + +// TODO: get rid of it. +const DeclStmt *DS = nullptr; WDYM? Also maybe downscope it? Comment at: clang/lib/StaticAnalyzer/Core/BugRep

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Got it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 __

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok this is amazing, no more comments!! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:210 + ///much. + virtual Result track(KnownS

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. In D103938#2806885 , @rsmith wrote: > This will diagnose unused values in unreachable code in constant-evaluated > contexts; that doesn't seem quite right. For example, in: > > void f() { > new double[false ? (1, 2) : 3][fals

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 351343. ychen added a comment. - Add `DiagIfReachable` and use it in `Sema::DiagnoseUnusedExprResult`. - Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 F

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM with some nits and if you extract FunctionStackPoisoner::initializeCallbacks into a separate patch Comment at: clang/test/CodeGen/asan-use-after-return.cpp:3 +/

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103595/new/ https://reviews.llvm.org/D103595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. In D104044#2811268 , @HazardyKnusperkeks wrote: > In D104044#2810909 , @darwin wrote: > >> Sorry, I may need some help here. It shows "Context not available.", how do >> I correct it? > >

[clang] 081ae5f - [RISCV] Remove extra assignment of intrinsic ID in ManualCodegen. NFC

Author: Craig Topper Date: 2021-06-10T20:46:34-07:00 New Revision: 081ae5fe1aa3ead6d9da75747d3698f09ff89cb9 URL: https://github.com/llvm/llvm-project/commit/081ae5fe1aa3ead6d9da75747d3698f09ff89cb9 DIFF: https://github.com/llvm/llvm-project/commit/081ae5fe1aa3ead6d9da75747d3698f09ff89cb9.diff

[clang] 85ca7e4 - Revert "[clang] NRVO: Improvements and handling of more cases."

Author: Arthur Eubanks Date: 2021-06-10T20:37:01-07:00 New Revision: 85ca7e424fd050582026a299906c9e8397043c52 URL: https://github.com/llvm/llvm-project/commit/85ca7e424fd050582026a299906c9e8397043c52 DIFF: https://github.com/llvm/llvm-project/commit/85ca7e424fd050582026a299906c9e8397043c52.diff

[clang] db26615 - Revert "[clang] Implement P2266 Simpler implicit move"

Author: Arthur Eubanks Date: 2021-06-10T19:54:50-07:00 New Revision: db26615aa6a165483e6540b3f6ed684a0cbe06df URL: https://github.com/llvm/llvm-project/commit/db26615aa6a165483e6540b3f6ed684a0cbe06df DIFF: https://github.com/llvm/llvm-project/commit/db26615aa6a165483e6540b3f6ed684a0cbe06df.diff

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aeubanks added a comment. Crashes on a stage 2 build on Windows: ../rel/bin/clang-cl /nologo /showIncludes /Foobj/llvm/lib/MC/MCParser/MCParser.MasmParser.obj /c ../../llvm/lib/MC/MCParser/MasmParser.cpp -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D95425#2810027 , @DavidSpickett wrote: > Also affecting riscv-v (riscvv?) so I've reverted the change. > > https://lab.llvm.org/buildbot/#/builders/67/builds/3087 Apologies for the breakages and thanks for reverting. I will tak

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan added a comment. The non-fuchsia stuff can be split up in a separate patch when ready, but I'll keep it here for now until we're set on the thread handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm

[PATCH] D104088: Add clang frontend flags for MIP

ellis created this revision. Herald added subscribers: dang, phosek, mgorny, emaste. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. ellis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Her

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

stella.stamenova added a comment. It looks like this caused a couple of failures on the Windows LLDB bot due to crashes in clang: https://lab.llvm.org/buildbot/#/builders/83/builds/7142 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ htt

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: Sanitizers. Herald added subscribers: jfb, mgorny, dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This patch splits up hwasan thread creati

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

ahatanak added a comment. Here is the patch that removes the fake FunctionDecls: https://reviews.llvm.org/D104082 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https://reviews.llvm.org/D98799 ___

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak added a comment. Also, is it okay to emit the `linkageName`, but not the `name` for the helper functions? It seems okay to me, but I'm not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/ https://reviews.llvm.org/D104082 _

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak created this revision. ahatanak added reviewers: rjmccall, aprantl, vsk. ahatanak added a project: clang. ahatanak requested review of this revision. These fake functions were causing clang to crash when https://reviews.llvm.org/D98799 made some changes. The line number information is n

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda updated this revision to Diff 351316. kda added a comment. - Change default parameters from Invalid to Never. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104076/new/ https://reviews.llvm.org/D104076 Files: clang/include/clang/Basic/CodeGen

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount updated this revision to Diff 351308. isthismyaccount added a comment. Rebased to hopefully resolve merge issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CM

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount commandeered this revision. isthismyaccount edited reviewers, added: aabbaabb; removed: isthismyaccount. isthismyaccount added a comment. Grabbing this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 _

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2811220 , @dblaikie wrote: > Any idea if the GDB test suite covers this functionality? I'd hope so, but > maybe it doesn't. > > But yeah, at the moment I don't have any great reason to avoid the imported > decla

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda created this revision. Herald added subscribers: ormris, dexonsmith, dang, hiraditya. kda requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Also: - add driver test (fsanitize-use-after-return.c) - add basic IR test (asa

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1589fc6d11: [static initializers] Emit global_ctors and global_dtors in reverse order when . (authored by wolfgangp). Repository: rG LLVM Github

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc018ebb608e: [IR] make -warn-frame-size into a module attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fc018eb - [IR] make -warn-frame-size into a module attr

Author: Nick Desaulniers Date: 2021-06-10T16:15:27-07:00 New Revision: fc018ebb608ee0c1239b405460e49f1835ab6175 URL: https://github.com/llvm/llvm-project/commit/fc018ebb608ee0c1239b405460e49f1835ab6175 DIFF: https://github.com/llvm/llvm-project/commit/fc018ebb608ee0c1239b405460e49f1835ab6175.di

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

sammccall added a comment. This includes both the traversal change and the clangd changes to adapt to it, since there ended up being few. I chickened out of the idea of changing the behavior of TranslationUnitDecl::decls(), for a couple of reasons: - having it apply to RecursiveASTVisitor only

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

sammccall created this revision. sammccall added reviewers: hokein, chh, srhines. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Given `int foo, bar;`, Tr

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd0054b9eb1: [clang] Implement P2266 Simpler implicit move (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cbd0054 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-11T00:56:06+02:00 New Revision: cbd0054b9eb17ec48f0702e3828209646c8f5ebd URL: https://github.com/llvm/llvm-project/commit/cbd0054b9eb17ec48f0702e3828209646c8f5ebd DIFF: https://github.com/llvm/llvm-project/commit/cbd0054b9eb17ec48f0702e3828209646c8f5ebd.dif

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. Actually we can land it now. @rsmith gave me the go ahead in private. The windows pipeline passes. The latest debian build failure is some random fortran thing, so we are good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. IMHO we should just land this already. (It's been sitting without major update since mid-April.) It is intended to affect only `-std=c++2b` mode, and implements a paper (full disclo

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 351274. mizvekov added a comment. rerun pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCorouti

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG667fbcdd0b2e: [clang] NRVO: Improvements and handling of more cases. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https:

[clang] 667fbcd - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-10T23:02:51+02:00 New Revision: 667fbcdd0b2ee5e78f5ce9789b862e3bbca94644 URL: https://github.com/llvm/llvm-project/commit/667fbcdd0b2ee5e78f5ce9789b862e3bbca94644 DIFF: https://github.com/llvm/llvm-project/commit/667fbcdd0b2ee5e78f5ce9789b862e3bbca94644.dif

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added reviewers: nickdesaulniers, pcc, tejohnson, kees, eugenis. samitolvanen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:79 + GlobalValue::InternalLinkage, Name, F, &ExportM); + appendToCompil

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. samitolvanen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Create an internal alias with the original name for static

[PATCH] D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Without this patch clangd

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers updated this revision to Diff 351250. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - move driver test from clang/test/Frontend/ to clang/test/Driver/, update comment, clarify TODOs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/test/Frontend/Wframe-larger-than.c:2 +// RUN: %clang -Wframe-larger-than=42 -v -E - < /dev/null 2>&1 | FileCheck %s +// Check that we pass -Wframe-larger-than through to cc1. +// CHECK: cc1 {{.*}} -fwa

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver added a comment. In D103958#2811246 , @efriedma wrote: >> Defining the value used to establish a control dependency, e.g. the load >> later writes depend on (kernel only defines writes to be ctrl-dependently >> ordered). > > `[[mustcontrol]]` als

[clang] 1d3873d - Move variable only used inside an assert into the assert.

Author: Sterling Augustine Date: 2021-06-10T13:14:45-07:00 New Revision: 1d3873d41eca67e974bafbaa91866581bcc0d973 URL: https://github.com/llvm/llvm-project/commit/1d3873d41eca67e974bafbaa91866581bcc0d973 DIFF: https://github.com/llvm/llvm-project/commit/1d3873d41eca67e974bafbaa91866581bcc0d973.

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. In D101868#2811290 , @HazardyKnusperkeks wrote: > In D101868#2810452 , @feg208 wrote: > >> If I can get someone to submit this on my behalf I think we can call it a >> day. > > Please pos

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D99840#2718959 , @curdeius wrote: > LGTM. I also consider it a bug. LLVM should not be affected as it uses > `AllowShortEnumsOnASingleLine: true` whereas this problem arises

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. Then we can push it, do you need some one to do that? If yes please post name and email. Comment at: clang/unittests/Format/FormatTest.cpp:18475 +)", +Style); } I think the pre merge lint means this line. Please fix that an

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK. I wouldn't mind the places that can use op<< to use that - not sure preserving the explicit radix argument is super high value. (I think people would generally assume that's th

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2787550 , @HazardyKnusperkeks wrote: > LGTM, but please wait for more responses. No one objected, so I declare it ready to commit. Do you need some one to do it? If yes please post name and email for the c

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Do you need some one to commit this? If yes please state name and email, some one will chime in to commit it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678 _

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D101868#2810452 , @feg208 wrote: > If I can get someone to submit this on my behalf I think we can call it a day. Please post the name and email for the commit. And if no o

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

HazardyKnusperkeks added a comment. I think this would be a nice addition, and in the past I would have used it. I really like the option `Pointer`. If this will be pursued I will be happy to review it. Comment at: clang/unittests/Format/FormatTest.cpp:895 + verifyFormat("in

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. In D104044#2810909 , @darwin wrote: > Sorry, I may need some help here. It shows "Context not available.", how do I > correct it? There are multiple ways: https://llvm.org/docs/Phabricator.html#requesting-a-review-vi

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https://reviews.llvm.org/D102186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. Hmm, I can't repro the module test failures locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 ___ cfe-commits mailing list cfe

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

efriedma added a comment. > Defining the value used to establish a control dependency, e.g. the load > later writes depend on (kernel only defines writes to be ctrl-dependently > ordered). `[[mustcontrol]]` also has this problem. At the LLVM IR level, if just want to split the load from the co

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. Any idea if the GDB test suite covers this functionality? I'd hope so, but maybe it doesn't. But yeah, at the moment I don't have any great reason to avoid the imported declaration form - so happy to go with that. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103495/new/ https://reviews.llvm.org/D103495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode(&InitializingVar .bind("declStmt")), +Body

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Before this patch, the dependence of CallExpr was only computed in the constructor, the dependence bits might not reflect truth -- some arguments might be not

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver updated this revision to Diff 351229. melver added a comment. As promised, some cleanups, docs, and updated test for the current version (no other major changes yet). While the identical-writes test is quite contrived, the currently failing switch test is a more realistic example. The exam

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ c

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

wolfgangp added a comment. If nobody has any more objections, I'll commit this change, then. Please let me know if you think otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103495/new/ https://reviews.llvm.org/D103495 ___ cfe-commit

[PATCH] D95496: [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonical loops.

Meinersbur abandoned this revision. Meinersbur added a comment. Obsolete since D94973 was committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95496/new/ https://reviews.llvm.org/D95496 ___

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); +

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

abhinavgaba added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &) _

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, amend the comment as suggested in the final commit Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + // Method overloading is handled above, s

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. Sorry, I may need some help here. It shows "Context not available.", how do I correct it? Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104044/new/ https://reviews.llvm.org/D104044 __

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin created this revision. darwin added a project: clang-format. darwin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This a bug fix of https://bugs.llvm.org/show_bug.cgi?id=50116 First revision only contains the change of the test co

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

mbenfield accepted this revision. mbenfield added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103949/new/ https://reviews.llvm.org/D103949 ___ cfe-commits mailing list cfe-com

[clang] c3cc14f - Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp-contract=on"

Author: Melanie Blower Date: 2021-06-10T12:19:02-04:00 New Revision: c3cc14f87f78f8172b74175bbd2557cfb9384900 URL: https://github.com/llvm/llvm-project/commit/c3cc14f87f78f8172b74175bbd2557cfb9384900 DIFF: https://github.com/llvm/llvm-project/commit/c3cc14f87f78f8172b74175bbd2557cfb9384900.diff

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked an inline comment as done. martong added a comment. I have the first measurements results in the attached zip file. The file contains the html file generated by csa-testbench. It's name contains `CTU` but actually it was a regular non-CTU analysis. The most interesting is probably

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 351195. andrewjcg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/Inputs/implic

[PATCH] D103987: Start tracking Clang's C implementation status

aaron.ballman closed this revision. aaron.ballman added a comment. In D103987#2809125 , @jyknight wrote: > Sounds like a great plan to me. > > I might suggest adding some text about the page being incomplete, so that > people don't wonder if the blank se

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

svenvh created this revision. svenvh added reviewers: azabaznov, Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add an emitter to produce something similar to `opencl-c.h` from th

[clang] 3a7a774 - Add a page to track the status of C proposals in Clang.

Author: Aaron Ballman Date: 2021-06-10T12:00:52-04:00 New Revision: 3a7a7749417854827cf621eaef6012d31e7a82ab URL: https://github.com/llvm/llvm-project/commit/3a7a7749417854827cf621eaef6012d31e7a82ab DIFF: https://github.com/llvm/llvm-project/commit/3a7a7749417854827cf621eaef6012d31e7a82ab.diff

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille updated this revision to Diff 351191. serge-sans-paille added a comment. Added test + fix suggested by @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 Files: clang/lib/AST/Expr.cpp clang/test/CodeGenCXX/aut

[PATCH] D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104033/new/ https://reviews.llvm.org/D104033 ___

[PATCH] D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104031/new/ https://reviews.llvm.org/D104031 ___

[PATCH] D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 added a subscriber: saudi. jansvoboda11 added a comment. FYI @saudi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104030/new/ https://reviews.llvm.org/D104030 ___ cfe-commits mailing list c

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

DNS320 added a comment. Friendly Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102576/new/ https://reviews.llvm.org/D102576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70b0e808da8: [clang-cl] Add /permissive and /permissive- (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c70b0e8 - [clang-cl] Add /permissive and /permissive-

Author: Markus Böck Date: 2021-06-10T17:06:19+02:00 New Revision: c70b0e808da8e1650f3ee426698a8b87c94b8910 URL: https://github.com/llvm/llvm-project/commit/c70b0e808da8e1650f3ee426698a8b87c94b8910 DIFF: https://github.com/llvm/llvm-project/commit/c70b0e808da8e1650f3ee426698a8b87c94b8910.diff L

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

This revision was automatically updated to reflect the committed changes. Closed by commit rG936d6756ccfb: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 936d675 - [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

Author: Markus Böck Date: 2021-06-10T17:02:44+02:00 New Revision: 936d6756ccfbe207a181b692b828f9fd8f1489f2 URL: https://github.com/llvm/llvm-project/commit/936d6756ccfbe207a181b692b828f9fd8f1489f2 DIFF: https://github.com/llvm/llvm-project/commit/936d6756ccfbe207a181b692b828f9fd8f1489f2.diff L

[PATCH] D103749: [clang][driver] Add -foperator-names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9833b57981c4: [clang][driver] Add -foperator-names (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 9833b57 - [clang][driver] Add -foperator-names

Author: Markus Böck Date: 2021-06-10T17:01:35+02:00 New Revision: 9833b57981c4e9402a326b5acd805e074cd2c802 URL: https://github.com/llvm/llvm-project/commit/9833b57981c4e9402a326b5acd805e074cd2c802 DIFF: https://github.com/llvm/llvm-project/commit/9833b57981c4e9402a326b5acd805e074cd2c802.diff L

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG49eba8bf1780: [clang] Do not crash when ArgTy is null in CheckArgAlignment (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ h

[clang] 49eba8b - [clang] Do not crash when ArgTy is null in CheckArgAlignment

Author: Adam Czachorowski Date: 2021-06-10T16:54:15+02:00 New Revision: 49eba8bf1780684f1173a455b909ce37008eaa09 URL: https://github.com/llvm/llvm-project/commit/49eba8bf1780684f1173a455b909ce37008eaa09 DIFF: https://github.com/llvm/llvm-project/commit/49eba8bf1780684f1173a455b909ce37008eaa09.d

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One of the goals of the dependency scanner is to provide command-lines that can be used t

[PATCH] D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves enabling system header deps from `clang-scan-deps` into the `D

[PATCH] D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves another piece of logic specific to `clang-scan-deps` into the `Depen

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm updated this revision to Diff 351165. olestrohm added a comment. Added a comment explaining what the check is meant for. Also added a `CHECK-NOT: used` to properly test that the __generic constructor is not used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102850/new/ http

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. The bot is showing a fail due to this patch, see https://lab.llvm.org/buildbot#builders/110/builds/4007 It looks like my updates to LNT earlier this week haven't been migrated to the bot, is that right? See https://reviews.llvm.org/rTccc86f938839d02de3a6564b2d80fb47a60

[PATCH] D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `clang-scan-deps` tool has some logic that parses and modifies the original

  1   2   >