[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 356321. chh added a comment. fix clang-format coding style issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 356319. chh marked an inline comment as done. chh added a comment. fix clang-format name style issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

MaskRay added a comment. In GCC -Wstack-usage= is more powerful. It can check `warning: stack usage might be unbounded`. If this is currently just an alias, does it address some application pain? If we don't actually implement the -Wstack-usage= functionality, I'd hope that applications know

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh marked an inline comment as done and an inline comment as not done. chh added a comment. Last build tests were green. Let's see if the new updated diff still passes all the tests. Looks like all choices have some risk/overhead in future maintenance and we need to pick one with the least

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 356307. chh marked an inline comment as done. chh edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra created this revision. tra added a reviewer: steffenlarsen. Herald added subscribers: bixia, hiraditya, yaxunl, jholewinski. tra requested review of this revision. Herald added a subscriber: jdoerfert. Herald added projects: clang, LLVM. Extends the changes in D104847

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

tra added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx-mma.cu:781-786 + // CHECK_PTX70_SM80: call {{.*}} @llvm.nvvm.wmma.m16n16k8.load.c.col.stride.f32 + // expected-error-re@+1 {{'__mma_tf32_m16n16k8_ld_c' needs target feature (sm_80{{.*}},(ptx70{{.* +

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. @anhtuyen I pushed a DR with a preliminary fix for it: https://reviews.llvm.org/D105380 This is not ready to merge, still have to add test cases and also decide between a pointed fix like this, or improving the ergonomics of `getDeclAlign` by returning possible

[PATCH] D105380: DRAFT: [clang] fixes named return of variables with dependent alignment

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105380 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D105368: Lex: add a callback for `#pragma mark`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f4c3ebef63: Lex: add a callback for `#pragma mark` (authored by compnerd, committed by Saleem Abdulrasool abdul...@google.com). Repository: rG

[clang] 24f4c3e - Lex: add a callback for `#pragma mark`

Author: Saleem Abdulrasool Date: 2021-07-02T15:44:01-07:00 New Revision: 24f4c3ebef63c7d2553132d7d9d75ea19338bcb7 URL: https://github.com/llvm/llvm-project/commit/24f4c3ebef63c7d2553132d7d9d75ea19338bcb7 DIFF:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. In D99696#2856285 , @anhtuyen wrote: > Hi Matheus @mizvekov, > The commit 12c90e2e25dfd1d38250055efc21acb42d158912 > from > this patch seems to cause a

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

tra added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx-mma.cu:781-786 + // CHECK_PTX70_SM80: call {{.*}} @llvm.nvvm.wmma.m16n16k8.load.c.col.stride.f32 + // expected-error-re@+1 {{'__mma_tf32_m16n16k8_ld_c' needs target feature (sm_80{{.*}},(ptx70{{.* +

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: morehouse. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105378 Files:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

anhtuyen added a comment. Hi Mathew @mizvekov, The commit 12c90e2e25dfd1d38250055efc21acb42d158912 from this patch seems to cause a regression, where an assertion failure starts to occur with testcases such as template

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I'm happy with this. Comment at: compiler-rt/include/profile/InstrProfData.inc:79 +INSTR_PROF_DATA(const IntPtrT, IntPtrTy, CounterPtr, +

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd updated this revision to Diff 356273. compnerd added a comment. Correct lifetime of data in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105368/new/ https://reviews.llvm.org/D105368 Files:

[PATCH] D105368: Lex: add a callback for `#pragma mark`

dgoldman added inline comments. Comment at: clang/unittests/Lex/PPCallbacksTest.cpp:119 +SourceLocation Location; +StringRef Trivia; + }; should this be an std::string? not sure of the lifetime guarantees here Repository: rG LLVM Github Monorepo

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 356272. quinnp marked 4 inline comments as done. quinnp added a comment. Fixing a typo and the format of a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev created this revision. ABataev added reviewers: jdoerfert, vzakharin, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Current implementation is not compatible with

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 356264. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 356256. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd created this revision. compnerd added reviewers: dgoldman, rsmith, aaron.ballman. Herald added subscribers: usaxena95, kadircet, kbarton, nemanjai. compnerd requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Allow a preprocessor

[clang] 5d689cf - [NFC][CUDA] Fix order of round(f) definition in __clang_cuda_math.h for non-LP64.

Author: Joachim Meyer Date: 2021-07-02T21:55:48+02:00 New Revision: 5d689cf2a667d8dc51768400455e0ecc55d19eaf URL: https://github.com/llvm/llvm-project/commit/5d689cf2a667d8dc51768400455e0ecc55d19eaf DIFF: https://github.com/llvm/llvm-project/commit/5d689cf2a667d8dc51768400455e0ecc55d19eaf.diff

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 356250. manas added a comment. Replace literal-value 0 with APSInt Zero Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files:

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas updated this revision to Diff 356249. manas added a comment. Remove redundant getAPSIntType calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105273/new/ https://reviews.llvm.org/D105273 Files:

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas updated this revision to Diff 356245. manas added a comment. Replace literal-value 0 with APSInt Zero Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105273/new/ https://reviews.llvm.org/D105273 Files:

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1485 + if (ResultType.isUnsigned() || + ((LHS.From() >= 0 && RHS.From() < 0) && + (LHS.To() >= 0 && RHS.To() < 0)) || manas wrote: > @vsavchenko

[PATCH] D105365: [Lexer] Fix bug in `makeFileCharRange` called on split tokens.

ymandel created this revision. ymandel added a reviewer: sammccall. ymandel requested review of this revision. Herald added a project: clang. When the end loc of the specified range is a split token, `makeFileCharRange` does not process it correctly. This patch adds proper support for split

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1485 + if (ResultType.isUnsigned() || + ((LHS.From() >= 0 && RHS.From() < 0) && + (LHS.To() >= 0 && RHS.To() < 0)) || @vsavchenko one thing crossed my

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas updated this revision to Diff 356235. manas marked 3 inline comments as done. manas added a comment. Merge conditionals with similar block and add test for one overflow on Tmax-side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105273/new/

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas marked 3 inline comments as done. manas added a comment. Thanks Valeriy. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1490 + // the resulting range should be [Min, Max]. + if (ResultType.isUnsigned()) { +return {RangeFactory,

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:727 TARGET_BUILTIN(__bmma_m8n8k128_ld_c, "vi*iC*UiIi", "", AND(SM_75,PTX63)) TARGET_BUILTIN(__bmma_m8n8k128_mma_xor_popc_b1, "vi*iC*iC*iC*Ii", "", AND(SM_75,PTX63))

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356226. RedDocMD added a comment. Simplify SVal on state split, other refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD marked 3 inline comments as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:484 + clang_analyzer_eval(nullPtr != nullptr);// expected-warning{{FALSE}} + clang_analyzer_eval(nullptr <= unknownPtr); // expected-warning{{TRUE}} +}

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

hctim added a comment. Hi, looks like this change caused a regression on the sanitizer buildbots (https://lab.llvm.org/buildbot/#/builders/169/builds/1290/steps/25/logs/stdio). Error copied below for your convenience. Can be repro'd using the bot instructions at

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a96e906cc0: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes (authored by sbc100). Changed prior to commit:

[clang] d1a96e9 - [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

Author: Sam Clegg Date: 2021-07-02T11:05:40-07:00 New Revision: d1a96e906cc03a95cfd41a1f22bdda92651250c7 URL: https://github.com/llvm/llvm-project/commit/d1a96e906cc03a95cfd41a1f22bdda92651250c7 DIFF: https://github.com/llvm/llvm-project/commit/d1a96e906cc03a95cfd41a1f22bdda92651250c7.diff

[clang] 3ec88ca - Revert "[clang-repl] Allow passing in code as positional arguments."

Author: Mitch Phillips Date: 2021-07-02T11:04:28-07:00 New Revision: 3ec88ca60b24418b2216de88fad1da4f269f6b8c URL: https://github.com/llvm/llvm-project/commit/3ec88ca60b24418b2216de88fad1da4f269f6b8c DIFF:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:431 + State, BOK, FirstPtrVal, SecondPtrVal, Call.getResultType()); + State = State->BindExpr(Call.getOriginExpr(), C.getLocationContext(), RetVal); + Now that

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

kripken accepted this revision. kripken added a comment. This revision is now accepted and ready to land. I believe we have all agreed that this is the right path forward, and so this can land? Doing this change now in emscripten does not prevent us from changing the emscripten ABI again

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. @airlied I think this patch is outdated as some features have been committed in the meantime. Are you still interested in working on this change? It might help splitting into smaller independent chunks. It is usually faster to review and test. Repository: rG LLVM

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105360

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

This revision was automatically updated to reflect the committed changes. Closed by commit rG75e941b05c78: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp` (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105322/new/

[clang] 75e941b - [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

Author: Joachim Meyer Date: 2021-07-02T19:03:15+02:00 New Revision: 75e941b05c78e19c51e5c960c925f334b08109bb URL: https://github.com/llvm/llvm-project/commit/75e941b05c78e19c51e5c960c925f334b08109bb DIFF: https://github.com/llvm/llvm-project/commit/75e941b05c78e19c51e5c960c925f334b08109bb.diff

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. In D105340#2855387 , @vsavchenko wrote: > Also, although the test is very extensive, it is pretty lopsided at the same > time. C-style cast is only one case out of the myriad of all explicit and, > more importantly,

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Wow, thanks for the CUDA stubs! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105322/new/ https://reviews.llvm.org/D105322

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

jdoerfert requested changes to this revision. jdoerfert added a comment. We need a macro for OPENMP and one for OPENMP_OFFLOAD, we can use a single one for the latter and avoid _NVPTX, _AMDGCN, ... but we need both as described by @fodinabor. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:38 + +static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) { + return __a[0]; pengfei wrote: > RKSimon wrote: > > I realize its a lot of work, but is there

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.h:748 bool hasVLX() const { return HasVLX; } + bool hasFP16() const { return HasFP16; } bool hasPKU() const { return HasPKU; } pengfei wrote: > RKSimon wrote: > > I'm a

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:38 + +static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) { + return __a[0]; RKSimon wrote: > I realize its a lot of work, but is there any chance that we

[PATCH] D105354: [clang][AST] Add support for DecompositionDecl to ASTImporter.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408 + auto makeSValFor = [, , this](const Expr *E, SVal S) -> SVal { +if (S.isZeroConstant()) { + return C.getSValBuilder().makeZeroVal(E->getType());

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:318 +ANALYZER_OPTION(bool, ShouldHandleIntegralCastForRanges, +"handle-integral-cast-for-ranges", +"Handle truncations, promotions and

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added a comment. Also, even though the test is very extensive it is pretty lopsided at the same time. C-style cast is only one case out of the myriad of all explicit and, more importantly, implicit casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

vsavchenko added a comment. Hey Manas! Great job, you put this together real quick! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1490 + // the resulting range should be [Min, Max]. + if (ResultType.isUnsigned()) { +return {RangeFactory,

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:334 +const Decl *SymbolCollector::getRefContainer(const Decl *Enclosing) { + const NamedDecl *ND = dyn_cast_or_null(Enclosing); why do we need to expose this

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2855322 , @pmatos wrote: > After @arsenm 's commit > https://github.com/llvm/llvm-project/commit/990278d026d680942c859be70836ad34a9a716f7, > MachineOperands store LLT for size instead of uint64_t and the constructor

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/produce-symbolcast.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -analyzer-config handle-integral-cast-for-ranges=true -verify %s + steakhal wrote: > vsavchenko

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. After @arsenm 's commit https://github.com/llvm/llvm-project/commit/990278d026d680942c859be70836ad34a9a716f7, MachineOperands store LLT for size instead of uint64_t and the constructor called from `SelectionDAG::getLoad`, calls `MachineMemOperand` which does: :

[clang-tools-extra] e42bb5e - Reapply [clangd] Fix possible assertion fail in TUScheduler

Author: Sam McCall Date: 2021-07-02T16:32:13+02:00 New Revision: e42bb5e35a88c6a163934080883d4c5bc1f32cfc URL: https://github.com/llvm/llvm-project/commit/e42bb5e35a88c6a163934080883d4c5bc1f32cfc DIFF: https://github.com/llvm/llvm-project/commit/e42bb5e35a88c6a163934080883d4c5bc1f32cfc.diff

[clang-tools-extra] 33ff807 - Revert "[clangd] Unbreak mac build differently 0c96a92d8666b8"

Author: Sam McCall Date: 2021-07-02T16:29:48+02:00 New Revision: 33ff8078ff744cb317ec8806c990a52d33310834 URL: https://github.com/llvm/llvm-project/commit/33ff8078ff744cb317ec8806c990a52d33310834 DIFF: https://github.com/llvm/llvm-project/commit/33ff8078ff744cb317ec8806c990a52d33310834.diff

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

steakhal added inline comments. Comment at: clang/test/Analysis/produce-symbolcast.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -analyzer-config handle-integral-cast-for-ranges=true -verify %s + vsavchenko wrote: > ASDenysPetrov

[clang-tools-extra] fff966b - Revert "[clangd] Fix possible assertion fail in TUScheduler"

Author: Sam McCall Date: 2021-07-02T16:07:11+02:00 New Revision: fff966b6855aee6fc0d0d4cd401cdd525a838572 URL: https://github.com/llvm/llvm-project/commit/fff966b6855aee6fc0d0d4cd401cdd525a838572 DIFF: https://github.com/llvm/llvm-project/commit/fff966b6855aee6fc0d0d4cd401cdd525a838572.diff

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2854939 , @lebedev.ri wrote: > Reverted again > > > FAIL: LLVM :: CodeGen/WebAssembly/funcref-call.ll (44466 of 44468) > TEST 'LLVM ::

[clang-tools-extra] 5056694 - [clangd] Fix possible assertion fail in TUScheduler

Author: Sam McCall Date: 2021-07-02T15:57:39+02:00 New Revision: 50566947e98ea845030cfa3b4c199fb9a2052d53 URL: https://github.com/llvm/llvm-project/commit/50566947e98ea845030cfa3b4c199fb9a2052d53 DIFF: https://github.com/llvm/llvm-project/commit/50566947e98ea845030cfa3b4c199fb9a2052d53.diff

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added inline comments. Comment at: clang/test/Analysis/produce-symbolcast.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -analyzer-config handle-integral-cast-for-ranges=true -verify %s + ASDenysPetrov wrote: > vsavchenko

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:38 + +static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) { + return __a[0]; I realize its a lot of work, but is there any chance that we could get doxygen

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. I will update the patch soon according to your suggestions. Comment at: clang/test/Analysis/bool-assignment.c:46-50 #ifdef ANALYZER_CM_Z3 BOOL x = y; // expected-warning {{Assignment of a non-Boolean value}} #else -BOOL x = y; //

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:429-435 +const ExplodedNode *N = BR.getErrorNode(); +while (N && N != NotePosition) { + const StreamState *StreamS = N->getState()->get(StreamSym); + if (!StreamS ||

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added inline comments. Comment at: clang/test/Analysis/range_casts.c:125-126 if (index - 1UL == 0L) // Was not reached prior fix. -clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}} +// Tempopary regression in scope of implementing integral

[clang] b77b220 - [NFC] Fix typo in comment

Author: Sven van Haastregt Date: 2021-07-02T11:39:17+01:00 New Revision: b77b2201dc1f50f10e724c8c0b63963c5d98bf74 URL: https://github.com/llvm/llvm-project/commit/b77b2201dc1f50f10e724c8c0b63963c5d98bf74 DIFF:

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

vsavchenko added a comment. Hey, thanks for starting on splitting into more pieces! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:96 QualType OriginalTy); + SVal simplifySymbolCast(nonloc::SymbolVal V, QualType

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. I redesigned the algorithm and did a complete long-term evaluation by myself, and got very good results. Whether it is -entropic=0 or 1, it performs very well, and -fork mode is now better than paralllel fuzzing mode Better performance, please move to D105084.

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei added a comment. In D105331#2854934 , @SjoerdMeijer wrote: > The patch on itself looks reasonable to me. I was just wondering about the > _Float16 support on X86 in general because the Clang docs says: > > _Float16 is currently only supported

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Reverted again FAIL: LLVM :: CodeGen/WebAssembly/funcref-call.ll (44466 of 44468) TEST 'LLVM :: CodeGen/WebAssembly/funcref-call.ll'

[clang] c2c0d3e - Revert "[WebAssembly] Implementation of global.get/set for reftypes in LLVM IR"

Author: Roman Lebedev Date: 2021-07-02T11:49:51+03:00 New Revision: c2c0d3ea894328667583155334f0607db0c0a73a URL: https://github.com/llvm/llvm-project/commit/c2c0d3ea894328667583155334f0607db0c0a73a DIFF: https://github.com/llvm/llvm-project/commit/c2c0d3ea894328667583155334f0607db0c0a73a.diff

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

SjoerdMeijer added a comment. The patch on itself looks reasonable to me. I was just wondering about the _Float16 support on X86 in general because the Clang docs says: _Float16 is currently only supported on the following targets, with further targets pending ABI standardization: Does X86

[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

xiangzhangllvm added a comment. Done at https://reviews.llvm.org/D105336, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104766/new/ https://reviews.llvm.org/D104766 ___ cfe-commits mailing

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356128. RedDocMD added a comment. Performing state split on normal comparision ops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor added a comment. I added a pretty simple regression that should make testing this -x cuda -fopenmp issue simpler: https://reviews.llvm.org/D105322 I guess a similar test for -x hip -fopenmp could be added, but it hasn't been an issue so far as HIP and OpenMP AMDGCN seem to use the

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

sammccall added a comment. In D100553#2852981 , @thakis wrote: > I guess now clangd/xpc needs an explicit dep on that .inc generating rule. I think it's rather missing `-I` for the generated clangd directory. (The targets in clangd/xpc depend on

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa27a17f88386: [clang][AST] Add support for BindingDecl to ASTImporter. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a27a17f - [clang][AST] Add support for BindingDecl to ASTImporter.

Author: Balázs Kéri Date: 2021-07-02T10:14:50+02:00 New Revision: a27a17f883864c1c44a0ba3fb01bbf1c89110b82 URL: https://github.com/llvm/llvm-project/commit/a27a17f883864c1c44a0ba3fb01bbf1c89110b82 DIFF: https://github.com/llvm/llvm-project/commit/a27a17f883864c1c44a0ba3fb01bbf1c89110b82.diff

[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

xiangzhangllvm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14834 +BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn); +BasicBlock *Error = createBasicBlock(StrErr, this->CurFn); craig.topper wrote: > Sorry I'm late

[clang-tools-extra] 26e1553 - [clangd] CMake: express -Iclangd/ at top level and inherit

Author: Sam McCall Date: 2021-07-02T09:52:36+02:00 New Revision: 26e1553a107f52667be879e99739a4153f8799d8 URL: https://github.com/llvm/llvm-project/commit/26e1553a107f52667be879e99739a4153f8799d8 DIFF: https://github.com/llvm/llvm-project/commit/26e1553a107f52667be879e99739a4153f8799d8.diff

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4facbf213c51: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Repository: rG LLVM Github Monorepo

[clang] 4facbf2 - [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

Author: Paulo Matos Date: 2021-07-02T09:46:28+02:00 New Revision: 4facbf213c51e4add2e8c19b08d5e58ad71c72de URL: https://github.com/llvm/llvm-project/commit/4facbf213c51e4add2e8c19b08d5e58ad71c72de DIFF: https://github.com/llvm/llvm-project/commit/4facbf213c51e4add2e8c19b08d5e58ad71c72de.diff

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

martong accepted this revision. martong added a comment. In D102492#2854811 , @balazske wrote: > Not using `auto` declarations. Still looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0c53f60 - [clangd] Add some more missing include dirs for completeness

Author: Sam McCall Date: 2021-07-02T09:04:53+02:00 New Revision: 0c53f602d5a9d7207abb13e463f68e9d092f47a7 URL: https://github.com/llvm/llvm-project/commit/0c53f602d5a9d7207abb13e463f68e9d092f47a7 DIFF: https://github.com/llvm/llvm-project/commit/0c53f602d5a9d7207abb13e463f68e9d092f47a7.diff

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 356110. balazske marked an inline comment as done. balazske added a comment. Not using `auto` declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files:

[clang-tools-extra] 86c5afa - [clangd] Fix XPC build due to missing include path

Author: Sam McCall Date: 2021-07-02T08:47:46+02:00 New Revision: 86c5afa6e601c4a80d46a7a8b892d5c49bcec078 URL: https://github.com/llvm/llvm-project/commit/86c5afa6e601c4a80d46a7a8b892d5c49bcec078 DIFF: https://github.com/llvm/llvm-project/commit/86c5afa6e601c4a80d46a7a8b892d5c49bcec078.diff