[PATCH] D105400: [clangd][iwyu] explicitly includes ``

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105400/new/ https://reviews.llvm.org/D105400

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

This revision was automatically updated to reflect the committed changes. Closed by commit rGc558b1fca735: [analyzer] Fix calculating offset for fields with an empty type (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c558b1f - [analyzer] Fix calculating offset for fields with an empty type

Author: Georgy Komarov Date: 2021-07-04T06:57:11+03:00 New Revision: c558b1fca7350f4f4d8e7387fb2ead951284a5cf URL: https://github.com/llvm/llvm-project/commit/c558b1fca7350f4f4d8e7387fb2ead951284a5cf DIFF:

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei updated this revision to Diff 356364. pengfei marked 2 inline comments as done. pengfei added a comment. Add prefix AVX512BW for non FP16 cases. Thanks Simon for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

anhtuyen added a comment. In D99696#2856370 , @mizvekov wrote: > @anhtuyen > > I pushed a DR with a preliminary fix for it: https://reviews.llvm.org/D105380 > > This is not ready to merge, still have to add test cases and also decide > between a pointed

[PATCH] D105400: [clangd][iwyu] explicitly includes ``

cjdb created this revision. Herald added subscribers: usaxena95, kadircet, jfb, arphaman. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Compiling clangd with Clang modules and libc++ revealed that

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. F17741480: 704.jpg I only have a few nits left. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:35 #include +#include

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

jrtc27 added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:239-246 +// RUN: -o - | FileCheck --check-prefix=CHECK-VAMO-EXT %s +// RUN: %clang -target riscv64-unknown-linux-gnu -menable-experimental-extensions \ +// RUN: -march=rv32izvamo0p10 -x c

[PATCH] D105396: [RISCV] Remove Zvamo implication for v1.0-rc change

arcbbb updated this revision to Diff 356353. arcbbb retitled this revision from "[RISCV] Remove Zvamo extension for v1.0-rc change" to "[RISCV] Remove Zvamo implication for v1.0-rc change". arcbbb edited the summary of this revision. arcbbb added a comment. keep Zvamo0p10 and remove the

[PATCH] D105396: [RISCV] Remove Zvamo extension for v1.0-rc change

arcbbb created this revision. arcbbb added reviewers: rogfer01, frasercrmck, jrtc27, craig.topper, evandro, HsiangKai, khchen, kito-cheng. Herald added subscribers: vkmr, dexonsmith, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, jfb, the_o,

[PATCH] D105396: [RISCV] Remove Zvamo extension for v1.0-rc change

jrtc27 added a comment. This is going to be a lot of churn. Why not just keep Zvamo0p10 as an experimental extension until a re-encoded version appears? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105396/new/ https://reviews.llvm.org/D105396

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

lebedev.ri added inline comments. Comment at: llvm/lib/Target/X86/X86ScheduleZnver3.td:64 - let CompleteModel = 1; + let CompleteModel = 0; } RKSimon wrote: > You could avoid this change if you add a scheduler class to whatever > instruction is

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ScheduleZnver3.td:64 - let CompleteModel = 1; + let CompleteModel = 0; } You could avoid this change if you add a scheduler class to whatever instruction is complaining? Repository: rG

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl marked an inline comment as done. pestctrl added a comment. @rsmith Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 ___ cfe-commits mailing list

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/vector-reduce-fmax-nnan.ll:7 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512f,+avx512bw | FileCheck %s --check-prefixes=ALL,AVX512 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown

[PATCH] D105395: [IRBuilder] Add type argument to CreateMaskedLoad/Gather

nikic added inline comments. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td:1519 string llvmBuilder = [{ +llvm::Type *Ty = $data->getType()->getPointerElementType(); $res = $pass_thru.empty() ? builder.CreateMaskedLoad( Would be great if

[PATCH] D105395: [IRBuilder] Add type argument to CreateMaskedLoad/Gather

nikic created this revision. nikic added a reviewer: opaque-pointers. Herald added subscribers: dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay updated this revision to Diff 356310. MaskRay marked an inline comment as done. MaskRay added a comment. Move ConstantExpr::getSub from .inc to InstrProfiling.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay updated this revision to Diff 356271. MaskRay edited the summary of this revision. MaskRay added a comment. Drop version 5 compatibility because the Linux kernel patch is suspended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/

[PATCH] D105380: DRAFT: [clang] fixes named return of variables with dependent alignment

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3401 +return false; + }; + Perhaps use `std::any_of`? Maybe there is even a range wrapper in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION