[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

NoQ added a comment. If everybody's happy let's commit :) Comment at: clang/test/Analysis/smart-ptr.cpp:467 + +void uniquePtrComparision(std::unique_ptr unknownPtr) { + auto ptr = std::unique_ptr(new int(13)); Comment at: clang/test/Analysi

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. I'll have to rebase/rebuild my build env, I'll try and have something rebasing this cleaner soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92004/new/ https://reviews.llvm.org/D92004 __

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge updated this revision to Diff 356428. nridge marked an inline comment as done. nridge added a comment. Addressed review comments, except for the one about using ContainerDC, for the reason explained Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:489 DeclRefs[ND].push_back( -SymbolRef{SM.getFileLoc(Loc), Roles, ASTNode.Parent}); +SymbolRef{SM.getFileLoc(Loc), Roles, getRefContainer(ASTNode.Parent)}); // Don

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

xgupta added subscribers: MyDeveloperDay, xgupta. xgupta added a reviewer: MyDeveloperDay. xgupta added a comment. Thanks for the patch @Et7f3! I tested it locally and can reproduce it with cat folder/file.c int main() { return 0; } And indeed the patch also solved the crash issue and emit a corr

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen updated this revision to Diff 356425. khchen added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71387/new/ https://reviews.llvm.org/D71387 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/Driver

[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/module-target-abi-tests.ll:5 +; RUN: cat %s > %t.emptyabi +; RUN: echo '!0 = !{i32 1, !"target-abi", !""}' >> %t.emptyabi +; RUN: llc -mtriple=riscv32 < %t.emptyabi -o /dev/null khchen wrote: > khc

[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

khchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102582/new/ https://reviews.llvm.org/D102582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Ping? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D104617: [clangd] Type hints for structured bindings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa15adbcddd07: [clangd] Type hints for structured bindings (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D104617?vs=35641

[clang-tools-extra] a15adbc - [clangd] Type hints for structured bindings

Author: Nathan Ridge Date: 2021-07-04T21:53:36-04:00 New Revision: a15adbcddd078e2ca6b860ec9e4b8c2e5afdb76f URL: https://github.com/llvm/llvm-project/commit/a15adbcddd078e2ca6b860ec9e4b8c2e5afdb76f DIFF: https://github.com/llvm/llvm-project/commit/a15adbcddd078e2ca6b860ec9e4b8c2e5afdb76f.diff

[PATCH] D104617: [clangd] Type hints for structured bindings

nridge updated this revision to Diff 356418. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104617/new/ https://reviews.llvm.org/D104617 Files: clang-tools-e

[PATCH] D105336: [X86] Refine code of generating BB labels in Keylocker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa39bb960fc1e: [X86] Refine code of generating BB labels in Keylocker (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subs

[clang] a39bb96 - [X86] Refine code of generating BB labels in Keylocker

Author: Xiang1 Zhang Date: 2021-07-05T09:29:51+08:00 New Revision: a39bb960fc1e097ac573f3a13e831de3f8826ca2 URL: https://github.com/llvm/llvm-project/commit/a39bb960fc1e097ac573f3a13e831de3f8826ca2 DIFF: https://github.com/llvm/llvm-project/commit/a39bb960fc1e097ac573f3a13e831de3f8826ca2.diff

[PATCH] D88398: [X86] Support Intel Key Locker

xiangzhangllvm added a comment. I'll use the old patch to recover it, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88398/new/ https://reviews.llvm.org/D88398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D88398: [X86] Support Intel Key Locker

xiangzhangllvm added a comment. Oh, sorry, It is a mistake, I planned to update to https://reviews.llvm.org/D105336 How can I revert this update ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88398/new/ https://reviews.llvm.org/D88398 ___ c

[PATCH] D88398: [X86] Support Intel Key Locker

craig.topper added a comment. In D88398#2857370 , @xiangzhangllvm wrote: > Refine Clang format Did you mean to upload to this old review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88398/new/ https://reviews.llvm.org/D88398 ___

[PATCH] D88398: [X86] Support Intel Key Locker

xiangzhangllvm updated this revision to Diff 356413. xiangzhangllvm added a comment. Refine Clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88398/new/ https://reviews.llvm.org/D88398 Files: clang/lib/CodeGen/CGBuiltin.cpp Index: clang/lib/CodeGen/CGBuiltin.cpp ===

[PATCH] D105414: Add x86 and x86_64 to the BareMetal toolchain

agvallejo added a comment. I'm still testing this patch, but so far it seems to do the trick. I'm able to compile with clang, link with lld and the resulting ELF file appears to be correctly free from host dependencies. The command lines (seen with clang -v) don't throw the host include paths,

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356409. mizvekov marked an inline comment as done. mizvekov added a comment. format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/Sem

[PATCH] D105414: Add x86 and x86_64 to the BareMetal toolchain

agvallejo created this revision. Herald added subscribers: pengfei, s.egerton, abidh, simoncook. agvallejo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. x86_64-unknown-elf should provide an freestanding environment usable in kernel develo

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13317 + std::any_of(range.begin(), range.end(), [](const AlignedAttr *I) { + return I->isAlignmentDependent(); + }); Quuxp

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356403. mizvekov added a comment. - Rename predicate variable from `I` to `AA`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/Sema/Sem

[libunwind] 7cdd768 - [libunwind] reflow some debug logs for better greppability

Author: Nico Weber Date: 2021-07-04T17:52:23-04:00 New Revision: 7cdd768ac93c6daae709d7a9b9f309716392211e URL: https://github.com/llvm/llvm-project/commit/7cdd768ac93c6daae709d7a9b9f309716392211e DIFF: https://github.com/llvm/llvm-project/commit/7cdd768ac93c6daae709d7a9b9f309716392211e.diff LO

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13317 + std::any_of(range.begin(), range.end(), [](const AlignedAttr *I) { + return I->isAlignmentDependent(); + }); Tangent: It would be nice to rename `isAlignm

[PATCH] D105380: DRAFT: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356401. mizvekov added a comment. - Add tests. - Refactor common users of this new utility. - Use std::any_of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files:

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

Et7f3 updated this revision to Diff 356391. Et7f3 edited the summary of this revision. Et7f3 added a comment. Add a reproduction case in commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105408/new/ https://reviews.llvm.org/D105408 Fil

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

Et7f3 created this revision. Herald added a subscriber: mgorny. Et7f3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Co-authored-by: "tartine8" Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105408 Files: clang/tool

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:38 + +static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) { + return __a[0]; RKSimon wrote: > pengfei wrote: > > RKSimon wrote: > > > I realize its a lot of

[PATCH] D105395: [IRBuilder] Add type argument to CreateMaskedLoad/Gather

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfabc17192ec1: [IRBuilder] Add type argument to CreateMaskedLoad/Gather (authored by nikic). Changed prior to commit: https://reviews.llvm.org/D105

[clang] fabc171 - [IRBuilder] Add type argument to CreateMaskedLoad/Gather

Author: Nikita Popov Date: 2021-07-04T12:17:59+02:00 New Revision: fabc17192ec1c43cb5f6e34eda3e1a55cd9c78f3 URL: https://github.com/llvm/llvm-project/commit/fabc17192ec1c43cb5f6e34eda3e1a55cd9c78f3 DIFF: https://github.com/llvm/llvm-project/commit/fabc17192ec1c43cb5f6e34eda3e1a55cd9c78f3.diff

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356371. RedDocMD added a comment. Little refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Che

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:316 + +class OperatorKind { + union { NoQ wrote: > One good place to put this may be `CheckerHelpers.h`. This is where w