[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb77364d0be: [OpenMP] Fix accidental reuse of VLA size (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107666/new/

[clang] bfb7736 - [OpenMP] Fix accidental reuse of VLA size

Author: Roger Ferrer Ibanez Date: 2021-08-07T05:55:27Z New Revision: bfb77364d0be8a5b159cdcf4eaf8e7a720802e89 URL: https://github.com/llvm/llvm-project/commit/bfb77364d0be8a5b159cdcf4eaf8e7a720802e89 DIFF:

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

rogfer01 added a comment. Thanks for the prompt review @ABataev! I'll push this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107666/new/ https://reviews.llvm.org/D107666 ___ cfe-commits

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson created this revision. mhjacobson added reviewers: MaskRay, benshi001. Herald added subscribers: Jim, dylanmckay. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test that ensures that an avr-libc in

[PATCH] D107682: [AVR][clang] Search avr-libc installtion path according to avr-gcc's

benshi001 added a comment. There are already test cases $llvm/clang/test/Driver/avr-ld.c $llvm/clang/test/Driveravr-toolchain.c and fake avr-gcc inside `$llvm/clang/test/Driver/Inputs/basic_avr_tree` to support the above two tests. So there is no need to add new ones. Repository: rG

[PATCH] D107682: [AVR][clang] Search avr-libc installtion path according to avr-gcc's

benshi001 created this revision. benshi001 added reviewers: MaskRay, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932423 , @MaskRay wrote: > @benshi001 This was prematurely committed. It has no test and has apparent > unaddressed issue. (I revamped many parts in the Linux/Gnu search paths so > am quite confident about my

[PATCH] D104854: Introduce intrinsic llvm.isnan

nemanjai added a comment. Rather than reverting this commit again, I pushed 62fe3dcf98d1 to use the same expansion as before (using unordered comparison) for `ppc_fp128`. I am not sure if there are other types that suffer

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932413 , @mhjacobson wrote: > At first glance, I think you're right: avr-gcc does expect avr-libc to be > relative to itself. That seems slightly weird to me (since avr-libc is > technically separate from GCC),

[PATCH] D107559: [clang] Fix libclang linking on Solaris

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `#` LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/ https://reviews.llvm.org/D107559

[PATCH] D106701: [clang] Implement -falign-loops=N (N is a power of 2) for non-LTO

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4749 + << A->getAsString(Args) << A->getValue(); +else if (Value & Value - 1) + TC.getDriver().Diag(diag::err_drv_alignment_not_power_of_two) craig.topper wrote: >

[PATCH] D106701: [clang] Implement -falign-loops=N (N is a power of 2) for non-LTO

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4749 + << A->getAsString(Args) << A->getValue(); +else if (Value & Value - 1) + TC.getDriver().Diag(diag::err_drv_alignment_not_power_of_two) gcc 5.4 is

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

MaskRay added a comment. @benshi001 This was prematurely committed. It has no test and has apparent unaddressed issue. (I revamped many parts in the Linux/Gnu search paths so quite confident about my observation.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106737: [clang] [hexagon] Add resource include dir

MaskRay added a comment. Thanks for the test. linux-cross.cpp has some `-SAME: {{^}} ` and `"[[RESOURCE]]/include"` patterns which you may use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106737/new/ https://reviews.llvm.org/D106737

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932406 , @MaskRay wrote: > I know nearly nothing about AVR, but from `avr-gcc a.c '-###'` I doubt this > is the GCC behavior. GCC's library path is relative to the GCC installation. >

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e71067f3fa: [AVR][clang] Add $SYSROOT/avr to possible avr-libc locations (authored by mhjacobson, committed by benshi001). Repository: rG LLVM

[clang] 71e7106 - [AVR][clang] Add '$SYSROOT/avr' to possible avr-libc locations

Author: Matt Jacobson Date: 2021-08-07T10:24:14+08:00 New Revision: 71e71067f3fa621d961e2607f1c8cea7cdce3f9d URL: https://github.com/llvm/llvm-project/commit/71e71067f3fa621d961e2607f1c8cea7cdce3f9d DIFF: https://github.com/llvm/llvm-project/commit/71e71067f3fa621d961e2607f1c8cea7cdce3f9d.diff

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

MaskRay added a comment. I know nearly nothing about AVR, but from `avr-gcc a.c '-###'` I doubt this is the GCC behavior. GCC's library path is relative to the GCC installation. `/usr/lib/gcc/avr/5.4.0/../../../avr/lib` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied updated this revision to Diff 364919. airlied added a comment. fixed issues with check-clang, might need some follow up changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 Files:

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:4478 + let Predicates = [HasFP16] in { +def VMOVSHZrr_REV: AVX512<0x11, MRMDestReg, (outs VR128X:$dst), +(ins VR128X:$src1, VR128X:$src2), pengfei wrote: >

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:4478 + let Predicates = [HasFP16] in { +def VMOVSHZrr_REV: AVX512<0x11, MRMDestReg, (outs VR128X:$dst), +(ins VR128X:$src1, VR128X:$src2), craig.topper wrote: > pengfei

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1854db74c549: opencl-c.h: add 3.0 optional extension support for a few more bits (authored by airlied). Repository: rG LLVM Github Monorepo

[clang] 1854db7 - opencl-c.h: add 3.0 optional extension support for a few more bits

Author: Dave Airlie Date: 2021-08-07T09:25:00+10:00 New Revision: 1854db74c549d952c0282096be1bb93d5d64f81b URL: https://github.com/llvm/llvm-project/commit/1854db74c549d952c0282096be1bb93d5d64f81b DIFF: https://github.com/llvm/llvm-project/commit/1854db74c549d952c0282096be1bb93d5d64f81b.diff

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

joerg added a comment. I'm puzzled by this change. I don't think we have any case so far where the compiler behavior changes with the host OS and I don't think it should. What's the point / use case of this macro? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104854: Introduce intrinsic llvm.isnan

nemanjai added a comment. In D104854#2932186 , @nemanjai wrote: > This appears to have caused some failures on PPC buildbots. For example: > https://lab.llvm.org/buildbot/#/builders/105/builds/13446 > We are investigating this. Can you please pull this

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932190 , @mhjacobson wrote: > I'm also tempted to remove `/usr/lib/avr`, because these paths make no sense > to me: `$SYSROOT/usr/lib/avr/lib` and `$SYSROOT/usr/lib/avr/include`. Ah. According to

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. I'm also tempted to remove `/usr/lib/avr`, because these paths make no sense to me: `$SYSROOT/usr/lib/avr/lib` and `$SYSROOT/usr/lib/avr/include`. But I haven't done that here, in case there's some reason those paths do make sense. (Also, the files in

[PATCH] D104854: Introduce intrinsic llvm.isnan

nemanjai added a comment. This appears to have caused some failures on PPC buildbots. For example: https://lab.llvm.org/buildbot/#/builders/105/builds/13446 We are investigating this. Can you please pull this to bring the bots back to green until we track down the reason for the problem and can

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson created this revision. mhjacobson added reviewers: benshi001, MaskRay, dylanmckay. Herald added a subscriber: Jim. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The paths in PossibleAVRLibcLocations are appended

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11172 +def err_attribute_removed_on_redeclaration : Error< + "'%0' attribute removed from redeclared variable">; aaron.ballman wrote: > This diagnostic is a

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 364892. nickdesaulniers marked 8 inline comments as done. nickdesaulniers added a comment. - rebase on D107613 , reuse diag::err_attribute_missing_on_first_decl - test matching redeclarations - remove getSpelling

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6b50c2596: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/

[clang] 41a6b50 - [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

Author: Joseph Huber Date: 2021-08-06T17:53:04-04:00 New Revision: 41a6b50c25961addc04438b567ee1f4ef9e40f98 URL: https://github.com/llvm/llvm-project/commit/41a6b50c25961addc04438b567ee1f4ef9e40f98 DIFF: https://github.com/llvm/llvm-project/commit/41a6b50c25961addc04438b567ee1f4ef9e40f98.diff

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo, JonChesterfield. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Temporary files created by the

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ https://reviews.llvm.org/D107649

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd238b6028582: [Clang][DiagnosticSemaKinds] combine diagnostic texts (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107613/new/

[clang] d238b60 - [Clang][DiagnosticSemaKinds] combine diagnostic texts

Author: Nick Desaulniers Date: 2021-08-06T13:58:21-07:00 New Revision: d238b60285820691b08bcca3ec510d13ea46a5ed URL: https://github.com/llvm/llvm-project/commit/d238b60285820691b08bcca3ec510d13ea46a5ed DIFF:

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre created this revision. thopre added reviewers: xur, tejohnson, lebedev.ri. Herald added subscribers: ormris, pengfei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test

[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb81e7083d25: [clangd] Add basic support for attributes (selection, hover) (authored by sammccall). Herald added a project: clang-tools-extra.

[clang-tools-extra] bb81e70 - [clangd] Add basic support for attributes (selection, hover)

Author: Sam McCall Date: 2021-08-06T22:49:14+02:00 New Revision: bb81e7083d25bfc9bcf2bd69f5431d0c53b86a32 URL: https://github.com/llvm/llvm-project/commit/bb81e7083d25bfc9bcf2bd69f5431d0c53b86a32 DIFF: https://github.com/llvm/llvm-project/commit/bb81e7083d25bfc9bcf2bd69f5431d0c53b86a32.diff

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107666/new/ https://reviews.llvm.org/D107666

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

rogfer01 created this revision. rogfer01 added a reviewer: ABataev. Herald added subscribers: guansong, yaxunl. rogfer01 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. We were using an

[clang] c8f1482 - Reapply "Support Attr in DynTypedNode and ASTMatchers."

Author: Sam McCall Date: 2021-08-06T22:30:32+02:00 New Revision: c8f148274f42aa2ae8c18e1420fa28fefec05a53 URL: https://github.com/llvm/llvm-project/commit/c8f148274f42aa2ae8c18e1420fa28fefec05a53 DIFF: https://github.com/llvm/llvm-project/commit/c8f148274f42aa2ae8c18e1420fa28fefec05a53.diff

[clang] 3241680 - Revert "Support Attr in DynTypedNode and ASTMatchers."

Author: Sam McCall Date: 2021-08-06T22:27:54+02:00 New Revision: 3241680f111ddf3eac37db88cacac199083543f0 URL: https://github.com/llvm/llvm-project/commit/3241680f111ddf3eac37db88cacac199083543f0 DIFF: https://github.com/llvm/llvm-project/commit/3241680f111ddf3eac37db88cacac199083543f0.diff

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4bdcdadc6ff: Support Attr in DynTypedNode and ASTMatchers. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] a4bdcda - Support Attr in DynTypedNode and ASTMatchers.

Author: Sam McCall Date: 2021-08-06T22:06:04+02:00 New Revision: a4bdcdadc6ffab250b218bbdae9a0ced05bebfc9 URL: https://github.com/llvm/llvm-project/commit/a4bdcdadc6ffab250b218bbdae9a0ced05bebfc9 DIFF: https://github.com/llvm/llvm-project/commit/a4bdcdadc6ffab250b218bbdae9a0ced05bebfc9.diff

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall marked 2 inline comments as done. sammccall added a comment. Herald added a project: clang-tools-extra. Finally getting around to landing this, sorry for the long delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89743/new/

[clang] f8a4495 - [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

Author: Thomas Johnson Date: 2021-08-06T12:18:06-07:00 New Revision: f8a449514931bf2b3a0b36328e821365ed8bf5c6 URL: https://github.com/llvm/llvm-project/commit/f8a449514931bf2b3a0b36328e821365ed8bf5c6 DIFF:

Re: [clang] 4389a41 - Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on"

Reminder to actually explain in the commit message why the particular change is being reverted. On Fri, Aug 6, 2021 at 10:02 PM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2021-08-06T12:01:47-07:00 > New Revision: 4389a413e2129d7d55ee779638b649aa852b6f8a

[clang] 4389a41 - Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on"

Author: Zahira Ammarguellat Date: 2021-08-06T12:01:47-07:00 New Revision: 4389a413e2129d7d55ee779638b649aa852b6f8a URL: https://github.com/llvm/llvm-project/commit/4389a413e2129d7d55ee779638b649aa852b6f8a DIFF:

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/SemaDecl.cpp:3686 +Diag(Old->getLocation(), diag::note_previous_declaration); + } nickdesaulniers wrote: > should `CXX11NoReturnAttr` be

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3686 +Diag(Old->getLocation(), diag::note_previous_declaration); + } should `CXX11NoReturnAttr` be `dropAttr` on `New` like the other cases, too? Repository: rG

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers updated this revision to Diff 364858. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. - more use of note_previous_declaration, fix WeakImportAttr, too Repository: rG LLVM Github Monorepo

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120 + OptimizationRemarkEmitter *ORE, + OptimizationRemark OptRemark) { + ORE->emit([&]() { return OptRemark; }); rampitec wrote: >

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364854. gandhi21299 added a comment. created a patch against llvm trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

marksl accepted this revision. marksl added a comment. This revision is now accepted and ready to land. Looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107611/new/ https://reviews.llvm.org/D107611

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns updated this revision to Diff 364855. thomasjohns added a comment. Thanks for the feedback, Mark. This change prefers `MI` over `SI` naming, updates instruction writing, and makes the test case more precise (the generated code was improved and no longer had an unneeded `mov %r1,

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang updated this revision to Diff 364856. NeHuang added a comment. - Rebased with ToT - Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 Files:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120 + OptimizationRemarkEmitter *ORE, + OptimizationRemark OptRemark) { + ORE->emit([&]() { return OptRemark; }); gandhi21299 wrote: >

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364853. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - improved code style in AtomicExpand and SIISelLowering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 marked 2 inline comments as done. gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120 + OptimizationRemarkEmitter *ORE, + OptimizationRemark OptRemark) { + ORE->emit([&]() { return

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3685 +<< NRA; +notePreviousDefinition(Old, New->getLocation()); + } aaron.ballman wrote: > nickdesaulniers

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan planned changes to this revision. stevewan added a comment. The query portion has been split out as https://reviews.llvm.org/D107598, which needs to be cleaned out from this patch. The record layout part also needs update as we uncover more problems with the current implementation.

[clang] 6a9cf21 - [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

Author: Artem Belevich Date: 2021-08-06T11:13:52-07:00 New Revision: 6a9cf21f5a2dcd02f90075d6d3576a87f1abd8a9 URL: https://github.com/llvm/llvm-project/commit/6a9cf21f5a2dcd02f90075d6d3576a87f1abd8a9 DIFF:

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a9cf21f5a2d: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA. (authored by tra). Repository: rG LLVM Github Monorepo

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3685 +<< NRA; +notePreviousDefinition(Old, New->getLocation()); + } nickdesaulniers wrote: > ah, this isn't quite right. It replaces warning of the first

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra updated this revision to Diff 364847. tra added a comment. rebase to HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106401/new/ https://reviews.llvm.org/D106401 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D101641: [Sema] Preserve invalid CXXCtorInitializers using RecoveryExpr in initializer

sammccall added a comment. Doh, I forgot this never landed :-( Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4475 // name that denotes that base class type. - bool Dependent = BaseType->isDependentType() || Init->isTypeDependent(); + bool Dependent =

[PATCH] D101641: [Sema] Preserve invalid CXXCtorInitializers using RecoveryExpr in initializer

sammccall updated this revision to Diff 364846. sammccall added a comment. Rebase and add clarifying comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101641/new/ https://reviews.llvm.org/D101641 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

jhuber6 updated this revision to Diff 364844. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ https://reviews.llvm.org/D107649 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3685 +<< NRA; +notePreviousDefinition(Old, New->getLocation()); + } ah, this isn't quite right. It replaces warning of the first declaration with warning of

[clang] dddd524 - Revert "[PowerPC][AIX] Limit attribute aligned to 4096."

Author: Sean Fertile Date: 2021-08-06T13:54:50-04:00 New Revision: 524bb8844b225d42c98d381d745d4fd549ea URL: https://github.com/llvm/llvm-project/commit/524bb8844b225d42c98d381d745d4fd549ea DIFF: https://github.com/llvm/llvm-project/commit/524bb8844b225d42c98d381d745d4fd549ea.diff

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec requested changes to this revision. rampitec added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:588 + Remark + << "A hardware CAS loop generated: if the memory is " + "known

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364825. gandhi21299 added a comment. - changed 'CAS instruction' to 'CAS loop' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

mikerice added a comment. Works for the test we have. What about a lit test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107649/new/ https://reviews.llvm.org/D107649 ___ cfe-commits mailing

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked an inline comment as done. dgoldman added a comment. PTAL, also updated the test to no longer check the children's order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 364840. dgoldman marked an inline comment as done. dgoldman added a comment. Simplify children moving Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files:

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers updated this revision to Diff 364838. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - prefer getAttr to hasAttr+getAttr, remove another diag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107624: [clangd] Rename Features.h -> Feature.h to avoid confilct with libstdc++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad9ec8a328c: [clangd] Rename Features.h - Feature.h to avoid confilct with libstdc++ (authored by sammccall). Repository: rG LLVM Github

[clang-tools-extra] 4ad9ec8 - [clangd] Rename Features.h -> Feature.h to avoid confilct with libstdc++

Author: Sam McCall Date: 2021-08-06T18:56:41+02:00 New Revision: 4ad9ec8a328ccb3b836c993bba954366f05b2fd4 URL: https://github.com/llvm/llvm-project/commit/4ad9ec8a328ccb3b836c993bba954366f05b2fd4 DIFF: https://github.com/llvm/llvm-project/commit/4ad9ec8a328ccb3b836c993bba954366f05b2fd4.diff

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

sammccall updated this revision to Diff 364832. sammccall added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107632/new/ https://reviews.llvm.org/D107632 Files: clang-tools-extra/clangd/Compiler.cpp

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

sammccall updated this revision to Diff 364829. sammccall added a comment. Herald added a subscriber: mgorny. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107632/new/ https://reviews.llvm.org/D107632 Files:

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Frontend/CreateInvocationFromCommandLine.cpp:92 - const driver::Command = cast(*Jobs.begin()); - if (StringRef(Cmd.getCreator().getName()) != "clang") {

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:248 def warn_option_invalid_ocl_version : Warning< - "OpenCL version %0 does not support the option '%1'">, InGroup; + "%select{OpenCL C|C++ for OpenCL}0 version %1 does not

[PATCH] D107528: [llvm][clang][NFC] updates inline licence info

lattner accepted this revision. lattner added a comment. Thank you for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107528/new/ https://reviews.llvm.org/D107528 ___ cfe-commits mailing

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:4478 + let Predicates = [HasFP16] in { +def VMOVSHZrr_REV: AVX512<0x11, MRMDestReg, (outs VR128X:$dst), +(ins VR128X:$src1, VR128X:$src2), pengfei wrote: >

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-swdiv.c:17 +// CHECK-LABEL: @test_swdiv( +// CHECK:[[TMP0:%.*]] = load double, double* @a, align 8 +// CHECK-NEXT:[[TMP1:%.*]] = load double, double* @b, align 8 nit:

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei marked 7 inline comments as done. pengfei added a comment. Thanks Yuanke. Comment at: clang/lib/Headers/avx512fp16intrin.h:292 + + return (__m128h)__builtin_ia32_loadsh128_mask((__v8hf *)__A, src, __U & 1); +} LuoYuanke wrote: > Just be curious, why

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

NeHuang added inline comments. Comment at: clang/test/Driver/ppc-mprivileged-support-check.c:25 +// HASPRIV: test() #0 { +// HASPRIV: attributes #0 { +// HASPRIV-SAME: +privileged maybe check for `attributes #0 = {` Repository: rG LLVM Github Monorepo

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

sfertile marked an inline comment as done. sfertile added inline comments. Comment at: clang/test/Sema/aix-pragma-align-packed-warn.c:13 + short a : 8; // expected-warning {{#pragma align(packed) may not be compatible with objects generated with AIX XL C/C++}} + short b : 8;

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

sfertile updated this revision to Diff 364814. sfertile added a comment. Fixed diagnostic to only emit when there is a bitfield member. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107506/new/ https://reviews.llvm.org/D107506 Files:

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

Anastasia added inline comments. Comment at: clang/include/clang/Sema/Initialization.h:341 +QualType Type = TypeInfo->getType(); +if (Context.getLangOpts().OpenCL && !Type.hasAddressSpace()) + Type = Context.getAddrSpaceQualType(Type, LangAS::opencl_private);

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

marksl added inline comments. Comment at: llvm/lib/Target/ARC/ARCExpandPseudos.cpp:86 + // %R2 = RSUB_cc_rru6 %R2, 31, pred:2, %STATUS + MachineInstr = *SII; + const MachineOperand = SI.getOperand(0); I know you're following ExpandStore above in using

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

sammccall added a comment. Thanks, this scope looks good for a first patch! Comment at: clang-tools-extra/clangd/IWYU.cpp:18 + +/// Main "driver" of the IWYU symbol usage discovery mechanism. Crawler +/// traverses the AST and feeds in the locations of (sometimes implicitly)

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); balazske wrote: > steakhal wrote: > > balazske wrote: > > > steakhal

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); steakhal wrote: > balazske

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

Anastasia added a subscriber: svenvh. Anastasia added a comment. LGTM! Thanks. CC to @azabaznov for any final feedback. FYI this has not been officially announced but in `clang-14` we would like to transition away from using the huge hard to maintain `opencl-c.h` in favour of a more concise

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns updated this revision to Diff 364806. thomasjohns added a comment. llvm clang-tidy rule: prefer `Register` over `unsinged int`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107611/new/ https://reviews.llvm.org/D107611 Files: clang/lib/Basic/Targets/ARC.h

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

vsavchenko added a comment. In D107636#2931302 , @steakhal wrote: > Seems reasonable to me. Let's wait for someone else as well. Sure, NP. > This is a really elegant patch, I should tell! Thanks! I guess my take on this, that this path to the solver

  1   2   >