[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:696 // Add transition for the failed state. Optional RetVal = makeRetVal(C, CE).castAs(); assert(RetVal && "Value should be NonLoc."

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6846-6847 +return; + if (hasBTFTagAttr(D, Str)) +return; + aaron.ballman wrote: > This should diagnose that the attribute is being ignored due to the mismatch > in tags (an

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei updated this revision to Diff 365360. pengfei added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.llvm.org/D105331 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Sema/DeclSpec.cpp cl

[PATCH] D95589: [RISCV] Support experimental 'P' extension 0.9

Jim updated this revision to Diff 365359. Jim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95589/new/ https://reviews.llvm.org/D95589 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/test/Driver/riscv-arch.c In

[PATCH] D95590: [RISCV] Define preprocessor definitions for 'P' extension

Jim updated this revision to Diff 365358. Jim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95590/new/ https://reviews.llvm.org/D95590 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h clang/tes

[PATCH] D106737: [clang] [hexagon] Add resource include dir

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/hexagon-toolchain-linux.c:106 +// CHECK008: InstalledDir: [[INSTALLED_DIR:.+]] +// CHECK008: "-resource-dir" "[[RESOURCE:[^"]+]]" +//

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107791/new/ https://reviews.llvm.org/D107791 ___ cfe-

[PATCH] D106737: [clang] [hexagon] Add resource include dir

bcain updated this revision to Diff 365352. bcain added a comment. Test case updates per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106737/new/ https://reviews.llvm.org/D106737 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clan

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

MaskRay added a comment. Seems a new RUN line is needed. If having too many mock trees are inconvenient, consider `clang/unittests/Driver/ToolChainTest.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. @MaskRay I have update my patch based on your new test avr-toolchain.c. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 365347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/av

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2936033 , @MaskRay wrote: > `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. > > sysroot is usually a directory which contains `usr/lib` and `lib/`. > `somewhere/usr/lib` is not usually used as a sysroo

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

MaskRay added a comment. `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. sysroot is usually a directory which contains `usr/lib` and `lib/`. `somewhere/usr/lib` is not usually used as a sysroot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson updated this revision to Diff 365343. mhjacobson added a comment. Rebase atop recent changes; use separate check lines and string substitution for `SYSROOT`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm

[PATCH] D107797: [Driver][test] Improve avr-toolchain.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb978df4af4c8: [Driver][test] Improve avr-toolchain.c (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] b978df4 - [Driver][test] Improve avr-toolchain.c

Author: Fangrui Song Date: 2021-08-09T20:25:33-07:00 New Revision: b978df4af4c8a668550fa035b70795312bf41f44 URL: https://github.com/llvm/llvm-project/commit/b978df4af4c8a668550fa035b70795312bf41f44 DIFF: https://github.com/llvm/llvm-project/commit/b978df4af4c8a668550fa035b70795312bf41f44.diff

[PATCH] D107797: [Driver][test] Improve avr-toolchain.c

benshi001 accepted this revision. benshi001 added a comment. Good! Then I can rebase my patch on your test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107797/new/ https://reviews.llvm.org/D107797 ___

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105263/new/ https://reviews.llvm.org/D105263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D107797: [Driver][test] Improve avr-toolchain.c

MaskRay created this revision. MaskRay added reviewers: benshi001, mhjacobson. Herald added subscribers: Jim, dylanmckay. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

MaskRay updated this revision to Diff 365332. MaskRay added a comment. Update inline-replay code and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107791/new/ https://reviews.llvm.org/D107791 Files: clang/test/CodeGen/thinlto-diagnostic-ha

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

hoy added inline comments. Comment at: llvm/test/Transforms/SampleProfile/inline-replay.ll:7 ;; Check replay inline decisions ; RUN: opt < %s -passes=sample-profile -sample-profile-file=%S/Inputs/inline-topdown.prof -sample-profile-inline-replay=%S/Inputs/inline-replay.txt -

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 365324. beanz added a comment. Updating documentation to be more clear about the behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files: clang/docs/LanguageE

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 365322. beanz added a comment. Addressing feedback by @aaron.ballman. If the pattern I used for the note diagnostic is good here, I'll apply it to the deprecated extension too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two" // NOT-AIX: error: unsupported option '-b' fo

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } aaron.ballman wro

[PATCH] D107786: [AIX]: Fix option processing for -b

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41e3ac398c3a: [AIX]: Fix option processing for -b (authored by etiotto). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 41e3ac3 - [AIX]: Fix option processing for -b

Author: Ettore Tiotto Date: 2021-08-09T19:52:31-04:00 New Revision: 41e3ac398c3ae9dfba5a57d80c420c122c1ec700 URL: https://github.com/llvm/llvm-project/commit/41e3ac398c3ae9dfba5a57d80c420c122c1ec700 DIFF: https://github.com/llvm/llvm-project/commit/41e3ac398c3ae9dfba5a57d80c420c122c1ec700.diff

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

MaskRay added a comment. (I haven't converted directories in tools/gold Transforms/ LTO/, but they should be pretty mechanical.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107791/new/ https://reviews.llvm.org/D107791 __

[PATCH] D107791: [InlineAdvisor] Add single quotes around caller/callee names

MaskRay created this revision. MaskRay added reviewers: anemet, hoy, tejohnson. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang diagnostics refe

[PATCH] D107786: [AIX]: Fix option processing for -b

etiotto added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two" // NOT-AIX: error: unsupported option '-b'

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji accepted this revision as: jsji. jsji added a comment. LGTM, Thanks. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two

[PATCH] D107786: [AIX]: Fix option processing for -b

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 __

[PATCH] D107786: [AIX]: Fix option processing for -b

etiotto updated this revision to Diff 365312. etiotto added a comment. Address code review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp cl

[PATCH] D107786: [AIX]: Fix option processing for -b

etiotto updated this revision to Diff 365311. etiotto added a comment. Adapting test for -b option processing on AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 Files: clang/lib/Driver/ToolChains/Co

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365310. vabridgers added a comment. Add missing test case :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D107786: [AIX]: Fix option processing for -b

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:271 // Handle reserved library options. -if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx)) +else if (A.getOption().matches(options::OPT_Z_reserved_lib_st

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

mhjacobson added a comment. In D107682#2932685 , @benshi001 wrote: > In D107682#2932607 , @mhjacobson > wrote: > >> For other examples of using four `..`s, look in `Gnu.cpp`, where there are >> several places wh

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz marked 5 inline comments as done. beanz added a comment. @aaron.ballman, thanks for the feedback! Some comments, but I'll work on updated patches and try to get them up tonight or tomorrow morning. Comment at: clang/docs/LanguageExtensions.rst:3913 +Clang supports the p

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:17 +// RUN: %clang %s -### -no-canonical-prefixes -target avr --sysroot %S/Inputs/basic_avr_tree/usr/lib 2>&1 | FileCheck -check-prefix CC1D %s +// CC1D: clang{{.*}} "-cc1" "-triple" "avr" {{.*}} "-i

[clang] a350089 - [HIP] Allow target addr space in target builtins

Author: Anshil Gandhi Date: 2021-08-09T16:38:04-06:00 New Revision: a35008955fa606487f79a050f5cc80fc7ee84dda URL: https://github.com/llvm/llvm-project/commit/a35008955fa606487f79a050f5cc80fc7ee84dda DIFF: https://github.com/llvm/llvm-project/commit/a35008955fa606487f79a050f5cc80fc7ee84dda.diff

[PATCH] D107786: [AIX]: Fix option processing for -b

jsji added a comment. Tests please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D107786: [AIX]: Fix option processing for -b

etiotto created this revision. etiotto added reviewers: ZarkoCA, hubert.reinterpretcast, Whitney, cebowleratibm. etiotto added a project: LLVM. etiotto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Code added by D106688

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

Conanap updated this revision to Diff 365289. Conanap marked 3 inline comments as done. Conanap added a comment. Merged the test case into the existing cmplx test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107138/new/ https://reviews.llvm.org/D1

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

vsapsai added a comment. Thanks for the review! I'll wait with committing this change until https://reviews.llvm.org/D104344 is ready to avoid bumping `VERSION_MAJOR` twice. While this change doesn't introduce any syntactical differences to serialized AST, it does introduce semantic differences

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/retaddr_multi_levels.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc64le-unknown-linux -mcpu=pwr8 | FileCheck %s -check-p

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba06ac8b45ca: [clangd] Support `#pragma mark` in the outline (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] ba06ac8 - [clangd] Support `#pragma mark` in the outline

Author: David Goldman Date: 2021-08-09T16:23:53-04:00 New Revision: ba06ac8b45ca2ad047131fb9cc9af922cb913ea1 URL: https://github.com/llvm/llvm-project/commit/ba06ac8b45ca2ad047131fb9cc9af922cb913ea1 DIFF: https://github.com/llvm/llvm-project/commit/ba06ac8b45ca2ad047131fb9cc9af922cb913ea1.diff

[PATCH] D106614: [Clang] add btf_tag attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6846-6847 +return; + if (hasBTFTagAttr(D, Str)) +return; + This should diagnose that the attribute is being ignored due to the mismatch in tags (and probably have a note to

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365279. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tools-extra/clan

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

stefanp updated this revision to Diff 365278. stefanp added a comment. Revewiers had a good catch where I forgot to add an equals sign to check in the test case. I've fixed that test now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/ ht

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365275. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. Alright. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365228. gandhi21299 added a comment. - floating point check is not required for cas loop check, getting rid of it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365277. dgoldman added a comment. Remove more AllOfs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tool

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 365276. MyDeveloperDay retitled this revision from "[clang-format] Add East/West Const fixer capability" to "[clang-format] Add Left/Right Const fixer capability". MyDeveloperDay added a comment. Remove East/West terminology for inclusivity CHANGES S

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365273. dgoldman marked 2 inline comments as done. dgoldman added a comment. Remove unnecessary AllOf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane resigned from this revision. erichkeane added a comment. This revision now requires review to proceed. Not sure if this will clear the 'needs revision', but an RFC has been sent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

cebowleratibm added a comment. In D107242#2934611 , @joerg wrote: > clang is fundamentally a cross-compiler only. I don't see any point for > having host-specific branches in this case at all. Either the macro should be > specified for the target all th

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. Whats left from my personal todo is adjusting the documentation. I think then this check can work as linter and if you want as fixer as well, but this has to be enable explicitly. I think that fixing still has more value than harm, e.g. in your IDE/editor. The most an

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 365257. JonasToth marked 4 inline comments as done. JonasToth added a comment. - remove transformation as default option, now it must be activated by the user explicitly - register only for C++ - add a test-case for VLAs Repository: rG LLVM Github Monor

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2935269 , @erichkeane wrote: > In D69764#2935218 , @MyDeveloperDay > wrote: > >> In D69764#2934666 , @erichkeane >> wrote: >>

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane added a comment. In D69764#2935218 , @MyDeveloperDay wrote: > In D69764#2934666 , @erichkeane > wrote: > >>> Someone internally pointed out the anti-inclusivity of the terminology, so >>> I figured I'd

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 365253. JonasToth added a comment. - retry upload of patch to be a diff to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/clang-tidy/

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 365252. JonasToth marked an inline comment as done. JonasToth added a comment. - rebase to master - fix a crash where a scope matched but non of its variables, leading to nullptr dereference (found with the current test-suite) - remove outcommenting of test

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:441 + if (Preamble) +Marks = Preamble->Marks; + Clang->getPreprocessor().addPPCallbacks( --

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2934666 , @erichkeane wrote: >> Someone internally pointed out the anti-inclusivity of the terminology, so I >> figured I'd bring it up. I apologise if I'm proliferating that, but could you educate me why its "a

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 365249. gAlfonso-bit added a comment. Remove other changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h =

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2935036 , @klimek wrote: > Happy to go the RFC route if @MyDeveloperDay wants to do that. I'm happy to do that (in fact I've written a draft), do people want to code review the RFC draft (as I could easily be pre

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit created this revision. gAlfonso-bit added reviewers: clang, LLVM. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ObjCObjectPointer is NOT a type specifier, so remove it from the list Repository: rG LLVM Github

[PATCH] D107633: Set supported target for asan-use-callbacks test

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. All but line 1 is LGTM Line 1 is probably not needed, but I don't know why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ ht

[PATCH] D107633: Set supported target for asan-use-callbacks test

vitalybuka added a comment. Why other tests, like CodeGen/asan-strings.c do not need REQUIRES: ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ https://reviews.llvm.org/D107633 ___ cfe-commits

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib

[PATCH] D107095: Implement #pragma clang header_unsafe

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3913 +Clang supports the pragma ``#pragma clang header_unsafe``, which can be used to +mark macros as unsafe to use in headers. This can be valuable when providing +headers with ABI stability requi

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

klimek added a comment. In D69764#2934686 , @aaron.ballman wrote: > In D69764#2934612 , @MyDeveloperDay > wrote: > >>> I was referring to @rsmith and @aaron.ballman (to clarify), both are >>> maintainers in 'clan

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

arsenm added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:626-632 + if (AI->isFloatingPointOperation()) +emitAtomicExpansionRemarks( +AI, Kind, +Remark << "A hardware CAS loop generated: if the memory is " +

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. In D107696#2934881 , @sammccall wrote: > Thanks, I know what to do next! > > While I have you here, any thoughts on future patches: > >> Only the bare name is completed, with no args. >> For args to be useful we need arg nam

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365224. gAlfonso-bit added a comment. Moved warnReturnTypestateForUnconsumableType back to SemaDeclCXX CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Co

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec36d18ec7b: [cuda] Mark builtin texture/surface reference variable as… (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107718/new/ http

[clang] 6ec36d1 - [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

Author: Michael Liao Date: 2021-08-09T13:27:40-04:00 New Revision: 6ec36d18ec7b29b471bbe50502beb5b35de3975c URL: https://github.com/llvm/llvm-project/commit/6ec36d18ec7b29b471bbe50502beb5b35de3975c DIFF: https://github.com/llvm/llvm-project/commit/6ec36d18ec7b29b471bbe50502beb5b35de3975c.diff

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. CUDA lowers texture/surface types into a special handle. I do not think `externally_initialized` matters for it. AFAICT this change is a no-op for CUDA. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

steven_wu added a comment. Please don't use `x86_64` as target or triple since it might default to some weird platform. Can you spell out a valid triple/platform? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107667/new/ https://reviews.llvm.org/D

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365202. gandhi21299 added a comment. - emit CAS loop remark only if the instruction is of floating point type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 File

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365199. gandhi21299 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu clang/test/

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall planned changes to this revision. sammccall added a comment. Thanks, I know what to do next! While I have you here, any thoughts on future patches: > Only the bare name is completed, with no args. > For args to be useful we need arg names. These *are* in the tablegen but > not currentl

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

manojgupta added a comment. Please also see https://bugs.llvm.org/show_bug.cgi?id=51416 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 ___ cfe-commits mailing li

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:599 * SPIR +* X86 Might be worth mentioning that it requires AVX512FP16 here Comment at: clang/lib/CodeGen/TargetInfo.cpp:2817 Current = SSE; +} els

[PATCH] D104854: Introduce intrinsic llvm.isnan

nemanjai added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6964 +return DAG.getSetCC(DL, ResultVT, Op, DAG.getConstantFP(0.0, DL, OperandVT), +ISD::SETUO); + sepavloff wrote: > nemanjai wrote: > > sep

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

yaxunl added a comment. LGTM on HIP side. I am not sure whether CUDA needs this. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4441 if (Linkage != llvm::GlobalValue::InternalLinkage && - (D->hasAttr() || D->hasAttr())) + (D->hasAttr() || D->hasAttr()

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4441 if (Linkage != llvm::GlobalValue::InternalLinkage && - (D->hasAttr() || D->hasAttr())) + (D->hasAttr() || D->hasAttr() || + D->getType()->isCUDADeviceBuiltinSurfac

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope) { sammccall wrote: > aaron.ballman wrote: > > Sho

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added reviewers: Anastasia, airlied, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Currently, -fdeclare-opencl-builtins always adds the gener

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:42 +if (isInsideMainFile(Loc, SM)) { + Position Start = sourceLocToPosition(SM, Loc); + Position End = {Start.line + 1, 0}; kadircet wrote: > are we fine with the

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365196. dgoldman marked 9 inline comments as done. dgoldman added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It's fine on my part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106644/new/ https://reviews.llvm.org/D106644 __

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

ldionne accepted this revision. ldionne added a comment. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2934612 , @MyDeveloperDay wrote: >> I was referring to @rsmith and @aaron.ballman (to clarify), both are >> maintainers in 'clang', the former of which is the 'superset' maintainer of >> this format project based

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane added a comment. In D69764#2934646 , @MyDeveloperDay wrote: >> I find it weird that we aren't handling ALL of the CV qualifiers. > > I will probably try and address this, I do have some ideas, but this will I > believe complicate the implement

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > I find it weird that we aren't handling ALL of the CV qualifiers. I will probably try and address this, I do have some ideas, but this will I believe complicate the implementation. For now I really want to understand if conceptually such a feature can be land

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers added a comment. I'll add a test and repost. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. Alright, I think we're almost ready to go! I left a few comments, please make sure to mark those done that you feel are properly addressed. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:393-394 + /// in this sense if a resource lea

  1   2   >