[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 367114. v.g.vassilev added a subscriber: sgraenitz. v.g.vassilev added a comment. Disable the case exception test of windows. cc: @sgraenitz CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files:

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song updated this revision to Diff 367109. yonghong-song edited the summary of this revision. yonghong-song added a comment. - do not use replacement-style API to set annotations. use creation-time parameter instead. - add a test case to show forward declaration doesn't generate btf_tag

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham created this revision. bnbarham added reviewers: vsapsai, dexonsmith. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reading the AST block can never fail with a recoverable error as modules cannot be removed during this

[clang] 3f4d00b - [NFC] More get/removeAttribute() cleanup

Author: Arthur Eubanks Date: 2021-08-17T21:05:41-07:00 New Revision: 3f4d00bc3b514d3218089fce15457457fc3312c3 URL: https://github.com/llvm/llvm-project/commit/3f4d00bc3b514d3218089fce15457457fc3312c3 DIFF:

[clang] de0ae9e - [NFC] Cleanup more AttributeList::addAttribute()

Author: Arthur Eubanks Date: 2021-08-17T21:05:41-07:00 New Revision: de0ae9e89ec437d9f58e4b2da04d210c161854a3 URL: https://github.com/llvm/llvm-project/commit/de0ae9e89ec437d9f58e4b2da04d210c161854a3 DIFF:

[clang] ad727ab - [NFC] Migrate some callers away from Function/AttributeLists methods that take an index

Author: Arthur Eubanks Date: 2021-08-17T21:05:40-07:00 New Revision: ad727ab7d9c21abe8b62df617d72e2c98d767561 URL: https://github.com/llvm/llvm-project/commit/ad727ab7d9c21abe8b62df617d72e2c98d767561 DIFF:

[clang] 46cf825 - [NFC] Replace Function handling of attributes with less confusing calls

Author: Arthur Eubanks Date: 2021-08-17T21:05:40-07:00 New Revision: 46cf82532cf1502b6320517a2ef42d8c435e598a URL: https://github.com/llvm/llvm-project/commit/46cf82532cf1502b6320517a2ef42d8c435e598a DIFF:

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

MaskRay added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1752 + else { +UniqueID = NextUniqueID++; +COMDATSymName = MBB.getParent()->getName(); I think `UniqueID = NextUniqueID++;` is not needed.

[PATCH] D105331: [CFE][X86] Enable complex _Float16 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aeca3b0a595: [CFE][X86] Enable complex _Float16 support (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/

[clang] 5aeca3b - [CFE][X86] Enable complex _Float16 support

Author: Wang, Pengfei Date: 2021-08-18T11:16:14+08:00 New Revision: 5aeca3b0a59562cc2c3df0b2991277ea506d1823 URL: https://github.com/llvm/llvm-project/commit/5aeca3b0a59562cc2c3df0b2991277ea506d1823 DIFF: https://github.com/llvm/llvm-project/commit/5aeca3b0a59562cc2c3df0b2991277ea506d1823.diff

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song added a comment. In D106615#2951101 , @dblaikie wrote: > In D106615#2950964 , @yonghong-song > wrote: > >> The attributes should be revolved during semantic analysis stage. So looks >> like

[clang] 59dfde7 - [clang] enable sanitizers for hexagon

Author: Brian Cain Date: 2021-08-17T19:59:24-07:00 New Revision: 59dfde7d9460242e75d4fe9b62d77ea0f1e8d7dc URL: https://github.com/llvm/llvm-project/commit/59dfde7d9460242e75d4fe9b62d77ea0f1e8d7dc DIFF: https://github.com/llvm/llvm-project/commit/59dfde7d9460242e75d4fe9b62d77ea0f1e8d7dc.diff

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. In D108265#2951222 , @dblaikie wrote: > I think it should probably stay as-is, given this is the documented LLVM > project naming convention: >

[PATCH] D107503: [clang][Rewriter] patch to fix bug with ReplaceText erasing too many characters when text has been inserted before the replace location.

jdenny added inline comments. Comment at: clang/lib/Rewrite/Rewriter.cpp:136 if (OrigLength != NewStr.size()) AddReplaceDelta(OrigOffset, NewStr.size() - OrigLength); } I think this needs to be fixed too. That is, the removal of the inserts requires

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

dblaikie added a comment. (eg: new projects should benefit from the LLVM default- less chance of further diversification of naming conventions) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://reviews.llvm.org/D108265

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

dblaikie added a comment. I think it should probably stay as-is, given this is the documented LLVM project naming convention: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly - a bit of extra friction for subprojects to opt-out of that

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay created this revision. MaskRay added reviewers: dblaikie, mehdi_amini. MaskRay requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, aheejin. Herald added projects: LLVM, clang-tools-extra. The variable related top-level readability-identifier-naming

Re: [clang] c411c1b - Fix missing qualifier in template type diffing

Thanks for the simplified test case. I've pushed it at 02e73d4 On Mon, Aug 16, 2021 at 10:31 PM David Blaikie wrote: > Perhaps the test case could be stripped down a bit? > > template > class Array {}; > > template > class S {}; > > template > Array Make(); > > void Call() { > Array> v =

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn:19 "//llvm/lib/Target:TargetsToBuild", +":exports", ] Run `gn format` before

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2379949aadce: [X86] AVX512FP16 instructions enabling 3/6 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

dblaikie added a comment. In D106615#2950964 , @yonghong-song wrote: > The attributes should be revolved during semantic analysis stage. So looks > like replace-style attribute setting is not really needed. I will change to > add attribute parameter

[PATCH] D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon

sidneym added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108178/new/ https://reviews.llvm.org/D108178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song added a comment. The attributes should be revolved during semantic analysis stage. So looks like replace-style attribute setting is not really needed. I will change to add attribute parameter during creation time. Thanks for suggestion. Repository: rG LLVM Github Monorepo

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

dblaikie added a comment. Can these values/this attribute list vary over the course of a source file? (eg: the first use of a type might only have one of the attributes specified at that point, but then more attributes appear later - and then those attributes should be applied too?) Perhaps a

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

This revision was automatically updated to reflect the committed changes. Closed by commit rG32208555af26: [Modules] Do not remove failed modules after the control block phase (authored by bnbarham, committed by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3220855 - [Modules] Do not remove failed modules after the control block phase

Author: Ben Barham Date: 2021-08-17T16:46:51-07:00 New Revision: 32208555af26c48f3df845a10b049c8eb74e2eb3 URL: https://github.com/llvm/llvm-project/commit/32208555af26c48f3df845a10b049c8eb74e2eb3 DIFF: https://github.com/llvm/llvm-project/commit/32208555af26c48f3df845a10b049c8eb74e2eb3.diff

[PATCH] D107850: [asan] [Patch 1/3] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added a comment. Please don't do [PATCH*] tags and just organize Phabricator "stack" Just in case, it should look like this random image from search: https://firefox-source-docs.mozilla.org/_images/example-stack.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but maybe wait for @sidneym feedback, or add as "blocking reviewer". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/

[PATCH] D107850: [asan] [Patch 1/3] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1369 + .addReg(X86::R8) + .addImm(MappingScale), + STI); vitalybuka wrote: > I

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

vzakhari updated this revision to Diff 367057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108246 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp Index:

[PATCH] D107850: [asan] [Patch 1/3] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added a comment. Can you please use "Edit related revisions" and link other patches of the features into the stack? Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:272-274 + [(int_asan_check_memaccess GR64NoR8:$addr, (i64 timm:$shadowbase), +(i32

[PATCH] D107503: [clang][Rewriter] patch to fix bug with ReplaceText erasing too many characters when text has been inserted before the replace location.

jdenny added a comment. Thanks for working on this. I agree there's a bug. However, this patch doesn't fix the bug. It provides a workaround. That is, the current default `ReplaceText` behavior, as revealed in the first test added by this patch, doesn't make sense.

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3478-3479 + if (D->hasAttr()) +RealDecl->replaceAnnotations(CollectBTFTagAnnotations(D)); + dblaikie wrote: > Any reason this has to be done with a replace-style API,

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

dblaikie added a comment. In D106615#2949685 , @yonghong-song wrote: > @dblaikie ping. Could you help take a look at the patch? Yeah, it's on my list. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3478-3479 + if (D->hasAttr()) +

[PATCH] D107850: [asan] [Patch 1/3] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. Compiles and tests are passing now. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___ cfe-commits mailing list

[PATCH] D77670: [CUDA] Add partial support for recent CUDA versions.

tra added a comment. See the patch stack at https://reviews.llvm.org/D108248 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77670/new/ https://reviews.llvm.org/D77670 ___ cfe-commits mailing list

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { vitalybuka wrote: > sidneym wrote: > > bcain wrote: > > >

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

vzakhari added a comment. In D108246#2950650 , @jdoerfert wrote: > I would prefer to revert 93d08acaacec951dbb302f77eeae51974985b6b2 > now and > then fix the CUDA toolchain rather

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367027. bcain added a comment. fixed iserror() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

tra created this revision. tra added reviewers: Hahnfeld, yaxunl. Herald added subscribers: dexonsmith, bixia. tra requested review of this revision. Herald added a project: clang. This should reduce the amount of noise issued by clang for the recent-ish CUDA versions. Clang still does not

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I would prefer to revert 93d08acaacec951dbb302f77eeae51974985b6b2 now and then fix the CUDA toolchain

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra created this revision. tra added reviewers: Hahnfeld, yaxunl. Herald added subscribers: dexonsmith, bixia. tra requested review of this revision. Herald added a project: clang. Always use cuda.h to detect CUDA version. It's a more universal approach compared to version.txt which is no longer

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, applications compile and run now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108246

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

vzakhari created this revision. vzakhari added a reviewer: jhuber6. vzakhari added a project: OpenMP. vzakhari requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This change-set puts

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367020. bcain added a comment. Herald added a subscriber: krytarowski. applied `clang-format-diff`, s/long/u32/ for syscall funcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. LGTM and I can confirm that this change fixes the check-globals.test that was failing due to this issue. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

jyknight added a comment. I've gone ahead and created a revert review: https://reviews.llvm.org/D108243 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 ___ cfe-commits mailing

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

jyknight created this revision. jyknight added reviewers: ahatanak, erik.pilkington, rjmccall. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It has been reverted in Apple's Clang fork for quite some time, possibly ever since it

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:88 +{ + register long r6 __asm__("r6") = n; + register long r0 __asm__("r0") = a; vitalybuka wrote: > should this use u64 like other

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2950522 , @jhuber6 wrote: > In D99551#2950515 , @vzakhari wrote: > >> In D99551#2950464 , @jhuber6 wrote: >> >>> In D99551#2950281

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 367015. v.g.vassilev added a comment. Try fix the win pre-merge bot. Clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. In D99551#2950515 , @vzakhari wrote: > In D99551#2950464 , @jhuber6 wrote: > >> In D99551#2950281 , @vzakhari wrote: >> >>> @jhuber6, thank you for

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367013. kstoimenov added a comment. Removed unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2950464 , @jhuber6 wrote: > In D99551#2950281 , @vzakhari wrote: > >> @jhuber6, thank you for reporting this. I do not have a properly setup CUDA >> system currently. Can you

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

ctetreau created this revision. Herald added a subscriber: kristof.beyls. ctetreau requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108241 Files:

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367011. kstoimenov edited the summary of this revision. kstoimenov added a comment. Instead of packing and bit shifting arguments passing them as individual intrinsic arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:94 # include #if defined(__mips64) || defined(__aarch64__) || defined(__arm__) || \ +defined(__hexagon__) || \ please use clang-format

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367008. bcain added a comment. added context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. In D99551#2950281 , @vzakhari wrote: > @jhuber6, thank you for reporting this. I do not have a properly setup CUDA > system currently. Can you please invoke `clang-offload-wrapper` with > `-save-temps` and send the temporary

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added a comment. The last snapshot uploaded without "arc diff", so it does not show "context" code around, which is inconvenient for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added a comment. In D108083#2949934 , @bcain wrote: > In D108083#2949815 , @vitalybuka > wrote: > >>> We can help create a bot for hexagon-unknown-linux-musl. What's the process? >> >> Thank you.

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

melver accepted this revision. melver added inline comments. Comment at: clang/docs/MemorySanitizer.rst:91 + +The ``disable_sanitizer_instrumentation`` attribute can be applied to a certain +function to prevent all kinds of instrumentation. This attribute overrides

[PATCH] D108202: [tsan] Add support for disable_sanitizer_instrumentation attribute

melver accepted this revision. melver added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ThreadSanitizer.rst:106 + +The ``disable_sanitizer_instrumentation`` attribute can be applied to a certain +function to prevent all kinds of

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added inline comments. Comment at: clang/test/CodeGen/attr-no-sanitize-coverage.c:1 +// RUN: %clang_cc1 -debug-info-kind=limited %s -emit-llvm -o - | FileCheck %s + This file says it's called attr-no-sanitize-coverage.c, I think that's the wrong name.

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: dexonsmith, bixia, hiraditya, jholewinski. tra requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

jdoerfert added a comment. In D107971#2941739 , @JonChesterfield wrote: > Failed a CI job that builds an openmp test in an environment without omp.h, > will revert. > > Thoughts on fixing? Putting the omp allocator definition in this header is >

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

tra added a comment. cuda-options-freebsd.cu has been removed as it does not test anything useful -- it's a somewhat out of date copy of cuda-options.cu with replaced host triple, which does not matter for processing GPU options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 366995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

tra created this revision. tra added a reviewer: Hahnfeld. Herald added subscribers: ormris, steven_wu, bixia, hiraditya, yaxunl, emaste. tra requested review of this revision. Herald added a project: clang. It's the oldest GPU architecture currently supported by all CUDA versions clang can use.

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366991. jyu2 added a comment. Address Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files: clang/include/clang/Sema/Sema.h

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. @jhuber6, thank you for reporting this. I do not have a properly setup CUDA system currently. Can you please invoke `clang-offload-wrapper` with `-save-temps` and send the temporary files to me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 02e73d4 - Simplify testcase from c411c1b

Author: Weverything Date: 2021-08-17T12:38:23-07:00 New Revision: 02e73d4b57b90ab95e8be128098c3cd430009f02 URL: https://github.com/llvm/llvm-project/commit/02e73d4b57b90ab95e8be128098c3cd430009f02 DIFF: https://github.com/llvm/llvm-project/commit/02e73d4b57b90ab95e8be128098c3cd430009f02.diff

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. This patch broke offloading on my machine. If I compile a basic offloading application I get an invalid device image. #include int main() { int isHost; #pragma omp target map(from:isHost) { isHost = omp_is_initial_device(); } return isHost; }

[PATCH] D105177: [clangd] Implemented indexing of standard library

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:72 + Inputs.TFS = + // TODO: can we get a real compile command from somewhere? + Inputs.CompileCommand.Directory = virtualRoot().str(); sammccall wrote: > I'm not sure what

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

NoQ closed this revision. NoQ added a comment. Committed as rG2d3668c997faac1f64cd3b8eb336af989069d135 (broken phabricator link). Yes, great, thanks!, sounds like the right thing to do. I guess the next potential step is

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:19481-19482 if (VD && DSAS->isThreadPrivate(VD)) { + if (NoDiagnose) +continue; DSAStackTy::DSAVarData DVar = DSAS->getTopDSA(VD, /*FromParent=*/false); jyu2 wrote:

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > jyu2 wrote: > > ABataev wrote: > > > `isa`. Also,

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 366978. v.g.vassilev added a comment. Split the exception handling test into a separate unittest and compile it with exceptions on. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files:

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. Never mind, this won't compile. Let me fix it and I will let you know when it is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov added a comment. Amended this patch to be the x86 only patch. PTAL. In D107850#2949939 , @vitalybuka wrote: > This can be split into 3 patches in the following order: > > 1. x86 > 2. Instrumentation > 3. clang > > Each of them needs tests,

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 366970. kstoimenov retitled this revision from "[asan] Implemented custom calling convention similar to the one used by HWASan for X86. " to "[asan] Implemented custom calling convention similar to the one used by HWASan for X86.". kstoimenov added a

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2947902 , @cjdb wrote: > @JonasToth, @aaron.ballman suspects that there's enough overlap between this > patch and D107873 to consider merging the > two efforts. I'm happy to

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

pcc added inline comments. Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16 - # For now, make libclang a static lib there. - libclang_target_type = "static_library" -} else { thakis wrote: > probably should update these too: > > ``` > % rg

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

pcc updated this revision to Diff 366966. pcc added a comment. Herald added subscribers: ormris, steven_wu, hiraditya. Also libLTO.so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108223/new/ https://reviews.llvm.org/D108223 Files:

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

jaykang10 added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.CGM.getDataLayout(), Src, svenvh wrote: > jaykang10 wrote: > >

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

aaron.ballman added a reviewer: rsmith. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3598 return true; +} else if (auto *UE = dyn_cast(E)) { + Expr::EvalResult Result; Comment at:

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

NoQ added a comment. > In D107078#2933682 , @NoQ wrote: > >> In D107078#2927899 , @steakhal >> wrote: >> >>> I did not fix the extra blue 'bubble' note issue, and I think that is out >>> of the scope of this

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); jyu2 wrote: > ABataev wrote: > > `isa`. Also, what if this is a

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

thakis added a comment. Hm, I kind of like the PIC-less build. But probably not worth having a toggle for it, I suppose. So lg, but: Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16 - # For now, make libclang a static lib there. - libclang_target_type =

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 marked 3 inline comments as done. gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12195 + if (!fpModeMatchesGlobalFPAtomicMode(RMW)) +return reportUnsafeHWInst(RMW, AtomicExpansionKind::None);

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:9 +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple=amdgcn-amd-amdhsa -target-cpu gfx90a \ +// RUN: -Rpass=si-lower -munsafe-fp-atomics %s -S -o - 2>&1 | \

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 marked 4 inline comments as not done. jyu2 added a comment. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > `isa`.

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

pcc created this revision. pcc added a reviewer: thakis. pcc requested review of this revision. Herald added a project: LLVM. This requires changing the ELF build to enable -fPIC, consistent with other platforms. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108223 Files:

[PATCH] D108215: [clang][deps] NFC: Move `ResourceDirectoryCache`

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I don't think this should be reused. If I'm reading the code correctly, this is just a super heavyweight (but cached) call to `Driver::GetResourcesPath()`. It should

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + ||

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added a comment. This can be split into 3 patches in the following order: 1. x86 2. Instrumentation 3. clang Each of them needs tests, Intrtumentation changes are not tested. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added a comment. In D108083#2949815 , @vitalybuka wrote: >> We can help create a bot for hexagon-unknown-linux-musl. What's the process? > > Thank you. https://llvm.org/docs/HowToAddABuilder.html Oh I think I misunderstood: > Volunteers can

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366945. jyu2 edited the summary of this revision. jyu2 added a comment. Address Alex's comments. Thanks Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files:

  1   2   >