[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

wingo created this revision. Herald added a subscriber: Anastasia. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LangAS local is only used in the OpenCL case; move its decl inwards. Repository: rG LLVM Github Monorepo https

[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

wingo added a reviewer: rjmccall. wingo added a comment. Just a drive-by cleanup while poking other address-space-related things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108449/new/ https://reviews.llvm.org/D108449 __

[clang] 9ae9262 - [OpenCL] Fix version reporting of C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-08-20T08:58:12+01:00 New Revision: 9ae9262857a1e7aadc385a68a00755896440f6b1 URL: https://github.com/llvm/llvm-project/commit/9ae9262857a1e7aadc385a68a00755896440f6b1 DIFF: https://github.com/llvm/llvm-project/commit/9ae9262857a1e7aadc385a68a00755896440f6b1.dif

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae9262857a1: [OpenCL] Fix version reporting of C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108379/new/ https:

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

wingo created this revision. wingo added a reviewer: rjmccall. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This function was defaulting to use the ABI alignment for the LLVM type. Here we change to use the preferred alignment. T

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

sammccall created this revision. sammccall added reviewers: hokein, guopeilin. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://bugs.llvm.org/show_bug.cgi?id=51554 Repository: rG LLVM Github Monorepo https://revi

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

sammccall added a comment. In D82657#2956751 , @guopeilin wrote: > Hi @hokein , I encounter a bug when clang parses enum and I have been > recorded in https://bugs.llvm.org/show_bug.cgi?id=51554. I added a comment on the bug and sent https://reviews.llvm

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

wingo added a comment. I tested by building with all targets enabled and there was no change in test results, running clang, llvm, and lld tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108450/new/ https://reviews.llvm.org/D108450 _

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel marked an inline comment as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibIndexTests.cpp:51 + Req.AnyScope = true; + EXPECT_THAT(match(*Index, Req), + UnorderedElementsAre(llvm::StringRef("myfunc"),

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon added a comment. Something I noticed is that we don't have much test coverage in clang/test/codegen for the fpclass intrinsics - including no constexpr testing afaict (although I don't think __builtin_fpclassify is constexpr yet) - is that something you'd be willing to take a look at?

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367737. kuhnel marked an inline comment as done. kuhnel added a comment. addressed code review comments also fixed use-after-free Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.o

[PATCH] D108119: Wiring of standard library indexing into clangd.

kuhnel updated this revision to Diff 367738. kuhnel added a comment. addressed some review comments question of integration with main functionality still open. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108119/new/ https://reviews.llvm.org/D108

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367739. jozefl added a comment. Here's an updated patch that stores the HWMult and CPU data for each MCU as strings instead of enums. This simplifies the patch as string conversions to and from enums are no longer required. Repository: rG LLVM Github Monore

[PATCH] D108119: Wiring of standard library indexing into clangd.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with the understanding that we'll have to move this to be more sophisticated later later, but it's useful to have the simple version now. Similarly I think it's OK to add the tests lat

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Remainder is just nits, looks good! Comment at: clang-tools-extra/clangd/FS.cpp:126 + // safely assume to exist is "/". + return "/"; +#endif "/virtu

[PATCH] D105169: [Clang/Test]: Enable enable_noundef_analysis as default

hyeongyukim updated this revision to Diff 367746. hyeongyukim added a comment. Herald added subscribers: cfe-commits, dexonsmith. Changed `disable_noundef_args` flag to `enable_noundef_args` to enable emitting `noundef` attributes on IR call arguments and return values by default. Changed test co

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG508b06699a39: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware… (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D108453: [Clang/Test]: Enable enable_noundef_analysis as default(2)

hyeongyukim created this revision. Herald added subscribers: mstorsjo, frasercrmck, lxfind, jdoerfert, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, jfb, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, delcyph

[PATCH] D108453: [Clang/Test]: Enable enable_noundef_analysis as default(2)

hyeongyukim added a comment. This and D105169 are renewed version of the old patch (D82317 ). When pushing to the main branch, I'll commit this and D105169 as a single commit to avoid CI failur

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman added a comment. In D108403#2955651 , @erichkeane wrote: > This whole function seems a little suspect, but I don't have a good example > of a place it would break. Is there no cases where a lookup could result in > the same COUNT but dif

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 367759. glider added a comment. Updated LangRef.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added a comment. In D108029#2954604 , @glider wrote: > In D108029#2954566 , @melver wrote: > >> llvm/docs/LangRef.rst also needs a corresponding change. > > Right, will do. I thought LangRef was missing the

[clang] 62f4c90 - [Sema] Remove dead return immediately after another return. NFC.

Author: Simon Pilgrim Date: 2021-08-20T12:11:23+01:00 New Revision: 62f4c90aaf1eb418f69e73cbbf170264a02c2688 URL: https://github.com/llvm/llvm-project/commit/62f4c90aaf1eb418f69e73cbbf170264a02c2688 DIFF: https://github.com/llvm/llvm-project/commit/62f4c90aaf1eb418f69e73cbbf170264a02c2688.diff

[clang] 5b72fb8 - [AST] getDeclLocForCommentSearch - remove dead return. NFC.

Author: Simon Pilgrim Date: 2021-08-20T12:32:29+01:00 New Revision: 5b72fb866c16d63a3403848f0a4f04f522da8ba3 URL: https://github.com/llvm/llvm-project/commit/5b72fb866c16d63a3403848f0a4f04f522da8ba3 DIFF: https://github.com/llvm/llvm-project/commit/5b72fb866c16d63a3403848f0a4f04f522da8ba3.diff

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

Hahnfeld created this revision. Hahnfeld added reviewers: tra, yaxunl. Hahnfeld requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. NVPTX does not allow dots in the identifier, so ptxas errors out wi

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

Hahnfeld added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6265-6268 +void CodeGenModule::printPostfixForExternalizedStaticVar( +llvm::raw_ostream &OS) const { + OS << ".static." << getContext().getCUIDHash(); +} I've tried to use this w

[clang-tools-extra] b2aa470 - [clangd] detectClangPath() - remove (dead) return. NFC.

Author: Simon Pilgrim Date: 2021-08-20T12:41:38+01:00 New Revision: b2aa470faeb7aaedfa63cb192a710fbe086f15c1 URL: https://github.com/llvm/llvm-project/commit/b2aa470faeb7aaedfa63cb192a710fbe086f15c1 DIFF: https://github.com/llvm/llvm-project/commit/b2aa470faeb7aaedfa63cb192a710fbe086f15c1.diff

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

wingo created this revision. wingo added a reviewer: rjmccall. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows a declaration of an Address to be invalid by default, allowing it to be added to e.g. a DenseMap. Will followu

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

wingo added inline comments. Comment at: clang/lib/CodeGen/Address.h:31 : Pointer(pointer), Alignment(alignment) { assert((!alignment.isZero() || pointer == nullptr) && "creating valid address with invalid alignment"); It would be nice to

[clang] b0391df - [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

Author: Alexander Potapenko Date: 2021-08-20T14:01:06+02:00 New Revision: b0391dfc737ede147e128fe877045f61fc5e4905 URL: https://github.com/llvm/llvm-project/commit/b0391dfc737ede147e128fe877045f61fc5e4905 DIFF: https://github.com/llvm/llvm-project/commit/b0391dfc737ede147e128fe877045f61fc5e4905

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0391dfc737e: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github Monorepo

[PATCH] D108421: Mark openmp internal global dso_local

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2182-2189 + llvm::GlobalVariable *GV = new llvm::GlobalVariable( + CGM.getModule(), Ty, /*IsConstant*/ false, + llvm::GlobalValue::CommonLinkage, llvm::Constant::getNullValue(Ty), + E

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman updated this revision to Diff 367765. aaron.ballman added a comment. Updating based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108403/new/ https://reviews.llvm.org/D108403 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclBase.h

[PATCH] D108459: [clang][CodeGen] Rely on implicitly invalid Address. NFC.

wingo created this revision. Herald added a subscriber: lxfind. wingo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Remove explicit uses of Address::invalid in initializers; the default constru

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 367767. glider added a comment. Updated after landing the disable_sanitizer_instrumentation to LLVM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108199/new/ https://reviews.llvm.org/D108199 Files: clang/docs

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Any thoughts? : ) Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:49 +void forEachFieldWithFilter(const RecordDecl &Record, const T &Fields, +bool &AnyMemberHasInitPerUnion, Func &&Fn) {

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D102325#2816919 , @mgartmann wrote: > I assume that these destructors are private by on purpose. Please correct me > if I am wrong.

[PATCH] D108461: [OpenCL] Supports optional generic address space in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_generic_address_space` in

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Any thoughts? : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. Any thoughts? : ) Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:263 + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable 'a' of the trivially-copyable type

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. Any thoughts? : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a comment. I'm unopposed here. Craig, what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 ___ cfe-commits mailing list cfe-comm

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 367774. glider marked 2 inline comments as done. glider added a comment. Addressed Marco's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108199/new/ https://reviews.llvm.org/D108199 Files: clang/docs

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo created this revision. wingo added a reviewer: rjmccall. Herald added subscribers: lxfind, sunfish, dschuff. wingo requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added a project: clang. It used to be tha

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: clang/docs/MemorySanitizer.rst:91 + +The ``disable_sanitizer_instrumentation`` attribute can be applied to a certain +function to prevent all kinds of instrumentation. This attribute overrides melver wrote: > Could apply

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a comment. So... besides the refactor, this is getting closer to where I'm going in https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still NFC. I think you can see where I would replace `getASTAllocaAddressSpace` with `getAllocaAddressSpace(QualType Ty)`,

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:115 - /// Emit a load from an i1 flag variable. - llvm::LoadInst *CreateFlagLoad(llvm::Value *Addr, it's the change to always return an `Address` from `CreateTempAlloca` that makes these

[clang] 8dc7dcd - [msan] Add support for disable_sanitizer_instrumentation attribute

Author: Alexander Potapenko Date: 2021-08-20T15:11:26+02:00 New Revision: 8dc7dcdca1e0d0ce4e39305272c8021a1aed07ed URL: https://github.com/llvm/llvm-project/commit/8dc7dcdca1e0d0ce4e39305272c8021a1aed07ed DIFF: https://github.com/llvm/llvm-project/commit/8dc7dcdca1e0d0ce4e39305272c8021a1aed07ed

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc7dcdca1e0: [msan] Add support for disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D108403#2957084 , @aaron.ballman wrote: > In D108403#2955651 , @erichkeane > wrote: > >> This wh

[clang] c94f4a9 - ClangOffloadBundler - getCompatibleOffloadTargets - Fix unknown parameter Wdocumentation warnings. NFC.

Author: Simon Pilgrim Date: 2021-08-20T14:31:11+01:00 New Revision: c94f4a9c5d8ca826986c9490e668ba66afad3419 URL: https://github.com/llvm/llvm-project/commit/c94f4a9c5d8ca826986c9490e668ba66afad3419 DIFF: https://github.com/llvm/llvm-project/commit/c94f4a9c5d8ca826986c9490e668ba66afad3419.diff

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Sema/SemaDecl.cpp:17752 +if (Enum->isDependentType() || Val->isTypeDependent() || +Val->containsErrors()) EltTy = Context.Dep

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

RKSimon added inline comments. Comment at: clang/lib/Frontend/PrintPreprocessedOutput.cpp:680 +if (RequireSpace || (!MinimizeWhitespace && Tok.hasLeadingSpace()) || +((EmittedTokensOnThisLine || EmittedTokensOnThisLine) && + AvoidConcat(PrevPrevTok, PrevTok, T

[clang] 48f73ee - Fix assertion when generating diagnostic for inline namespaces

Author: Aaron Ballman Date: 2021-08-20T09:50:24-04:00 New Revision: 48f73ee666a264d23716ff6bb671cad836b65ccf URL: https://github.com/llvm/llvm-project/commit/48f73ee666a264d23716ff6bb671cad836b65ccf DIFF: https://github.com/llvm/llvm-project/commit/48f73ee666a264d23716ff6bb671cad836b65ccf.diff

[PATCH] D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

glider created this revision. glider added reviewers: eugenis, melver. Herald added a subscriber: pengfei. glider requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because KMSAN is not supported on many architectures, explicitly build the tes

[PATCH] D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

glider added a comment. TBR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108465/new/ https://reviews.llvm.org/D108465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. Who reported the issue? Might be worth mentioning in commit message, otherwise it appears to come out of nowhere (although it's semi-obvious given x86-64 is only supported). Repository: rG

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thanks for the reviews! I've committed (with the formatting fix) in 48f73ee666a264d23716ff6bb671cad836b65ccf .

[PATCH] D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

glider updated this revision to Diff 367783. glider added a comment. Updated patch description with links to bot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108465/new/ https://reviews.llvm.org/D108465 Files: clang/test/CodeGen/sanit

[PATCH] D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

glider added a comment. In D108465#2957355 , @melver wrote: > Who reported the issue? Might be worth mentioning in commit message, > otherwise it appears to come out of nowhere (although it's semi-obvious given > x86-64 is only supported). Right. Added

[clang] 417a49e - [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

Author: Alexander Potapenko Date: 2021-08-20T16:00:25+02:00 New Revision: 417a49e78e730c964c60840110455c29fb562ee0 URL: https://github.com/llvm/llvm-project/commit/417a49e78e730c964c60840110455c29fb562ee0 DIFF: https://github.com/llvm/llvm-project/commit/417a49e78e730c964c60840110455c29fb562ee0

[PATCH] D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG417a49e78e73: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c (authored by glider). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367787. kuhnel added a comment. fixing windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ext

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko updated this revision to Diff 367788. vsavchenko added a comment. Herald added a subscriber: manas. Join 'suppress' and 'analyzer_suppress' attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https://reviews.llvm.org/D93

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added a comment. Finally I had a chance to come back to this patch. @aaron.ballman what do you think about it? I tried to address your notes and implemented both features under one attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") what commented out features? Repository: rG LLVM G

[PATCH] D104854: Introduce intrinsic llvm.isnan

spatel added a comment. Is it intentional that we are not canonicalizing the intrinsic call back to `fcmp uno` in the default FP environment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 _

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") RKSimon wrote: > what commented out features? So th

[clang] c7aacce - Use DeclContext::getNonTransparentContext(); NFC

Author: Aaron Ballman Date: 2021-08-20T11:08:58-04:00 New Revision: c7aacce3046985cedd9c15d69dc52a68850b1659 URL: https://github.com/llvm/llvm-project/commit/c7aacce3046985cedd9c15d69dc52a68850b1659 DIFF: https://github.com/llvm/llvm-project/commit/c7aacce3046985cedd9c15d69dc52a68850b1659.diff

[PATCH] D108380: [openmp][nfc] Refactor GridValues

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 ___

[clang] bdeda95 - Make wide multi-character character literals ill-formed

Author: Corentin Jabot Date: 2021-08-20T11:10:53-04:00 New Revision: bdeda959abd74c88a6cfc34b10c1b665cb45cb8d URL: https://github.com/llvm/llvm-project/commit/bdeda959abd74c88a6cfc34b10c1b665cb45cb8d DIFF: https://github.com/llvm/llvm-project/commit/bdeda959abd74c88a6cfc34b10c1b665cb45cb8d.diff

[PATCH] D106215: Make wide multi-character character literals ill-formed

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've landed in bdeda959abd74c88a6cfc34b10c1b665cb45cb8d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck added a comment. Ah no, my mistake. This would be a drop in functionality if `getMaxVScale` is removed, since its replacement only checks the IR attribute and will not be affected by our backend flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2957423 , @spatel wrote: > Is it intentional that we are not canonicalizing the intrinsic call back to > `fcmp uno` in the default FP environment? It is lowered to unordered comparison by default. Changing `llvm.isn

[clang] 2a47a84 - [openmp][nfc] Refactor GridValues

Author: Jon Chesterfield Date: 2021-08-20T16:41:26+01:00 New Revision: 2a47a84b40115b01e03e4d89c1d47ba74beb7bf3 URL: https://github.com/llvm/llvm-project/commit/2a47a84b40115b01e03e4d89c1d47ba74beb7bf3 DIFF: https://github.com/llvm/llvm-project/commit/2a47a84b40115b01e03e4d89c1d47ba74beb7bf3.di

[PATCH] D108380: [openmp][nfc] Refactor GridValues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a47a84b4011: [openmp][nfc] Refactor GridValues (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D104854: Introduce intrinsic llvm.isnan

lebedev.ri added a comment. In D104854#2957471 , @sepavloff wrote: > In D104854#2957423 , @spatel wrote: > >> Is it intentional that we are not canonicalizing the intrinsic call back to >> `fcmp uno` in the defau

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1222 + DeclContext *DC = this; + while (DC && DC->isTransparentContext()) +DC = DC->getParent(); Can getParent() be null? If it cam, then this function can return null which you don't c

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

erichkeane added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1222 + DeclContext *DC = this; + while (DC && DC->isTransparentContext()) +DC = DC->getParent(); cor3ntin wrote: > Can getParent() be null? If it cam, then this function can return nul

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song updated this revision to Diff 367797. yonghong-song added a comment. - fix clang-format warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106616/new/ https://reviews.llvm.org/D106616 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[clang] 2456e11 - [WebAssembly] Add SIMD intrinsics using unsigned integers

Author: Thomas Lively Date: 2021-08-20T08:56:51-07:00 New Revision: 2456e11614c10a2e648005e27e3213c77b7ab7a4 URL: https://github.com/llvm/llvm-project/commit/2456e11614c10a2e648005e27e3213c77b7ab7a4 DIFF: https://github.com/llvm/llvm-project/commit/2456e11614c10a2e648005e27e3213c77b7ab7a4.diff

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2456e11614c1: [WebAssembly] Add SIMD intrinsics using unsigned integers (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song added a comment. @dblaikie could you take a look at this patch? The same as previous DIComposite patch (D106615 ), if the patch is accepted, I will break into llvm part and clang part and commit them separately. Repository: rG LLVM Github Monor

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

craig.topper added a comment. I'm not opposed either. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") erichkeane wrote: > RKSimon w

[clang] 65bcdea - Replace an unnecessary null check with an assert; NFC

Author: Aaron Ballman Date: 2021-08-20T12:04:46-04:00 New Revision: 65bcdeaa15b729dae40190c6a990cd67c12e9f10 URL: https://github.com/llvm/llvm-project/commit/65bcdeaa15b729dae40190c6a990cd67c12e9f10 DIFF: https://github.com/llvm/llvm-project/commit/65bcdeaa15b729dae40190c6a990cd67c12e9f10.diff

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1222 + DeclContext *DC = this; + while (DC && DC->isTransparentContext()) +DC = DC->getParent(); erichkeane wrote: > cor3ntin wrote: > > Can getParent() be null? If it cam, then thi

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. There's nothing later than CannonLake here - does Intel need to at least reference up to Tiger/Rocketlake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 ___

[PATCH] D104854: Introduce intrinsic llvm.isnan

spatel added a comment. In D104854#2957471 , @sepavloff wrote: > In D104854#2957423 , @spatel wrote: > >> Is it intentional that we are not canonicalizing the intrinsic call back to >> `fcmp uno` in the default F

[PATCH] D108469: Improve handling of static assert messages. Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string (which we

cor3ntin created this revision. Herald added a subscriber: martong. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...g). `FormatDiagnostic` is modified to escape non printable characters and invalid UTF-8. This ensures that uni

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a subscriber: LuoYuanke. erichkeane added a comment. In D108422#2957528 , @RKSimon wrote: > There's nothing later than CannonLake here - does Intel need to at least > reference up to Tiger/Rocketlake? @LuoYuanke ^^ Repository: rG LL

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367802. cor3ntin retitled this revision from "Improve handling of static assert messages. Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string (which we know is valid UTF-8 by virtue

[clang] 64a9957 - [WebAssembly] Make shift values unsigned in wasm_simd128.h

Author: Thomas Lively Date: 2021-08-20T09:10:37-07:00 New Revision: 64a9957bf7b65a0d10819918ac2a565d69e9c4bb URL: https://github.com/llvm/llvm-project/commit/64a9957bf7b65a0d10819918ac2a565d69e9c4bb DIFF: https://github.com/llvm/llvm-project/commit/64a9957bf7b65a0d10819918ac2a565d69e9c4bb.diff

[PATCH] D108415: [WebAssembly] Make shift values unsigned in wasm_simd128.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG64a9957bf7b6: [WebAssembly] Make shift values unsigned in wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108415/new/ ht

[PATCH] D104854: Introduce intrinsic llvm.isnan

xbolva00 added a comment. In D104854#2957529 , @spatel wrote: > In D104854#2957471 , @sepavloff > wrote: > >> In D104854#2957423 , @spatel wrote: >> >>> Is it intentional

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh created this revision. svenvh added reviewers: Anastasia, jaykang10. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. With -fpreserve-vec3-type enabled, a cast was not created when conv

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367805. jozefl added a comment. Here's an updated patch to fix the win64 failure. MSVC can't handle the conversion from a ForwardIterator to a const pointer when the container being searched with std::lower_bound is a std::array. Meanwhile clang-tidy warns whe

[PATCH] D104854: Introduce intrinsic llvm.isnan

lebedev.ri added a comment. In D104854#2957529 , @spatel wrote: > In D104854#2957471 , @sepavloff > wrote: > >> In D104854#2957423 , @spatel wrote: >> >>> Is it intention

[clang] 88962ce - [WebAssembly] Restore builtins and intrinsics for pmin/pmax

Author: Thomas Lively Date: 2021-08-20T09:21:31-07:00 New Revision: 88962cea46805dbcc60524f7107030c986833052 URL: https://github.com/llvm/llvm-project/commit/88962cea46805dbcc60524f7107030c986833052 DIFF: https://github.com/llvm/llvm-project/commit/88962cea46805dbcc60524f7107030c986833052.diff

[PATCH] D108387: [WebAssembly] Restore builtins and intrinsics for pmin/pmax

This revision was automatically updated to reflect the committed changes. Closed by commit rG88962cea4680: [WebAssembly] Restore builtins and intrinsics for pmin/pmax (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108387/new/ h

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 367811. cor3ntin added a comment. Fix diagnostic for avaibility attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy

  1   2   >