[clang] 323a6bf - Add "REQUIRES: arm-registered-target" line to test added in D108603.

Author: Douglas Yung Date: 2021-08-24T22:22:16-07:00 New Revision: 323a6bfbb8cf8082e22dc482abeaf6664d84bbdf URL: https://github.com/llvm/llvm-project/commit/323a6bfbb8cf8082e22dc482abeaf6664d84bbdf DIFF: https://github.com/llvm/llvm-project/commit/323a6bfbb8cf8082e22dc482abeaf6664d84bbdf.diff

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

ChuanqiXu added a comment. In D108615#2962618 , @lxfind wrote: > I am not familiar with the process of when to move something out of > experimental, but I do wonder how this is normally done so that people who > uses coroutines can have a smooth

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2958594 , @modimo wrote: > @tejohnson Indirect calls are not captured in FunctionSummaries in CallGraph > or in a flag form saying they exist. Also looks like >

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

rjmccall added a comment. Why do you want to add `noinline` to a function declaration that lacks a definition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108618/new/ https://reviews.llvm.org/D108618

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:262-263 + int a = 10; + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable 'a' of the

[PATCH] D107021: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and pointers to structs

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107021/new/ https://reviews.llvm.org/D107021

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 planned changes to this revision. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. I'm going to move code gen into `OMPIRBuilder`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4d6d718b2e: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cd4d6d7 - PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

Author: Richard Smith Date: 2021-08-24T19:53:44-07:00 New Revision: cd4d6d718b2e51ed830a28d01d765da2a220afd3 URL: https://github.com/llvm/llvm-project/commit/cd4d6d718b2e51ed830a28d01d765da2a220afd3 DIFF: https://github.com/llvm/llvm-project/commit/cd4d6d718b2e51ed830a28d01d765da2a220afd3.diff

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108680/new/ https://reviews.llvm.org/D108680

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. I agree with James; I know you've reached out to the Itanium ABI group about mangling, but ABI involvement needs to mean also reaching out and getting psABI agreement about representation. I would suggest proposing a generic ABI, getting consensus on that generic ABI

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

rsmith added a comment. Note that there's a potential ABI impact here: because we accidentally put the `__cxx_global_init` function into a COMDAT with the variable, that meant that the `_ZTH` symbol (which is an alias to `__cxx_global_init`) also pointed into that same COMDAT. I'm not sure how

[PATCH] D67429: Improve code generation for thread_local variables:

rsmith added a comment. https://reviews.llvm.org/D108680 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

rsmith created this revision. rsmith added a reviewer: rjmccall. rsmith requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Previously when emitting a C++ guarded initializer, we tried to work out what the enclosing function would be

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

sugak added subscribers: weiwang, sugak. sugak added a comment. Herald added a subscriber: sstefan1. Hi @yaxunl! I'm working on upgrading a large codebase from LLVM-9 to LLVM-12. I noticed on average 10% compilation speed regression that seems to be caused this change. We use Clang modules and

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added a comment. Thanks! I will submit tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___ cfe-commits mailing list

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa947b40cafa8: [WebAssembly] Add Wasm SjLj option support for clang (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a947b40 - [WebAssembly] Add Wasm SjLj option support for clang

Author: Heejin Ahn Date: 2021-08-24T18:12:52-07:00 New Revision: a947b40cafa8a1d7e241699c1400d80c77e9894c URL: https://github.com/llvm/llvm-project/commit/a947b40cafa8a1d7e241699c1400d80c77e9894c DIFF: https://github.com/llvm/llvm-project/commit/a947b40cafa8a1d7e241699c1400d80c77e9894c.diff

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin updated this revision to Diff 368519. aheejin added a comment. This revision is now accepted and ready to land. Remove multivalue setting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 Files:

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6609892a2dcd: [clang] allow -fstack-clash-protection on FreeBSD (authored by emaste). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

jyknight added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:581 /// limitation is put into place for ABI reasons. - virtual bool hasExtIntType() const { + /// FIXME: _BitInt is a required type in C23, so there's not much utility in + /// asking

[clang] 6609892 - [clang] allow -fstack-clash-protection on FreeBSD

Author: Ed Maste Date: 2021-08-24T21:02:36-04:00 New Revision: 6609892a2dcdd1a4f6adefe191b55524861f020c URL: https://github.com/llvm/llvm-project/commit/6609892a2dcdd1a4f6adefe191b55524861f020c DIFF: https://github.com/llvm/llvm-project/commit/6609892a2dcdd1a4f6adefe191b55524861f020c.diff

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin added a comment. As we discussed offline, I'll remove `+multivalue` part for now; it doesn't have reliable support in the Wasm LLVM backend and Binaryen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b921b870aa: [WebAssembly] Tidy up EH/SjLj options (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka accepted this revision. vitalybuka added a comment. And if it's straightforward fix for the revert you can "reuse" approvals and land without additional review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368510. kstoimenov added a comment. Updated with the fix for Bazel build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. Checking build timing in release mode Clang self-build looking at purely thinlink timing: | Mode | Time (s) | | base | 2.254| | base + propagation | 2.556| | noinline | 8.870| | noinline + propagation |

[clang] df7b6b9 - Extend diagnostic for out of date AST input file.

Author: Richard Smith Date: 2021-08-24T17:03:06-07:00 New Revision: df7b6b91422dbdbdb1de66fd865853e78ea3e5d2 URL: https://github.com/llvm/llvm-project/commit/df7b6b91422dbdbdb1de66fd865853e78ea3e5d2 DIFF: https://github.com/llvm/llvm-project/commit/df7b6b91422dbdbdb1de66fd865853e78ea3e5d2.diff

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 368485. ricejasonf added a comment. I added a simple lit test. The case is the reduced case mentioned in the bug. I spent some time trying to reproduce this outside decomposition. The only other way (I know of) to produce an ArrayInitLoopExpr is an

[PATCH] D108647: [clang][deps] Use top-level modules as precompiled dependencies

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. > The documentation of Module::PresumedModuleMapFile says this field is > non-empty only when building from preprocessed source. This means there can > still be cases

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

dexonsmith added a comment. In D108544#2962890 , @jansvoboda11 wrote: > I created D108647 to more > directly/correctly address the issues I'm seeing at the moment in explicit > builds. > > I think dealing with the

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

arsenm added a comment. Could use some MIR tests to make sure that parser doesn't explode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D108661 ___ cfe-commits

[PATCH] D67429: Improve code generation for thread_local variables:

rsmith added a comment. In D67429#2961873 , @rjmccall wrote: > @rsmith, can you fix or revert? Sorry for the long delay here. Looking now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/

[PATCH] D108603: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c829ce1e362: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction (authored by inglorion). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1c829ce - [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

Author: Bob Haarman Date: 2021-08-24T21:25:49Z New Revision: 1c829ce1e3627cf9b22da33943dc2e423ded11c4 URL: https://github.com/llvm/llvm-project/commit/1c829ce1e3627cf9b22da33943dc2e423ded11c4 DIFF: https://github.com/llvm/llvm-project/commit/1c829ce1e3627cf9b22da33943dc2e423ded11c4.diff LOG:

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

craig.topper added a comment. Wild speculation. This may be a historical artifact of LoadInst and StoreInst having their getAlignment() function written like this when this limit was created unsigned getAlignment() const { return (1 << (getSubclassDataFromInstruction() >> 1)) >> 1; }

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. In D108003#2956332 , @xbolva00 wrote: >>> and it would be more of an optimization than correctness issue as far as I >>> understand > > Yeah, this is right, indeed. > > Maybe @rpbeltran has some idea or motivating cases for OR

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri created this revision. lebedev.ri added reviewers: jdoerfert, efriedma, aaron.ballman, nikic, MaskRay. lebedev.ri added a project: LLVM. Herald added subscribers: dexonsmith, okura, kuter, pengfei, jfb. lebedev.ri requested review of this revision. Herald added a reviewer: sstefan1.

[PATCH] D108648: [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rG148bc251f48e: [Clang][OpenMP] Use enum to dereference children data array in… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 148bc25 - [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

Author: Shilei Tian Date: 2021-08-24T16:00:24-04:00 New Revision: 148bc251f48ee68af9b7c7eb725d4ed888629b5c URL: https://github.com/llvm/llvm-project/commit/148bc251f48ee68af9b7c7eb725d4ed888629b5c DIFF: https://github.com/llvm/llvm-project/commit/148bc251f48ee68af9b7c7eb725d4ed888629b5c.diff

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

dschuff accepted this revision. dschuff added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449 + // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires + // Emscripten libraries and processed together in

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

ldionne added a subscriber: CaseyCarter. ldionne added a comment. In D42225#2963190 , @mstorsjo wrote: > In D42225#2962348 , @ldionne wrote: > >> @pcc @mstorsjo Are we aware of anyone using these extensions? >> >>

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368432. kstoimenov added a comment. Updating after pushing D107850 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9588b685c6b2: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

mstorsjo added a comment. In D42225#2962348 , @ldionne wrote: > @pcc @mstorsjo Are we aware of anyone using these extensions? > > I would like to suggest that we either remove this extension if it's not > useful, or make it unconditional (not only on

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 368427. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov planned changes to this revision. kstoimenov added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 368426. ABataev added a comment. Herald added a subscriber: jfb. Rebase + update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. In D108377#2962445 , @kstoimenov wrote: > Tests are still WIP. This is not ready for review yet. I will ping you when > it it. There is also "Add Acction..."-> "Plan changes", which will remove it from reviewers

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

leonardchan updated this revision to Diff 368423. leonardchan edited the summary of this revision. Herald added subscribers: dexonsmith, dang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files:

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. LGTM, pending some level of Itanium ABI blessing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108643/new/ https://reviews.llvm.org/D108643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

pcc added subscribers: thomasanderson, thakis. pcc added a comment. I believe that Chromium uses it (or at least it did at the time that I added this, and Chromium has since switched to using libc++ on Windows). I don't work on Chromium much anymore but perhaps @thakis or @thomasanderson can

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:145 +- The mangling of the ``_ExtInt(N)`` datatype has changed in both the Microsoft + ABI and Itanium ABI. erichkeane wrote: > Hrm... not a huge fan that this still claims that

[PATCH] D108648: [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108648/new/ https://reviews.llvm.org/D108648

[PATCH] D108648: [Clang][OpenMP] Use enum to dereference children data array in OMPAtomicDirective

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. Please feel free to wordsmith my ABI change comment. I don't feel strongly other than trying to make it clear that `_ExtInt` is no longer a type/types. A question for other reviewers: Do we feel strongly enough to try to keep the old mangling around via the

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 368405. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1489 + InGroup>; +def warn_prec2x_compat_bit_int : Warning< + "'_BitInt' is incompatible with C standards before C2x">, erichkeane wrote: > should this be

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. I created D108647 to more directly address the issues I'm seeing at the moment in explicit builds. I think dealing with the possibility of empty `PresumedModuleMapFile` is still

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 368395. dgoldman added a comment. Simplify setting the definition language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files:

[PATCH] D108647: [clang][deps] Use top-level modules as precompiled dependencies

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ASTReader` populates `Module::PresumedModuleMapFile` only for top-level

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 368393. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:107 +- Clang now supports the _BitInt(N) family of bit-precise integer types from + C23. This type was previously exposed as _ExtInt(N), which is still supported This section should

[PATCH] D107021: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and pointers to structs

ahatanak updated this revision to Diff 368391. ahatanak added a comment. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107021/new/ https://reviews.llvm.org/D107021 Files: clang/lib/Sema/SemaExprObjC.cpp

[PATCH] D108603: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. Thanks for fix this! I like this fix and the patch looks good to me. -Rong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108603/new/

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

a.elovikov updated this revision to Diff 368390. a.elovikov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108423/new/ https://reviews.llvm.org/D108423 Files: clang/lib/Basic/Targets/X86.cpp

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman removed subscribers: aheejin, MaskRay, jholewinski, dschuff, sdardis, nemanjai, jvesely, nhaehnle, sbc100, jgravelle-google, kbarton, fedor.sergeev, kosarev, asb, rbar, johnrusso, simoncook, sabuasal, niosHD, martong, jrtc27, zzheng, edward-jones, atanasyan, rogfer01,

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5775-5802 +static void emitOMPAtomicCompareExpr(CodeGenFunction , + llvm::AtomicOrdering AO, const Expr *X, +

[clang] 4c418c1 - Try to fix build with modules enabled after D108422

Author: Andrei Elovikov Date: 2021-08-24T10:18:15-07:00 New Revision: 4c418c1bfbc544e24b9614efc3926fe2c6218b0c URL: https://github.com/llvm/llvm-project/commit/4c418c1bfbc544e24b9614efc3926fe2c6218b0c DIFF:

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2797-2824 + enum DataPositionTy : size_t { +POS_X = 0, +POS_V, +POS_D, +POS_E, +POS_UpdateExpr, +POS_CondExpr, It is worth it to pre-commit these and related

[clang] 1b19f90 - Revert "[AST] Pick last tentative definition as the acting definition"

Author: Benson Chu Date: 2021-08-24T11:41:50-05:00 New Revision: 1b19f90a2390b60852c0ff5e1671c76dd82dac83 URL: https://github.com/llvm/llvm-project/commit/1b19f90a2390b60852c0ff5e1671c76dd82dac83 DIFF: https://github.com/llvm/llvm-project/commit/1b19f90a2390b60852c0ff5e1671c76dd82dac83.diff

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, 24 Aug 2021 at 17:30, James Y Knight wrote: > Yes, the Gerrit hosting which Go uses ("googlesource.com") only permits a > google-account login as a matter of policy. But that's not a restriction of > Gerrit itself -- it can perfectly well be configured to use a github login. > Ah,

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, Aug 24, 2021 at 7:33 AM Renato Golin wrote: > The main problem with that (Go) solution is that the Gerrit install > doesn't single-sign-on with Github accounts, it asked me for my Google > account. We shouldn't ask people to create more accounts if we want > integration with Github. I

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf387a3617860: [NFC][clang] Move remaining part of X86Target.def to… (authored by a.elovikov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f387a36 - [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

Author: Andrei Elovikov Date: 2021-08-24T09:16:31-07:00 New Revision: f387a361786081f8aadf079aa32e73ed05386242 URL: https://github.com/llvm/llvm-project/commit/f387a361786081f8aadf079aa32e73ed05386242 DIFF:

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added inline comments. Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1426 + OutStreamer->emitInstruction(MCInstBuilder(X86::AND32ri8) + .addReg(X86::ECX) + .addReg(X86::ECX)

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

lxfind added a comment. I am not familiar with the process of when to move something out of experimental, but I do wonder how this is normally done so that people who uses coroutines can have a smooth migration? I assume that this is going to be a breaking change that existing code using

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368367. kstoimenov marked an inline comment as done. kstoimenov added a comment. Fixed a crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. Which do you prefer? @Quuxplusone Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:262-263 + int a = 10; + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. What do you think? @aaron.ballman @bkramer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-commits mailing list

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368352. kstoimenov added a comment. Second attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108456/new/ https://reviews.llvm.org/D108456 ___ cfe-commits mailing list

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 368348. jozefl added a comment. Here's an updated patch that fixes some minor nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov added a comment. Tests are still WIP. This is not ready for review yet. I will ping you when it it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2962008 , @kadircet wrote: > thanks, it looks good as a contained fix. but it feels like we probably don't > want these to be treated as decls in other places too (e.g. can we really > provide any useful goto/hover

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368347. kstoimenov added a comment. Attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368346. kstoimenov added a comment. Attempt to split AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. In D108584#2962271 , @sammccall wrote: >> Likely will send a follow up diff to include more context in the Objective-C >> decl printing so they highlight properly. > > This might make sense if it provides useful context to

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/16663/step_7.txt Please to a look. Just adding a -triple flag is probably sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

ldionne added subscribers: mstorsjo, ldionne. ldionne added a comment. Herald added a subscriber: libcxx-commits. @pcc @mstorsjo Are we aware of anyone using these extensions? I would like to suggest that we either remove this extension if it's not useful, or make it unconditional (not only on

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 3 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:57 + "Const_Reverse_Iterator", +

[clang-tools-extra] 8d50a84 - [clang-tidy] Hotfix default parameter value in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-08-24T16:10:19+02:00 New Revision: 8d50a847d410295a9fca466d38a261cca4c2302b URL: https://github.com/llvm/llvm-project/commit/8d50a847d410295a9fca466d38a261cca4c2302b DIFF: https://github.com/llvm/llvm-project/commit/8d50a847d410295a9fca466d38a261cca4c2302b.diff

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a5f38885056: [AST] Pick last tentative definition as the acting definition (authored by pestctrl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[clang] 9a5f388 - [AST] Pick last tentative definition as the acting definition

Author: Benson Chu Date: 2021-08-24T08:51:50-05:00 New Revision: 9a5f3888505630cea88f8372d3068b2d63cfb381 URL: https://github.com/llvm/llvm-project/commit/9a5f3888505630cea88f8372d3068b2d63cfb381 DIFF: https://github.com/llvm/llvm-project/commit/9a5f3888505630cea88f8372d3068b2d63cfb381.diff

[PATCH] D108625: [Test][Time profiler] Fix test time checking

anton-afanasyev created this revision. anton-afanasyev added reviewers: broadwaylamb, russell.gallop. anton-afanasyev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test sometimes triggers failures during build testing. For instance,

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

sammccall added a comment. > Likely will send a follow up diff to include more context in the Objective-C > decl printing so they highlight properly. This might make sense if it provides useful context to human readers without too much syntactic weight. However if the issue is that particular

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

luismarques added inline comments. Comment at: clang/test/Sema/inline-asm-validate-riscv.c:27-28 + register long x10 asm("x10"); + asm volatile("" :: "r"(x10) : "x10"); // expected-error {{conflicts with asm clobber list}} + asm volatile("" :: "r"(x10) : "a0"); //

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Tue, Aug 24, 2021 at 8:18 AM Renato Golin wrote: > > On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote: >> >> > A minor issue is that the messages Gerrit sends to Github are a bit >> > pointless "Message from PersonA: (1 comment)". It would be better if the >> > integration either works

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

luismarques updated this revision to Diff 368323. luismarques added a comment. Nit: remove nop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108624/new/ https://reviews.llvm.org/D108624 Files: clang/lib/Basic/Targets/RISCV.h

  1   2   >