[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE Seems just adding `%clang_cc1

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 370155. keith added a comment. Some of the other checks were invalid given the current tests, these seem to be enough to solve this issue without breaking existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith created this revision. keith added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, hiraditya. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a follow up to

[PATCH] D108756: [clang] Add '-ast-dump-filter=' support

oToToT added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108756/new/ https://reviews.llvm.org/D108756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109127: Use python 3 in add_new_check.py and rename_check.py

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. As of this commit: https://github.com/llvm/llvm-project/commit/307b1fdd If either

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds Big-Endian checks for the existing MMA test cases. Repository: rG LLVM Github

[PATCH] D104344: [modules] Track how headers are included by different submodules.

vsapsai planned changes to this revision. vsapsai added a comment. Investigate less heavy-weight approaches similar to those used for tracking macros from different submodules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/

[PATCH] D104344: [modules] Track how headers are included by different submodules.

vsapsai added a comment. That's a good point. Let me check how we track macros, I haven't thought about that approach. And I haven't considered using `Preprocessor::SubmoduleState`, was too excited `HeaderSearch::ShouldEnterIncludeFile` works correctly with the updated data.

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. In D106343#2967089 , @haonanya wrote: > Hi, svenvh. > Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to > guard the functions using atomic_double type? > Thanks very much. > > #if

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. @rjmccall @lxfind @junparser hi, do you feel comfortable with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 6eda66b - PR50294: Fix a performance regression from 2c9dbcd.

Author: Richard Smith Date: 2021-09-01T18:00:07-07:00 New Revision: 6eda66b0a9f793c65852aa94430ae9bd891bcf63 URL: https://github.com/llvm/llvm-project/commit/6eda66b0a9f793c65852aa94430ae9bd891bcf63 DIFF: https://github.com/llvm/llvm-project/commit/6eda66b0a9f793c65852aa94430ae9bd891bcf63.diff

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In order to tackle the issues, I think we can do it this way: put the clang default lib ahead of `LIBRARY_PATH`. This can make sure `clang` always uses the bitcode library that comes with it, and if it is not there, it also has the ability to find a potential

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. I checked EmitAutoVarAlloca(). It emits the llvm.stacksave() due to // If the type is variably-modified, emit all the VLA sizes for it. if (Ty->isVariablyModifiedType()) EmitVariablyModifiedType(Ty); Here, in order not to generate llvm.stacksave(), we need

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

thakis updated this revision to Diff 370128. thakis added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109105/new/ https://reviews.llvm.org/D109105 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp

[PATCH] D104344: [modules] Track how headers are included by different submodules.

rsmith added a comment. I wonder if perhaps we're tracking this state in the wrong way. The "has been included" information for `#pragma once` / `#import` should behave exactly like macro definition visibility: it should be reset whenever we enter a new "clean slate" state and should be saved

[clang] 64ebf31 - [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

Author: Volodymyr Sapsai Date: 2021-09-01T17:07:35-07:00 New Revision: 64ebf313a7e485e1a90da9cd69c412e06615a9bc URL: https://github.com/llvm/llvm-project/commit/64ebf313a7e485e1a90da9cd69c412e06615a9bc DIFF:

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64ebf313a7e4: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai updated this revision to Diff 370117. vsapsai added a comment. Clarify some comments; rebase for a fresh pre-commit testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 Files:

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1671 unsigned KeyLen = key.Filename.size() + 1 + 8 + 8; - unsigned DataLen = 1 + 2 + 4 + 4; + unsigned DataLen = 1 + 4 + 4 + 4; + for (auto ModuleIncluder :

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

rjmccall added a comment. Whoa. That does not seem like it's in the contract for `stripPointerCasts()` generically. At best that should be enabled by the strip kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. In D105671#2978248 , @rjmccall wrote: > How does `stripPointerCasts` "see through" an attribute on the underlying > call instruction?

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

rjmccall added a comment. How does `stripPointerCasts` "see through" an attribute on the underlying call instruction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dexonsmith, Jim, atanasyan, jrtc27, fedor.sergeev, sdardis, dylanmckay, emaste. thakis requested review of this revision. Herald added a project: LLVM. Now prints the list of known archs. This requires

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

rjmccall closed this revision. rjmccall added a comment. I agree. This isn't the right approach. The patch in question is currently reverted; if you'd like to argue to not restore it, that conversation should be part of that review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

grokos added a comment. LG. One possible suggestion is that you leave the double dash (`--`) variant in some tests so that we can make sure both variants (e.g. both `openmp-amdgcn-amd-amdhsa--gfx906` and `openmp-amdgcn-amd-amdhsa-gfx906`) are correctly parsed. Repository: rG LLVM Github

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro added a comment. In D108886#2978169 , @apivovarov wrote: > Add Cortex-A78C Support for Clang and LLVM > > is similar to this patch. As we can see

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a comment. Add Cortex-A78C Support for Clang and LLVM is similar to this patch. As we can see `cortex-a78c` support was included to the ReleaseNotes 12.x

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield requested review of this revision. JonChesterfield added a comment. Sending back to review now that the test updates are included and LIBRARY_PATH removed from the test setup entirely Comment at: clang/test/Driver/openmp-offload-gpu.c:151 /// Check that the

[PATCH] D108794: Fully qualify template template parameters when printing

dblaikie marked an inline comment as done. dblaikie added a comment. Ping In D108794#2976063 , @rtrieu wrote: > It looks like a strict improvement on printing and most callers using the > default args won't need to be updated. > > There's one more

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370087. JonChesterfield added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

[PATCH] D108794: Fully qualify template template parameters when printing

dblaikie updated this revision to Diff 370086. dblaikie added a comment. Herald added subscribers: usaxena95, kadircet. Herald added a project: clang-tools-extra. Fix the clang-tools-extra caller, and update the TemplateName::print doc comment Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro added a comment. In D108886#2978038 , @apivovarov wrote: > Evandro, similar notes have been made in the past for Release Notes 12.x and > 11.x for Arm and RISC-V processors: >

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.h:40 + static constexpr int DefaultSmallMaxSize = 16; + int SmallMaxSize = Options.get("SmallMaxSize", DefaultSmallMaxSize); + jmarrec wrote: >

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a comment. Evandro, similar notes have been made in the past for Release Notes 12.x and 11.x for Arm and RISC-V processors: https://github.com/llvm/llvm-project/blob/release/12.x/clang/docs/ReleaseNotes.rst#modified-compiler-flags

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro added a comment. I don't think that such a minor change makes sense to be added to the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov updated this revision to Diff 370072. apivovarov added a comment. Added a note to Release Notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

jdoerfert added a subscriber: Meinersbur. jdoerfert added a comment. In D109057#2977859 , @JonChesterfield wrote: > Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to > Windows. I can't run anything on Windows locally, and

[PATCH] D108886: Add RISC-V sifive-s51 cpu

jrtc27 added a comment. In D108886#2977873 , @apivovarov wrote: > In D108886#2977733 , @jrtc27 wrote: > >> You don't need to tag people as well as adding them as reviewers, it's just >> annoying. Also, it's

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro accepted this revision. evandro added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a comment. In D108886#2977733 , @jrtc27 wrote: > You don't need to tag people as well as adding them as reviewers, it's just > annoying. Also, it's only been four days; the developer policy is that for > non-urgent patches you

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to Windows. I can't run anything on Windows locally, and trial and error while watching http://45.33.8.238/win has taken too many iterations already, so I've dropped the test case in

[clang] 06cdf48 - [openmp] Drop test from D109057, disproportionately difficult to run on windows

Author: Jon Chesterfield Date: 2021-09-01T21:51:51+01:00 New Revision: 06cdf48a0d94749a19b0b7075a8baf9d979bb409 URL: https://github.com/llvm/llvm-project/commit/06cdf48a0d94749a19b0b7075a8baf9d979bb409 DIFF:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370047. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp openmp/libomptarget/test/lit.cfg Index:

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

thakis updated this revision to Diff 370041. thakis added a comment. no-op rebase in the hope that the precommit bot doesn't run in a "git lockfile already held" error again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109085/new/ https://reviews.llvm.org/D109085 Files:

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cbf1a03ea6: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D109057?vs=370006=370040#toc Repository: rG LLVM

[clang] c7cbf1a - [openmp] Accept directory for libomptarget-bc-path

Author: Jon Chesterfield Date: 2021-09-01T21:22:35+01:00 New Revision: c7cbf1a03ea6f624be54370ea7b571842bc67dda URL: https://github.com/llvm/llvm-project/commit/c7cbf1a03ea6f624be54370ea7b571842bc67dda DIFF:

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: pengfei. thakis requested review of this revision. When using __readfsdword(), clang used to warn that one has to include -- no matter if that was already included or not. Now it only warns if it's not yet

[PATCH] D108886: Add RISC-V sifive-s51 cpu

MaskRay added a comment. Looks reasonable. You can add a bullet point to clang/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 ___

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. That helps disambiguate. You aren't concerned that this change will break the in tree tests, rather that people who currently rely on LIBRARY_PATH to choose a bitcode library to use with a clang located somewhere else in the filesystem will now need to pass

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 updated this revision to Diff 370036. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/ https://reviews.llvm.org/D102449 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D108886: Add RISC-V sifive-s51 cpu

jrtc27 added a comment. In D108886#2977730 , @apivovarov wrote: > @evandro @kito-cheng @kito.cheng @khchen @MaskRay Could you review this > patch? Thank you You don't need to tag people as well as adding them as reviewers, it's just annoying. Also,

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a subscriber: kito.cheng. apivovarov added a comment. @evandro @kito-cheng @kito.cheng @khchen @MaskRay Could you review this patch? Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/

[clang] 8976a1e - VFS: Document goals of 'use-external-name' and related logic, NFC

Author: Duncan P. N. Exon Smith Date: 2021-09-01T15:55:33-04:00 New Revision: 8976a1e111393aab7b4965196364ad734a17f2d5 URL: https://github.com/llvm/llvm-project/commit/8976a1e111393aab7b4965196364ad734a17f2d5 DIFF:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In D109061#2977714 , @JonChesterfield wrote: > Using LIBRARY_PATH to find the bitcode is a reasonable interpretation of > LIBRARY_PATH but it's a disaster in terms of using clang on a system that has > LIBRARY_PATH

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

Anastasia added a comment. In D106343#2974055 , @haonanya wrote: > Hi, svenvh and Anastasia. If you approve the patch, could you please submit > it? > I don't have permission to do it. Sure, I can commit it on your behalf, `atomic_half` can be added

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Using LIBRARY_PATH to find the bitcode is a reasonable interpretation of LIBRARY_PATH but it's a disaster in terms of using clang on a system that has LIBRARY_PATH pointing at some other version of clang. Rpath will be ignored by the bitcode lib handling. How

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. Another thing is how we deal with a corner case. Say the OpenMP code is written in the following way: #pragma omp atomic compare x = e < x ? e : x; That's how OpenMP spec defines the atomic operation. `x` is always in "else statement" of a conditional

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. From my perspective, using `LIBRARY_PATH` to find bitcode library conforms with convention because the library is linked in a linkage during compilation time, where `LIBRARY_PATH` is used by the linker. If we don't want to mess up test results, the patch to

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Bad times. Changing that to accept the / was a shotgun fix for the problem but it collides with one of the nearby regex, reverting while I work out what is going on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6b0636c - Revert "[openmp] Accept directory for libomptarget-bc-path"

Author: Jon Chesterfield Date: 2021-09-01T20:45:41+01:00 New Revision: 6b0636ce535efb8649e7cd01ccd03825fd63f8a2 URL: https://github.com/llvm/llvm-project/commit/6b0636ce535efb8649e7cd01ccd03825fd63f8a2 DIFF:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In D109061#2977690 , @JonChesterfield wrote: > Nope, works the same as it used to - looks relative to clang. However I think > it's broken some CI machines Well, it also breaks when OpenMP is built standalone.

[clang] cef1199 - Revert "[openmp] No longer use LIBRARY_PATH to find devicertl"

Author: Jon Chesterfield Date: 2021-09-01T20:44:12+01:00 New Revision: cef1199686475c0c63ba63ddb56f46bc7866fa3e URL: https://github.com/llvm/llvm-project/commit/cef1199686475c0c63ba63ddb56f46bc7866fa3e DIFF:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Nope, works the same as it used to - looks relative to clang. However I think it's broken some CI machines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

[clang] 88511f6 - [libomptarget] Drop path separator from test to fix windows build

Author: Jon Chesterfield Date: 2021-09-01T20:34:58+01:00 New Revision: 88511f6bc56792b47fb6e003f5357eff3b94717a URL: https://github.com/llvm/llvm-project/commit/88511f6bc56792b47fb6e003f5357eff3b94717a DIFF:

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977632 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt > > Please take a look and revert if it takes a while to fix. Probably just need > to optionally accept win

[clang] 7a228f8 - [openmp] No longer use LIBRARY_PATH to find devicertl

Author: Jon Chesterfield Date: 2021-09-01T20:24:34+01:00 New Revision: 7a228f872fbbefa6a6eba1d51da192761879fcca URL: https://github.com/llvm/llvm-project/commit/7a228f872fbbefa6a6eba1d51da192761879fcca DIFF:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a228f872fbb: [openmp] No longer use LIBRARY_PATH to find devicertl (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. I suppose it require users to add a command line argument every time they want to build a program? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370024. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt Please take a look and revert if it takes a while to fix. Probably just need to optionally accept win slashiness in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108818: [clang] Add a -canonical-prefixes option

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d157cfcc4ef: [clang] Add a -canonical-prefixes option (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3d157cf - [clang] Add a -canonical-prefixes option

Author: Nico Weber Date: 2021-09-01T14:51:06-04:00 New Revision: 3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7 URL: https://github.com/llvm/llvm-project/commit/3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7 DIFF: https://github.com/llvm/llvm-project/commit/3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7.diff

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0173e024fd9e: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0173e02 - [openmp] Accept directory for libomptarget-bc-path

Author: Jon Chesterfield Date: 2021-09-01T19:46:21+01:00 New Revision: 0173e024fd9e779a94503040a532bcf125277f86 URL: https://github.com/llvm/llvm-project/commit/0173e024fd9e779a94503040a532bcf125277f86 DIFF:

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @efriedma Thanks for suggestion! Let me look at CodeGenFunction::EmitAutoVarAlloca() call instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

efriedma added a comment. I'd prefer not to mess with the AST if we don't need to; more differences between targets make it harder to understand any issues that come up. BPF-flavored C already has enough weird differences without adding unnecessary changes. If all you need is to avoid

[PATCH] D108360: [clang][NFC] Remove dead code

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108360

[PATCH] D108360: [clang][NFC] Remove dead code

Anastasia added a comment. In D108360#2962010 , @wingo wrote: > @Anastasia is this good to go for you or does this need closer attention? Yeah I agree that this code seems like a left-over from some refactoring as it seems to have no effect.

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, ZarkoCA. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the system libc++ header location to the driver. As well we

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 ___ cfe-commits mailing

[PATCH] D108761: [OpenCL] Remove decls for scalar vloada_half and vstorea_half* fns

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108761/new/ https://reviews.llvm.org/D108761

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

Jake-Egan updated this revision to Diff 369992. Jake-Egan added a comment. Add negative test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. @aaron.ballman would it be possible for you to review this patch, so we can fix our broken builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. We recently enabled assertions in our Fuchsia builds, and our builds started to fail: FAILED: obj/src/lib/storage/vfs/cpp/libcpp.fuchsia_vfs.cc.o ../../../recipe_cleanup/clangLhcV7J/bin/clang++ -MD -MF obj/src/lib/storage/vfs/cpp/libcpp.fuchsia_vfs.cc.o.d

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

nemanjai added a comment. The idea with putting all of these in a separate function was to: 1. Make it easy to limit it to specific targets as I suggested above 2. Have them all in one place to easily identify which ones are added for this compatibility so we can eventually pull this support

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/lib/Basic/TargetInfo.cpp:413 OpenCLFeaturesMap, "__opencl_c_generic_address_space"); - Opts.OpenCLPipes = -

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. OK, test added, same code as originally, checked that the test fails on trunk. Because it's driver only we don't get a far as the fatal error, but you can see the driver passing the directory through to builtin-bitcode. Will land when the premerge checks catch

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369972. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/openmp-offload-gpu.c Index:

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369971. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/openmp-offload-gpu.c Index:

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Well, that's not helpful. Managed to add a test through the webui as arcanist was misbehaving but it has worked by deleting the functional change. Will try again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369969. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/test/Driver/openmp-offload-gpu.c Index: clang/test/Driver/openmp-offload-gpu.c

[PATCH] D108421: Mark openmp internal global dso_local

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D108421#2977107 , @kamleshbhalui wrote: > In D108421#2958848 , @MaskRay wrote: > >> If you

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977084 , @jdoerfert wrote: > LG, but please add a test for this. D109061 sends everything in check-openmp down this code path, but we should indeed have a check for the

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. In D108421#2958848 , @MaskRay wrote: > If you read the comment in TargetMachine::shouldAssumeDSOLocal: this is the > wrong direction. dso_local is assumed to be marked by the frontend. > > Direct accesses and GOT accesses

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Preprocessor/init-ppc.c:520 // PPC-AIX:#define __POWERPC__ 1 +// PPC-AIX:#define __PPC 1 // PPC-AIX:#define __PPC__ 1

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but please add a test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057

  1   2   >