[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added a comment. This patch has landed as 83f3782c6129e7a5df3faaf0ae576611d16a8d49 but not reflected on Phabricator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 370837. kamleshbhalui added a comment. mark dso_local only when non-pic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 Files:

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#2983021 , @ldionne wrote: > Based on the commit description, I don't understand this change at all. Why > do we want to tweak the name lookup just for `std::coroutine`? Yes, we do > have an action item to finish

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Hey Richard - was just going back over some of the modular codegen code (due to a discussion on the EWG mailing list about file extensions that ended up touching on the nature of how modules are built) - and I came across this code & had the same question I see I wrote up here already but got lost

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. I further analyzer the false positive and its probably not so simple to fix. 'NoOp' is always used to add qualifiers. This is true for `const` and `__unaligned`, but there seems to be no further information to disambiguate those. Maybe this requires even something in

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 370813. JonasToth added a comment. - add reproducer for '__unaligned' bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2956218 , @tiagoma wrote: > I am getting false positives with > > struct S{}; > > void f(__unaligned S*); > > void scope() > { > S s; > f(); > } This godbolt link has the AST for the

[clang-tools-extra] dfc46f0 - [clang-tidy] Drop unnecessary const from return types (NFC)

Author: Kazu Hirata Date: 2021-09-05T08:37:27-07:00 New Revision: dfc46f02681447370a1ccbe340034e970bc7e572 URL: https://github.com/llvm/llvm-project/commit/dfc46f02681447370a1ccbe340034e970bc7e572 DIFF: https://github.com/llvm/llvm-project/commit/dfc46f02681447370a1ccbe340034e970bc7e572.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 370808. JonasToth added a comment. - Merge branch 'main' into feature_rebase_const_transform_20210808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 370807. JonasToth marked 2 inline comments as done. JonasToth added a comment. - minor adjustments for comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk marked 8 inline comments as done. FederAndInk added a comment. Ok, so I removed git invocation and I tell the user what are their options, at least warnings are emitted for new plurals, and they will be shown in git status/diff and in revisions. Repository: rG LLVM Github

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 370796. FederAndInk added a comment. remove git invocation and user input, tell the user what the plurals are used for Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a subscriber: benshi001. justinlatimer added a comment. @benshi001 would it be possible to get this committed? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. For me it feels enough to output to stderr that we are missing plurals and what they are for, it’s not like you can say what they should be is it? This will happen so infrequently that it’s not worth the environment issues that checking git will cause.

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I think interacting with git or even blocking for input doesn’t feel right I have an issue out on llvm preserve checks that would run this tool and that couldn’t